235187 2022-01-13 09:16:10 -0800 [Cleanup] Line::selectionState logic is slightly confusing and redundant 2022-01-13 19:27:17 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1830570 0 zalan 2022-01-13 09:16:10 -0800 just a cleanup 1830574 1 449070 zalan 2022-01-13 09:22:49 -0800 Created attachment 449070 Patch 1830792 2 ews-feeder 2022-01-13 19:26:40 -0800 Committed r288006 (246032@main): <https://commits.webkit.org/246032@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449070. 1830793 3 webkit-bug-importer 2022-01-13 19:27:17 -0800 <rdar://problem/87583638> 449070 2022-01-13 09:22:49 -0800 2022-01-13 19:26:42 -0800 Patch bug-235187-20220113092248.patch text/plain 4205 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3OTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDg5NDdlNWU4YTI0MjUy YzQwNWZhZDZiMDIzY2JjMTRjZGYwYjFhYy4uYTVhMGRmMjg2YjkzZTMyZDM2NTQyY2ZmNDlhYmIz M2U4NzY4NWJhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAxLTEzICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbQ2xlYW51cF0gTGluZTo6c2Vs ZWN0aW9uU3RhdGUgbG9naWMgaXMgc2xpZ2h0bHkgY29uZnVzaW5nIGFuZCByZWR1bmRhbnQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTE4NworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdvIGZyb20gYSBz ZWVtaW5nbHkgcmFuZG9tIHNldCBvZiBjb25kaXRpb25zIHRvIGEgaW5jcmVtZW50YWwgc3RhdGUg Y2hhbmdlIChOb25lIC0+IFN0YXJ0IC0+IEluc2lkZSAtPiBFbmQpLgorICAgICAgICAoVGhpcyBh bHNvIHJlbW92ZXMgcmVkdW5kYW50IGNvZGUgbGlrZSAiaWYgKHN0YXRlID09IE5vbmUgfHwgKChi b3hTdGF0ZSA9PSBTdGFydCB8fCBib3hTdGF0ZSA9PSBFbmQpICYmIChzdGF0ZSA9PSBOb25lIHx8 IHN0YXRlID09IEluc2lkZSkpKSIKKyAgICAgICAgYW5kIGNsZWFycyB1cCB3aGF0ICJzdGF0ZSIg aGVyZSBhY3R1YWxseSBtZWFucy4pCisKKyAgICAgICAgKiBsYXlvdXQvaW50ZWdyYXRpb24vSW5s aW5lSXRlcmF0b3JMaW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklubGluZUl0ZXJhdG9yOjpM aW5lOjpzZWxlY3Rpb25TdGF0ZSBjb25zdCk6CisKIDIwMjItMDEtMTMgIEFsYW4gQnVqdGFzICA8 emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyNzg1NjEpOiBSaWdodCBj bGlja2luZyBhIGxpbmsgc2VsZWN0cyB0aGUgZnVsbCBsaW5lIHdpdGggdW5yZWxhdGVkIHRleHQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9JbmxpbmVJdGVy YXRvckxpbmUuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0lubGluZUl0 ZXJhdG9yTGluZS5jcHAKaW5kZXggOWYxNDNhOWE3MjUzZDM0MGEwYjUwOGNlNzFiOTliY2Y1MmI2 ZGZkOS4uN2QxZmQ1NmU1NGYwYjdhZjU1NzNjZjQ3MWJkZTU1OGMxOTIxMTkwZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0lubGluZUl0ZXJhdG9yTGluZS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0lubGluZUl0ZXJhdG9y TGluZS5jcHAKQEAgLTE3NSwyOCArMTc1LDMxIEBAIExheW91dFVuaXQgTGluZTo6c2VsZWN0aW9u SGVpZ2h0QWRqdXN0ZWRGb3JQcmVjZWRpbmdCbG9jaygpIGNvbnN0CiBSZW5kZXJPYmplY3Q6Okhp Z2hsaWdodFN0YXRlIExpbmU6OnNlbGVjdGlvblN0YXRlKCkgY29uc3QKIHsKICAgICBhdXRvJiBi bG9jayA9IGNvbnRhaW5pbmdCbG9jaygpOwotICAgIGlmIChibG9jay5zZWxlY3Rpb25TdGF0ZSgp ID09IFJlbmRlck9iamVjdDo6Tm9uZSkKLSAgICAgICAgcmV0dXJuIFJlbmRlck9iamVjdDo6Tm9u ZTsKKyAgICBpZiAoYmxvY2suc2VsZWN0aW9uU3RhdGUoKSA9PSBSZW5kZXJPYmplY3Q6OkhpZ2hs aWdodFN0YXRlOjpOb25lKQorICAgICAgICByZXR1cm4gUmVuZGVyT2JqZWN0OjpIaWdobGlnaHRT dGF0ZTo6Tm9uZTsKIAotICAgIGF1dG8gc3RhdGUgPSBSZW5kZXJPYmplY3Q6Ok5vbmU7CisgICAg YXV0byBsaW5lU3RhdGUgPSBSZW5kZXJPYmplY3Q6OkhpZ2hsaWdodFN0YXRlOjpOb25lOwogICAg IGZvciAoYXV0byBib3ggPSBmaXJzdExlYWZCb3goKTsgYm94OyBib3gudHJhdmVyc2VOZXh0T25M aW5lKCkpIHsKICAgICAgICAgYXV0byBib3hTdGF0ZSA9IGJveC0+c2VsZWN0aW9uU3RhdGUoKTsK LSAgICAgICAgaWYgKChib3hTdGF0ZSA9PSBSZW5kZXJPYmplY3Q6OkhpZ2hsaWdodFN0YXRlOjpT dGFydCAmJiBzdGF0ZSA9PSBSZW5kZXJPYmplY3Q6OkhpZ2hsaWdodFN0YXRlOjpFbmQpCi0gICAg ICAgICAgICB8fCAoYm94U3RhdGUgPT0gUmVuZGVyT2JqZWN0OjpIaWdobGlnaHRTdGF0ZTo6RW5k ICYmIHN0YXRlID09IFJlbmRlck9iamVjdDo6SGlnaGxpZ2h0U3RhdGU6OlN0YXJ0KSkKLSAgICAg ICAgICAgIHN0YXRlID0gUmVuZGVyT2JqZWN0OjpIaWdobGlnaHRTdGF0ZTo6Qm90aDsKLSAgICAg ICAgZWxzZSBpZiAoc3RhdGUgPT0gUmVuZGVyT2JqZWN0OjpIaWdobGlnaHRTdGF0ZTo6Tm9uZSB8 fCAoKGJveFN0YXRlID09IFJlbmRlck9iamVjdDo6SGlnaGxpZ2h0U3RhdGU6OlN0YXJ0IHx8IGJv eFN0YXRlID09IFJlbmRlck9iamVjdDo6SGlnaGxpZ2h0U3RhdGU6OkVuZCkKLSAgICAgICAgICAg ICYmIChzdGF0ZSA9PSBSZW5kZXJPYmplY3Q6OkhpZ2hsaWdodFN0YXRlOjpOb25lIHx8IHN0YXRl ID09IFJlbmRlck9iamVjdDo6SGlnaGxpZ2h0U3RhdGU6Okluc2lkZSkpKQotICAgICAgICAgICAg c3RhdGUgPSBib3hTdGF0ZTsKLSAgICAgICAgZWxzZSBpZiAoYm94U3RhdGUgPT0gUmVuZGVyT2Jq ZWN0OjpIaWdobGlnaHRTdGF0ZTo6Tm9uZSAmJiBzdGF0ZSA9PSBSZW5kZXJPYmplY3Q6OkhpZ2hs aWdodFN0YXRlOjpTdGFydCkgewotICAgICAgICAgICAgLy8gV2UgYXJlIHBhc3QgdGhlIGVuZCBv ZiB0aGUgc2VsZWN0aW9uLgotICAgICAgICAgICAgc3RhdGUgPSBSZW5kZXJPYmplY3Q6OkhpZ2hs aWdodFN0YXRlOjpCb3RoOwotICAgICAgICB9IGVsc2UgaWYgKGJveFN0YXRlID09IFJlbmRlck9i amVjdDo6SGlnaGxpZ2h0U3RhdGU6Ok5vbmUgJiYgc3RhdGUgPT0gUmVuZGVyT2JqZWN0OjpIaWdo bGlnaHRTdGF0ZTo6SW5zaWRlKQotICAgICAgICAgICAgc3RhdGUgPSBSZW5kZXJPYmplY3Q6Okhp Z2hsaWdodFN0YXRlOjpFbmQ7Ci0KLSAgICAgICAgaWYgKHN0YXRlID09IFJlbmRlck9iamVjdDo6 SGlnaGxpZ2h0U3RhdGU6OkJvdGgpCisgICAgICAgIGlmIChsaW5lU3RhdGUgPT0gUmVuZGVyT2Jq ZWN0OjpIaWdobGlnaHRTdGF0ZTo6Tm9uZSkKKyAgICAgICAgICAgIGxpbmVTdGF0ZSA9IGJveFN0 YXRlOworICAgICAgICBlbHNlIGlmIChsaW5lU3RhdGUgPT0gUmVuZGVyT2JqZWN0OjpIaWdobGln aHRTdGF0ZTo6U3RhcnQpIHsKKyAgICAgICAgICAgIGlmIChib3hTdGF0ZSA9PSBSZW5kZXJPYmpl Y3Q6OkhpZ2hsaWdodFN0YXRlOjpFbmQgfHwgYm94U3RhdGUgPT0gUmVuZGVyT2JqZWN0OjpIaWdo bGlnaHRTdGF0ZTo6Tm9uZSkKKyAgICAgICAgICAgICAgICBsaW5lU3RhdGUgPSBSZW5kZXJPYmpl Y3Q6OkhpZ2hsaWdodFN0YXRlOjpCb3RoOworICAgICAgICB9IGVsc2UgaWYgKGxpbmVTdGF0ZSA9 PSBSZW5kZXJPYmplY3Q6OkhpZ2hsaWdodFN0YXRlOjpJbnNpZGUpIHsKKyAgICAgICAgICAgIGlm IChib3hTdGF0ZSA9PSBSZW5kZXJPYmplY3Q6OkhpZ2hsaWdodFN0YXRlOjpTdGFydCB8fCBib3hT dGF0ZSA9PSBSZW5kZXJPYmplY3Q6OkhpZ2hsaWdodFN0YXRlOjpFbmQpCisgICAgICAgICAgICAg ICAgbGluZVN0YXRlID0gYm94U3RhdGU7CisgICAgICAgICAgICBlbHNlIGlmIChib3hTdGF0ZSA9 PSBSZW5kZXJPYmplY3Q6OkhpZ2hsaWdodFN0YXRlOjpOb25lKQorICAgICAgICAgICAgICAgIGxp bmVTdGF0ZSA9IFJlbmRlck9iamVjdDo6SGlnaGxpZ2h0U3RhdGU6OkVuZDsKKyAgICAgICAgfSBl bHNlIGlmIChsaW5lU3RhdGUgPT0gUmVuZGVyT2JqZWN0OjpIaWdobGlnaHRTdGF0ZTo6RW5kKSB7 CisgICAgICAgICAgICBpZiAoYm94U3RhdGUgPT0gUmVuZGVyT2JqZWN0OjpIaWdobGlnaHRTdGF0 ZTo6U3RhcnQpCisgICAgICAgICAgICAgICAgbGluZVN0YXRlID0gUmVuZGVyT2JqZWN0OjpIaWdo bGlnaHRTdGF0ZTo6Qm90aDsKKyAgICAgICAgfQorCisgICAgICAgIGlmIChsaW5lU3RhdGUgPT0g UmVuZGVyT2JqZWN0OjpIaWdobGlnaHRTdGF0ZTo6Qm90aCkKICAgICAgICAgICAgIGJyZWFrOwog ICAgIH0KLSAgICByZXR1cm4gc3RhdGU7CisgICAgcmV0dXJuIGxpbmVTdGF0ZTsKIH0KIAogTGVh ZkJveEl0ZXJhdG9yIExpbmU6OmZpcnN0U2VsZWN0ZWRCb3goKSBjb25zdAo=