235181 2022-01-13 05:14:33 -0800 MediaPlayerPrivateMediaStreamAVFObjC::m_videoTransform is redundant 2022-01-14 12:45:16 -0800 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kkinnunen kkinnunen eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer youennf oldest_to_newest 1830524 0 kkinnunen 2022-01-13 05:14:33 -0800 MediaPlayerPrivateMediaStreamAVFObjC::m_videoTransform is redundant Makes it needlessly hard to understand the code, as it is reset in thread-related code. 1830527 1 449051 kkinnunen 2022-01-13 05:33:06 -0800 Created attachment 449051 Patch 1831029 2 ews-feeder 2022-01-14 12:44:31 -0800 Committed r288026 (246052@main): <https://commits.webkit.org/246052@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449051. 1831030 3 webkit-bug-importer 2022-01-14 12:45:16 -0800 <rdar://problem/87614090> 449051 2022-01-13 05:33:06 -0800 2022-01-14 12:44:34 -0800 Patch bug-235181-20220113153304.patch text/plain 6716 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3OTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDlmM2E3MjUwM2I3OTVl ZmJjYzJjMjdiYTNkOTE2MzcyN2ExYWRjZC4uZWNmYjZmYzFhZjg5NTQ4YWY1ZDY5Y2VlZjgyNTQ0 NzkwNGIyNzhiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDIyLTAxLTEzICBLaW1t byBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CisKKyAgICAgICAgTWVkaWFQbGF5ZXJQ cml2YXRlTWVkaWFTdHJlYW1BVkZPYmpDOjptX3ZpZGVvVHJhbnNmb3JtIGlzIHJlZHVuZGFudAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM1MTgxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHZpZGVv IHNhbXBsZSB0cmFuc2Zvcm0gd2FzIHN0b3JlZCBhcyBhIG1lbWJlciB2YXJpYWJsZSBkdXJpbmcg dmlkZW8gc2FtcGxlCisgICAgICAgIGVucXVldWluZy4gSG93ZXZlciwgdGhpcyBpcyBqdXN0IGEg bm9ybWFsIHZpZGVvIHNhbXBsZSBwcm9wZXJ0eSwgYW5kCisgICAgICAgIGRvZXMgbm90IG5lZWQg dG8gYmUgaGFuZGxlZCBzcGVjaWFsbHkuIFRoZSBtZW1iZXIgdmFyaWFibGUgYW55d2F5IGVuZGVk IHVwIGJlaW5nIGFzc2lnbmVkCisgICAgICAgIGR1cmluZyB1c2UuIENhbGN1bGF0aW5nIHRoZSB0 cmFuc2Zvcm0gaXMgbm90IGEgaGVhdnkgb3BlcmF0aW9uLCBzaW5jZSBpdAorICAgICAgICBpcyBh Y2Nlc3NlZCBvbmNlIHBlciB2aWRlbyBwYWludC4KKworICAgICAgICBUaGlzIHNpbXBsaWZpZXMg dGhlIGZ1dHVyZSBjb2RlIHdoZXJlIHRoZSB1bmRlcmx5aW5nIHZpZGVvIGZyYW1lIHdvdWxkIGJl CisgICAgICAgIHVzZWQgYXMtaXMgYnkgV2ViR0wsIGFzIHRoZXJlIHdlIG5lZWQgdG8gaGF2ZSB0 aGUgY29ycmVjdCB0cmFuc2Zvcm0uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCByZWZhY3Rvci4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxh eWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2JqQy5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2Jq Qy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZG T2JqQzo6dmlkZW9TYW1wbGVBdmFpbGFibGUpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5 ZXJQcml2YXRlTWVkaWFTdHJlYW1BVkZPYmpDOjpwcm9jZXNzTmV3VmlkZW9TYW1wbGUpOgorICAg ICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTdHJlYW1BVkZPYmpDOjp1cGRh dGVSZW5kZXJpbmdNb2RlKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZU1l ZGlhU3RyZWFtQVZGT2JqQzo6cGFpbnRDdXJyZW50RnJhbWVJbkNvbnRleHQpOgorCiAyMDIyLTAx LTExICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAg IFJlbW92ZSBEaXJlY3QyRCBjb2RlIChwYXJ0IDIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVN ZWRpYVN0cmVhbUFWRk9iakMuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2 Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2JqQy5oCmlu ZGV4IDE0ODc0ZjJhZTMxYjBjMTVkMzVmYTNlMTAxN2JmMzYyYzI0NzJkZDIuLjZkOTU1Njc0ZDA2 Mjc1YWU0MzNlNWE1NGEzN2MzNGU2YmYzN2Y5YTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1l ZGlhU3RyZWFtQVZGT2JqQy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2JqQy5o CkBAIC0xMzYsNyArMTM2LDcgQEAgcHJpdmF0ZToKIAogICAgIHZvaWQgZmx1c2hSZW5kZXJlcnMo KTsKIAotICAgIHZvaWQgcHJvY2Vzc05ld1ZpZGVvU2FtcGxlKE1lZGlhU2FtcGxlJiwgYm9vbCBo YXNDaGFuZ2VkT3JpZW50YXRpb24sIFZpZGVvU2FtcGxlTWV0YWRhdGEsIFNlY29uZHMpOworICAg IHZvaWQgcHJvY2Vzc05ld1ZpZGVvU2FtcGxlKE1lZGlhU2FtcGxlJiwgVmlkZW9TYW1wbGVNZXRh ZGF0YSwgU2Vjb25kcyk7CiAgICAgdm9pZCBlbnF1ZXVlVmlkZW9TYW1wbGUoTWVkaWFTYW1wbGUm KTsKICAgICB2b2lkIHJlcXVlc3ROb3RpZmljYXRpb25XaGVuUmVhZHlGb3JWaWRlb0RhdGEoKTsK IApAQCAtMjQ4LDcgKzI0OCw2IEBAIHByaXZhdGU6CiAgICAgZmxvYXQgbV92b2x1bWUgeyAxIH07 CiAgICAgRGlzcGxheU1vZGUgbV9kaXNwbGF5TW9kZSB7IE5vbmUgfTsKICAgICBQbGF5YmFja1N0 YXRlIG1fcGxheWJhY2tTdGF0ZSB7IFBsYXliYWNrU3RhdGU6Ok5vbmUgfTsKLSAgICBzdGQ6Om9w dGlvbmFsPENHQWZmaW5lVHJhbnNmb3JtPiBtX3ZpZGVvVHJhbnNmb3JtOwogCiAgICAgLy8gVXNl ZCBvbiBib3RoIG1haW4gdGhyZWFkIGFuZCBzYW1wbGUgdGhyZWFkLgogICAgIHN0ZDo6dW5pcXVl X3B0cjxTYW1wbGVCdWZmZXJEaXNwbGF5TGF5ZXI+IG1fc2FtcGxlQnVmZmVyRGlzcGxheUxheWVy OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0 aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTdHJlYW1BVkZPYmpDLm1tIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQ cml2YXRlTWVkaWFTdHJlYW1BVkZPYmpDLm1tCmluZGV4IDE1Y2YzNjU0NDY3OWRjNWIwNGU5ZjI4 YjVmZmRiNDU3YWY1MDg1OTYuLjQ5ZjQyZjljMDJiODI5NTMyNTc3MzhjMzQ0MDQzZGViNDEwODUx YzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRh dGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2JqQy5tbQorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBs YXllclByaXZhdGVNZWRpYVN0cmVhbUFWRk9iakMubW0KQEAgLTI0Nyw3ICsyNDcsNyBAQCBzdGF0 aWMgaW5saW5lIENHQWZmaW5lVHJhbnNmb3JtIHZpZGVvVHJhbnNmb3JtYXRpb25NYXRyaXgoTWVk aWFTYW1wbGUmIHNhbXBsZSkKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTdHJlYW1BVkZP YmpDOjp2aWRlb1NhbXBsZUF2YWlsYWJsZShNZWRpYVNhbXBsZSYgc2FtcGxlLCBWaWRlb1NhbXBs ZU1ldGFkYXRhIG1ldGFkYXRhKQogewogICAgIGF1dG8gcHJlc2VudGF0aW9uVGltZSA9IE1vbm90 b25pY1RpbWU6Om5vdygpLnNlY29uZHNTaW5jZUVwb2NoKCk7Ci0gICAgcHJvY2Vzc05ld1ZpZGVv U2FtcGxlKHNhbXBsZSwgc2FtcGxlLnZpZGVvUm90YXRpb24oKSAhPSBtX3ZpZGVvUm90YXRpb24g fHwgc2FtcGxlLnZpZGVvTWlycm9yZWQoKSAhPSBtX3ZpZGVvTWlycm9yZWQsIG1ldGFkYXRhLCBw cmVzZW50YXRpb25UaW1lKTsKKyAgICBwcm9jZXNzTmV3VmlkZW9TYW1wbGUoc2FtcGxlLCBtZXRh ZGF0YSwgcHJlc2VudGF0aW9uVGltZSk7CiAgICAgZW5xdWV1ZVZpZGVvU2FtcGxlKHNhbXBsZSk7 CiB9CiAKQEAgLTI3NywyMCArMjc3LDE3IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFT dHJlYW1BVkZPYmpDOjplbnF1ZXVlVmlkZW9TYW1wbGUoTWVkaWFTYW1wbGUmIHNhbXBsCiAgICAg bV9zYW1wbGVCdWZmZXJEaXNwbGF5TGF5ZXItPmVucXVldWVTYW1wbGUoc2FtcGxlKTsKIH0KIAot dm9pZCBNZWRpYVBsYXllclByaXZhdGVNZWRpYVN0cmVhbUFWRk9iakM6OnByb2Nlc3NOZXdWaWRl b1NhbXBsZShNZWRpYVNhbXBsZSYgc2FtcGxlLCBib29sIGhhc0NoYW5nZWRPcmllbnRhdGlvbiwg VmlkZW9TYW1wbGVNZXRhZGF0YSBtZXRhZGF0YSwgU2Vjb25kcyBwcmVzZW50YXRpb25UaW1lKQor dm9pZCBNZWRpYVBsYXllclByaXZhdGVNZWRpYVN0cmVhbUFWRk9iakM6OnByb2Nlc3NOZXdWaWRl b1NhbXBsZShNZWRpYVNhbXBsZSYgc2FtcGxlLCBWaWRlb1NhbXBsZU1ldGFkYXRhIG1ldGFkYXRh LCBTZWNvbmRzIHByZXNlbnRhdGlvblRpbWUpCiB7CiAgICAgaWYgKCFpc01haW5UaHJlYWQoKSkg ewogICAgICAgICB7CiAgICAgICAgICAgICBMb2NrZXIgbG9ja2VyIHsgbV9jdXJyZW50VmlkZW9T YW1wbGVMb2NrIH07CiAgICAgICAgICAgICBtX2N1cnJlbnRWaWRlb1NhbXBsZSA9ICZzYW1wbGU7 CiAgICAgICAgIH0KLSAgICAgICAgY2FsbE9uTWFpblRocmVhZChbd2Vha1RoaXMgPSBXZWFrUHRy IHsgKnRoaXMgfSwgaGFzQ2hhbmdlZE9yaWVudGF0aW9uLCBtZXRhZGF0YSwgcHJlc2VudGF0aW9u VGltZV0oKSBtdXRhYmxlIHsKKyAgICAgICAgY2FsbE9uTWFpblRocmVhZChbd2Vha1RoaXMgPSBX ZWFrUHRyIHsgKnRoaXMgfSwgbWV0YWRhdGEsIHByZXNlbnRhdGlvblRpbWVdKCkgbXV0YWJsZSB7 CiAgICAgICAgICAgICBpZiAoIXdlYWtUaGlzKQogICAgICAgICAgICAgICAgIHJldHVybjsKIAot ICAgICAgICAgICAgaWYgKGhhc0NoYW5nZWRPcmllbnRhdGlvbikKLSAgICAgICAgICAgICAgICB3 ZWFrVGhpcy0+bV92aWRlb1RyYW5zZm9ybSA9IHsgfTsKLQogICAgICAgICAgICAgUmVmUHRyPE1l ZGlhU2FtcGxlPiBzYW1wbGU7CiAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgTG9ja2Vy IGxvY2tlciB7IHdlYWtUaGlzLT5tX2N1cnJlbnRWaWRlb1NhbXBsZUxvY2sgfTsKQEAgLTI5OSw3 ICsyOTYsNyBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2JqQzo6cHJv Y2Vzc05ld1ZpZGVvU2FtcGxlKE1lZGlhU2FtcGxlJiBzYQogICAgICAgICAgICAgaWYgKCFzYW1w bGUpCiAgICAgICAgICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgICAgICB3ZWFrVGhpcy0+cHJv Y2Vzc05ld1ZpZGVvU2FtcGxlKCpzYW1wbGUsIGhhc0NoYW5nZWRPcmllbnRhdGlvbiwgbWV0YWRh dGEsIHByZXNlbnRhdGlvblRpbWUpOworICAgICAgICAgICAgd2Vha1RoaXMtPnByb2Nlc3NOZXdW aWRlb1NhbXBsZSgqc2FtcGxlLCBtZXRhZGF0YSwgcHJlc2VudGF0aW9uVGltZSk7CiAgICAgICAg IH0pOwogICAgICAgICByZXR1cm47CiAgICAgfQpAQCAtMzA3LDkgKzMwNCw2IEBAIHZvaWQgTWVk aWFQbGF5ZXJQcml2YXRlTWVkaWFTdHJlYW1BVkZPYmpDOjpwcm9jZXNzTmV3VmlkZW9TYW1wbGUo TWVkaWFTYW1wbGUmIHNhCiAgICAgaWYgKCFtX2FjdGl2ZVZpZGVvVHJhY2spCiAgICAgICAgIHJl dHVybjsKIAotICAgIGlmIChoYXNDaGFuZ2VkT3JpZW50YXRpb24pCi0gICAgICAgIG1fdmlkZW9U cmFuc2Zvcm0gPSB7IH07Ci0KICAgICBpZiAoIW1faW1hZ2VQYWludGVyLm1lZGlhU2FtcGxlIHx8 IG1fZGlzcGxheU1vZGUgIT0gUGF1c2VkSW1hZ2UpIHsKICAgICAgICAgbV9pbWFnZVBhaW50ZXIu bWVkaWFTYW1wbGUgPSAmc2FtcGxlOwogICAgICAgICBtX2ltYWdlUGFpbnRlci5jZ0ltYWdlID0g bnVsbHB0cjsKQEAgLTcyMSw3ICs3MTUsNiBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlh U3RyZWFtQVZGT2JqQzo6dXBkYXRlUmVuZGVyaW5nTW9kZSgpCiAgICAgICAgIHJldHVybjsKIAog ICAgIHNjaGVkdWxlRGVmZXJyZWRUYXNrKFt0aGlzXSB7Ci0gICAgICAgIG1fdmlkZW9UcmFuc2Zv cm0gPSB7IH07CiAgICAgICAgIGlmIChtX3BsYXllcikKICAgICAgICAgICAgIG1fcGxheWVyLT5y ZW5kZXJpbmdNb2RlQ2hhbmdlZCgpOwogICAgIH0pOwpAQCAtMTAwNCw5ICs5OTcsNyBAQCB2b2lk IE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2JqQzo6cGFpbnRDdXJyZW50RnJhbWVJ bkNvbnRleHQoR3JhcGhpY3NDbwogCiAgICAgYXV0byYgaW1hZ2UgPSBtX2ltYWdlUGFpbnRlci5j Z0ltYWdlOwogICAgIEZsb2F0UmVjdCBpbWFnZVJlY3QgeyBGbG9hdFBvaW50Ojp6ZXJvKCksIGlt YWdlLT5zaXplKCkgfTsKLSAgICBpZiAoIW1fdmlkZW9UcmFuc2Zvcm0pCi0gICAgICAgIG1fdmlk ZW9UcmFuc2Zvcm0gPSB2aWRlb1RyYW5zZm9ybWF0aW9uTWF0cml4KCptX2ltYWdlUGFpbnRlci5t ZWRpYVNhbXBsZSk7Ci0gICAgQWZmaW5lVHJhbnNmb3JtIHZpZGVvVHJhbnNmb3JtID0gKm1fdmlk ZW9UcmFuc2Zvcm07CisgICAgQWZmaW5lVHJhbnNmb3JtIHZpZGVvVHJhbnNmb3JtID0gdmlkZW9U cmFuc2Zvcm1hdGlvbk1hdHJpeCgqbV9pbWFnZVBhaW50ZXIubWVkaWFTYW1wbGUpOwogICAgIEZs b2F0UmVjdCB0cmFuc2Zvcm1lZERlc3RSZWN0ID0gdmFsdWVPckRlZmF1bHQodmlkZW9UcmFuc2Zv cm0uaW52ZXJzZSgpKS5tYXBSZWN0KGRlc3RSZWN0KTsKICAgICBjb250ZXh0LmNvbmNhdENUTSh2 aWRlb1RyYW5zZm9ybSk7CiAgICAgY29udGV4dC5kcmF3TmF0aXZlSW1hZ2UoKmltYWdlLCBpbWFn ZVJlY3Quc2l6ZSgpLCB0cmFuc2Zvcm1lZERlc3RSZWN0LCBpbWFnZVJlY3QpOwo=