235178 2022-01-13 04:11:10 -0800 Remove the code inside USE(OPENGL) && ENABLE(WEBGL2) 2022-01-13 12:44:38 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 225563 1 alex webkit-unassigned cdumez changseok clord dino esprehn+autocc ews-watchlist gyuyoung.kim kbr kkinnunen kondapallykalyan webkit-bug-importer oldest_to_newest 1830509 0 alex 2022-01-13 04:11:10 -0800 No port is supporting WebGL2 without ANGLE nowadays, that code is historical. 1830514 1 449045 alex 2022-01-13 04:36:11 -0800 Created attachment 449045 Proposed patch Proposed patch. 1830641 2 ews-feeder 2022-01-13 11:13:03 -0800 Committed r287984 (246013@main): <https://commits.webkit.org/246013@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449045. 1830643 3 webkit-bug-importer 2022-01-13 11:14:16 -0800 <rdar://problem/87560764> 1830659 4 kkinnunen 2022-01-13 12:17:48 -0800 Great work! Are you further working on this? E.g removing all !ANGLE, OPENGL_ES codes from WebGL2 codepaths and removing #if USE(ANGLE)s? Asking just so I know if somebody is working on it or not? 1830670 5 alex 2022-01-13 12:44:38 -0800 (In reply to Kimmo Kinnunen from comment #4) > Great work! > Are you further working on this? E.g removing all !ANGLE, OPENGL_ES codes > from WebGL2 codepaths and removing #if USE(ANGLE)s? Asking just so I know if > somebody is working on it or not? further working on this? E.g removing all !ANGLE, OPENGL_ES codes from WebGL2 codepaths and removing #if +USE(ANGLE)s? Asking just so I know if somebody is working We are still not working on it, we did this one because we needed it to solve WEBGL2 compilation, but our plan is to finish the implementation of the final architecture for the ANGLE backend in GTK/WPE ports first, and later we can work removing the code. For the moment for our ports OPENGL continues to be the solution for WEBGL (and WEBGL2 is not supported) until we make the new architecture with ANGLE backend work without perfomance/feature regressions. To avoid a lot of rebases in the process of landing the refactorings we need for the new architecture. 449045 2022-01-13 04:36:11 -0800 2022-01-13 11:13:07 -0800 Proposed patch patch text/plain 3514 alex ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5YWZhZWM2NmRkNzguLjA5MGU0OWIyYmNmOSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE5IEBACisyMDIyLTAxLTEzICBBbGVqYW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2Fs aWEuY29tPgorCisgICAgICAgIFJlbW92ZSB0aGUgY29kZSBpbnNpZGUgVVNFKE9QRU5HTCkgJiYg RU5BQkxFKFdFQkdMMikKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzNTE3OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIHBvcnQgaXMgc3VwcG9ydGluZyBXZWJHTDIgd2l0aG91dCBBTkdMRSBub3dhZGF5 cywgdGhhdCBjb2RlIGlzCisgICAgICAgIGhpc3RvcmljYWwgYW5kIHdlIGNhbiByZW1vdmUgaXQu CisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OmdldFJlc3RhcnRJbmRleCk6IERlbGV0ZWQuCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dEdMT3BlbkdMLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dEdMT3BlbkdMOjpwcmltaXRpdmVSZXN0YXJ0 SW5kZXgpOiBEZWxldGVkLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFw aGljc0NvbnRleHRHTE9wZW5HTC5oOgorCiAyMDIyLTAxLTEyICBBbGVqYW5kcm8gRy4gQ2FzdHJv ICA8YWxleEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdW1dQRV1bV2ViR0wyXSBjb21waWxh dGlvbiBmaXhlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xS ZW5kZXJpbmdDb250ZXh0QmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJH TFJlbmRlcmluZ0NvbnRleHRCYXNlLmNwcAppbmRleCAzMGM1NTU1MDUzZWYuLmQzMGU4YzgzOGM5 ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdD b250ZXh0QmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5k ZXJpbmdDb250ZXh0QmFzZS5jcHAKQEAgLTI3NjYsMjIgKzI3NjYsNiBAQCB2b2lkIFdlYkdMUmVu ZGVyaW5nQ29udGV4dEJhc2U6OmRyYXdBcnJheXMoR0NHTGVudW0gbW9kZSwgR0NHTGludCBmaXJz dCwgR0NHTHNpegogICAgIG1hcmtDb250ZXh0Q2hhbmdlZEFuZE5vdGlmeUNhbnZhc09ic2VydmVy KCk7CiB9CiAKLSNpZiBVU0UoT1BFTkdMKSAmJiBFTkFCTEUoV0VCR0wyKQotc3RhdGljIEdDR0x1 aW50IGdldFJlc3RhcnRJbmRleChHQ0dMZW51bSB0eXBlKQotewotICAgIHN3aXRjaCAodHlwZSkg ewotICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0R0w6OlVOU0lHTkVEX0JZVEU6Ci0gICAgICAgIHJl dHVybiBzdGQ6Om51bWVyaWNfbGltaXRzPEdDR0x1Ynl0ZT46Om1heCgpOwotICAgIGNhc2UgR3Jh cGhpY3NDb250ZXh0R0w6OlVOU0lHTkVEX1NIT1JUOgotICAgICAgICByZXR1cm4gc3RkOjpudW1l cmljX2xpbWl0czxHQ0dMdXNob3J0Pjo6bWF4KCk7Ci0gICAgY2FzZSBHcmFwaGljc0NvbnRleHRH TDo6VU5TSUdORURfSU5UOgotICAgICAgICByZXR1cm4gc3RkOjpudW1lcmljX2xpbWl0czxHQ0dM dWludD46Om1heCgpOwotICAgIH0KLQotICAgIHJldHVybiAwOwotfQotI2VuZGlmCi0KIHZvaWQg V2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZTo6ZHJhd0VsZW1lbnRzKEdDR0xlbnVtIG1vZGUsIEdD R0xzaXplaSBjb3VudCwgR0NHTGVudW0gdHlwZSwgbG9uZyBsb25nIG9mZnNldCkKIHsKICNpZiBV U0UoQU5HTEUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9v cGVuZ2wvR3JhcGhpY3NDb250ZXh0R0xPcGVuR0wuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dEdMT3BlbkdMLmNwcAppbmRleCAyYzBk OTk3Y2YzODAuLjYwYmE0NDNhMTMxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dEdMT3BlbkdMLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0R0xPcGVu R0wuY3BwCkBAIC0yMzgzLDE2ICsyMzgzLDYgQEAgdm9pZCBHcmFwaGljc0NvbnRleHRHTE9wZW5H TDo6dmVydGV4QXR0cmliRGl2aXNvcihHQ0dMdWludCBpbmRleCwgR0NHTHVpbnQgZGl2aXMKICAg ICBnZXRFeHRlbnNpb25zKCkudmVydGV4QXR0cmliRGl2aXNvckFOR0xFKGluZGV4LCBkaXZpc29y KTsKIH0KIAotI2lmIEhBVkUoT1BFTkdMXzQpICYmIEVOQUJMRShXRUJHTDIpCi12b2lkIEdyYXBo aWNzQ29udGV4dEdMT3BlbkdMOjpwcmltaXRpdmVSZXN0YXJ0SW5kZXgoR0NHTHVpbnQgaW5kZXgp Ci17Ci0gICAgaWYgKCFtYWtlQ29udGV4dEN1cnJlbnQoKSkKLSAgICAgICAgcmV0dXJuOwotCi0g ICAgOjpnbFByaW1pdGl2ZVJlc3RhcnRJbmRleChpbmRleCk7Ci19Ci0jZW5kaWYKLQogdm9pZCBH cmFwaGljc0NvbnRleHRHTE9wZW5HTDo6YnVmZmVyRGF0YShHQ0dMZW51bSB0YXJnZXQsIGNvbnN0 IHZvaWQqIGRhdGEsIEdDR0xlbnVtIHVzYWdlLCBHQ0dMdWludCBzcmNPZmZzZXQsIEdDR0x1aW50 IGxlbmd0aCkKIHsKICAgICBVTlVTRURfUEFSQU0odGFyZ2V0KTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHRHTE9wZW5H TC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29u dGV4dEdMT3BlbkdMLmgKaW5kZXggZjJhNzkyOGQ1ZWU1Li40NjVjYmM2Mjc3YzIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRl eHRHTE9wZW5HTC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5n bC9HcmFwaGljc0NvbnRleHRHTE9wZW5HTC5oCkBAIC0zODMsMTEgKzM4Myw2IEBAIHB1YmxpYzoK ICAgICBzdGQ6Om9wdGlvbmFsPFBpeGVsQnVmZmVyPiByZWFkUmVuZGVyaW5nUmVzdWx0c0ZvclBh aW50aW5nKCk7CiAgICAgc3RkOjpvcHRpb25hbDxQaXhlbEJ1ZmZlcj4gcmVhZENvbXBvc2l0ZWRS ZXN1bHRzRm9yUGFpbnRpbmcoKTsKIAotI2lmIFVTRShPUEVOR0wpICYmIEVOQUJMRShXRUJHTDIp Ci0gICAgdm9pZCBwcmltaXRpdmVSZXN0YXJ0SW5kZXgoR0NHTHVpbnQpOwotI2VuZGlmCi0KLQog ICAgIHZvaWQgc2V0Q29udGV4dFZpc2liaWxpdHkoYm9vbCkgZmluYWw7CiAKICAgICAvLyBTdXBw b3J0IGZvciBidWZmZXIgY3JlYXRpb24gYW5kIGRlbGV0aW9uCg==