235169 2022-01-12 17:38:19 -0800 [macOS WK1] fast/canvas/large-getImageData.html is consistently failing 2022-01-14 20:16:37 -0800 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=234321 InRadar P2 Normal --- 1 ryanhaddad mmaxfield dino mmaxfield webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1830426 0 ryanhaddad 2022-01-12 17:38:19 -0800 fast/canvas/large-getImageData.html has been consistently failing on macOS WK1 bots since it was added with https://trac.webkit.org/changeset/287805/webkit --- /Volumes/Data/worker/catalina-release-tests-wk1/build/layout-test-results/fast/canvas/large-getImageData-expected.txt +++ /Volumes/Data/worker/catalina-release-tests-wk1/build/layout-test-results/fast/canvas/large-getImageData-actual.txt @@ -1,5 +1,7 @@ -PASS large getImageData worked +CONSOLE MESSAGE: Total canvas memory use exceeds the maximum limit (64 MB). +FAIL large getImageData threw PASS successfullyParsed is true +Some tests failed. TEST COMPLETE https://results.webkit.org/?suite=layout-tests&test=fast%2Fcanvas%2Flarge-getImageData.html 1830427 1 webkit-bug-importer 2022-01-12 17:38:32 -0800 <rdar://problem/87523265> 1830428 2 ryanhaddad 2022-01-12 17:38:38 -0800 Myles, is this expected to fail on WK1? 1830447 3 mmaxfield 2022-01-12 19:21:34 -0800 Oh yes this will fail on WK1. We should add a skip (not flakey!) line to TestExpectations. 1830567 4 ryanhaddad 2022-01-13 09:11:02 -0800 (In reply to Myles C. Maxfield from comment #3) > Oh yes this will fail on WK1. We should add a skip (not flakey!) line to > TestExpectations. Would you please take care of this? Thanks! 1830608 5 449078 mmaxfield 2022-01-13 10:17:50 -0800 Created attachment 449078 Patch 1831118 6 ap 2022-01-14 16:33:43 -0800 Is this good to go? 1831151 7 mmaxfield 2022-01-14 20:06:35 -0800 (In reply to Alexey Proskuryakov from comment #6) > Is this good to go? Checking now... 1831153 8 mmaxfield 2022-01-14 20:11:10 -0800 Yes. 1831154 9 mmaxfield 2022-01-14 20:16:37 -0800 Committed r288051 (246071@trunk): <https://commits.webkit.org/246071@trunk> 449078 2022-01-13 10:17:50 -0800 2022-01-14 20:11:19 -0800 Patch bug-235169-20220113101749.patch text/plain 2066 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3OTgwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDFiNjY3NjZhOTQ4M2UzOWFlZDM1 N2M2NDAyZmZlN2RhN2YyYjgzMy4uY2NiNjg2M2Q0NGY0OTEwMTcyMjIyMWI2OGI1NzQwZmZlY2Qy Y2Q1NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAxLTEzICBNeWxlcyBDLiBNYXhmaWVs ZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TIFdLMV0gZmFzdC9jYW52 YXMvbGFyZ2UtZ2V0SW1hZ2VEYXRhLmh0bWwgaXMgY29uc2lzdGVudGx5IGZhaWxpbmcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTE2OQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgdGVzdCBnZXRz IHZlcnkgY2xvc2UgdG8gdGhlIGNhbnZhcyBtZW1vcnkgbGltaXQuIEJlY2F1c2UKKyAgICAgICAg SlNDIGhhcyBubyBndWFyYW50ZWVzIGFib3V0IHdoZW4gb2JqZWN0cyBhcmUgY29sbGVjdGVkLCB0 aGlzIHRlc3QKKyAgICAgICAgaGFzIHRvIGJlIHJ1biBpbiBpdHMgb3duIHByb2Nlc3MsIHdoaWNo IG1lYW5zIGl0IHJlcXVpcmVzIFdLMiBhbmQKKyAgICAgICAgPCEtLSB3ZWJraXQtdGVzdC1ydW5u ZXIgWyBydW5TaW5nbHk9dHJ1ZSBdIC0tPi4KKworICAgICAgICAqIFRlc3RFeHBlY3RhdGlvbnM6 CisgICAgICAgICogcGxhdGZvcm0vd2syL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMjItMDEtMTAg IFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAgW2Nz cy1mbGV4Ym94XSBJbmNvcnJlY3QgaGVpZ2h0IG9mIGZsZXggaXRlbXMgd2l0aCBhc3BlY3QtcmF0 aW8gd2hlbmV2ZXIgdGhlIGNyb3NzIGF4aXMgaW50cmluc2ljIHNpemUgaXMgbGFyZ2VyIHRoYW4g dGhlIHZpZXdwb3J0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zIGIv TGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA1YzUwYzg5MzZhNzcwOTBhODUwNDQ0 MzdmMGM1NWRhOTQ5YWUwMmQ0Li42ZTRkYzc0Mjg1NWJjYzlkZjY4NGIxNzdkMzI1NTAzZmQxYzg2 OTVkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91 dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTUyNzEsMyArNTI3MSw2IEBAIGltcG9ydGVkL2Js aW5rL2h0dHAvdGVzdHMvcGx1Z2lucyBbIFNraXAgXQogaW1wb3J0ZWQvYmxpbmsvcGx1Z2lucyBb IFNraXAgXQoganMvZG9tL3JlZmxlY3Qtc2V0LW9udG8tZG9tLmh0bWwgWyBTa2lwIF0KIHVzZXJz Y3JpcHRzL3VzZXItc2NyaXB0LXBsdWdpbi1kb2N1bWVudC5odG1sIFsgU2tpcCBdCisKKyMgVGhp cyBpcyBtYXJrZWQgYXMgcGFzc2luZyBvbiBXSzIuCitmYXN0L2NhbnZhcy9sYXJnZS1nZXRJbWFn ZURhdGEuaHRtbCBbIFNraXAgXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2sy L1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93azIvVGVzdEV4cGVjdGF0 aW9ucwppbmRleCA5ODkxMzM0YjMyMzI3MTExMGRhMDdiNjg0NDU2YWNlN2Q4YWE0YWU5Li44N2Jl M2I4MGZmMTI5ZTM3ZGViZTFhZmNkM2ZmZWY5ZTkzMzhhMzJmIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS93azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS93azIvVGVzdEV4cGVjdGF0aW9ucwpAQCAtODYwLDMgKzg2MCw0IEBAIGltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvc3RvcmFnZS8gWyBQYXNzIF0KIGltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvZmlsZS1zeXN0ZW0tYWNjZXNzLyBbIFBhc3MgXQogc3RvcmFnZS9maWxl c3lzdGVtYWNjZXNzLyBbIFBhc3MgXQogCitmYXN0L2NhbnZhcy9sYXJnZS1nZXRJbWFnZURhdGEu aHRtbCBbIFBhc3MgXQo=