235168 2022-01-12 17:21:11 -0800 REGRESSION (r287574): ASSERTION FAILED: !m_impl || !m_shouldEnableAssertions || m_impl->wasConstructedOnMainThread() == isMainThread() under WebCore::AVTrackPrivateAVFObjCImpl::initializeAssetTrack() 2022-02-24 10:21:07 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=237125 InRadar P2 Normal --- 1 ryanhaddad jer.noble cdumez eric.carlson jer.noble webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1830423 0 ryanhaddad 2022-01-12 17:21:11 -0800 The following API tests are asserting on iOS Debug bots: TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS TestWebKitAPI.WebKitLegacy.PreemptVideoFullscreen TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia ASSERTION FAILED: !m_impl || !m_shouldEnableAssertions || m_impl->wasConstructedOnMainThread() == isMainThread() /Volumes/Data/worker/ios-simulator-15-debug/build/WebKitBuild/Debug-iphonesimulator/usr/local/include/wtf/WeakPtr.h(148) : T *WTF::WeakPtr<WebCore::AVTrackPrivateAVFObjCImpl>::operator->() const 1 0x117b9ef99 WTFCrash 2 0x16712b27b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x1671c554a WTF::WeakPtr<WebCore::AVTrackPrivateAVFObjCImpl, WTF::EmptyCounter>::operator->() const 4 0x1671c53bf WebCore::AVTrackPrivateAVFObjCImpl::initializeAssetTrack()::$_0::operator()()::'lambda'()::operator()() const 5 0x1671c52f9 WTF::Detail::CallableWrapper<WebCore::AVTrackPrivateAVFObjCImpl::initializeAssetTrack()::$_0::operator()()::'lambda'(), void>::call() 6 0x117bcc3a2 WTF::Function<void ()>::operator()() const 7 0x117c5e27e WTF::RunLoop::performWork() 8 0x117c62aae WTF::RunLoop::performWork(void*) 9 0x10da57e25 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 10 0x10da57d1d __CFRunLoopDoSource0 11 0x10da571f2 __CFRunLoopDoSources0 12 0x10da51951 __CFRunLoopRun 13 0x10da51103 CFRunLoopRunSpecific 14 0x10e6cc41c -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 15 0x106f2fc53 TestWebKitAPI::Util::run(bool*) 16 0x10635ce03 TestWebKitAPI::WebKitLegacy_AudioSessionCategoryIOS_Test::TestBody() 17 0x106fa80fb void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) 18 0x106f7f95a void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) 19 0x106f7f8a3 testing::Test::Run() 20 0x106f80931 testing::TestInfo::Run() 21 0x106f819b4 testing::TestSuite::Run() 22 0x106f9052f testing::internal::UnitTestImpl::RunAllTests() 23 0x106fac40b bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) 24 0x106f8ff0a bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) 25 0x106f8fdeb testing::UnitTest::Run() 26 0x10674cf11 RUN_ALL_TESTS() 27 0x10674cea6 TestWebKitAPI::TestsController::run(int, char**) 28 0x106f53cfb main 29 0x109542e1e https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS&test=TestWebKitAPI.WebKitLegacy.PreemptVideoFullscreen&test=TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia Test history suggests this regressed with https://trac.webkit.org/changeset/287574/webkit 1830424 1 webkit-bug-importer 2022-01-12 17:21:22 -0800 <rdar://problem/87518939> 1844955 2 452923 jer.noble 2022-02-22 17:17:30 -0800 Created attachment 452923 Patch 1844979 3 452923 ap 2022-02-22 19:09:33 -0800 Comment on attachment 452923 Patch r=ews Are there any tests to unskip? 1845139 4 ews-feeder 2022-02-23 07:56:03 -0800 Committed r290372 (247688@main): <https://commits.webkit.org/247688@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452923. 1845170 5 ryanhaddad 2022-02-23 09:26:21 -0800 (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 452923 [details] > Patch > > r=ews > > Are there any tests to unskip? No, thanks for checking. 452923 2022-02-22 17:17:30 -0800 2022-02-23 07:56:05 -0800 Patch bug-235168-20220222171729.patch text/plain 2063 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMzE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGEwMGJjZjE1NTk4YzQx NGJkMzZhNWM5YjNkYWQzNGU3ZDA4MjRkYi4uODE5OTgzMjAwMDcxMWZkOTVjMjQxZGM3N2RjNGM2 OGYwZjAwNTRlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAyLTIyICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyODc1 NzQpOiBBU1NFUlRJT04gRkFJTEVEOiAhbV9pbXBsIHx8ICFtX3Nob3VsZEVuYWJsZUFzc2VydGlv bnMgfHwgbV9pbXBsLT53YXNDb25zdHJ1Y3RlZE9uTWFpblRocmVhZCgpID09IGlzTWFpblRocmVh ZCgpIHVuZGVyIFdlYkNvcmU6OkFWVHJhY2tQcml2YXRlQVZGT2JqQ0ltcGw6OmluaXRpYWxpemVB c3NldFRyYWNrKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIzNTE2OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODc1MTg5Mzk+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHJ1bk9uTWFpblRocmVh ZCgpIGZyb20gd2l0aGluIFdlYkNvcmUsIGFzIGl0IHdpbGwgZGlzcGF0Y2ggdG8gdGhlIGNvcnJl Y3QgdGhyZWFkIHdoZW4KKyAgICAgICAgcnVubmluZyB1bmRlciBpT1MvV2ViS2l0TGVnYWN5Lgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL0FWVHJhY2tQcml2YXRl QVZGT2JqQ0ltcGwubW06CisgICAgICAgIChXZWJDb3JlOjpBVlRyYWNrUHJpdmF0ZUFWRk9iakNJ bXBsOjppbml0aWFsaXplQXNzZXRUcmFjayk6CisKIDIwMjItMDItMjEgIEplciBOb2JsZSAgPGpl ci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gV2ViS2l0IGFwcCBpcyBzb21ldGlt ZXMgbm90ICJOb3cgUGxheWluZyIgZHVyaW5nIGluaXRpYWwgcGxheWJhY2sKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9BVlRyYWNrUHJp dmF0ZUFWRk9iakNJbXBsLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZm b3VuZGF0aW9uL0FWVHJhY2tQcml2YXRlQVZGT2JqQ0ltcGwubW0KaW5kZXggOTZlM2ZlZDgxNWY0 MzNjYTY2NDFjYjhiNzk0MTdhYjI5ZjFlOGEzNC4uNWU3YjRlNzgzYWI4YzEzODE1M2FkZTUwZGNj ODQ5YjRhMWZkZGZiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvYXZmb3VuZGF0aW9uL0FWVHJhY2tQcml2YXRlQVZGT2JqQ0ltcGwubW0KKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL0FWVHJhY2tQcml2YXRlQVZG T2JqQ0ltcGwubW0KQEAgLTg3LDcgKzg3LDcgQEAgdm9pZCBBVlRyYWNrUHJpdmF0ZUFWRk9iakNJ bXBsOjppbml0aWFsaXplQXNzZXRUcmFjaygpCiAgICAgICAgIHJldHVybjsKIAogICAgIFttX2Fz c2V0VHJhY2sgbG9hZFZhbHVlc0FzeW5jaHJvbm91c2x5Rm9yS2V5czphc3NldFRyYWNrQ29uZmln dXJhdGlvbktleU5hbWVzKCkgY29tcGxldGlvbkhhbmRsZXI6W3dlYWtUaGlzID0gV2Vha1B0cih0 aGlzKV0gKCkgbXV0YWJsZSB7Ci0gICAgICAgIGNhbGxPbk1haW5SdW5Mb29wKFt3ZWFrVGhpcyA9 IFdURk1vdmUod2Vha1RoaXMpXSB7CisgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoW3dlYWtUaGlz ID0gV1RGTW92ZSh3ZWFrVGhpcyldIHsKICAgICAgICAgICAgIGlmICh3ZWFrVGhpcyAmJiB3ZWFr VGhpcy0+bV9hdWRpb1RyYWNrQ29uZmlndXJhdGlvbk9ic2VydmVyKQogICAgICAgICAgICAgICAg ICgqd2Vha1RoaXMtPm1fYXVkaW9UcmFja0NvbmZpZ3VyYXRpb25PYnNlcnZlcikoKTsKICAgICAg ICAgICAgIGlmICh3ZWFrVGhpcyAmJiB3ZWFrVGhpcy0+bV92aWRlb1RyYWNrQ29uZmlndXJhdGlv bk9ic2VydmVyKQo=