235162 2022-01-12 15:47:17 -0800 Fix a few Objective-C object leaks due to early returns in `init` 2022-02-02 11:58:19 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 236033 1 thorton thorton darin ews-watchlist joepeck keith_miller mark.lam msaboff saam sam tzagallo webkit-bug-importer wenson_hsieh oldest_to_newest 1830381 0 thorton 2022-01-12 15:47:17 -0800 Fix a few Objective-C object leaks due to early returns in `init` 1830385 1 449008 thorton 2022-01-12 15:50:29 -0800 Created attachment 449008 Patch 1830386 2 thorton 2022-01-12 15:50:31 -0800 <rdar://problem/87489048> 1830390 3 449008 wenson_hsieh 2022-01-12 15:58:01 -0800 Comment on attachment 449008 Patch rs=me 1830404 4 449008 joepeck 2022-01-12 16:23:13 -0800 Comment on attachment 449008 Patch Yay! Thanks! 1830660 5 449008 thorton 2022-01-13 12:19:32 -0800 Comment on attachment 449008 Patch Debug EWS is hosed for unrelated reasons. 1830662 6 ews-feeder 2022-01-13 12:24:01 -0800 Committed r287986 (246015@main): <https://commits.webkit.org/246015@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449008. 449008 2022-01-12 15:50:29 -0800 2022-01-13 12:24:04 -0800 Patch bug-235162-20220112155028.patch text/plain 5606 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3OTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh YWQ0ZDIxOWM2OWVlY2U5YWVlNjIzYTFmMTNmNDY4ZTcyZTNkM2E0Li5iNDYzYTc3MjlmZDlmZjE5 ZWI0NzdmYTRmY2MwZTNlYjc1N2NmNTY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAyMi0wMS0xMiAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxl LmNvbT4KKworICAgICAgICBGaXggYSBmZXcgT2JqZWN0aXZlLUMgb2JqZWN0IGxlYWtzIGR1ZSB0 byBlYXJseSByZXR1cm5zIGluIGBpbml0YAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjM1MTYyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NzQ4OTA0 OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEFQ SS9KU1ZhbHVlLm1tOgorICAgICAgICAoLVtKU1ZhbHVlIGluaXRXaXRoVmFsdWU6aW5Db250ZXh0 Ol0pOgorCiAyMDIyLTAxLTEyICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9y Zz4KIAogICAgICAgICBVbnJldmlld2VkLCByZXZlcnRpbmcgcjI4NzkwOC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCAzZWIzN2EzZTgzYWY3YTIwMmYzZDQ1MDAyNDYwNGRhNjQ3MzNhZDMyLi4zMGNmOTk4NjNmMjE5 YTUzMWRkZDI3ZDhiOTMwMjlhZWUxNTExMmM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMjItMDEtMTIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAg ICAgICAgRml4IGEgZmV3IE9iamVjdGl2ZS1DIG9iamVjdCBsZWFrcyBkdWUgdG8gZWFybHkgcmV0 dXJucyBpbiBgaW5pdGAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzNTE2MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODc0ODkwNDg+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mv V2ViQVZQbGF5ZXJDb250cm9sbGVyLm1tOgorICAgICAgICAoLVtXZWJBVlBsYXllckNvbnRyb2xs ZXIgaW5pdF0pOgorCiAyMDIyLTAxLTEyICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBw bGUuY29tPgogCiAgICAgICAgIFttYWNPU10gW1dLMl0gTlNGb250UGFuZWwgVUkgKGZvbnQgY29s b3IsIHRleHQgZGVjb3JhdGlvbnMsIGZvbnQgc2hhZG93KSBkb2Vzbid0IHVwZGF0ZSBvbiBzZWxl Y3Rpb24gY2hhbmdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM1ZDhkNzkwYjExZGViNTNkZTM2ZGRlMTA0ZjU5ZWFi Y2RjZjk4ZWIuLjlhMGQ2ODU2MThlYzlhNzQ0ZjlhY2U0N2Y2YzQ4ZjlhYjk2MDI3OWUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjItMDEtMTIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hv cnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGEgZmV3IE9iamVjdGl2ZS1DIG9iamVjdCBs ZWFrcyBkdWUgdG8gZWFybHkgcmV0dXJucyBpbiBgaW5pdGAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTE2MgorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vODc0ODkwNDg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLSG92ZXJQbGF0dGVyLm1tOgorICAgICAgICAoLVtXS0hv dmVyUGxhdHRlciBpbml0V2l0aFZpZXc6ZGVsZWdhdGU6XSk6CisKIDIwMjItMDEtMTIgIFdlbnNv biBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW21hY09TXSBbV0sy XSBOU0ZvbnRQYW5lbCBVSSAoZm9udCBjb2xvciwgdGV4dCBkZWNvcmF0aW9ucywgZm9udCBzaGFk b3cpIGRvZXNuJ3QgdXBkYXRlIG9uIHNlbGVjdGlvbiBjaGFuZ2UKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0No YW5nZUxvZwppbmRleCBiMTUxNDVmMWQ3ZDdmODQ4OTY3NjU2NzRlZTQxZjJlODlhMjRhMzhiLi4z YTBkNjdkNjYyMDRkMmEzNThhOGE1ZTU2YmVmZGMzZWNjMjkyNDUzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9t YWMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjItMDEtMTIgIFRpbSBIb3J0b24gIDx0 aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGEgZmV3IE9iamVjdGl2ZS1D IG9iamVjdCBsZWFrcyBkdWUgdG8gZWFybHkgcmV0dXJucyBpbiBgaW5pdGAKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTE2MgorICAgICAgICA8cmRh cjovL3Byb2JsZW0vODc0ODkwNDg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTdG9yYWdlL1dlYkRhdGFiYXNlUXVvdGFNYW5hZ2VyLm1tOgorICAg ICAgICAoV2ViQ29yZTo6aWYpOgorCiAyMDIyLTAxLTEyICBNYXR0IFdvb2Ryb3cgIDxtYXR0d29v ZHJvd0BhcHBsZS5jb20+CiAKICAgICAgICAgX3BhaW50QmVoYXZpb3JGb3JEZXN0aW5hdGlvbkNv bnRleHQgc2hvdWxkIGNvbnNpZGVyIGtDR0NvbnRleHRUeXBlRGlzcGxheUxpc3QgdHlwZSBjb250 ZXh0cyBhcyBwb3RlbnRpYWxseSBiZWluZyBzbmFwc2hvdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9BUEkvSlNWYWx1ZS5tbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkv SlNWYWx1ZS5tbQppbmRleCAyMWY5MTkwNjcxMWRmNjRhZjhjNzViMjkyMzZlNTc4ODkxNzI3NjVi Li5lZTczYjMxYzgwMzQwOTlkOTkxOGJjNjRmMDA2NDVmYWE2NTU4ODU5IDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTVmFsdWUubW0KKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL0FQSS9KU1ZhbHVlLm1tCkBAIC0xMTA4LDggKzExMDgsMTAgQEAgLSAoSlNWYWx1ZSAq KWluaXQKIAogLSAoSlNWYWx1ZSAqKWluaXRXaXRoVmFsdWU6KEpTVmFsdWVSZWYpdmFsdWUgaW5D b250ZXh0OihKU0NvbnRleHQgKiljb250ZXh0CiB7Ci0gICAgaWYgKCF2YWx1ZSB8fCAhY29udGV4 dCkKKyAgICBpZiAoIXZhbHVlIHx8ICFjb250ZXh0KSB7CisgICAgICAgIFtzZWxmIHJlbGVhc2Vd OwogICAgICAgICByZXR1cm4gbmlsOworICAgIH0KIAogICAgIHNlbGYgPSBbc3VwZXIgaW5pdF07 CiAgICAgaWYgKCFzZWxmKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9z L1dlYkFWUGxheWVyQ29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9X ZWJBVlBsYXllckNvbnRyb2xsZXIubW0KaW5kZXggYjdiY2I5ZjE1MTYzY2I1NGQ3OTQzNTBiNjY4 OTAyMmUzNDE4YjVhYi4uNjllMzkzYzJkNzAxNTVlNzFhMzMwMDU2Zjc0OGQzOTU4ZDVmN2FjNiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYkFWUGxheWVyQ29udHJv bGxlci5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViQVZQbGF5ZXJDb250 cm9sbGVyLm1tCkBAIC02Niw4ICs2NiwxMCBAQCBAaW1wbGVtZW50YXRpb24gV2ViQVZQbGF5ZXJD b250cm9sbGVyIHsKIAogLSAoaW5zdGFuY2V0eXBlKWluaXQKIHsKLSAgICBpZiAoIWdldEFWUGxh eWVyQ29udHJvbGxlckNsYXNzKCkpCisgICAgaWYgKCFnZXRBVlBsYXllckNvbnRyb2xsZXJDbGFz cygpKSB7CisgICAgICAgIFtzZWxmIHJlbGVhc2VdOwogICAgICAgICByZXR1cm4gbmlsOworICAg IH0KIAogICAgIGlmICghKHNlbGYgPSBbc3VwZXIgaW5pdF0pKQogICAgICAgICByZXR1cm4gc2Vs ZjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0hvdmVyUGxhdHRl ci5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0hvdmVyUGxhdHRlci5tbQppbmRl eCA0YzlkMDAxZTRhOTc4YjRkNWFmOTBlNzg2MmM0YzljNmZhY2RiMjBiLi40ZjBmZTlkMDExMGZk ZGM4MmZhNTRkZDc5MjZlNDRjOTQ3NjRhYjViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9pb3MvV0tIb3ZlclBsYXR0ZXIubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvaW9zL1dLSG92ZXJQbGF0dGVyLm1tCkBAIC05Myw4ICs5MywxMCBAQCBAaW1wbGVtZW50YXRp b24gV0tIb3ZlclBsYXR0ZXIgewogLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoVmlldzooVUlWaWV3 ICopdmlldyBkZWxlZ2F0ZTooaWQgPFdLSG92ZXJQbGF0dGVyRGVsZWdhdGU+KWRlbGVnYXRlCiB7 CiAgICAgYXV0byBwYXJhbWV0ZXJzID0gV0tIb3ZlclBsYXR0ZXJEb21haW4ucm9vdFNldHRpbmdz OwotICAgIGlmICghcGFyYW1ldGVycy5wbGF0dGVyRW5hYmxlZEZvck1vdXNlICYmICFwYXJhbWV0 ZXJzLnBsYXR0ZXJFbmFibGVkRm9ySG92ZXIpCisgICAgaWYgKCFwYXJhbWV0ZXJzLnBsYXR0ZXJF bmFibGVkRm9yTW91c2UgJiYgIXBhcmFtZXRlcnMucGxhdHRlckVuYWJsZWRGb3JIb3Zlcikgewor ICAgICAgICBbc2VsZiByZWxlYXNlXTsKICAgICAgICAgcmV0dXJuIG5pbDsKKyAgICB9CiAKICAg ICBzZWxmID0gW3N1cGVyIGluaXRdOwogICAgIGlmICghc2VsZikKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXRMZWdhY3kvbWFjL1N0b3JhZ2UvV2ViRGF0YWJhc2VRdW90YU1hbmFnZXIubW0gYi9T b3VyY2UvV2ViS2l0TGVnYWN5L21hYy9TdG9yYWdlL1dlYkRhdGFiYXNlUXVvdGFNYW5hZ2VyLm1t CmluZGV4IDEwOGM1Mjg3ZjkwN2U4MWE2MWEwMWFhNzI0MjNjOTYwNzk1MGJjOTUuLjIwNDU3Mjc2 ZGNlMDY2OGE1ZWJiZjNhY2FhMjhlMGE0Nzg1MWJmMmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXRMZWdhY3kvbWFjL1N0b3JhZ2UvV2ViRGF0YWJhc2VRdW90YU1hbmFnZXIubW0KKysrIGIvU291 cmNlL1dlYktpdExlZ2FjeS9tYWMvU3RvcmFnZS9XZWJEYXRhYmFzZVF1b3RhTWFuYWdlci5tbQpA QCAtMzUsOCArMzUsMTAgQEAgQGltcGxlbWVudGF0aW9uIFdlYkRhdGFiYXNlUXVvdGFNYW5hZ2Vy CiAKIC0gKGlkKWluaXRXaXRoT3JpZ2luOihXZWJTZWN1cml0eU9yaWdpbiAqKW9yaWdpbgogewot ICAgIGlmICghb3JpZ2luKQorICAgIGlmICghb3JpZ2luKSB7CisgICAgICAgIFtzZWxmIHJlbGVh c2VdOwogICAgICAgICByZXR1cm4gbmlsOworICAgIH0KIAogICAgIHNlbGYgPSBbc3VwZXIgaW5p dF07CiAgICAgaWYgKCFzZWxmKQo=