235128 2022-01-12 11:44:53 -0800 Clean up MediaPlaybackTargetPicker::Client 2022-01-13 09:18:19 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 peng.liu6 peng.liu6 eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1830250 0 peng.liu6 2022-01-12 11:44:53 -0800 Clean up MediaPlaybackTargetPicker::Client 1830254 1 448980 peng.liu6 2022-01-12 11:48:43 -0800 Created attachment 448980 [fast-cq] Patch 1830258 2 448980 eric.carlson 2022-01-12 11:57:59 -0800 Comment on attachment 448980 [fast-cq] Patch Can you also make the class `final`? 1830287 3 peng.liu6 2022-01-12 12:22:17 -0800 (In reply to Eric Carlson from comment #2) > Comment on attachment 448980 [details] > Patch > > Can you also make the class `final`? Do you mean class `WebMediaSessionManager`? It is the base class of `WebMediaSessionManagerMac`, so we cannot make it `final`. 1830571 4 ews-feeder 2022-01-13 09:17:22 -0800 Committed r287980 (246009@main): <https://commits.webkit.org/246009@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448980. 1830572 5 webkit-bug-importer 2022-01-13 09:18:19 -0800 <rdar://problem/87553166> 448980 2022-01-12 11:48:43 -0800 2022-01-13 09:17:23 -0800 [fast-cq] Patch bug-235128-20220112114842.patch text/plain 2416 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3OTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzM1Mzk0ZjJiMTZhYTg5 N2E4MzdkYmY2YzI0NzA0ZDgyYmM0Y2MwNS4uMzQ3MjRhYzlkMDJmZmYzZjY4OGZjMWQ0ODRlMTY2 ZjljNGI1NTJiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTAxLTEyICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgQ2xlYW4gdXAgTWVkaWFQbGF5 YmFja1RhcmdldFBpY2tlcjo6Q2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMzUxMjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBTbWFsbCBjbGVhbnVwIHRvIHJlbW92ZSBhbiB1bnVzZWQgZnVuY3Rp b24gYW5kIGNoYW5nZSBvdmVycmlkZSB0byBmaW5hbC4KKworICAgICAgICAqIE1vZHVsZXMvYWly cGxheS9XZWJNZWRpYVNlc3Npb25NYW5hZ2VyLmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvTWVkaWFQbGF5YmFja1RhcmdldFBpY2tlci5oOgorCiAyMDIyLTAxLTEyICBBbnRvaW5lIFF1 aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgogCiAgICAgICAgIGNzcy9jc3MtdHJhbnNpdGlvbnMv cHNldWRvLWVsZW1lbnRzLTAwMi5odG1sIFdQVCBpcyBhIGZhaWx1cmUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvYWlycGxheS9XZWJNZWRpYVNlc3Npb25NYW5hZ2VyLmggYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2FpcnBsYXkvV2ViTWVkaWFTZXNzaW9uTWFuYWdlci5oCmlu ZGV4IDZhZDc3MTUwM2E2ZWU2YjUzODQ2ZGQxZWI2ZGNmY2FlMGM2ODcwNTguLjc4ODNhMTI5ZTlj OWQ4ZDlhN2FiYjc4YzE5ZTdiZTQyZDg0NmMzZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvYWlycGxheS9XZWJNZWRpYVNlc3Npb25NYW5hZ2VyLmgKKysrIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9haXJwbGF5L1dlYk1lZGlhU2Vzc2lvbk1hbmFnZXIuaApAQCAtNzUsOSAr NzUsOSBAQCBwcml2YXRlOgogICAgIFdlYkNvcmU6Ok1lZGlhUGxheWJhY2tUYXJnZXRQaWNrZXJN b2NrJiBtb2NrUGlja2VyKCk7CiAKICAgICAvLyBNZWRpYVBsYXliYWNrVGFyZ2V0UGlja2VyOjpD bGllbnQKLSAgICB2b2lkIHNldFBsYXliYWNrVGFyZ2V0KFJlZjxXZWJDb3JlOjpNZWRpYVBsYXli YWNrVGFyZ2V0PiYmKSBvdmVycmlkZTsKLSAgICB2b2lkIGV4dGVybmFsT3V0cHV0RGV2aWNlQXZh aWxhYmxlRGlkQ2hhbmdlKGJvb2wpIG92ZXJyaWRlOwotICAgIHZvaWQgcGxheWJhY2tUYXJnZXRQ aWNrZXJXYXNEaXNtaXNzZWQoKSBvdmVycmlkZTsKKyAgICB2b2lkIHNldFBsYXliYWNrVGFyZ2V0 KFJlZjxXZWJDb3JlOjpNZWRpYVBsYXliYWNrVGFyZ2V0PiYmKSBmaW5hbDsKKyAgICB2b2lkIGV4 dGVybmFsT3V0cHV0RGV2aWNlQXZhaWxhYmxlRGlkQ2hhbmdlKGJvb2wpIGZpbmFsOworICAgIHZv aWQgcGxheWJhY2tUYXJnZXRQaWNrZXJXYXNEaXNtaXNzZWQoKSBmaW5hbDsKIAogICAgIHNpemVf dCBmaW5kKFdlYk1lZGlhU2Vzc2lvbk1hbmFnZXJDbGllbnQqLCBQbGF5YmFja1RhcmdldENsaWVu dENvbnRleHRJZGVudGlmaWVyKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvTWVkaWFQbGF5YmFja1RhcmdldFBpY2tlci5oIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5YmFja1RhcmdldFBpY2tlci5oCmluZGV4IDgyZGNl ZGYwMWExYzEyYWZmMDk4NGFhMjJkYTUyOGUxOWI3YmQ1OWYuLjIzMjZjZDBlNjQ4ZmNiZjNiNTlh NmU0NmJiYWQwNjY2MTVkYjQ3YTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL01lZGlhUGxheWJhY2tUYXJnZXRQaWNrZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXliYWNrVGFyZ2V0UGlja2VyLmgKQEAgLTQ3LDgg KzQ3LDYgQEAgcHVibGljOgogICAgICAgICB2aXJ0dWFsIHZvaWQgc2V0UGxheWJhY2tUYXJnZXQo UmVmPE1lZGlhUGxheWJhY2tUYXJnZXQ+JiYpID0gMDsKICAgICAgICAgdmlydHVhbCB2b2lkIGV4 dGVybmFsT3V0cHV0RGV2aWNlQXZhaWxhYmxlRGlkQ2hhbmdlKGJvb2wpID0gMDsKICAgICAgICAg dmlydHVhbCB2b2lkIHBsYXliYWNrVGFyZ2V0UGlja2VyV2FzRGlzbWlzc2VkKCkgPSAwOwotCi0g ICAgICAgIHZvaWQgaW52YWxpZGF0ZSgpOwogICAgIH07CiAKICAgICB2aXJ0dWFsIH5NZWRpYVBs YXliYWNrVGFyZ2V0UGlja2VyKCk7Cg==