235122 2022-01-12 10:20:07 -0800 Live Text is sometimes horizontally clipped when injecting TextRecognitionBlockData 2022-01-12 15:15:16 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh akeerthi bdakin cdumez esprehn+autocc ews-watchlist hi kangil.han megan_gardner thorton webkit-bug-importer oldest_to_newest 1830197 0 wenson_hsieh 2022-01-12 10:20:07 -0800 . 1830218 1 448967 wenson_hsieh 2022-01-12 10:58:51 -0800 Created attachment 448967 Patch 1830307 2 448967 hi 2022-01-12 12:55:15 -0800 Comment on attachment 448967 Patch r=me, neat :) 1830346 3 448967 wenson_hsieh 2022-01-12 14:31:33 -0800 Comment on attachment 448967 Patch Thanks for the review! 1830363 4 ews-feeder 2022-01-12 15:14:51 -0800 Committed r287954 (245983@main): <https://commits.webkit.org/245983@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448967. 1830364 5 webkit-bug-importer 2022-01-12 15:15:16 -0800 <rdar://problem/87490408> 448967 2022-01-12 10:58:51 -0800 2022-01-12 15:14:53 -0800 Patch bug-235122-20220112105851.patch text/plain 7457 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3ODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjgzZjUxM2Q0YzU4Y2Yw NjRlY2NjYjA1ZmFjZDQ4YjgxMjlmMDBhYS4uNjljOTg5YWQ2YTA5YjZkNDI1MzEwZmNjZWRhMGE4 OTIxYTVkODdmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIyLTAxLTEyICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIExpdmUgVGV4dCBp cyBzb21ldGltZXMgaG9yaXpvbnRhbGx5IGNsaXBwZWQgd2hlbiBpbmplY3RpbmcgVGV4dFJlY29n bml0aW9uQmxvY2tEYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMzUxMjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgY3VycmVudCBoZXVyaXN0aWMgZm9yIHNpemluZyBMaXZlIFRleHQgcGFyYWdy YXBocyBhdm9pZHMgdmVydGljYWwgb3ZlcmZsb3csIGJ1dCBkb2VzIG5vdCBhdm9pZCBob3Jpem9u dGFsCisgICAgICAgIG92ZXJmbG93LiBMaW5lIGJyZWFraW5nIGluc2lkZSB0aGUgZml4ZWQtd2lk dGggY29udGFpbmVyIHByZXZlbnRzIHRoZSBsYXR0ZXIgaW4gbW9zdCBjYXNlcywgYnV0IG5vdCBp biB0aGUKKyAgICAgICAgc2NlbmFyaW8gd2hlcmUgdGhlIHJlY29nbml6ZWQgdGV4dCBibG9jayBp cyBhIHNpbmdsZSB3b3JkIHdpdGggbm8gb3Bwb3J0dW5pdHkgZm9yIGxpbmUgYnJlYWsuCisKKyAg ICAgICAgQWRkcmVzcyB0aGlzIGJ5IGFkanVzdGluZyB0aGUgc2l6aW5nIGhldXJpc3RpYyB0byBz aHJpbmsgYm90aCB0aGUgd2lkdGggYW5kIGhlaWdodCB0byBmaXQgd2l0aGluIHRoZSB0YXJnZXQg c2l6ZQorICAgICAgICAocmF0aGVyIHRoYW4ganVzdCBmaXR0aW5nIHRoZSBoZWlnaHQpLgorCisg ICAgICAgIFRlc3Q6IGZhc3QvaW1hZ2VzL3RleHQtcmVjb2duaXRpb24vaW1hZ2Utb3ZlcmxheS1i bG9jay1ob3Jpem9udGFsLW92ZXJmbG93Lmh0bWwKKworICAgICAgICAqIGRvbS9JbWFnZU92ZXJs YXkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VPdmVybGF5Ojp1cGRhdGVXaXRoVGV4dFJl Y29nbml0aW9uUmVzdWx0KToKKwogMjAyMi0wMS0xMiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hz aWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbTGl2ZSBUZXh0XSBJbWFnZSBvdmVybGF5IHRleHQg aXMgbWlzYWxpZ25lZCBvbiByZmkuZnIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9J bWFnZU92ZXJsYXkuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0ltYWdlT3ZlcmxheS5jcHAKaW5k ZXggNTgzZjFjMzM4MTg5MzEzNzlhNjk5YzA0NDQxZTAwZmQ1YWUwZDMwMy4uMGY5OTNmYTFkZWE0 Y2M0YjI2N2EzMDJkM2UwNjgyY2E0ODAzNjRkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv ZG9tL0ltYWdlT3ZlcmxheS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0ltYWdlT3Zlcmxh eS5jcHAKQEAgLTUyMiw3ICs1MjIsNyBAQCB2b2lkIHVwZGF0ZVdpdGhUZXh0UmVjb2duaXRpb25S ZXN1bHQoSFRNTEVsZW1lbnQmIGVsZW1lbnQsIGNvbnN0IFRleHRSZWNvZ25pdGlvbgogCiAgICAg c3RydWN0IEZvbnRTaXplQWRqdXN0bWVudFN0YXRlIHsKICAgICAgICAgUmVmPEhUTUxFbGVtZW50 PiBjb250YWluZXI7Ci0gICAgICAgIGZsb2F0IHRhcmdldEhlaWdodDsKKyAgICAgICAgRmxvYXRT aXplIHRhcmdldFNpemU7CiAgICAgICAgIGZsb2F0IHNjYWxlIHsgaW5pdGlhbFNjYWxlRm9yRm9u dFNpemUgfTsKICAgICAgICAgZmxvYXQgbWluU2NhbGUgeyBtaW5TY2FsZUZvckZvbnRTaXplIH07 CiAgICAgICAgIGZsb2F0IG1heFNjYWxlIHsgbWF4U2NhbGVGb3JGb250U2l6ZSB9OwpAQCAtNTQx LDcgKzU0MSw3IEBAIHZvaWQgdXBkYXRlV2l0aFRleHRSZWNvZ25pdGlvblJlc3VsdChIVE1MRWxl bWVudCYgZWxlbWVudCwgY29uc3QgVGV4dFJlY29nbml0aW9uCiAgICAgICAgIGF1dG8gYmxvY2tD b250YWluZXIgPSBlbGVtZW50cy5ibG9ja3NbaW5kZXhdOwogICAgICAgICBhdXRvIGJvdW5kcyA9 IGZpdEVsZW1lbnRUb1F1YWQoYmxvY2tDb250YWluZXIuZ2V0KCksIGNvbnZlcnRUb0NvbnRhaW5l ckNvb3JkaW5hdGVzKGJsb2NrLm5vcm1hbGl6ZWRRdWFkKSk7CiAgICAgICAgIGJsb2NrQ29udGFp bmVyLT5zZXRJbmxpbmVTdHlsZVByb3BlcnR5KENTU1Byb3BlcnR5Rm9udFNpemUsIGluaXRpYWxT Y2FsZUZvckZvbnRTaXplICogYm91bmRzLnNpemUuaGVpZ2h0KCksIENTU1VuaXRUeXBlOjpDU1Nf UFgpOwotICAgICAgICBlbGVtZW50c1RvQWRqdXN0LnVuY2hlY2tlZEFwcGVuZCh7IFdURk1vdmUo YmxvY2tDb250YWluZXIpLCBib3VuZHMuc2l6ZS5oZWlnaHQoKSB9KTsKKyAgICAgICAgZWxlbWVu dHNUb0FkanVzdC51bmNoZWNrZWRBcHBlbmQoeyBXVEZNb3ZlKGJsb2NrQ29udGFpbmVyKSwgYm91 bmRzLnNpemUgfSk7CiAgICAgfQogCiAgICAgdW5zaWduZWQgY3VycmVudEl0ZXJhdGlvbiA9IDA7 CkBAIC01NjMsNyArNTYzLDcgQEAgdm9pZCB1cGRhdGVXaXRoVGV4dFJlY29nbml0aW9uUmVzdWx0 KEhUTUxFbGVtZW50JiBlbGVtZW50LCBjb25zdCBUZXh0UmVjb2duaXRpb24KICAgICAgICAgICAg ICAgICBjb250aW51ZTsKICAgICAgICAgICAgIH0KIAotICAgICAgICAgICAgYXV0byBjdXJyZW50 U2NvcmUgPSB0ZXh0UmVuZGVyZXItPmxpbmVzQm91bmRpbmdCb3goKS5oZWlnaHQoKSAvIHN0YXRl LnRhcmdldEhlaWdodDsKKyAgICAgICAgICAgIGF1dG8gY3VycmVudFNjb3JlID0gKHRleHRSZW5k ZXJlci0+bGluZXNCb3VuZGluZ0JveCgpLnNpemUoKSAvIHN0YXRlLnRhcmdldFNpemUpLm1heERp bWVuc2lvbigpOwogICAgICAgICAgICAgaWYgKGN1cnJlbnRTY29yZSA8IG1pblRhcmdldFNjb3Jl KQogICAgICAgICAgICAgICAgIHN0YXRlLm1pblNjYWxlID0gc3RhdGUuc2NhbGU7CiAgICAgICAg ICAgICBlbHNlIGlmIChjdXJyZW50U2NvcmUgPiBtYXhUYXJnZXRTY29yZSkKQEAgLTU3NCw3ICs1 NzQsNyBAQCB2b2lkIHVwZGF0ZVdpdGhUZXh0UmVjb2duaXRpb25SZXN1bHQoSFRNTEVsZW1lbnQm IGVsZW1lbnQsIGNvbnN0IFRleHRSZWNvZ25pdGlvbgogICAgICAgICAgICAgfQogCiAgICAgICAg ICAgICBzdGF0ZS5zY2FsZSA9IChzdGF0ZS5taW5TY2FsZSArIHN0YXRlLm1heFNjYWxlKSAvIDI7 Ci0gICAgICAgICAgICBzdGF0ZS5jb250YWluZXItPnNldElubGluZVN0eWxlUHJvcGVydHkoQ1NT UHJvcGVydHlGb250U2l6ZSwgc3RhdGUudGFyZ2V0SGVpZ2h0ICogc3RhdGUuc2NhbGUsIENTU1Vu aXRUeXBlOjpDU1NfUFgpOworICAgICAgICAgICAgc3RhdGUuY29udGFpbmVyLT5zZXRJbmxpbmVT dHlsZVByb3BlcnR5KENTU1Byb3BlcnR5Rm9udFNpemUsIHN0YXRlLnRhcmdldFNpemUuaGVpZ2h0 KCkgKiBzdGF0ZS5zY2FsZSwgQ1NTVW5pdFR5cGU6OkNTU19QWCk7CiAgICAgICAgIH0KIAogICAg ICAgICBlbGVtZW50c1RvQWRqdXN0LnJlbW92ZUFsbE1hdGNoaW5nKFtdKGF1dG8mIHN0YXRlKSB7 CkBAIC01ODQsNyArNTg0LDcgQEAgdm9pZCB1cGRhdGVXaXRoVGV4dFJlY29nbml0aW9uUmVzdWx0 KEhUTUxFbGVtZW50JiBlbGVtZW50LCBjb25zdCBUZXh0UmVjb2duaXRpb24KICAgICAgICAgaWYg KCsrY3VycmVudEl0ZXJhdGlvbiA+IGl0ZXJhdGlvbkxpbWl0KSB7CiAgICAgICAgICAgICAvLyBG YWxsIGJhY2sgdG8gdGhlIGxhcmdlc3QgZm9udCBzaXplIHRoYXQgc3RpbGwgdmVydGljYWxseSBm aXRzIHdpdGhpbiB0aGUgY29udGFpbmVyLgogICAgICAgICAgICAgZm9yIChhdXRvJiBzdGF0ZSA6 IGVsZW1lbnRzVG9BZGp1c3QpCi0gICAgICAgICAgICAgICAgc3RhdGUuY29udGFpbmVyLT5zZXRJ bmxpbmVTdHlsZVByb3BlcnR5KENTU1Byb3BlcnR5Rm9udFNpemUsIHN0YXRlLnRhcmdldEhlaWdo dCAqIHN0YXRlLm1pblNjYWxlLCBDU1NVbml0VHlwZTo6Q1NTX1BYKTsKKyAgICAgICAgICAgICAg ICBzdGF0ZS5jb250YWluZXItPnNldElubGluZVN0eWxlUHJvcGVydHkoQ1NTUHJvcGVydHlGb250 U2l6ZSwgc3RhdGUudGFyZ2V0U2l6ZS5oZWlnaHQoKSAqIHN0YXRlLm1pblNjYWxlLCBDU1NVbml0 VHlwZTo6Q1NTX1BYKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgfQpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmlu ZGV4IGEzMDg2ODk5MWQ4NWFhMGM2ZmFiOWI2YWVhYmI5NTk0MWNmMDc5NWYuLjJkM2M4ZDk4YTRj ODc5YjA0YjA3YjlhNDg2OWFiZmZiNWYzZTQwN2QgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0No YW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAy Mi0wMS0xMiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KKworICAgICAg ICBMaXZlIFRleHQgaXMgc29tZXRpbWVzIGhvcml6b250YWxseSBjbGlwcGVkIHdoZW4gaW5qZWN0 aW5nIFRleHRSZWNvZ25pdGlvbkJsb2NrRGF0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM1MTIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCB0byB2ZXJpZnkgdGhhdCBhIHNpbmdsZSwg dmVyeSBsb25nIHdvcmQgaW4gaW5qZWN0ZWQgdGV4dCByZWNvZ25pdGlvbiBibG9jayBkYXRhIGRv ZXMgbm90IHRyaWdnZXIKKyAgICAgICAgaG9yaXpvbnRhbCBvdmVyZmxvdy4KKworICAgICAgICAq IGZhc3QvaW1hZ2VzL3RleHQtcmVjb2duaXRpb24vaW1hZ2Utb3ZlcmxheS1ibG9jay1ob3Jpem9u dGFsLW92ZXJmbG93LWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvaW1hZ2Vz L3RleHQtcmVjb2duaXRpb24vaW1hZ2Utb3ZlcmxheS1ibG9jay1ob3Jpem9udGFsLW92ZXJmbG93 Lmh0bWw6IEFkZGVkLgorCiAyMDIyLTAxLTEyICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhA YXBwbGUuY29tPgogCiAgICAgICAgIFtMaXZlIFRleHRdIEltYWdlIG92ZXJsYXkgdGV4dCBpcyBt aXNhbGlnbmVkIG9uIHJmaS5mcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMv dGV4dC1yZWNvZ25pdGlvbi9pbWFnZS1vdmVybGF5LWJsb2NrLWhvcml6b250YWwtb3ZlcmZsb3ct ZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL3RleHQtcmVjb2duaXRpb24v aW1hZ2Utb3ZlcmxheS1ibG9jay1ob3Jpem9udGFsLW92ZXJmbG93LWV4cGVjdGVkLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uNzQxZWE4MjhmMGQ5NDk2YzYxYzg2YTJiZTIxYTM5OGI4NWM3YWNmOAotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL3RleHQtcmVjb2duaXRpb24vaW1h Z2Utb3ZlcmxheS1ibG9jay1ob3Jpem9udGFsLW92ZXJmbG93LWV4cGVjdGVkLmh0bWwKQEAgLTAs MCArMSwyMyBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHN0eWxlPgorYm9k eSwgaHRtbCB7CisgICAgbWFyZ2luOiAwOworfQorCisuY292ZXItYmxvY2stY29udGFpbmVyIHsK KyAgICBwb3NpdGlvbjogYWJzb2x1dGU7CisgICAgdG9wOiAwOworICAgIGxlZnQ6IDA7CisgICAg d2lkdGg6IDIwMHB4OworICAgIGhlaWdodDogMjAwcHg7CisgICAgYmFja2dyb3VuZC1jb2xvcjog YmxhY2s7Cit9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+Cis8aW1nIHNyYz0iLi4vcmVzb3Vy Y2VzL2dyZWVuLTQwMHg0MDAucG5nIj48L2ltZz4KKzxkaXYgY2xhc3M9ImNvdmVyLWJsb2NrLWNv bnRhaW5lciI+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2Yg ZmlsZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvdGV4dC1yZWNvZ25pdGlv bi9pbWFnZS1vdmVybGF5LWJsb2NrLWhvcml6b250YWwtb3ZlcmZsb3cuaHRtbCBiL0xheW91dFRl c3RzL2Zhc3QvaW1hZ2VzL3RleHQtcmVjb2duaXRpb24vaW1hZ2Utb3ZlcmxheS1ibG9jay1ob3Jp em9udGFsLW92ZXJmbG93Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDZmMjA3OWRlYTIxMzk5NTc2MWJmZDI2 NzM1NzgyMDQ1YjU4M2I0OAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvaW1h Z2VzL3RleHQtcmVjb2duaXRpb24vaW1hZ2Utb3ZlcmxheS1ibG9jay1ob3Jpem9udGFsLW92ZXJm bG93Lmh0bWwKQEAgLTAsMCArMSwzOSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFk PgorPHN0eWxlPgorYm9keSwgaHRtbCB7CisgICAgbWFyZ2luOiAwOworfQorCisuY292ZXItYmxv Y2stY29udGFpbmVyIHsKKyAgICBwb3NpdGlvbjogYWJzb2x1dGU7CisgICAgdG9wOiAwOworICAg IGxlZnQ6IDA7CisgICAgd2lkdGg6IDIwMHB4OworICAgIGhlaWdodDogMjAwcHg7CisgICAgYmFj a2dyb3VuZC1jb2xvcjogYmxhY2s7Cit9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+Cis8aW1n IHNyYz0iLi4vcmVzb3VyY2VzL2dyZWVuLTQwMHg0MDAucG5nIj48L2ltZz4KKzxkaXYgY2xhc3M9 ImNvdmVyLWJsb2NrLWNvbnRhaW5lciI+PC9kaXY+Cis8c2NyaXB0PgorYWRkRXZlbnRMaXN0ZW5l cigibG9hZCIsICgpID0+IHsKKyAgICBsZXQgaW1hZ2UgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9y KCJpbWciKTsKKyAgICBpbnRlcm5hbHMuaW5zdGFsbEltYWdlT3ZlcmxheShpbWFnZSwgW10sIFsK KyAgICAgICAgeworICAgICAgICAgICAgdG9wTGVmdCA6IG5ldyBET01Qb2ludFJlYWRPbmx5KDAu MSwgMC4xKSwKKyAgICAgICAgICAgIHRvcFJpZ2h0IDogbmV3IERPTVBvaW50UmVhZE9ubHkoMC40 LCAwLjEpLAorICAgICAgICAgICAgYm90dG9tUmlnaHQgOiBuZXcgRE9NUG9pbnRSZWFkT25seSgw LjQsIDAuNCksCisgICAgICAgICAgICBib3R0b21MZWZ0IDogbmV3IERPTVBvaW50UmVhZE9ubHko MC4xLCAwLjQpLAorICAgICAgICAgICAgdGV4dCA6ICJBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB QUFBQUEiLAorICAgICAgICB9CisgICAgXSk7CisgICAgY29uc3QgYmxvY2sgPSBpbnRlcm5hbHMu c2hhZG93Um9vdChpbWFnZSkucXVlcnlTZWxlY3RvcigiZGl2LmltYWdlLW92ZXJsYXktYmxvY2si KTsKKyAgICBibG9jay5zdHlsZS5vdmVyZmxvdyA9ICJ2aXNpYmxlIjsKK30pOworPC9zY3JpcHQ+ Cis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=