235108 2022-01-12 03:52:24 -0800 [WPE] Fix building WebXR with ANGLE enabled 2022-01-12 08:20:04 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 235064 1 clord clord alex aperez dino kbr kkinnunen koivisto mcatanzaro sam webkit-bug-importer oldest_to_newest 1830072 0 clord 2022-01-12 03:52:24 -0800 Currently WebXR code doesn't build with ANGLE enabled due to assuming that USE(OPENGL_ES) applies to the WebGL context even when USE(ANGLE) is defined. 1830076 1 448928 clord 2022-01-12 03:59:27 -0800 Created attachment 448928 Patch 1830108 2 448928 alex 2022-01-12 06:52:55 -0800 Comment on attachment 448928 Patch LGTM, great! :-) 1830110 3 ews-feeder 2022-01-12 07:05:49 -0800 Committed r287923 (245956@main): <https://commits.webkit.org/245956@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448928. 1830111 4 webkit-bug-importer 2022-01-12 07:06:22 -0800 <rdar://problem/87456823> 448928 2022-01-12 03:59:27 -0800 2022-01-12 08:20:04 -0800 Patch bug-235108-20220112115925.patch text/plain 4856 clord U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3ODM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTE0OThiNzVjYWJhMTgy YzNiZmY2ZGM3MDhmYTQyZTk3N2NkYjc2MS4uMDQxYjYyMGI4NGNhY2FiMDU1NTExNGNhYmI4YWVj NTU0MmYyNDNiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAxLTEyICBDaHJp cyBMb3JkICA8Y2xvcmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBGaXggYnVpbGRpbmcg V2ViWFIgd2l0aCBBTkdMRSBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMzUxMDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggYnVpbGRpbmcgYm90aCBBTkdMRSBXZWJHTCBhbmQgV2ViWFIg c2ltdWx0YW5lb3VzbHkgd2hlbiBHTEVTIGlzCisgICAgICAgIGJlaW5nIHVzZWQuCisKKyAgICAg ICAgKiBNb2R1bGVzL3dlYnhyL1dlYlhST3BhcXVlRnJhbWVidWZmZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6V2ViWFJPcGFxdWVGcmFtZWJ1ZmZlcjo6c3RhcnRGcmFtZSk6CisgICAgICAgIChX ZWJDb3JlOjpXZWJYUk9wYXF1ZUZyYW1lYnVmZmVyOjpzZXR1cEZyYW1lYnVmZmVyKToKKwogMjAy Mi0wMS0xMSAgQ2hyaXMgTG9yZCAgPGNsb3JkQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dQRV0g RW5hYmxlIFdlYkdMIEFOR0xFIHN1cHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvd2VieHIvV2ViWFJPcGFxdWVGcmFtZWJ1ZmZlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3dlYnhyL1dlYlhST3BhcXVlRnJhbWVidWZmZXIuY3BwCmluZGV4IGYwZDkzOWM4ODQy N2UyY2FhYjZhYzgzOThmNGFlNTVmYmMwZjAzZGUuLjIzOWEyMmJkMTAzMDIxZDEyNzUyNmEwZjQ4 YzcwMWQ5YjY3NDBlMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2VieHIv V2ViWFJPcGFxdWVGcmFtZWJ1ZmZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93 ZWJ4ci9XZWJYUk9wYXF1ZUZyYW1lYnVmZmVyLmNwcApAQCAtMzEsMTEgKzMxLDkgQEAKIAogI2lm ICFVU0UoQU5HTEUpCiAjaW5jbHVkZSAiRXh0ZW5zaW9uc0dMT3BlbkdMQ29tbW9uLmgiCi0jZW5k aWYKICNpZiBVU0UoT1BFTkdMX0VTKQogI2luY2x1ZGUgIkV4dGVuc2lvbnNHTE9wZW5HTEVTLmgi CiAjZW5kaWYKLSNpZiAhVVNFKEFOR0xFKQogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dEdMLmgi CiAjZW5kaWYKICNpbmNsdWRlICJJbnRTaXplLmgiCkBAIC0xNzgsNyArMTc2LDcgQEAgdm9pZCBX ZWJYUk9wYXF1ZUZyYW1lYnVmZmVyOjpzdGFydEZyYW1lKGNvbnN0IFBsYXRmb3JtWFI6OkRldmlj ZTo6RnJhbWVEYXRhOjpMYXkKICNlbHNlCiAgICAgbV9vcGFxdWVUZXh0dXJlID0gZGF0YS5vcGFx dWVUZXh0dXJlOwogCi0jaWYgVVNFKE9QRU5HTF9FUykKKyNpZiBVU0UoT1BFTkdMX0VTKSAmJiAh VVNFKEFOR0xFKQogICAgIGF1dG8mIGV4dGVuc2lvbnMgPSByZWludGVycHJldF9jYXN0PEV4dGVu c2lvbnNHTE9wZW5HTEVTJj4oZ2wuZ2V0RXh0ZW5zaW9ucygpKTsKICAgICBpZiAobV9hdHRyaWJ1 dGVzLmFudGlhbGlhcyAmJiBleHRlbnNpb25zLmlzSW1hZ2luYXRpb24oKSkgewogICAgICAgICBl eHRlbnNpb25zLmZyYW1lYnVmZmVyVGV4dHVyZTJETXVsdGlzYW1wbGVJTUcoR0w6OkZSQU1FQlVG RkVSLCBHTDo6Q09MT1JfQVRUQUNITUVOVDAsIEdMOjpURVhUVVJFXzJELCBtX29wYXF1ZVRleHR1 cmUsIDAsIG1fc2FtcGxlQ291bnQpOwpAQCAtMjY5LDE1ICsyNjcsMTUgQEAgYm9vbCBXZWJYUk9w YXF1ZUZyYW1lYnVmZmVyOjpzZXR1cEZyYW1lYnVmZmVyKCkKIAogICAgIC8vIFNldCB1cCBjb2xv ciwgZGVwdGggYW5kIHN0ZW5jaWwgZm9ybWF0cwogICAgIGJvb2wgaGFzRGVwdGhPclN0ZW5jaWwg PSBtX2F0dHJpYnV0ZXMuc3RlbmNpbCB8fCBtX2F0dHJpYnV0ZXMuZGVwdGg7Ci0jaWYgVVNFKE9Q RU5HTF9FUykKKyNpZiBVU0UoQU5HTEUpCisgICAgYm9vbCBwbGF0Zm9ybVN1cHBvcnRzUGFja2Vk RGVwdGhTdGVuY2lsID0gdHJ1ZTsKKyAgICBhdXRvIGRlcHRoRm9ybWF0ID0gcGxhdGZvcm1TdXBw b3J0c1BhY2tlZERlcHRoU3RlbmNpbCA/IEdMOjpERVBUSDI0X1NURU5DSUw4IDogR0w6OkRFUFRI X0NPTVBPTkVOVDsKKyAgICBhdXRvIHN0ZW5jaWxGb3JtYXQgPSBHTDo6U1RFTkNJTF9JTkRFWDg7 CisjZWxpZiBVU0UoT1BFTkdMX0VTKQogICAgIGF1dG8mIGV4dGVuc2lvbnMgPSByZWludGVycHJl dF9jYXN0PEV4dGVuc2lvbnNHTE9wZW5HTEVTJj4oZ2wuZ2V0RXh0ZW5zaW9ucygpKTsKICAgICBi b29sIHBsYXRmb3JtU3VwcG9ydHNQYWNrZWREZXB0aFN0ZW5jaWwgPSBoYXNEZXB0aE9yU3RlbmNp bCAmJiBleHRlbnNpb25zLnN1cHBvcnRzKCJHTF9PRVNfcGFja2VkX2RlcHRoX3N0ZW5jaWwiKTsK ICAgICBhdXRvIGRlcHRoRm9ybWF0ID0gcGxhdGZvcm1TdXBwb3J0c1BhY2tlZERlcHRoU3RlbmNp bCA/IEdMOjpERVBUSDI0X1NURU5DSUw4IDogR0w6OkRFUFRIX0NPTVBPTkVOVDE2OwogICAgIGF1 dG8gc3RlbmNpbEZvcm1hdCA9IEdMOjpTVEVOQ0lMX0lOREVYODsKLSNlbGlmIFVTRShBTkdMRSkK LSAgICBib29sIHBsYXRmb3JtU3VwcG9ydHNQYWNrZWREZXB0aFN0ZW5jaWwgPSB0cnVlOwotICAg IGF1dG8gZGVwdGhGb3JtYXQgPSBwbGF0Zm9ybVN1cHBvcnRzUGFja2VkRGVwdGhTdGVuY2lsID8g R0w6OkRFUFRIMjRfU1RFTkNJTDggOiBHTDo6REVQVEhfQ09NUE9ORU5UOwotICAgIGF1dG8gc3Rl bmNpbEZvcm1hdCA9IEdMOjpTVEVOQ0lMX0lOREVYODsKICNlbHNlCiAgICAgYXV0byYgZXh0ZW5z aW9ucyA9IHJlaW50ZXJwcmV0X2Nhc3Q8RXh0ZW5zaW9uc0dMT3BlbkdMQ29tbW9uJj4oZ2wuZ2V0 RXh0ZW5zaW9ucygpKTsKICAgICBib29sIHBsYXRmb3JtU3VwcG9ydHNQYWNrZWREZXB0aFN0ZW5j aWwgPSBoYXNEZXB0aE9yU3RlbmNpbCAmJiBleHRlbnNpb25zLnN1cHBvcnRzKCJHTF9FWFRfcGFj a2VkX2RlcHRoX3N0ZW5jaWwiKTsKQEAgLTI5OCw3ICsyOTYsNyBAQCBib29sIFdlYlhST3BhcXVl RnJhbWVidWZmZXI6OnNldHVwRnJhbWVidWZmZXIoKQogICAgICAgICBtX3NhbXBsZUNvdW50ID0g c3RkOjptaW4oNCwgbWF4U2FtcGxlQ291bnQpOwogICAgIH0KIAotI2lmIFVTRShPUEVOR0xfRVMp CisjaWYgVVNFKE9QRU5HTF9FUykgJiYgIVVTRShBTkdMRSkKICAgICAvLyBVc2UgbXVsdGlzYW1w bGVkX3JlbmRlcl90b190ZXh0dXJlIGV4dGVuc2lvbiBpZiBhdmFpbGFibGUuCiAgICAgaWYgKG1f YXR0cmlidXRlcy5hbnRpYWxpYXMgJiYgZXh0ZW5zaW9ucy5pc0ltYWdpbmF0aW9uKCkpIHsKICAg ICAgICAgLy8gZnJhbWVidWZmZXJUZXh0dXJlMkRNdWx0aXNhbXBsZUlNRyBpcyBzZXQgdXAgaW4g c3RhcnRGcmFtZSBjYWxsLgpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21h a2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZQppbmRleCA4ZmMyZjc3NDI4M2I1NzRl OGJhZjMyYjhhZjhkOThmZWIzYTZkYTliLi5hN2U2NTI2NDBlYWU0YTMzODM0NjM5ZGNjMzZkMDM3 YjgyM2RiZDhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZQorKysg Yi9Tb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZQpAQCAtODksOCArODksNiBAQCBXRUJLSVRf T1BUSU9OX0RFRklORShVU0VfRVhURVJOQUxfSE9MRVBVTkNIICJXaGV0aGVyIHRvIGVuYWJsZSBl eHRlcm5hbCBob2xlcHVuYwogV0VCS0lUX09QVElPTl9ERUZJTkUoVVNFX0FOR0xFX1dFQkdMICJX aGV0aGVyIHRvIHVzZSBBTkdMRSBhcyBXZWJHTCBiYWNrZW5kLiIgUFJJVkFURSBPRkYpCiBXRUJL SVRfT1BUSU9OX0RFUEVORChVU0VfQU5HTEVfV0VCR0wgRU5BQkxFX1dFQkdMKQogCi1XRUJLSVRf T1BUSU9OX0NPTkZMSUNUKFVTRV9BTkdMRV9XRUJHTCBFTkFCTEVfV0VCWFIpCi0KIGlmIChDTUFL RV9TWVNURU1fTkFNRSBNQVRDSEVTICJMaW51eCIpCiAgICAgV0VCS0lUX09QVElPTl9ERUZBVUxU X1BPUlRfVkFMVUUoRU5BQkxFX0JVQkJMRVdSQVBfU0FOREJPWCBQVUJMSUMgT04pCiAgICAgV0VC S0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX01FTU9SWV9TQU1QTEVSIFBSSVZB VEUgT04pCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNDUzOGZhNjBk MDM1NWQxYzg2YzM3YzcxZTU3NjEwYzlmOTE4Nzg1Ni4uMTUyZjZkYzI1ODIwMDAwM2RiZjc0NWUx MWU3YzcwYzcyOWI0MjExMCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDIyLTAxLTEyICBDaHJpcyBMb3JkICA8Y2xvcmRAaWdhbGlhLmNv bT4KKworICAgICAgICBbV1BFXSBGaXggYnVpbGRpbmcgV2ViWFIgd2l0aCBBTkdMRSBlbmFibGVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzUxMDgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUg Y29uZmxpY3QgYmV0d2VlbiBXZWJYUiBhbmQgQU5HTEUgV2ViR0wgZm9yIFdQRS4KKworICAgICAg ICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlOgorCiAyMDIyLTAxLTExICBDaHJpcyBM b3JkICA8Y2xvcmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXSBFbmFibGUgV2ViR0wgQU5H TEUgc3VwcG9ydAo=