235093 2022-01-11 20:03:17 -0800 Build WebKitSwift when building with make or build-webkit 2022-01-19 10:08:06 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 235324 1 achristensen achristensen ap emw eric.carlson webkit-bug-importer oldest_to_newest 1829988 0 achristensen 2022-01-11 20:03:17 -0800 Build WebKitSwift when building with make or build-webkit 1829990 1 448900 achristensen 2022-01-11 20:04:52 -0800 Created attachment 448900 Patch 1830166 2 448900 ap 2022-01-12 09:26:41 -0800 Comment on attachment 448900 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448900&action=review > Source/WebKit/ChangeLog:9 > + For various internal reasons, we have to have no depency between the two, > + but we command line builders want to build and test it just like everyone else. Not sure if I know all of the internal reasons, but typically, we add new Xcode projects, not add independent targets to existing ones. Is there a reason why this case has to be different? > Makefile.shared:113 > + $1 xcodebuild $2 $(OTHER_OPTIONS) $(XCODE_TARGET) $(XCODE_OPTIONS) $3 $(WEBKIT_ADDITIONAL_XCODE_MAKEFILE_ARGS) | $(OUTPUT_FILTER) && exit $${PIPESTATUS[0]} \ This new variable is vaguely named, but looks like we can just use XCODE_TARGET? 1830225 3 448970 achristensen 2022-01-12 11:10:40 -0800 Created attachment 448970 Patch 1830234 4 448970 ap 2022-01-12 11:22:18 -0800 Comment on attachment 448970 Patch Seems fine as a temporary approach, as discussed on Slack. 1830235 5 448970 eric.carlson 2022-01-12 11:22:38 -0800 Comment on attachment 448970 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448970&action=review > Source/WebKit/ChangeLog:9 > + but we command line builders want to build and test it just like everyone else. Do you mean "but *the* command line builders"? 1830238 6 achristensen 2022-01-12 11:24:26 -0800 I am a command line builder because I use the command line to build WebKit more often than building from within Xcode. I believe there are several of us. 1830283 7 ews-feeder 2022-01-12 12:19:10 -0800 Committed r287944 (245973@main): <https://commits.webkit.org/245973@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448970. 1830284 8 webkit-bug-importer 2022-01-12 12:20:16 -0800 <rdar://problem/87476125> 1830405 9 ryanhaddad 2022-01-12 16:28:08 -0800 Monterey builds appear to be failing with errors in WKGroupSession.swift after this change: https://build.webkit.org/#/builders/368/builds/1643/steps/8/logs/stdio 1830422 10 ryanhaddad 2022-01-12 17:17:36 -0800 Reverted r287944 for reason: Breaks Monterey build. Committed r287964 (245993@trunk): <https://commits.webkit.org/245993@trunk> 1831818 11 ews-feeder 2022-01-18 14:09:13 -0800 ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!. 1831819 12 achristensen 2022-01-18 14:09:32 -0800 r288147 1832068 13 achristensen 2022-01-19 10:08:06 -0800 Reverted in http://trac.webkit.org/r288214 448900 2022-01-11 20:04:52 -0800 2022-01-12 11:10:37 -0800 Patch bug-235093-20220111200451.patch text/plain 3728 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3OTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVhMDk0NDkwODYwZDAxMThk NDUwYTE4NDY5YmYyNWJlZGYwMWY2MGUuLjgwNTYxZmM3YTA2MDk3NWYxNDdkYTA3YWMxMjQ2ZWJk MmE2ZWM0MWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjItMDEtMTEgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBCdWlsZCBXZWJL aXRTd2lmdCB3aGVuIGJ1aWxkaW5nIHdpdGggbWFrZSBvciBidWlsZC13ZWJraXQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTA5MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvciB2YXJpb3VzIGludGVy bmFsIHJlYXNvbnMsIHdlIGhhdmUgdG8gaGF2ZSBubyBkZXBlbmN5IGJldHdlZW4gdGhlIHR3bywK KyAgICAgICAgYnV0IHdlIGNvbW1hbmQgbGluZSBidWlsZGVycyB3YW50IHRvIGJ1aWxkIGFuZCB0 ZXN0IGl0IGp1c3QgbGlrZSBldmVyeW9uZSBlbHNlLgorCisgICAgICAgICogTWFrZWZpbGU6CisK IDIwMjItMDEtMTEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4K IAogICAgICAgICBSZW1vdmUgcmVmZXJlbmNlcyB0byBtb3ZlZC9kZWxldGVkIGZpbGVzIGluIFdl YktpdC54Y29kZXByb2oKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTWFrZWZpbGUgYi9Tb3Vy Y2UvV2ViS2l0L01ha2VmaWxlCmluZGV4IGNiNGMxMWE1N2M2NzM5YTE0MjZhNWJiOWQ4MTJiNzMw MDFlNjlkOTEuLjA4YjZjZWQ5ZWU3NDFjZGU3ZGEwMDA3MDVhNDYzN2Y5YjJiNzMyZWMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTWFrZWZpbGUKKysrIGIvU291cmNlL1dlYktpdC9NYWtlZmls ZQpAQCAtMSArMSwyIEBACitleHBvcnQgV0VCS0lUX0FERElUSU9OQUxfWENPREVfTUFLRUZJTEVf QVJHUyA9IC10YXJnZXQgV2ViS2l0IC10YXJnZXQgV2ViS2l0U3dpZnQKIGluY2x1ZGUgLi4vTWFr ZWZpbGUuc2hhcmVkCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VM b2cKaW5kZXggNjg1MWY2MTI4OTRjZjliZmQ4MWUxMzUxZGQ0MWI3MGYzMjVjNWRkYy4uM2UwZTY5 M2ZiZTgzM2JiZjIyMGI4YmE2ZTg2ODVjNTcyMTNlNGQzYyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hh bmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIyLTAxLTEx ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAg QnVpbGQgV2ViS2l0U3dpZnQgd2hlbiBidWlsZGluZyB3aXRoIG1ha2Ugb3IgYnVpbGQtd2Via2l0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzUwOTMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlw dHMvYnVpbGQtd2Via2l0OgorCiAyMDIyLTAxLTExICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVthMTF5XSBXZWIgcHJvY2VzcyBjcmFz aGVzIGluIHNvbWUgc2l0ZXMgaGF2aW5nIFNWRyBpbWFnZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvYnVpbGQtd2Via2l0IGIvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggMWUz ZGI1YTRkM2UzOWI4ZDU0ZDE2ODFlMDViZjZjY2NiN2ZjZDA2MS4uZjNlMGQ2NjhjMWI4MThhYjE0 Mjg5N2EzMjU4MDM4OWM1NmU1MTkzOCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9idWlsZC13 ZWJraXQKKysrIGIvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKQEAgLTM1MCw2ICszNTAsOSBA QCBpZiAoaXNBcHBsZVdpbldlYktpdCgpIHx8IGlzV2luQ2Fpcm8oKSB8fCBpc1BsYXlTdGF0aW9u KCkgfHwgaXNGVFcoKSkgewogICAgICAgICBwdXNoIEBsb2NhbF9vcHRpb25zLCBYY29kZUNvdmVy YWdlU3VwcG9ydE9wdGlvbnMoKSBpZiAkY292ZXJhZ2VTdXBwb3J0OwogICAgICAgICBwdXNoIEBs b2NhbF9vcHRpb25zLCBYY29kZVN0YXRpY0FuYWx5emVyT3B0aW9uKCkgaWYgJHNob3VsZFJ1blN0 YXRpY0FuYWx5emVyOwogICAgICAgICBwdXNoIEBsb2NhbF9vcHRpb25zLCAiV0tfTFRPX01PREU9 JGx0b01vZGUiIGlmICgkbHRvTW9kZSBuZSAiZGVmYXVsdCIpOworICAgICAgICBpZiAoJGRpciBl cSAiU291cmNlL1dlYktpdCIpIHsKKyAgICAgICAgICAgIHB1c2ggQGxvY2FsX29wdGlvbnMsICIt dGFyZ2V0IiwgIldlYktpdCIsICItdGFyZ2V0IiwgIldlYktpdFN3aWZ0IgorICAgICAgICB9CiAg ICAgICAgIG15ICRwcm9qZWN0UGF0aCA9ICRwcm9qZWN0ID1+IC9ndGVzdC8gPyAieGNvZGUvZ3Rl c3QiIDogJHByb2plY3Q7CiAgICAgICAgICRyZXN1bHQgPSBidWlsZFhDb2RlUHJvamVjdCgkcHJv amVjdFBhdGgsICRjbGVhbiwgQGxvY2FsX29wdGlvbnMsIEBBUkdWKTsKIApkaWZmIC0tZ2l0IGEv Q2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGFmZGE3OWIyOGZmNzM5ZDgxYjlmYmE1ZDZlMjAx NzliYjY3YmRjZjQuLmM2YWFlM2EwNjc5Y2MxOWE4ZDgxMjBkNTU1Y2RlMzE5MzgzOGIzN2MgMTAw NjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAy Mi0wMS0xMSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgorCisg ICAgICAgIEJ1aWxkIFdlYktpdFN3aWZ0IHdoZW4gYnVpbGRpbmcgd2l0aCBtYWtlIG9yIGJ1aWxk LXdlYmtpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjM1MDkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBNYWtlZmlsZS5zaGFyZWQ6CisKIDIwMjItMDEtMTAgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hy aXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBTdGFydCB1c2luZyBDKysyMApkaWZmIC0t Z2l0IGEvTWFrZWZpbGUuc2hhcmVkIGIvTWFrZWZpbGUuc2hhcmVkCmluZGV4IDM3Mjk2NjlkYTA0 YTAyOTA0NTY4ZGJjNzIzZTU1NWE5ZmYzNWFkZDQuLmNmMzhlNTkwZDI2ODVmOTFmODlhMGE5ZjQz MDM3M2RmMDc3NTVmZmEgMTAwNjQ0Ci0tLSBhL01ha2VmaWxlLnNoYXJlZAorKysgYi9NYWtlZmls ZS5zaGFyZWQKQEAgLTExMCw3ICsxMTAsNyBAQCBkZWZpbmUgaW52b2tlX3hjb2RlCiAJCWVjaG87 IFwKIAkJZWNobyAiPT09PT0gQlVJTERJTkcgJCQoYmFzZW5hbWUgIiQkKHB3ZCkiKSA9PT09PSI7 IFwKIAkJZWNobzsgXAotCQkkMSB4Y29kZWJ1aWxkICQyICQoT1RIRVJfT1BUSU9OUykgJChYQ09E RV9UQVJHRVQpICQoWENPREVfT1BUSU9OUykgJDMgfCAkKE9VVFBVVF9GSUxURVIpICYmIGV4aXQg JCR7UElQRVNUQVRVU1swXX0gXAorCQkkMSB4Y29kZWJ1aWxkICQyICQoT1RIRVJfT1BUSU9OUykg JChYQ09ERV9UQVJHRVQpICQoWENPREVfT1BUSU9OUykgJDMgJChXRUJLSVRfQURESVRJT05BTF9Y Q09ERV9NQUtFRklMRV9BUkdTKSB8ICQoT1VUUFVUX0ZJTFRFUikgJiYgZXhpdCAkJHtQSVBFU1RB VFVTWzBdfSBcCiAJKQogZW5kZWYKIAo= 448970 2022-01-12 11:10:40 -0800 2022-01-18 14:09:23 -0800 Patch bug-235093-20220112111039.patch text/plain 2667 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3OTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVhMDk0NDkwODYwZDAxMThk NDUwYTE4NDY5YmYyNWJlZGYwMWY2MGUuLjgwNTYxZmM3YTA2MDk3NWYxNDdkYTA3YWMxMjQ2ZWJk MmE2ZWM0MWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjItMDEtMTEgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBCdWlsZCBXZWJL aXRTd2lmdCB3aGVuIGJ1aWxkaW5nIHdpdGggbWFrZSBvciBidWlsZC13ZWJraXQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTA5MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvciB2YXJpb3VzIGludGVy bmFsIHJlYXNvbnMsIHdlIGhhdmUgdG8gaGF2ZSBubyBkZXBlbmN5IGJldHdlZW4gdGhlIHR3bywK KyAgICAgICAgYnV0IHdlIGNvbW1hbmQgbGluZSBidWlsZGVycyB3YW50IHRvIGJ1aWxkIGFuZCB0 ZXN0IGl0IGp1c3QgbGlrZSBldmVyeW9uZSBlbHNlLgorCisgICAgICAgICogTWFrZWZpbGU6CisK IDIwMjItMDEtMTEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4K IAogICAgICAgICBSZW1vdmUgcmVmZXJlbmNlcyB0byBtb3ZlZC9kZWxldGVkIGZpbGVzIGluIFdl YktpdC54Y29kZXByb2oKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTWFrZWZpbGUgYi9Tb3Vy Y2UvV2ViS2l0L01ha2VmaWxlCmluZGV4IGNiNGMxMWE1N2M2NzM5YTE0MjZhNWJiOWQ4MTJiNzMw MDFlNjlkOTEuLjQyYWJlYzg3ZDdlMDMyN2JmZjE2N2QxYTYzZmFjNjc3MzI5Y2JiNzEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTWFrZWZpbGUKKysrIGIvU291cmNlL1dlYktpdC9NYWtlZmls ZQpAQCAtMSArMSwyIEBACitleHBvcnQgWENPREVfVEFSR0VUID0gLXRhcmdldCBXZWJLaXQgLXRh cmdldCBXZWJLaXRTd2lmdAogaW5jbHVkZSAuLi9NYWtlZmlsZS5zaGFyZWQKZGlmZiAtLWdpdCBh L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2ODUxZjYxMjg5NGNmOWJm ZDgxZTEzNTFkZDQxYjcwZjMyNWM1ZGRjLi4zZTBlNjkzZmJlODMzYmJmMjIwYjhiYTZlODY4NWM1 NzIxM2U0ZDNjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjItMDEtMTEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hy aXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBCdWlsZCBXZWJLaXRTd2lmdCB3aGVuIGJ1 aWxkaW5nIHdpdGggbWFrZSBvciBidWlsZC13ZWJraXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTA5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9idWlsZC13ZWJraXQ6CisKIDIwMjIt MDEtMTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtHVEtdW2ExMXldIFdlYiBwcm9jZXNzIGNyYXNoZXMgaW4gc29tZSBzaXRlcyBoYXZpbmcg U1ZHIGltYWdlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQgYi9Ub29s cy9TY3JpcHRzL2J1aWxkLXdlYmtpdAppbmRleCAxZTNkYjVhNGQzZTM5YjhkNTRkMTY4MWUwNWJm NmNjY2I3ZmNkMDYxLi5kZTljODRhNzhkMzA3ZjczOTg3NmNkZjNlODY0MzliYTNlYmQ4NjhjIDEw MDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAorKysgYi9Ub29scy9TY3JpcHRz L2J1aWxkLXdlYmtpdApAQCAtMzUwLDYgKzM1MCwxMiBAQCBpZiAoaXNBcHBsZVdpbldlYktpdCgp IHx8IGlzV2luQ2Fpcm8oKSB8fCBpc1BsYXlTdGF0aW9uKCkgfHwgaXNGVFcoKSkgewogICAgICAg ICBwdXNoIEBsb2NhbF9vcHRpb25zLCBYY29kZUNvdmVyYWdlU3VwcG9ydE9wdGlvbnMoKSBpZiAk Y292ZXJhZ2VTdXBwb3J0OwogICAgICAgICBwdXNoIEBsb2NhbF9vcHRpb25zLCBYY29kZVN0YXRp Y0FuYWx5emVyT3B0aW9uKCkgaWYgJHNob3VsZFJ1blN0YXRpY0FuYWx5emVyOwogICAgICAgICBw dXNoIEBsb2NhbF9vcHRpb25zLCAiV0tfTFRPX01PREU9JGx0b01vZGUiIGlmICgkbHRvTW9kZSBu ZSAiZGVmYXVsdCIpOworCisgICAgICAgICMgRklYTUU6IE1vdmUgV2ViS2l0U3dpZnQgdG8gaXRz IG93biBkaXJlY3RvcnkgYW5kIHJlbW92ZSB0aGlzIGhhY2suCisgICAgICAgIGlmICgkZGlyIGVx ICJTb3VyY2UvV2ViS2l0IikgeworICAgICAgICAgICAgcHVzaCBAbG9jYWxfb3B0aW9ucywgIi10 YXJnZXQiLCAiV2ViS2l0IiwgIi10YXJnZXQiLCAiV2ViS2l0U3dpZnQiCisgICAgICAgIH0KKwog ICAgICAgICBteSAkcHJvamVjdFBhdGggPSAkcHJvamVjdCA9fiAvZ3Rlc3QvID8gInhjb2RlL2d0 ZXN0IiA6ICRwcm9qZWN0OwogICAgICAgICAkcmVzdWx0ID0gYnVpbGRYQ29kZVByb2plY3QoJHBy b2plY3RQYXRoLCAkY2xlYW4sIEBsb2NhbF9vcHRpb25zLCBAQVJHVik7CiAK