235082 2022-01-11 14:02:11 -0800 [JSC] Fix kind of error thrown by wasm module creation 2022-01-11 15:42:16 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1829912 0 ysuzuki 2022-01-11 14:02:11 -0800 [JSC] Fix kind of error thrown by wasm module creation 1829913 1 448876 ysuzuki 2022-01-11 14:03:07 -0800 Created attachment 448876 Patch 1829914 2 448876 msaboff 2022-01-11 14:05:17 -0800 Comment on attachment 448876 Patch r=me 1829916 3 448876 ysuzuki 2022-01-11 14:08:21 -0800 Comment on attachment 448876 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448876&action=review > Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp:58 > if (UNLIKELY(!error)) { I'll also remove RETURN_IF_EXCEPTION thing in L49 since this is not necessary. createJSWebAssemblyCompileError will not throw. So, the code should be aligned to L61. 1829941 4 ysuzuki 2022-01-11 15:41:37 -0800 Committed r287901 (?): <https://commits.webkit.org/r287901> 1829942 5 webkit-bug-importer 2022-01-11 15:42:16 -0800 <rdar://problem/87423396> 448876 2022-01-11 14:03:07 -0800 2022-01-11 14:05:17 -0800 Patch bug-235082-20220111140306.patch text/plain 1756 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3ODk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 ZjFhNjE2OWU2YTc2ZTUyZDZmM2YyNzk2Njg3Y2Q3YjJmODMyM2RjLi5iMzAxMTNkNTIzZDRkYWQy MjA2NmZkYzg0YjJmZDM0MzQ2YzYxYjQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMi0wMS0xMSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEZpeCBraW5kIG9mIGVycm9yIHRocm93biBieSB3YXNtIG1vZHVs ZSBjcmVhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjM1MDgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSXQgc2hvdWxkIHRocm93IFdlYkFzc2VtYmx5LkNvbXBpbGVFcnJvciBpbnN0ZWFkIG9mIFdl YkFzc2VtYmx5LkxpbmtFcnJvci4KKyAgICAgICAgVGhpcyBmaXhlcyBvY2Nhc2lvbmFsIGZhaWx1 cmUgaW4gd2FzbSBpbXBvcnRzLW9vbS5qcyB0ZXN0LgorCisgICAgICAgICogd2FzbS9qcy9KU1dl YkFzc2VtYmx5TW9kdWxlLmNwcDoKKyAgICAgICAgKEpTQzo6SlNXZWJBc3NlbWJseU1vZHVsZTo6 Y3JlYXRlU3R1Yik6CisKIDIwMjItMDEtMTEgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVy ZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBOb24tdW5pZmllZCBidWlsZCBmaXhlcywgZWFybHkg SmFudWFyeSAyMDIyIGVkaXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93 YXNtL2pzL0pTV2ViQXNzZW1ibHlNb2R1bGUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dh c20vanMvSlNXZWJBc3NlbWJseU1vZHVsZS5jcHAKaW5kZXggNjZhOWNkOTNkYWQ5ZGEwZWQ1NmM3 YzUwNGQ2N2E5OGNlODg4NmZkNy4uYWIxYmMxMjQ5NmFlZGIwMTE4ZDU2OWIxYmIwNWZiNzRmMWE0 M2FmMyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vanMvSlNXZWJBc3Nl bWJseU1vZHVsZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vanMvSlNXZWJB c3NlbWJseU1vZHVsZS5jcHAKQEAgLTU4LDcgKzU4LDcgQEAgSlNXZWJBc3NlbWJseU1vZHVsZSog SlNXZWJBc3NlbWJseU1vZHVsZTo6Y3JlYXRlU3R1YihWTSYgdm0sIEpTR2xvYmFsT2JqZWN0KiBn bG8KICAgICBpZiAoVU5MSUtFTFkoIWVycm9yKSkgewogICAgICAgICBzd2l0Y2ggKGVycm9yLmVy cm9yKCkpIHsKICAgICAgICAgY2FzZSBXYXNtOjpCaW5kaW5nRmFpbHVyZTo6T3V0T2ZNZW1vcnk6 Ci0gICAgICAgICAgICB0aHJvd0V4Y2VwdGlvbihnbG9iYWxPYmplY3QsIHNjb3BlLCBjcmVhdGVK U1dlYkFzc2VtYmx5TGlua0Vycm9yKGdsb2JhbE9iamVjdCwgdm0sICJPdXQgb2YgZXhlY3V0YWJs ZSBtZW1vcnkiX3MpKTsKKyAgICAgICAgICAgIHRocm93RXhjZXB0aW9uKGdsb2JhbE9iamVjdCwg c2NvcGUsIGNyZWF0ZUpTV2ViQXNzZW1ibHlDb21waWxlRXJyb3IoZ2xvYmFsT2JqZWN0LCB2bSwg Ik91dCBvZiBleGVjdXRhYmxlIG1lbW9yeSJfcykpOwogICAgICAgICAgICAgcmV0dXJuIG51bGxw dHI7CiAgICAgICAgIH0KICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Cg==