235049 2022-01-10 15:09:13 -0800 Remove unused Document::ListenerType enumerators 2022-01-25 14:10:15 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Enhancement --- 1 ashvayka ashvayka cdumez darin esprehn+autocc ews-watchlist kangil.han sam webkit-bug-importer oldest_to_newest 1829648 0 ashvayka 2022-01-10 15:09:13 -0800 Remove unused Document::ListenerType enumerators 1829651 1 448804 ashvayka 2022-01-10 15:13:16 -0800 Created attachment 448804 Patch 1829700 2 448804 darin 2022-01-10 18:02:32 -0800 Comment on attachment 448804 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448804&action=review > Source/WebCore/ChangeLog:9 > + Except for RESIZE_LISTENER, which just seems to be left behind, legacyType() of EventTarget.cpp > + handles all other event types, deleted in this patch, according to the spec [1]. We could also change this to an OptionSet some day, and STOP USING ALL CAPITAL LETTERS FOR IT. The style being so stream is just because this is really old. 1829703 3 448804 darin 2022-01-10 18:02:55 -0800 Comment on attachment 448804 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448804&action=review >> Source/WebCore/ChangeLog:9 >> + handles all other event types, deleted in this patch, according to the spec [1]. > > We could also change this to an OptionSet some day, and STOP USING ALL CAPITAL LETTERS FOR IT. The style being so stream is just because this is really old. strange, not stream, thanks autocorrect (or my brain) 1829814 4 darin 2022-01-11 08:40:38 -0800 Did I forget to set review+? Oops! 1831576 5 webkit-bug-importer 2022-01-17 15:10:18 -0800 <rdar://problem/87689367> 1833855 6 ashvayka 2022-01-25 14:09:15 -0800 Committed r288584 (246406@trunk): <https://commits.webkit.org/246406@trunk> 1833856 7 ashvayka 2022-01-25 14:10:15 -0800 Thanks Darin and Sam! (In reply to Darin Adler from comment #2) > We could also change this to an OptionSet some day, and STOP USING ALL > CAPITAL LETTERS FOR IT. The style being so stream is just because this is > really old. That would be nice, added a FIXME. 448804 2022-01-10 15:13:16 -0800 2022-01-11 06:32:24 -0800 Patch bug-235049-20220110231314.patch text/plain 4518 ashvayka SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4Nzg2MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDIyLTAxLTEwICBBbGV4ZXkg U2h2YXlrYSAgPGFzaHZheWthQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW51c2VkIERv Y3VtZW50OjpMaXN0ZW5lclR5cGUgZW51bWVyYXRvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTA0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4Y2VwdCBmb3IgUkVTSVpFX0xJU1RFTkVSLCB3aGlj aCBqdXN0IHNlZW1zIHRvIGJlIGxlZnQgYmVoaW5kLCBsZWdhY3lUeXBlKCkgb2YgRXZlbnRUYXJn ZXQuY3BwCisgICAgICAgIGhhbmRsZXMgYWxsIG90aGVyIGV2ZW50IHR5cGVzLCBkZWxldGVkIGlu IHRoaXMgcGF0Y2gsIGFjY29yZGluZyB0byB0aGUgc3BlYyBbMV0uCisKKyAgICAgICAgWzFdIGh0 dHBzOi8vZG9tLnNwZWMud2hhdHdnLm9yZy8jY29uY2VwdC1ldmVudC1saXN0ZW5lci1pbnZva2Ug KHN0ZXAgOSkKKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKwor ICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6 YWRkTGlzdGVuZXJUeXBlSWZOZWVkZWQpOgorICAgICAgICAqIGRvbS9Eb2N1bWVudC5oOgorCiAy MDIyLTAxLTEwICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAg ICAgIE1vZGFsIGNvbnRhaW5lciBvYnNlcnZlciBzaG91bGQgY2xhc3NpZnkgZWxlbWVudHMgdGhh dCBhcmUgc3R5bGVkIGxpa2UgY2xpY2thYmxlIGNvbnRyb2xzCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9kb20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAJKHJldmlzaW9uIDI4Nzg1MikKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUyNjMsMTQgKzUyNjMsNiBAQCB2b2lkIERvY3VtZW50 OjphZGRMaXN0ZW5lclR5cGVJZk5lZWRlZChjCiAgICAgICAgIGFkZExpc3RlbmVyVHlwZShET01D SEFSQUNURVJEQVRBTU9ESUZJRURfTElTVEVORVIpOwogICAgIGVsc2UgaWYgKGV2ZW50VHlwZSA9 PSBldmVudE5hbWVzKCkub3ZlcmZsb3djaGFuZ2VkRXZlbnQpCiAgICAgICAgIGFkZExpc3RlbmVy VHlwZShPVkVSRkxPV0NIQU5HRURfTElTVEVORVIpOwotICAgIGVsc2UgaWYgKGV2ZW50VHlwZSA9 PSBldmVudE5hbWVzKCkud2Via2l0QW5pbWF0aW9uU3RhcnRFdmVudCB8fCBldmVudFR5cGUgPT0g ZXZlbnROYW1lcygpLmFuaW1hdGlvbnN0YXJ0RXZlbnQpCi0gICAgICAgIGFkZExpc3RlbmVyVHlw ZShBTklNQVRJT05TVEFSVF9MSVNURU5FUik7Ci0gICAgZWxzZSBpZiAoZXZlbnRUeXBlID09IGV2 ZW50TmFtZXMoKS53ZWJraXRBbmltYXRpb25FbmRFdmVudCB8fCBldmVudFR5cGUgPT0gZXZlbnRO YW1lcygpLmFuaW1hdGlvbmVuZEV2ZW50KQotICAgICAgICBhZGRMaXN0ZW5lclR5cGUoQU5JTUFU SU9ORU5EX0xJU1RFTkVSKTsKLSAgICBlbHNlIGlmIChldmVudFR5cGUgPT0gZXZlbnROYW1lcygp LndlYmtpdEFuaW1hdGlvbkl0ZXJhdGlvbkV2ZW50IHx8IGV2ZW50VHlwZSA9PSBldmVudE5hbWVz KCkuYW5pbWF0aW9uaXRlcmF0aW9uRXZlbnQpCi0gICAgICAgIGFkZExpc3RlbmVyVHlwZShBTklN QVRJT05JVEVSQVRJT05fTElTVEVORVIpOwotICAgIGVsc2UgaWYgKGV2ZW50VHlwZSA9PSBldmVu dE5hbWVzKCkud2Via2l0VHJhbnNpdGlvbkVuZEV2ZW50IHx8IGV2ZW50VHlwZSA9PSBldmVudE5h bWVzKCkudHJhbnNpdGlvbmVuZEV2ZW50KQotICAgICAgICBhZGRMaXN0ZW5lclR5cGUoVFJBTlNJ VElPTkVORF9MSVNURU5FUik7CiAgICAgZWxzZSBpZiAoZXZlbnRUeXBlID09IGV2ZW50TmFtZXMo KS5iZWZvcmVsb2FkRXZlbnQpCiAgICAgICAgIGFkZExpc3RlbmVyVHlwZShCRUZPUkVMT0FEX0xJ U1RFTkVSKTsKICAgICBlbHNlIGlmIChldmVudFR5cGUgPT0gZXZlbnROYW1lcygpLnNjcm9sbEV2 ZW50KQpAQCAtNTI4Myw4ICs1Mjc1LDYgQEAgdm9pZCBEb2N1bWVudDo6YWRkTGlzdGVuZXJUeXBl SWZOZWVkZWQoYwogICAgICAgICBhZGRMaXN0ZW5lclR5cGUoRk9SQ0VET1dOX0xJU1RFTkVSKTsK ICAgICBlbHNlIGlmIChldmVudFR5cGUgPT0gZXZlbnROYW1lcygpLndlYmtpdG1vdXNlZm9yY2V1 cEV2ZW50KQogICAgICAgICBhZGRMaXN0ZW5lclR5cGUoRk9SQ0VVUF9MSVNURU5FUik7Ci0gICAg ZWxzZSBpZiAoZXZlbnRUeXBlID09IGV2ZW50TmFtZXMoKS5yZXNpemVFdmVudCkKLSAgICAgICAg YWRkTGlzdGVuZXJUeXBlKFJFU0laRV9MSVNURU5FUik7CiAgICAgZWxzZSBpZiAoZXZlbnRUeXBl ID09IGV2ZW50TmFtZXMoKS5mb2N1c2luRXZlbnQpCiAgICAgICAgIGFkZExpc3RlbmVyVHlwZShG T0NVU0lOX0xJU1RFTkVSKTsKICAgICBlbHNlIGlmIChldmVudFR5cGUgPT0gZXZlbnROYW1lcygp LmZvY3Vzb3V0RXZlbnQpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAkocmV2aXNpb24gMjg3ODUy KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTg5 NiwxOSArODk2LDE1IEBAIHB1YmxpYzoKICAgICAgICAgRE9NTk9ERUlOU0VSVEVESU5UT0RPQ1VN RU5UX0xJU1RFTkVSID0gMSA8PCA0LAogICAgICAgICBET01DSEFSQUNURVJEQVRBTU9ESUZJRURf TElTVEVORVIgICAgPSAxIDw8IDUsCiAgICAgICAgIE9WRVJGTE9XQ0hBTkdFRF9MSVNURU5FUiAg ICAgICAgICAgICA9IDEgPDwgNiwKLSAgICAgICAgQU5JTUFUSU9ORU5EX0xJU1RFTkVSICAgICAg ICAgICAgICAgID0gMSA8PCA3LAotICAgICAgICBBTklNQVRJT05TVEFSVF9MSVNURU5FUiAgICAg ICAgICAgICAgPSAxIDw8IDgsCi0gICAgICAgIEFOSU1BVElPTklURVJBVElPTl9MSVNURU5FUiAg ICAgICAgICA9IDEgPDwgOSwKLSAgICAgICAgVFJBTlNJVElPTkVORF9MSVNURU5FUiAgICAgICAg ICAgICAgID0gMSA8PCAxMCwKLSAgICAgICAgQkVGT1JFTE9BRF9MSVNURU5FUiAgICAgICAgICAg ICAgICAgID0gMSA8PCAxMSwKLSAgICAgICAgU0NST0xMX0xJU1RFTkVSICAgICAgICAgICAgICAg ICAgICAgID0gMSA8PCAxMiwKLSAgICAgICAgRk9SQ0VXSUxMQkVHSU5fTElTVEVORVIgICAgICAg ICAgICAgID0gMSA8PCAxMywKLSAgICAgICAgRk9SQ0VDSEFOR0VEX0xJU1RFTkVSICAgICAgICAg ICAgICAgID0gMSA8PCAxNCwKLSAgICAgICAgRk9SQ0VET1dOX0xJU1RFTkVSICAgICAgICAgICAg ICAgICAgID0gMSA8PCAxNSwKLSAgICAgICAgRk9SQ0VVUF9MSVNURU5FUiAgICAgICAgICAgICAg ICAgICAgID0gMSA8PCAxNiwKLSAgICAgICAgUkVTSVpFX0xJU1RFTkVSICAgICAgICAgICAgICAg ICAgICAgID0gMSA8PCAxNywKLSAgICAgICAgRk9DVVNJTl9MSVNURU5FUiAgICAgICAgICAgICAg ICAgICAgID0gMSA8PCAxOCwKLSAgICAgICAgRk9DVVNPVVRfTElTVEVORVIgICAgICAgICAgICAg ICAgICAgID0gMSA8PCAxOSwKKyAgICAgICAgVFJBTlNJVElPTkVORF9MSVNURU5FUiAgICAgICAg ICAgICAgID0gMSA8PCA3LAorICAgICAgICBCRUZPUkVMT0FEX0xJU1RFTkVSICAgICAgICAgICAg ICAgICAgPSAxIDw8IDgsCisgICAgICAgIFNDUk9MTF9MSVNURU5FUiAgICAgICAgICAgICAgICAg ICAgICA9IDEgPDwgOSwKKyAgICAgICAgRk9SQ0VXSUxMQkVHSU5fTElTVEVORVIgICAgICAgICAg ICAgID0gMSA8PCAxMCwKKyAgICAgICAgRk9SQ0VDSEFOR0VEX0xJU1RFTkVSICAgICAgICAgICAg ICAgID0gMSA8PCAxMSwKKyAgICAgICAgRk9SQ0VET1dOX0xJU1RFTkVSICAgICAgICAgICAgICAg ICAgID0gMSA8PCAxMiwKKyAgICAgICAgRk9SQ0VVUF9MSVNURU5FUiAgICAgICAgICAgICAgICAg ICAgID0gMSA8PCAxMywKKyAgICAgICAgRk9DVVNJTl9MSVNURU5FUiAgICAgICAgICAgICAgICAg ICAgID0gMSA8PCAxNCwKKyAgICAgICAgRk9DVVNPVVRfTElTVEVORVIgICAgICAgICAgICAgICAg ICAgID0gMSA8PCAxNSwKICAgICB9OwogCiAgICAgYm9vbCBoYXNMaXN0ZW5lclR5cGUoTGlzdGVu ZXJUeXBlIGxpc3RlbmVyVHlwZSkgY29uc3QgeyByZXR1cm4gKG1fbGlzdGVuZXJUeXBlcyAmIGxp c3RlbmVyVHlwZSk7IH0K