235036 2022-01-10 10:47:00 -0800 REGRESSION(r287787): CKEditor < v4.11 relies on WebKit emitting "DOMFocusIn" / "DOMFocusOut" events 2022-01-20 13:34:06 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build All All RESOLVED INVALID https://bugs.webkit.org/show_bug.cgi?id=234978 InRadar P2 Normal --- 1 ashvayka ashvayka ap cdumez cmarcelo darin esprehn+autocc ews-watchlist ggaren kangil.han webkit-bug-importer youennf oldest_to_newest 1829543 0 ashvayka 2022-01-10 10:47:00 -0800 REGRESSION(r287787): CKEditor < v4.10 relies on WebKit emitting "DOMFocusIn" / "DOMFocusOut" events 1829547 1 448774 ashvayka 2022-01-10 10:49:29 -0800 Created attachment 448774 Patch 1829581 2 448774 ashvayka 2022-01-10 12:14:46 -0800 Comment on attachment 448774 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448774&action=review > Source/WebCore/ChangeLog:14 > + show up in Chrome stats due to UA-conditional code. Hmm, taking a fresh look I don't see why editable.attachListener( editable, CKEDITOR.env.webkit ? 'DOMFocusIn' : 'focus', function() wouldn't show up in a Chrome stats... Feature usage counter seems to be in place: https://github.com/chromium/chromium/blob/0c27745e3c88ecab65fb1180d7033f936eb3a965/third_party/blink/renderer/core/dom/events/event_target.cc#L192-L193. 1829601 3 ashvayka 2022-01-10 12:56:53 -0800 Although CKEditor v4.9 seems to work even with "DOMFocusIn" / "DOMFocusOut" events, we can't rely on Chrome counters for this, and there might other code performing UA-testing to work around Firefox but not Safari. 1829602 4 ashvayka 2022-01-10 12:57:12 -0800 (In reply to Alexey Shvayka from comment #3) > Although CKEditor v4.9 seems to work even with "DOMFocusIn" / "DOMFocusOut" *without* 1829638 5 darin 2022-01-10 14:43:58 -0800 We have to figure out why we are seeing failures on the "win" EWS bot for every patch. 1829645 6 ashvayka 2022-01-10 15:05:25 -0800 (In reply to Darin Adler from comment #5) Thanks for review, Darin! I'm going to investigate the impact of removing legacy event types on CKEditor < v4.11 before deciding if we should bring them back. (In reply to Alexey Shvayka from comment #2) > Hmm, taking a fresh look I don't see why > > editable.attachListener( editable, CKEDITOR.env.webkit ? 'DOMFocusIn' : > 'focus', function() > > wouldn't show up in a Chrome stats... It appears the code above is invoked very rarely, only with a particular add-on to CKEditor < v4.11, and causes only a minor issue to UX, which Firefox also suffered from. Not a show-stopper. Chrome has a single method to count event type usage, so it's unlikely the stats are incorrect. While we can indeed preserve the optimization while still emitting these events, removing them is a small step towards making web platform more compatible. Any advice is appreciated. 1829647 7 ashvayka 2022-01-10 15:07:03 -0800 (In reply to Darin Adler from comment #5) > We have to figure out why we are seeing failures on the "win" EWS bot for > every patch. streams/readable-stream-lock-after-worker-terminates-crash.html timeout may be related to https://bugs.webkit.org/show_bug.cgi?id=234890, although the "win" EWS is green for the patch itself. 1831530 8 webkit-bug-importer 2022-01-17 10:47:16 -0800 <rdar://problem/87685583> 1832554 9 ashvayka 2022-01-20 13:34:06 -0800 Closing per https://bugs.webkit.org/show_bug.cgi?id=235036#c6: I've extensively tested ToT with CKEditor v4.9, everything works as expected, including text (de-)selection. 448774 2022-01-10 10:49:29 -0800 2022-01-10 14:40:40 -0800 Patch bug-235036-20220110184928.patch text/plain 12137 ashvayka SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4Nzg0NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM5IEBACisyMDIyLTAxLTEwICBBbGV4ZXkg U2h2YXlrYSAgPGFzaHZheWthQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyODc3 ODcpOiBDS0VkaXRvciA8IHY0LjEwIHJlbGllcyBvbiBXZWJLaXQgZW1pdHRpbmcgIkRPTUZvY3Vz SW4iIC8gIkRPTUZvY3VzT3V0IiBldmVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzNTAzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIERlc3BpdGUgdWx0cmEtbG93IHdlYnNpdGUgdXNhZ2UgKHBlciBD aHJvbWUgc3RhdHMpIGFuZCB0aGUgZmFjdCB0aGF0IEZpcmVmb3ggbmV2ZXIgc3VwcG9ydGVkCisg ICAgICAgIHRoZXNlIGV2ZW50cywgdGhleSBjYW4ndCBiZSByZW1vdmVkIHlldCBiZWNhdXNlIENL RWRpdG9yIGJlZm9yZSB2NC4xMCBwZXJmb3JtcyBicm93c2VyCisgICAgICAgIGRldGVjdGlvbiB2 aWEgVXNlci1BZ2VudCBhbmQgcmVsaWVzIG9uIFdlYktpdCBlbWl0dGluZyAiRE9NRm9jdXNJbiIg LyAiRE9NRm9jdXNPdXQiIGV2ZW50cy4KKworICAgICAgICBXaGlsZSB0aGlzIHdhcyBmaXhlZCB0 aHJlZSB5ZWFycyBhZ28gWzFdLCB0aGVyZSBhcmUgc3RpbGwgfjRLIHdlYnNpdGVzIHRoYXQgYnVu ZGxlIG9sZCB2ZXJzaW9uCisgICAgICAgIG9mIENLRWRpdG9yIFsyXSwgYXZhaWxhYmxlIGFsc28g YXMgYSBqUXVlcnkgcGx1Z2luLCBhbmQgc28gbWFueSBtb3JlIG9uIHRoZSB3ZWIgdGhhdCB3b24n dAorICAgICAgICBzaG93IHVwIGluIENocm9tZSBzdGF0cyBkdWUgdG8gVUEtY29uZGl0aW9uYWwg Y29kZS4KKworICAgICAgICBUaGlzIHBhdGNoIHJldmVydHMgcjI4Nzc4NywgYWxpZ25pbmcgdXMg d2l0aCBDaHJvbWUsIHdoaWxlIHByZXNlcnZlcyB0aGUgb3B0aW1pemF0aW9uIG9mIHIyODc4MDIu CisgICAgICAgIFVuZm9ydHVuYXRlbHksIEV2ZW50VGFyZ2V0LmNwcCdzIGxlZ2FjeVR5cGUoKSBj YW4ndCBiZSBsZXZlcmFnZXMgYXMgaXQgaW50ZW50aW9uYWxseSBwcmV2ZW50cworICAgICAgICBs ZWdhY3kgZXZlbnQgdHlwZSBmcm9tIGJlaW5nIGZpcmVkIGlmIGEgc3RhbmRhcmQgZXZlbnQgbGlz dGVuZXIgd2FzIGludm9rZWQgb24gdGhlIHRhcmdldC4KKworICAgICAgICBbMV0gaHR0cHM6Ly9n aXRodWIuY29tL2NrZWRpdG9yL2NrZWRpdG9yNC9wdWxsLzE1MDUKKyAgICAgICAgWzJdIGh0dHBz Oi8vZ2l0aHViLmNvbS9zZWFyY2g/cT1DS0VESVRPUi5lbnYud2Via2l0KyUzRislMjdET01Gb2N1 c0luJTI3JnR5cGU9Y29kZQorCisgICAgICAgIFRlc3Q6IGZhc3QvZXZlbnRzL2ZvY3VzaW5vdXQu aHRtbAorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRv Y3VtZW50OjpzZXRGb2N1c2VkRWxlbWVudCk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6 YWRkTGlzdGVuZXJUeXBlSWZOZWVkZWQpOgorICAgICAgICAqIGRvbS9Eb2N1bWVudC5oOgorICAg ICAgICAqIGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OmRpc3Bh dGNoRm9jdXNJbkV2ZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OmRpc3BhdGNoRm9j dXNPdXRFdmVudCk6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50OjpkaXNwYXRjaEZvY3VzSW5F dmVudElmTmVlZGVkKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OmRpc3Bh dGNoRm9jdXNPdXRFdmVudElmTmVlZGVkKTogRGVsZXRlZC4KKyAgICAgICAgKiBkb20vRWxlbWVu dC5oOgorICAgICAgICAqIGRvbS9FdmVudE5hbWVzLmg6CisKIDIwMjItMDEtMTAgIFNhbSBXZWlu aWcgIDx3ZWluaWdAYXBwbGUuY29tPgogCiAgICAgICAgIFtDU1MgQ29sb3IgNF0gQ1NTIGNvbG9y KCkgZnVuY3Rpb24gc2hvdWxkIG5vdCBjbGFtcCBjaGFubmVscyB0byB0aGUgMC0xIHJhbmdlCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDI4NzgwMikKKysrIFNvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ2NTgsNyArNDY1OCwx MSBAQCBib29sIERvY3VtZW50OjpzZXRGb2N1c2VkRWxlbWVudChFbGVtZW50CiAgICAgICAgICAg ICAgICAgbmV3Rm9jdXNlZEVsZW1lbnQgPSBudWxscHRyOwogICAgICAgICAgICAgfQogCi0gICAg ICAgICAgICBvbGRGb2N1c2VkRWxlbWVudC0+ZGlzcGF0Y2hGb2N1c091dEV2ZW50SWZOZWVkZWQo bmV3Rm9jdXNlZEVsZW1lbnQuY29weVJlZigpKTsgLy8gRE9NIGxldmVsIDMgYnViYmxpbmcgYmx1 ciBldmVudC4KKyAgICAgICAgICAgIGlmIChoYXNMaXN0ZW5lclR5cGUoRk9DVVNPVVRfTElTVEVO RVIpKQorICAgICAgICAgICAgICAgIG9sZEZvY3VzZWRFbGVtZW50LT5kaXNwYXRjaEZvY3VzT3V0 RXZlbnQoZXZlbnROYW1lcygpLmZvY3Vzb3V0RXZlbnQsIG5ld0ZvY3VzZWRFbGVtZW50LmNvcHlS ZWYoKSk7IC8vIERPTSBsZXZlbCAzIGJ1YmJsaW5nIGJsdXIgZXZlbnQuCisKKyAgICAgICAgICAg IGlmIChVTkxJS0VMWShoYXNMaXN0ZW5lclR5cGUoRE9NRk9DVVNPVVRfTElTVEVORVIpKSkKKyAg ICAgICAgICAgICAgICBvbGRGb2N1c2VkRWxlbWVudC0+ZGlzcGF0Y2hGb2N1c091dEV2ZW50KGV2 ZW50TmFtZXMoKS5ET01Gb2N1c091dEV2ZW50LCBuZXdGb2N1c2VkRWxlbWVudC5jb3B5UmVmKCkp OyAvLyBET00gbGV2ZWwgMiBmb3IgY29tcGF0aWJpbGl0eSwgc2VlIHdlYmtpdC5vcmcvYi8yMzUw MzYuCiAKICAgICAgICAgICAgIGlmIChtX2ZvY3VzZWRFbGVtZW50KSB7CiAgICAgICAgICAgICAg ICAgLy8gaGFuZGxlciBzaGlmdGVkIGZvY3VzCkBAIC00NzIzLDExICs0NzI3LDIyIEBAIGJvb2wg RG9jdW1lbnQ6OnNldEZvY3VzZWRFbGVtZW50KEVsZW1lbnQKICAgICAgICAgICAgIHJldHVybiBm YWxzZTsKICAgICAgICAgfQogCi0gICAgICAgIG1fZm9jdXNlZEVsZW1lbnQtPmRpc3BhdGNoRm9j dXNJbkV2ZW50SWZOZWVkZWQob2xkRm9jdXNlZEVsZW1lbnQuY29weVJlZigpKTsgLy8gRE9NIGxl dmVsIDMgYnViYmxpbmcgZm9jdXMgZXZlbnQuCisgICAgICAgIGlmIChoYXNMaXN0ZW5lclR5cGUo Rk9DVVNJTl9MSVNURU5FUikpIHsKKyAgICAgICAgICAgIG1fZm9jdXNlZEVsZW1lbnQtPmRpc3Bh dGNoRm9jdXNJbkV2ZW50KGV2ZW50TmFtZXMoKS5mb2N1c2luRXZlbnQsIG9sZEZvY3VzZWRFbGVt ZW50LmNvcHlSZWYoKSk7IC8vIERPTSBsZXZlbCAzIGJ1YmJsaW5nIGZvY3VzIGV2ZW50LgogCi0g ICAgICAgIGlmIChtX2ZvY3VzZWRFbGVtZW50ICE9IG5ld0ZvY3VzZWRFbGVtZW50KSB7Ci0gICAg ICAgICAgICAvLyBoYW5kbGVyIHNoaWZ0ZWQgZm9jdXMKLSAgICAgICAgICAgIHJldHVybiBmYWxz ZTsKKyAgICAgICAgICAgIGlmIChtX2ZvY3VzZWRFbGVtZW50ICE9IG5ld0ZvY3VzZWRFbGVtZW50 KSB7CisgICAgICAgICAgICAgICAgLy8gaGFuZGxlciBzaGlmdGVkIGZvY3VzCisgICAgICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICAgICAgfQorICAgICAgICB9CisKKyAgICAgICAg aWYgKFVOTElLRUxZKGhhc0xpc3RlbmVyVHlwZShET01GT0NVU0lOX0xJU1RFTkVSKSkpIHsKKyAg ICAgICAgICAgIG1fZm9jdXNlZEVsZW1lbnQtPmRpc3BhdGNoRm9jdXNJbkV2ZW50KGV2ZW50TmFt ZXMoKS5ET01Gb2N1c0luRXZlbnQsIG9sZEZvY3VzZWRFbGVtZW50LmNvcHlSZWYoKSk7IC8vIERP TSBsZXZlbCAyIGZvciBjb21wYXRpYmlsaXR5LCBzZWUgd2Via2l0Lm9yZy9iLzIzNTAzNi4KKwor ICAgICAgICAgICAgaWYgKG1fZm9jdXNlZEVsZW1lbnQgIT0gbmV3Rm9jdXNlZEVsZW1lbnQpIHsK KyAgICAgICAgICAgICAgICAvLyBoYW5kbGVyIHNoaWZ0ZWQgZm9jdXMKKyAgICAgICAgICAgICAg ICByZXR1cm4gZmFsc2U7CisgICAgICAgICAgICB9CiAgICAgICAgIH0KIAogICAgICAgICBpZiAo bV9mb2N1c2VkRWxlbWVudC0+aXNSb290RWRpdGFibGVFbGVtZW50KCkpCkBAIC01Mjg5LDYgKzUz MDQsMTAgQEAgdm9pZCBEb2N1bWVudDo6YWRkTGlzdGVuZXJUeXBlSWZOZWVkZWQoYwogICAgICAg ICBhZGRMaXN0ZW5lclR5cGUoRk9DVVNJTl9MSVNURU5FUik7CiAgICAgZWxzZSBpZiAoZXZlbnRU eXBlID09IGV2ZW50TmFtZXMoKS5mb2N1c291dEV2ZW50KQogICAgICAgICBhZGRMaXN0ZW5lclR5 cGUoRk9DVVNPVVRfTElTVEVORVIpOworICAgIGVsc2UgaWYgKGV2ZW50VHlwZSA9PSBldmVudE5h bWVzKCkuRE9NRm9jdXNJbkV2ZW50KQorICAgICAgICBhZGRMaXN0ZW5lclR5cGUoRE9NRk9DVVNJ Tl9MSVNURU5FUik7CisgICAgZWxzZSBpZiAoZXZlbnRUeXBlID09IGV2ZW50TmFtZXMoKS5ET01G b2N1c091dEV2ZW50KQorICAgICAgICBhZGRMaXN0ZW5lclR5cGUoRE9NRk9DVVNPVVRfTElTVEVO RVIpOwogfQogCiBIVE1MRnJhbWVPd25lckVsZW1lbnQqIERvY3VtZW50Ojpvd25lckVsZW1lbnQo KSBjb25zdApJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgJKHJldmlzaW9uIDI4NzgwMikKKysrIFNv dXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC05MDksNiArOTA5 LDggQEAgcHVibGljOgogICAgICAgICBSRVNJWkVfTElTVEVORVIgICAgICAgICAgICAgICAgICAg ICAgPSAxIDw8IDE3LAogICAgICAgICBGT0NVU0lOX0xJU1RFTkVSICAgICAgICAgICAgICAgICAg ICAgPSAxIDw8IDE4LAogICAgICAgICBGT0NVU09VVF9MSVNURU5FUiAgICAgICAgICAgICAgICAg ICAgPSAxIDw8IDE5LAorICAgICAgICBET01GT0NVU0lOX0xJU1RFTkVSICAgICAgICAgICAgICAg ICAgPSAxIDw8IDIwLAorICAgICAgICBET01GT0NVU09VVF9MSVNURU5FUiAgICAgICAgICAgICAg ICAgPSAxIDw8IDIxLAogICAgIH07CiAKICAgICBib29sIGhhc0xpc3RlbmVyVHlwZShMaXN0ZW5l clR5cGUgbGlzdGVuZXJUeXBlKSBjb25zdCB7IHJldHVybiAobV9saXN0ZW5lclR5cGVzICYgbGlz dGVuZXJUeXBlKTsgfQpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkocmV2aXNpb24gMjg3ODAy KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z MTgyLDIwICszMTgyLDE4IEBAIHZvaWQgRWxlbWVudDo6cnVuRm9jdXNpbmdTdGVwc0ZvckF1dG9m b2MKICAgICBmb2N1cygpOwogfQogCi12b2lkIEVsZW1lbnQ6OmRpc3BhdGNoRm9jdXNJbkV2ZW50 SWZOZWVkZWQoUmVmUHRyPEVsZW1lbnQ+JiYgb2xkRm9jdXNlZEVsZW1lbnQpCit2b2lkIEVsZW1l bnQ6OmRpc3BhdGNoRm9jdXNJbkV2ZW50KGNvbnN0IEF0b21TdHJpbmcmIGV2ZW50VHlwZSwgUmVm UHRyPEVsZW1lbnQ+JiYgb2xkRm9jdXNlZEVsZW1lbnQpCiB7Ci0gICAgaWYgKCFkb2N1bWVudCgp Lmhhc0xpc3RlbmVyVHlwZShEb2N1bWVudDo6Rk9DVVNJTl9MSVNURU5FUikpCi0gICAgICAgIHJl dHVybjsKICAgICBSRUxFQVNFX0FTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKFNjcmlw dERpc2FsbG93ZWRTY29wZTo6SW5NYWluVGhyZWFkOjppc1NjcmlwdEFsbG93ZWQoKSB8fCAhaXNJ bldlYlByb2Nlc3MoKSk7Ci0gICAgZGlzcGF0Y2hTY29wZWRFdmVudChGb2N1c0V2ZW50OjpjcmVh dGUoZXZlbnROYW1lcygpLmZvY3VzaW5FdmVudCwgRXZlbnQ6OkNhbkJ1YmJsZTo6WWVzLCBFdmVu dDo6SXNDYW5jZWxhYmxlOjpObywgZG9jdW1lbnQoKS53aW5kb3dQcm94eSgpLCAwLCBXVEZNb3Zl KG9sZEZvY3VzZWRFbGVtZW50KSkpOworICAgIEFTU0VSVChldmVudFR5cGUgPT0gZXZlbnROYW1l cygpLmZvY3VzaW5FdmVudCB8fCBldmVudFR5cGUgPT0gZXZlbnROYW1lcygpLkRPTUZvY3VzSW5F dmVudCk7CisgICAgZGlzcGF0Y2hTY29wZWRFdmVudChGb2N1c0V2ZW50OjpjcmVhdGUoZXZlbnRU eXBlLCBFdmVudDo6Q2FuQnViYmxlOjpZZXMsIEV2ZW50OjpJc0NhbmNlbGFibGU6Ok5vLCBkb2N1 bWVudCgpLndpbmRvd1Byb3h5KCksIDAsIFdURk1vdmUob2xkRm9jdXNlZEVsZW1lbnQpKSk7CiB9 CiAKLXZvaWQgRWxlbWVudDo6ZGlzcGF0Y2hGb2N1c091dEV2ZW50SWZOZWVkZWQoUmVmUHRyPEVs ZW1lbnQ+JiYgbmV3Rm9jdXNlZEVsZW1lbnQpCit2b2lkIEVsZW1lbnQ6OmRpc3BhdGNoRm9jdXNP dXRFdmVudChjb25zdCBBdG9tU3RyaW5nJiBldmVudFR5cGUsIFJlZlB0cjxFbGVtZW50PiYmIG5l d0ZvY3VzZWRFbGVtZW50KQogewotICAgIGlmICghZG9jdW1lbnQoKS5oYXNMaXN0ZW5lclR5cGUo RG9jdW1lbnQ6OkZPQ1VTT1VUX0xJU1RFTkVSKSkKLSAgICAgICAgcmV0dXJuOwogICAgIFJFTEVB U0VfQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oU2NyaXB0RGlzYWxsb3dlZFNjb3Bl OjpJbk1haW5UaHJlYWQ6OmlzU2NyaXB0QWxsb3dlZCgpIHx8ICFpc0luV2ViUHJvY2VzcygpKTsK LSAgICBkaXNwYXRjaFNjb3BlZEV2ZW50KEZvY3VzRXZlbnQ6OmNyZWF0ZShldmVudE5hbWVzKCku Zm9jdXNvdXRFdmVudCwgRXZlbnQ6OkNhbkJ1YmJsZTo6WWVzLCBFdmVudDo6SXNDYW5jZWxhYmxl OjpObywgZG9jdW1lbnQoKS53aW5kb3dQcm94eSgpLCAwLCBXVEZNb3ZlKG5ld0ZvY3VzZWRFbGVt ZW50KSkpOworICAgIEFTU0VSVChldmVudFR5cGUgPT0gZXZlbnROYW1lcygpLmZvY3Vzb3V0RXZl bnQgfHwgZXZlbnRUeXBlID09IGV2ZW50TmFtZXMoKS5ET01Gb2N1c091dEV2ZW50KTsKKyAgICBk aXNwYXRjaFNjb3BlZEV2ZW50KEZvY3VzRXZlbnQ6OmNyZWF0ZShldmVudFR5cGUsIEV2ZW50OjpD YW5CdWJibGU6OlllcywgRXZlbnQ6OklzQ2FuY2VsYWJsZTo6Tm8sIGRvY3VtZW50KCkud2luZG93 UHJveHkoKSwgMCwgV1RGTW92ZShuZXdGb2N1c2VkRWxlbWVudCkpKTsKIH0KIAogdm9pZCBFbGVt ZW50OjpkaXNwYXRjaEZvY3VzRXZlbnQoUmVmUHRyPEVsZW1lbnQ+JiYgb2xkRm9jdXNlZEVsZW1l bnQsIEZvY3VzRGlyZWN0aW9uKQpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCShyZXZpc2lvbiAyODc4 MDIpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC01 NzEsOCArNTcxLDggQEAgcHVibGljOgogICAgIGJvb2wgZGlzcGF0Y2hTaW11bGF0ZWRDbGljayhF dmVudCogdW5kZXJseWluZ0V2ZW50LCBTaW11bGF0ZWRDbGlja01vdXNlRXZlbnRPcHRpb25zID0g U2VuZE5vRXZlbnRzLCBTaW11bGF0ZWRDbGlja1Zpc3VhbE9wdGlvbnMgPSBTaG93UHJlc3NlZExv b2spOwogCiAgICAgLy8gRklYTUU6IENvbnNpZGVyIGNoYW5naW5nIHNpZ25hdHVyZSB0byBhY2Nl cHQgRWxlbWVudCogYmVjYXVzZSBhbGwgY2FsbGVycyBwZXJmb3JtIGNvcHlSZWYoKS4KLSAgICB2 b2lkIGRpc3BhdGNoRm9jdXNJbkV2ZW50SWZOZWVkZWQoUmVmUHRyPEVsZW1lbnQ+JiYgb2xkRm9j dXNlZEVsZW1lbnQpOwotICAgIHZvaWQgZGlzcGF0Y2hGb2N1c091dEV2ZW50SWZOZWVkZWQoUmVm UHRyPEVsZW1lbnQ+JiYgbmV3Rm9jdXNlZEVsZW1lbnQpOworICAgIHZvaWQgZGlzcGF0Y2hGb2N1 c0luRXZlbnQoY29uc3QgQXRvbVN0cmluZyYgZXZlbnRUeXBlLCBSZWZQdHI8RWxlbWVudD4mJiBv bGRGb2N1c2VkRWxlbWVudCk7CisgICAgdm9pZCBkaXNwYXRjaEZvY3VzT3V0RXZlbnQoY29uc3Qg QXRvbVN0cmluZyYgZXZlbnRUeXBlLCBSZWZQdHI8RWxlbWVudD4mJiBuZXdGb2N1c2VkRWxlbWVu dCk7CiAgICAgdmlydHVhbCB2b2lkIGRpc3BhdGNoRm9jdXNFdmVudChSZWZQdHI8RWxlbWVudD4m JiBvbGRGb2N1c2VkRWxlbWVudCwgRm9jdXNEaXJlY3Rpb24pOwogICAgIHZpcnR1YWwgdm9pZCBk aXNwYXRjaEJsdXJFdmVudChSZWZQdHI8RWxlbWVudD4mJiBuZXdGb2N1c2VkRWxlbWVudCk7CiAg ICAgdm9pZCBkaXNwYXRjaFdlYktpdEltYWdlUmVhZHlFdmVudEZvclRlc3RpbmcoKTsKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2RvbS9FdmVudE5hbWVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvZG9tL0V2ZW50TmFtZXMuaAkocmV2aXNpb24gMjg3ODAyKQorKysgU291cmNlL1dlYkNv cmUvZG9tL0V2ZW50TmFtZXMuaAkod29ya2luZyBjb3B5KQpAQCAtNDQsNiArNDQsOCBAQCBuYW1l c3BhY2UgV2ViQ29yZSB7CiAgICAgbWFjcm8oRE9NQWN0aXZhdGUpIFwKICAgICBtYWNybyhET01D aGFyYWN0ZXJEYXRhTW9kaWZpZWQpIFwKICAgICBtYWNybyhET01Db250ZW50TG9hZGVkKSBcCisg ICAgbWFjcm8oRE9NRm9jdXNJbikgXAorICAgIG1hY3JvKERPTUZvY3VzT3V0KSBcCiAgICAgbWFj cm8oRE9NTm9kZUluc2VydGVkKSBcCiAgICAgbWFjcm8oRE9NTm9kZUluc2VydGVkSW50b0RvY3Vt ZW50KSBcCiAgICAgbWFjcm8oRE9NTm9kZVJlbW92ZWQpIFwKSW5kZXg6IExheW91dFRlc3RzL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4 NzgwMikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE0IEBACisyMDIyLTAxLTEwICBBbGV4ZXkgU2h2YXlrYSAgPGFzaHZheWthQGFwcGxlLmNvbT4K KworICAgICAgICBSRUdSRVNTSU9OKHIyODc3ODcpOiBDS0VkaXRvciA8IHY0LjEwIHJlbGllcyBv biBXZWJLaXQgZW1pdHRpbmcgIkRPTUZvY3VzSW4iIC8gIkRPTUZvY3VzT3V0IiBldmVudHMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTAzNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9ldmVu dHMvZm9jdXNpbm91dC1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9ldmVudHMvZm9jdXNp bm91dC5odG1sOgorICAgICAgICAqIGZhc3QvZXZlbnRzL3Njb3BlZC9lZGl0aW5nLWNvbW1hbmRz Lmh0bWw6CisKIDIwMjItMDEtMDcgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+ CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI4MzkzNSk6IFsgbWFjT1Mgd2sxIF0gaW1wb3J0ZWQv dzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9pbnRlcmFjdGl2ZS1lbGVtZW50 cy90aGUtZGlhbG9nLWVsZW1lbnQvZGlhbG9nLWF1dG9mb2N1cy1tdWx0aXBsZS10aW1lcy5odG1s IGlzIGEgZmxha3kgZmFpbHVyZQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvZm9jdXNp bm91dC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMv Zm9jdXNpbm91dC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDI4NzgwMikKKysrIExheW91dFRlc3Rz L2Zhc3QvZXZlbnRzL2ZvY3VzaW5vdXQtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0z LDMgKzMsNSBAQCBQQVNTCiBQQVNTCiBQQVNTCiBQQVNTCitQQVNTCitQQVNTCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L2V2ZW50cy9mb2N1c2lub3V0Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZmFzdC9ldmVudHMvZm9jdXNpbm91dC5odG1sCShyZXZpc2lvbiAyODc4MDIpCisrKyBM YXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9mb2N1c2lub3V0Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAg LTI5LDYgKzI5LDIyIEBAIGZ1bmN0aW9uIGJsdXJIYW5kbGVyKGV2ZW50KQogICAgIGVsc2UKICAg ICAgICAgd3JpdGVGYWlsZWQoJ3Jlc3VsdDInLCAiV3JvbmcgZXZlbnQgdHlwZSIpOwogfQorCitm dW5jdGlvbiBmb2N1c0hhbmRsZXJUd28oZXZlbnQpCit7CisgICAgaWYgKGV2ZW50LnR5cGUgPT0g IkRPTUZvY3VzSW4iKQorICAgICAgICB3cml0ZVBhc3MoJ3Jlc3VsdDMnKTsKKyAgICBlbHNlCisg ICAgICAgIHdyaXRlRmFpbGVkKCdyZXN1bHQzJywgIldyb25nIGV2ZW50IHR5cGUiKTsKK30KKwor ZnVuY3Rpb24gYmx1ckhhbmRsZXJUd28oZXZlbnQpCit7CisgICAgaWYgKGV2ZW50LnR5cGUgPT0g IkRPTUZvY3VzT3V0IikKKyAgICAgICAgd3JpdGVQYXNzKCdyZXN1bHQ0Jyk7CisgICAgZWxzZQor ICAgICAgICB3cml0ZUZhaWxlZCgncmVzdWx0NCcsICJXcm9uZyBldmVudCB0eXBlIik7Cit9CiA8 L3NjcmlwdD4KIDwvaGVhZD4KIDxib2R5IG9ubG9hZD0iZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J2ZpZWxkJykuZm9jdXMoKTtkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZmllbGQnKS5ibHVyKCki PgpAQCAtMzksMTEgKzU1LDE1IEBAIGZ1bmN0aW9uIGJsdXJIYW5kbGVyKGV2ZW50KQogCiA8ZGl2 IGlkPSJyZXN1bHQxIj5GQUlMPC9kaXY+CiA8ZGl2IGlkPSJyZXN1bHQyIj5GQUlMPC9kaXY+Cis8 ZGl2IGlkPSJyZXN1bHQzIj5GQUlMPC9kaXY+Cis8ZGl2IGlkPSJyZXN1bHQ0Ij5GQUlMPC9kaXY+ CiA8ZGl2IGlkPSJyZXN1bHQ1Ij5GQUlMPC9kaXY+CiA8ZGl2IGlkPSJyZXN1bHQ2Ij5GQUlMPC9k aXY+CiAKIDxzY3JpcHQ+CiBkb2N1bWVudC5kb2N1bWVudEVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5l cigiZm9jdXNpbiIsIGZvY3VzSGFuZGxlciwgZmFsc2UpOwogZG9jdW1lbnQuZG9jdW1lbnRFbGVt ZW50LmFkZEV2ZW50TGlzdGVuZXIoImZvY3Vzb3V0IiwgYmx1ckhhbmRsZXIsIGZhbHNlKTsKK2Rv Y3VtZW50LmRvY3VtZW50RWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJET01Gb2N1c0luIiwgZm9j dXNIYW5kbGVyVHdvLCBmYWxzZSk7Citkb2N1bWVudC5kb2N1bWVudEVsZW1lbnQuYWRkRXZlbnRM aXN0ZW5lcigiRE9NRm9jdXNPdXQiLCBibHVySGFuZGxlclR3bywgZmFsc2UpOwogPC9zY3JpcHQ+ CiAKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3Njb3BlZC9lZGl0aW5nLWNvbW1hbmRz Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc2NvcGVkL2VkaXRp bmctY29tbWFuZHMuaHRtbAkocmV2aXNpb24gMjg3ODAyKQorKysgTGF5b3V0VGVzdHMvZmFzdC9l dmVudHMvc2NvcGVkL2VkaXRpbmctY29tbWFuZHMuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtNTMs NiArNTMsOCBAQCB2YXIgZXZlbnRzID0gewogICAgICdET01Ob2RlUmVtb3ZlZCc6IGZhbHNlLAog ICAgICdET01Ob2RlUmVtb3ZlZEZyb21Eb2N1bWVudCc6IGZhbHNlLAogICAgICdET01Ob2RlSW5z ZXJ0ZWRJbnRvRG9jdW1lbnQnOiB0cnVlLCAvLyB0aGlzIGV2ZW50IGNhbiBuZXZlciBiZSBvYnNl cnZlZC4KKyAgICAnRE9NRm9jdXNJbic6IGZhbHNlLAorICAgICdET01Gb2N1c091dCc6IGZhbHNl LAogICAgICdmb2N1c2luJzogZmFsc2UsCiAgICAgJ2ZvY3Vzb3V0JzogZmFsc2UsCiB9Owo=