<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>235005</bug_id>
          
          <creation_ts>2022-01-08 10:51:42 -0800</creation_ts>
          <short_desc>[css-flexbox][css-grid] Support last baseline</short_desc>
          <delta_ts>2022-10-12 10:13:59 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>Safari Technology Preview</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>243523</dependson>
    
    <dependson>243524</dependson>
          <blocked>236959</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Philip Jägenstedt">philip</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>sgill26</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1829235</commentid>
    <comment_count>0</comment_count>
    <who name="Philip Jägenstedt">philip</who>
    <bug_when>2022-01-08 10:51:42 -0800</bug_when>
    <thetext>The `last baseline` keyword for alignment properties (align-content, align-items, and align-self) is recognized by the parser but for both flex and grid layout, there are FIXMEs for actually supporting it:
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp?rev=287742#L1679
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/rendering/RenderGrid.cpp?rev=287742#L1437

Support for this in other browsers can be seen here:
https://developer.mozilla.org/en-US/docs/Web/CSS/align-content#browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/CSS/align-items#browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/CSS/align-self#browser_compatibility

Note that the data is a bit messy and also wrong in places, which is why I started looking into support across browsers and filed this bug.

https://crbug.com/885175 is the Chromium bug for this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1831212</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-01-15 10:52:16 -0800</bug_when>
    <thetext>&lt;rdar://problem/87640022&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1905074</commentid>
    <comment_count>2</comment_count>
    <who name="Philip Jägenstedt">philip</who>
    <bug_when>2022-10-12 08:56:35 -0700</bug_when>
    <thetext>Bug 245792 did something, but I&apos;m not sure if it fixed this bug. (Haven&apos;t tested.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1905103</commentid>
    <comment_count>3</comment_count>
    <who name="Sammy Gill">sgill26</who>
    <bug_when>2022-10-12 10:13:59 -0700</bug_when>
    <thetext>(In reply to Philip Jägenstedt from comment #2)
&gt; Bug 245792 did something, but I&apos;m not sure if it fixed this bug. (Haven&apos;t
&gt; tested.)

Not quite. That bug implemented the ability to get the last baseline of block containers via lastLineBaseline. There are a number of other bugs open that are similar but for other objects. These will be used to actually align items by last baseline for flex containers and grids (which are other bugs).</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>