23500 2009-01-23 05:25:06 -0800 KURL::parse() incorrectly compares its result to original string 2009-02-26 11:41:09 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap mitz oldest_to_newest 106737 0 ap 2009-01-23 05:25:06 -0800 KURL::parse() has an optimization, where it reuses an original String if parsing didn't change it. But the sting comparison is incorrect, as it doesn't check that string lengths are the same: if (originalString && strncmp(buffer.data(), url, m_fragmentEnd) == 0) Unfortunately, if I fix this bug, I'm getting a regression in fast/loader/url-parse-1.html. 111208 1 28019 ap 2009-02-26 09:59:01 -0800 Created attachment 28019 damn the torpedoes See also bug 22731. 111233 2 28019 darin 2009-02-26 11:09:03 -0800 Comment on attachment 28019 damn the torpedoes r=me 111251 3 ap 2009-02-26 11:41:09 -0800 Committed revision 41262. 28019 2009-02-26 09:59:01 -0800 2009-02-26 11:09:03 -0800 damn the torpedoes KURLOriginalString.txt text/plain 2950 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTI1MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDItMjYgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzUwMAorICAgICAgICBL VVJMOjpwYXJzZSgpIGluY29ycmVjdGx5IGNvbXBhcmVzIGl0cyByZXN1bHQgdG8gb3JpZ2luYWwg c3RyaW5nCisKKyAgICAgICAgKiBwbGF0Zm9ybS9LVVJMLmNwcDogKFdlYkNvcmU6OktVUkw6OnBh cnNlKTogVGFrZSBzdHJpbmcgbGVuZ3RoIGludG8gYWNjb3VudC4KKwogMjAwOS0wMi0yNiAgSm9u YXRob24gSm9uZ3NtYSAgPGpvbmF0aG9uQHF1b3RpZGlhbi5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgSG9sZ2VyIEZyZXl0aGVyLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL0tVUkwuY3BwCShyZXZpc2lvbiA0MTI0NSkK KysrIFdlYkNvcmUvcGxhdGZvcm0vS1VSTC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyOTksNyAr MTI5OSw3IEBAIHZvaWQgS1VSTDo6cGFyc2UoY29uc3QgY2hhciogdXJsLCBjb25zdCAKIAogICAg IC8vIElmIHdlIGRpZG4ndCBlbmQgdXAgYWN0dWFsbHkgY2hhbmdpbmcgdGhlIG9yaWdpbmFsIHN0 cmluZyBhbmQKICAgICAvLyBpdCB3YXMgYWxyZWFkeSBpbiBhIFN0cmluZywgcmV1c2UgaXQgdG8g YXZvaWQgZXh0cmEgYWxsb2NhdGlvbi4KLSAgICBpZiAob3JpZ2luYWxTdHJpbmcgJiYgc3RybmNt cChidWZmZXIuZGF0YSgpLCB1cmwsIG1fZnJhZ21lbnRFbmQpID09IDApCisgICAgaWYgKG9yaWdp bmFsU3RyaW5nICYmIG9yaWdpbmFsU3RyaW5nLT5sZW5ndGgoKSA9PSBzdGF0aWNfY2FzdDx1bnNp Z25lZD4obV9mcmFnbWVudEVuZCkgJiYgc3RybmNtcChidWZmZXIuZGF0YSgpLCB1cmwsIG1fZnJh Z21lbnRFbmQpID09IDApCiAgICAgICAgIG1fc3RyaW5nID0gKm9yaWdpbmFsU3RyaW5nOwogICAg IGVsc2UKICAgICAgICAgbV9zdHJpbmcgPSBTdHJpbmcoYnVmZmVyLmRhdGEoKSwgbV9mcmFnbWVu dEVuZCk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA0MTI1MikKKysrIExheW91dFRlc3RzL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDA5LTAyLTI2ICBBbGV4ZXkgUHJv c2t1cnlha292ICA8YXBAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjM1MDAKKyAgICAgICAgS1VSTDo6cGFyc2UoKSBpbmNvcnJlY3RseSBjb21wYXJlcyBpdHMg cmVzdWx0IHRvIG9yaWdpbmFsIHN0cmluZworCisgICAgICAgICogZmFzdC9sb2FkZXIvdXJsLXBh cnNlLTEtZXhwZWN0ZWQudHh0OiBVcGRhdGVkIHJlc3VsdHMuIE5laXRoZXIgb2xkIG5vciBuZXcg cmVzdWx0cyBtYXRjaAorICAgICAgICBGaXJlZm94IHByZWNpc2VseS4KKwogMjAwOS0wMi0yNSAg Q2FtZXJvbiBad2FyaWNoICA8Y3d6d2FyaWNoQHV3YXRlcmxvby5jYT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvbG9hZGVy L3VybC1wYXJzZS0xLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0 L2xvYWRlci91cmwtcGFyc2UtMS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDQxMjQ1KQorKysgTGF5 b3V0VGVzdHMvZmFzdC9sb2FkZXIvdXJsLXBhcnNlLTEtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNv cHkpCkBAIC0xMywxOCArMTMsMTggQEAgZmlsZToJZmlsZTovLy9CQVNFLwkJL0JBU0UvCiBmaWxl OnRlc3QJZmlsZTovLy9CQVNFL3Rlc3QJCS9CQVNFL3Rlc3QKIGZpbGU6LwlmaWxlOi8vLwkJLwog ZmlsZTovdGVzdAlmaWxlOi8vL3Rlc3QJCS90ZXN0Ci1maWxlOi8vCWZpbGU6Ly8JCQorZmlsZTov LwlmaWxlOgkJCiBmaWxlOi8vdGVzdAlmaWxlOi8vdGVzdAl0ZXN0CQogZmlsZTovLy8JZmlsZTov Ly8JCS8KIGZpbGU6Ly8vdGVzdAlmaWxlOi8vL3Rlc3QJCS90ZXN0Ci1maWxlOi8vbG9jYWxob3N0 CWZpbGU6Ly9sb2NhbGhvc3QJCQorZmlsZTovL2xvY2FsaG9zdAlmaWxlOgkJCiBmaWxlOi8vbG9j YWxob3N0LwlmaWxlOi8vLwkJLwogZmlsZTovL2xvY2FsaG9zdC90ZXN0CWZpbGU6Ly8vdGVzdAkJ L3Rlc3QKIGh0dHA6CWh0dHA6LwkJLwogaHR0cDovCWh0dHA6LwkJLwotaHR0cDovLwlodHRwOi8v CQkvCi1odHRwOi8vLwlodHRwOi8vLwkJLwotaHR0cDovLy8vCWh0dHA6Ly8vLwkJLy8KK2h0dHA6 Ly8JaHR0cDovCQkvCitodHRwOi8vLwlodHRwOi8JCS8KK2h0dHA6Ly8vLwlodHRwOi8vCQkvLwog aHR0cDovL2xvY2FsaG9zdAlodHRwOi8vbG9jYWxob3N0Lwlsb2NhbGhvc3QJLwogaHR0cDovL2xv Y2FsaG9zdC8JaHR0cDovL2xvY2FsaG9zdC8JbG9jYWxob3N0CS8KIGh0dHA6Ly9sb2NhbGhvc3Qv dGVzdAlodHRwOi8vbG9jYWxob3N0L3Rlc3QJbG9jYWxob3N0CS90ZXN0Cg==