234989 2022-01-07 14:41:33 -0800 WebKit::nsTextAlignmentFromTextAlignment() falls through ASSERT_NOT_REACHED() 2022-01-19 14:21:53 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 234932 1 ddkilzer cdumez cdumez darin kkinnunen webkit-bug-importer oldest_to_newest 1829083 0 ddkilzer 2022-01-07 14:41:33 -0800 WebKit::nsTextAlignmentFromTextAlignment() falls through ASSERT_NOT_REACHED(). In the `default` case, `nsTextAlignment` is returned uninitialized. static NSTextAlignment nsTextAlignmentFromTextAlignment(TextAlignment textAlignment) { NSTextAlignment nsTextAlignment; switch (textAlignment) { case NoAlignment: nsTextAlignment = NSTextAlignmentNatural; break; case LeftAlignment: nsTextAlignment = NSTextAlignmentLeft; break; case RightAlignment: nsTextAlignment = NSTextAlignmentRight; break; case CenterAlignment: nsTextAlignment = NSTextAlignmentCenter; break; case JustifiedAlignment: nsTextAlignment = NSTextAlignmentJustified; break; default: ASSERT_NOT_REACHED(); } return nsTextAlignment; } See Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm. 1829084 1 webkit-bug-importer 2022-01-07 14:41:59 -0800 <rdar://problem/87273264> 1832086 2 449494 cdumez 2022-01-19 10:51:12 -0800 Created attachment 449494 Patch 1832232 3 ews-feeder 2022-01-19 14:21:48 -0800 Committed r288241 (246195@main): <https://commits.webkit.org/246195@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449494. 449494 2022-01-19 10:51:12 -0800 2022-01-19 14:21:50 -0800 Patch bug-234989-20220119105111.patch text/plain 2183 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4MjAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDkzNjU1MGY2MmE0NjBjM2Zl YTA3MTgwM2FjNmFiNDgwNmY3Y2Y3OTcuLjM1NWIwYmRlOTVkOWQ3NmNhZWRkMjFjYmRmYjhlNWVi Y2Y1Nzg5NWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjItMDEtMTkgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBXZWJLaXQ6Om5zVGV4dEFsaWdubWVu dEZyb21UZXh0QWxpZ25tZW50KCkgZmFsbHMgdGhyb3VnaCBBU1NFUlRfTk9UX1JFQUNIRUQoKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0OTg5Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NzI3MzI2ND4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5t bToKKyAgICAgICAgKFdlYktpdDo6bnNUZXh0QWxpZ25tZW50RnJvbVRleHRBbGlnbm1lbnQpOgor CiAyMDIyLTAxLTE5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg V2Vic2l0ZURhdGFTdG9yZS5jcHAgdXNlcyBzd2l0Y2ggc3RhdGVtZW50cyBmb3IgV2ViS2l0OjpQ cm9jZXNzQWNjZXNzVHlwZSBlbnVtIHRoYXQgZmFsbCB0aHJvdWdoIEFTU0VSVF9OT1RfUkVBQ0hF RCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1w bC5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tCmluZGV4 IGU0YjNhYWZlZGE3MmFkYzI1MGJiNGZlMjFlNDU5NTg2ZjVjYzVjNDcuLjkyMWUxOTYwMjZjYzY1 MWRlNjVjZDc2NDRjOGFlMjJjZjgyYTliZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0NvY29hL1dlYlZpZXdJbXBsLm1tCkBAIC0xMjM3LDI4ICsxMjM3LDIwIEBAIE5TVG91Y2hCYXIg KldlYlZpZXdJbXBsOjp0ZXh0VG91Y2hCYXIoKSBjb25zdAogCiBzdGF0aWMgTlNUZXh0QWxpZ25t ZW50IG5zVGV4dEFsaWdubWVudEZyb21UZXh0QWxpZ25tZW50KFRleHRBbGlnbm1lbnQgdGV4dEFs aWdubWVudCkKIHsKLSAgICBOU1RleHRBbGlnbm1lbnQgbnNUZXh0QWxpZ25tZW50OwogICAgIHN3 aXRjaCAodGV4dEFsaWdubWVudCkgewogICAgIGNhc2UgTm9BbGlnbm1lbnQ6Ci0gICAgICAgIG5z VGV4dEFsaWdubWVudCA9IE5TVGV4dEFsaWdubWVudE5hdHVyYWw7Ci0gICAgICAgIGJyZWFrOwor ICAgICAgICByZXR1cm4gTlNUZXh0QWxpZ25tZW50TmF0dXJhbDsKICAgICBjYXNlIExlZnRBbGln bm1lbnQ6Ci0gICAgICAgIG5zVGV4dEFsaWdubWVudCA9IE5TVGV4dEFsaWdubWVudExlZnQ7Ci0g ICAgICAgIGJyZWFrOworICAgICAgICByZXR1cm4gTlNUZXh0QWxpZ25tZW50TGVmdDsKICAgICBj YXNlIFJpZ2h0QWxpZ25tZW50OgotICAgICAgICBuc1RleHRBbGlnbm1lbnQgPSBOU1RleHRBbGln bm1lbnRSaWdodDsKLSAgICAgICAgYnJlYWs7CisgICAgICAgIHJldHVybiBOU1RleHRBbGlnbm1l bnRSaWdodDsKICAgICBjYXNlIENlbnRlckFsaWdubWVudDoKLSAgICAgICAgbnNUZXh0QWxpZ25t ZW50ID0gTlNUZXh0QWxpZ25tZW50Q2VudGVyOwotICAgICAgICBicmVhazsKKyAgICAgICAgcmV0 dXJuIE5TVGV4dEFsaWdubWVudENlbnRlcjsKICAgICBjYXNlIEp1c3RpZmllZEFsaWdubWVudDoK LSAgICAgICAgbnNUZXh0QWxpZ25tZW50ID0gTlNUZXh0QWxpZ25tZW50SnVzdGlmaWVkOwotICAg ICAgICBicmVhazsKLSAgICBkZWZhdWx0OgotICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK KyAgICAgICAgcmV0dXJuIE5TVGV4dEFsaWdubWVudEp1c3RpZmllZDsKICAgICB9Ci0KLSAgICBy ZXR1cm4gbnNUZXh0QWxpZ25tZW50OworICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJl dHVybiBOU1RleHRBbGlnbm1lbnROYXR1cmFsOwogfQogCiB2b2lkIFdlYlZpZXdJbXBsOjp1cGRh dGVUZXh0VG91Y2hCYXIoKQo=