234984 2022-01-07 13:27:30 -0800 REGRESSION(r287683): <dialog> elements inside clipped/overflowed elements are no longer shown 2022-01-10 10:51:56 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 84635 231292 1 ntim ntim bfulgham changseok esprehn+autocc ews-watchlist fred.wang glenn kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1829053 0 ntim 2022-01-07 13:27:30 -0800 We used to show them before r287683, just at the wrong place, and with the wrong size. Now, we no longer show them. Example testcases are: imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-containing-block.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-overflow-clip.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-parent-overflow-scroll.html [ ImageOnlyFailure ] 1829054 1 webkit-bug-importer 2022-01-07 13:27:45 -0800 <rdar://problem/87269825> 1829055 2 448626 ntim 2022-01-07 13:31:17 -0800 Created attachment 448626 Patch 1829065 3 448626 zalan 2022-01-07 14:05:26 -0800 Comment on attachment 448626 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448626&action=review It'd be interesting to know if Simon agrees with this direction. > Source/WebCore/rendering/RenderLayer.cpp:1780 > +static inline bool isContainerForPositioned(RenderLayer& layer, PositionType position, bool establishesTopLayer) It's hard to tell what establishesTopLayer means in this context without looking at the callsites (like what establishes the top layer). > LayoutTests/TestExpectations:2361 > I am curious about this change (going from Skip -> Crash -while I understand that it is a more precise definition of the expected outcome, I am wondering if there are other reasons) 1829066 4 ntim 2022-01-07 14:14:25 -0800 (In reply to zalan from comment #3) > > LayoutTests/TestExpectations:2361 > > > > I am curious about this change (going from Skip -> Crash -while I understand > that it is a more precise definition of the expected outcome, I am wondering > if there are other reasons) I changed it to Crash so if there is an unexpected PASS (either by this change, or by other changes I'm working on), it would be caught, while Skip would just leave it disabled, with less testing coverage. 1829527 5 448626 simon.fraser 2022-01-10 10:25:25 -0800 Comment on attachment 448626 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448626&action=review > Source/WebCore/rendering/RenderLayer.cpp:4549 > + auto parentLayer = establishesTopLayer() ? renderer().view().layer() : parent(); Calling this 'parentLayer' is confusing because it's not always the parent layer. Maybe containerLayer? 1829537 6 ntim 2022-01-10 10:40:37 -0800 (In reply to zalan from comment #3) > Comment on attachment 448626 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448626&action=review > > It'd be interesting to know if Simon agrees with this direction. > > > Source/WebCore/rendering/RenderLayer.cpp:1780 > > +static inline bool isContainerForPositioned(RenderLayer& layer, PositionType position, bool establishesTopLayer) > > It's hard to tell what establishesTopLayer means in this context without > looking at the callsites (like what establishes the top layer). I followed the naming of the `position` argument, though maybe we should look into merging both argument (taking a renderer?), but let's not do this here. 1829542 7 448773 ntim 2022-01-10 10:46:23 -0800 Created attachment 448773 [fast-cq] Patch 1829549 8 ews-feeder 2022-01-10 10:51:51 -0800 Committed r287845 (245894@main): <https://commits.webkit.org/245894@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448773. 448626 2022-01-07 13:31:17 -0800 2022-01-10 10:25:25 -0800 Patch bug-234984-20220107223116.patch text/plain 7207 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWIyOWE3N2ZhOGMzMjIy MDRhYTBmZGRjODE3OGI2MTA0YjEzNWVmOS4uMDI1N2ZlODBhZDc3ZmI4ODhkNTM5OGU4Nzg1MzA4 OWVkNWE4NWExYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAxLTA3ICBUaW0g Tmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjg3NjgzKTog PGRpYWxvZz4gZWxlbWVudHMgaW5zaWRlIGNsaXBwZWQvb3ZlcmZsb3dlZCBlbGVtZW50cyBhcmUg bm8gbG9uZ2VyIHNob3duCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMzQ5ODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBQYWludCBhdCB0aGUgcmlnaHQgcGxhY2UgYnkgZml4aW5nIGlzQ29udGFpbmVyRm9y UG9zaXRpb25lZCwgYWxzbyBmaXggY2xpcCByZWN0cy4KKworICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjppc0NvbnRhaW5lckZvclBvc2l0aW9u ZWQpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmVuY2xvc2luZ0FuY2VzdG9yRm9y UG9zaXRpb24gY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6YWNjdW11bGF0ZU9mZnNldFRvd2Fy ZHNBbmNlc3Rvcik6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6Y2FsY3VsYXRlQ2xp cFJlY3RzIGNvbnN0KToKKwogMjAyMi0wMS0wNiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVo QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYSBoZWxwZXIgZnVuY3Rpb24gdGhhdCByZXR1cm5z IHRoZSB2YWx1ZSBvZiBhIHN0ZDo6b3B0aW9uYWw8VD4gb3IgY29uc3RydWN0cyBUIGlmIG5lZWRl ZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggOWIyMmQzYjQ5 ZDI3NjQwYWJmOTY0MTkwMzJiYzkzODdjZTViMTBhOC4uOWQ1ZWFmZmYzMmU4M2Y0YmUwNTM2Yzhl ZWQ4YzAxZDc2NjAxZDRkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIu Y3BwCkBAIC0xNzc3LDggKzE3NzcsMTEgQEAgRmxvYXRQb2ludCBSZW5kZXJMYXllcjo6cGVyc3Bl Y3RpdmVPcmlnaW4oKSBjb25zdAogICAgIHJldHVybiBmbG9hdFBvaW50Rm9yTGVuZ3RoUG9pbnQo cmVuZGVyZXIoKS5zdHlsZSgpLnBlcnNwZWN0aXZlT3JpZ2luKCksIGJvcmRlckJveC5zaXplKCkp OwogfQogCi1zdGF0aWMgaW5saW5lIGJvb2wgaXNDb250YWluZXJGb3JQb3NpdGlvbmVkKFJlbmRl ckxheWVyJiBsYXllciwgUG9zaXRpb25UeXBlIHBvc2l0aW9uKQorc3RhdGljIGlubGluZSBib29s IGlzQ29udGFpbmVyRm9yUG9zaXRpb25lZChSZW5kZXJMYXllciYgbGF5ZXIsIFBvc2l0aW9uVHlw ZSBwb3NpdGlvbiwgYm9vbCBlc3RhYmxpc2hlc1RvcExheWVyKQogeworICAgIGlmIChlc3RhYmxp c2hlc1RvcExheWVyKQorICAgICAgICByZXR1cm4gbGF5ZXIuaXNSZW5kZXJWaWV3TGF5ZXIoKTsK KwogICAgIHN3aXRjaCAocG9zaXRpb24pIHsKICAgICBjYXNlIFBvc2l0aW9uVHlwZTo6Rml4ZWQ6 CiAgICAgICAgIHJldHVybiBsYXllci5yZW5kZXJlcigpLmNhbkNvbnRhaW5GaXhlZFBvc2l0aW9u T2JqZWN0cygpOwpAQCAtMTgxNSw3ICsxODE4LDcgQEAgUmVuZGVyTGF5ZXIqIFJlbmRlckxheWVy OjplbmNsb3NpbmdBbmNlc3RvckZvclBvc2l0aW9uKFBvc2l0aW9uVHlwZSBwb3NpdGlvbikgY28K ICAgICAgICAgcmV0dXJuIHJlbmRlcmVyKCkudmlldygpLmxheWVyKCk7CiAKICAgICBSZW5kZXJM YXllciogY3VyciA9IHBhcmVudCgpOwotICAgIHdoaWxlIChjdXJyICYmICFpc0NvbnRhaW5lckZv clBvc2l0aW9uZWQoKmN1cnIsIHBvc2l0aW9uKSkKKyAgICB3aGlsZSAoY3VyciAmJiAhaXNDb250 YWluZXJGb3JQb3NpdGlvbmVkKCpjdXJyLCBwb3NpdGlvbiwgZXN0YWJsaXNoZXNUb3BMYXllcigp KSkKICAgICAgICAgY3VyciA9IGN1cnItPnBhcmVudCgpOwogCiAgICAgcmV0dXJuIGN1cnI7CkBA IC0yMjkyLDcgKzIyOTUsNyBAQCBzdGF0aWMgaW5saW5lIGNvbnN0IFJlbmRlckxheWVyKiBhY2N1 bXVsYXRlT2Zmc2V0VG93YXJkc0FuY2VzdG9yKGNvbnN0IFJlbmRlckxheQogICAgICAgICAgICAg aWYgKGN1cnJMYXllciA9PSBhbmNlc3RvckxheWVyKQogICAgICAgICAgICAgICAgIGZvdW5kQW5j ZXN0b3IgPSB0cnVlOwogCi0gICAgICAgICAgICBpZiAoaXNDb250YWluZXJGb3JQb3NpdGlvbmVk KCpjdXJyTGF5ZXIsIFBvc2l0aW9uVHlwZTo6Rml4ZWQpKSB7CisgICAgICAgICAgICBpZiAoaXND b250YWluZXJGb3JQb3NpdGlvbmVkKCpjdXJyTGF5ZXIsIFBvc2l0aW9uVHlwZTo6Rml4ZWQsIGxh eWVyLT5lc3RhYmxpc2hlc1RvcExheWVyKCkpKSB7CiAgICAgICAgICAgICAgICAgZml4ZWRQb3Np dGlvbkNvbnRhaW5lckxheWVyID0gY3VyckxheWVyOwogICAgICAgICAgICAgICAgIEFTU0VSVF9V TlVTRUQoZm91bmRBbmNlc3RvciwgZm91bmRBbmNlc3Rvcik7CiAgICAgICAgICAgICAgICAgYnJl YWs7CkBAIC0yMzMxLDcgKzIzMzQsNyBAQCBzdGF0aWMgaW5saW5lIGNvbnN0IFJlbmRlckxheWVy KiBhY2N1bXVsYXRlT2Zmc2V0VG93YXJkc0FuY2VzdG9yKGNvbnN0IFJlbmRlckxheQogICAgICAg ICAgICAgLy8gUmVuZGVyRnJhZ21lbnRlZEZsb3cgaXMgYSBwb3NpdGlvbmVkIGNvbnRhaW5lciwg Y2hpbGQgb2YgUmVuZGVyVmlldywgcG9zaXRpb25lZCBhdCAoMCwwKS4KICAgICAgICAgICAgIC8v IFRoaXMgaW1wbGllcyB0aGF0LCBmb3Igb3V0LW9mLWZsb3cgcG9zaXRpb25lZCBlbGVtZW50cyBp bnNpZGUgYSBSZW5kZXJGcmFnbWVudGVkRmxvdywKICAgICAgICAgICAgIC8vIHdlIGFyZSBiYWls aW5nIG91dCBiZWZvcmUgcmVhY2hpbmcgcm9vdCBsYXllci4KLSAgICAgICAgICAgIGlmIChpc0Nv bnRhaW5lckZvclBvc2l0aW9uZWQoKnBhcmVudExheWVyLCBwb3NpdGlvbikpCisgICAgICAgICAg ICBpZiAoaXNDb250YWluZXJGb3JQb3NpdGlvbmVkKCpwYXJlbnRMYXllciwgcG9zaXRpb24sIGxh eWVyLT5lc3RhYmxpc2hlc1RvcExheWVyKCkpKQogICAgICAgICAgICAgICAgIGJyZWFrOwogCiAg ICAgICAgICAgICBpZiAocGFyZW50TGF5ZXIgPT0gYW5jZXN0b3JMYXllcikgewpAQCAtNDU0MSwx MSArNDU0NCwxMiBAQCB2b2lkIFJlbmRlckxheWVyOjpjYWxjdWxhdGVDbGlwUmVjdHMoY29uc3Qg Q2xpcFJlY3RzQ29udGV4dCYgY2xpcFJlY3RzQ29udGV4dCwgQwogCiBSZWY8Q2xpcFJlY3RzPiBS ZW5kZXJMYXllcjo6cGFyZW50Q2xpcFJlY3RzKGNvbnN0IENsaXBSZWN0c0NvbnRleHQmIGNsaXBS ZWN0c0NvbnRleHQpIGNvbnN0CiB7Ci0gICAgQVNTRVJUKHBhcmVudCgpKTsKKyAgICBBU1NFUlQo cGFyZW50KCkgfHwgZXN0YWJsaXNoZXNUb3BMYXllcigpKTsKIAorICAgIGF1dG8gcGFyZW50TGF5 ZXIgPSBlc3RhYmxpc2hlc1RvcExheWVyKCkgPyByZW5kZXJlcigpLnZpZXcoKS5sYXllcigpIDog cGFyZW50KCk7CiAgICAgYXV0byB0ZW1wb3JhcnlQYXJlbnRDbGlwUmVjdHMgPSBbJl0oY29uc3Qg Q2xpcFJlY3RzQ29udGV4dCYgY2xpcENvbnRleHQpIHsKICAgICAgICAgYXV0byBwYXJlbnRDbGlw UmVjdHMgPSBDbGlwUmVjdHM6OmNyZWF0ZSgpOwotICAgICAgICBwYXJlbnQoKS0+Y2FsY3VsYXRl Q2xpcFJlY3RzKGNsaXBDb250ZXh0LCBwYXJlbnRDbGlwUmVjdHMpOworICAgICAgICBwYXJlbnRM YXllci0+Y2FsY3VsYXRlQ2xpcFJlY3RzKGNsaXBDb250ZXh0LCBwYXJlbnRDbGlwUmVjdHMpOwog ICAgICAgICByZXR1cm4gcGFyZW50Q2xpcFJlY3RzOwogICAgIH07CiAKQEAgLTQ1NTgsNyArNDU2 Miw3IEBAIFJlZjxDbGlwUmVjdHM+IFJlbmRlckxheWVyOjpwYXJlbnRDbGlwUmVjdHMoY29uc3Qg Q2xpcFJlY3RzQ29udGV4dCYgY2xpcFJlY3RzQ29uCiAgICAgICAgIHJldHVybiB0ZW1wb3JhcnlQ YXJlbnRDbGlwUmVjdHModGVtcENsaXBSZWN0c0NvbnRleHQpOwogICAgIH0KIAotICAgIHJldHVy biBwYXJlbnQoKS0+dXBkYXRlQ2xpcFJlY3RzKGNsaXBSZWN0c0NvbnRleHQpOworICAgIHJldHVy biBwYXJlbnRMYXllci0+dXBkYXRlQ2xpcFJlY3RzKGNsaXBSZWN0c0NvbnRleHQpOwogfQogCiBz dGF0aWMgaW5saW5lIENsaXBSZWN0IGJhY2tncm91bmRDbGlwUmVjdEZvclBvc2l0aW9uKGNvbnN0 IENsaXBSZWN0cyYgcGFyZW50UmVjdHMsIFBvc2l0aW9uVHlwZSBwb3NpdGlvbikKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0 ZmU3YTA1MWYyMzA0Nzk0ZWQxNmRhYmUyMTUwYzE4MDZkMzAyMWFiLi43YTMwOGZiZTk0YjVhOWIx YjM4ZDNkNTQ1MWE3NGIyMzcxNWFlNjk0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjItMDEt MDcgIFRpbSBOZ3V5ZW4gIDxudGltQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIy ODc2ODMpOiA8ZGlhbG9nPiBlbGVtZW50cyBpbnNpZGUgY2xpcHBlZC9vdmVyZmxvd2VkIGVsZW1l bnRzIGFyZSBubyBsb25nZXIgc2hvd24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIzNDk4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEVuYWJsZSByZWxldmFudCB0ZXN0cy4gU2V0IHRoZSBhc3NlcnRpbmcg dGVzdCBhcyBDcmFzaCBpbnN0ZWFkIG9mIFNraXBwaW5nLgorCisgICAgICAgICogVGVzdEV4cGVj dGF0aW9uczoKKwogMjAyMi0wMS0wNiAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBw bGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjI4MTM4OSk6IFRleHQgd3JhcHMgdW5uZWNl c3NhcmlseSB3aXRoaW4gaW50cmluc2ljYWxseS1zaXplZCBlbGVtZW50cyB3aGVuIHVzaW5nIGNl cnRhaW4gZm9udHMgYW5kIHRoZSBpbm5lciBIVE1MIG9mIHRoZSBlbGVtZW50IGNvbnRhaW5zIGEg bmV3IGxpbmUgdGhhdCBpcyBub3QgcHJlY2VkZWQgYnkgYSBzcGFjZQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMK aW5kZXggZDhiZTEyZTQ0MGUwMWIxMWY5M2IyMDAzOTVkMmMzOGQwODQ4YzQxYS4uMGE1YTMzOGU2 NDM0Y2NiOGMyYjBjOWFhYjEwZmQ3N2VmOTFjZTBiNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv VGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBAIC0y MzU2LDEyICsyMzU2LDggQEAgZmFzdC9tdWx0aWNvbC9tdWx0aWNvbC13aXRoLWNoaWxkLXJlbmRl ckxheWVyLWZvci1pbnB1dC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZQogIyBUb3AgbGF5ZXIgdGVz dHMKIHdlYmtpdC5vcmcvYi8yMjkzMTUgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9o dG1sL3NlbWFudGljcy9pbnRlcmFjdGl2ZS1lbGVtZW50cy90aGUtZGlhbG9nLWVsZW1lbnQvbW9k YWwtZGlhbG9nLWluLXJlcGxhY2VkLXJlbmRlcmVyLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0K IHdlYmtpdC5vcmcvYi8yMjkzMTUgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1s L3NlbWFudGljcy9pbnRlcmFjdGl2ZS1lbGVtZW50cy90aGUtZGlhbG9nLWVsZW1lbnQvbW9kYWwt ZGlhbG9nLWluLXRhYmxlLWNvbHVtbi5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCi13ZWJraXQu b3JnL2IvMjMxMjkyIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRp Y3MvaW50ZXJhY3RpdmUtZWxlbWVudHMvdGhlLWRpYWxvZy1lbGVtZW50L3RvcC1sYXllci1jb250 YWluaW5nLWJsb2NrLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8yMzEy OTIgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9pbnRlcmFj dGl2ZS1lbGVtZW50cy90aGUtZGlhbG9nLWVsZW1lbnQvdG9wLWxheWVyLXN0YWNraW5nLmh0bWwg WyBJbWFnZU9ubHlGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8yMzEyOTIgaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9pbnRlcmFjdGl2ZS1lbGVtZW50cy90aGUt ZGlhbG9nLWVsZW1lbnQvdG9wLWxheWVyLXBhcmVudC1vdmVyZmxvdy1jbGlwLmh0bWwgWyBJbWFn ZU9ubHlGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8yMzEyOTIgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9pbnRlcmFjdGl2ZS1lbGVtZW50cy90aGUtZGlhbG9n LWVsZW1lbnQvdG9wLWxheWVyLXBhcmVudC1vdmVyZmxvdy1zY3JvbGwuaHRtbCBbIEltYWdlT25s eUZhaWx1cmUgXQogIyBOZWVkcyBsYXllciByZS1wYXJlbnRpbmcKLXdlYmtpdC5vcmcvYi8yMzEy OTIgWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRp Y3MvaW50ZXJhY3RpdmUtZWxlbWVudHMvdGhlLWRpYWxvZy1lbGVtZW50L3RvcC1sYXllci1wYXJl bnQtdHJhbnNmb3JtLmh0bWwgWyBTa2lwIF0KK3dlYmtpdC5vcmcvYi8yMzQ5ODAgWyBEZWJ1ZyBd IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvaW50ZXJhY3Rp dmUtZWxlbWVudHMvdGhlLWRpYWxvZy1lbGVtZW50L3RvcC1sYXllci1wYXJlbnQtdHJhbnNmb3Jt Lmh0bWwgWyBDcmFzaCBdCiAKICMgQXNzZXJ0aW9uIGZhaWx1cmUgaW4gTWVzc2FnZVBvcnQ6OmNv bnRleHREZXN0cm95ZWQsIHVzdWFsbHkgYXR0cmlidXRlZCB0byBsYXRlciB0ZXN0cwogd2Via2l0 Lm9yZy9iLzk0NDU4IGh0dHAvdGVzdHMvc2VjdXJpdHkvTWVzc2FnZVBvcnQvZXZlbnQtbGlzdGVu ZXItY29udGV4dC5odG1sIFsgU2tpcCBdCg== 448773 2022-01-10 10:46:23 -0800 2022-01-10 10:51:53 -0800 [fast-cq] Patch bug-234984-20220110194621.patch text/plain 7109 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3ODQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQ4MzUyOWE5NWQxNDg4 ZWE2NWJkMDgwYTFiYzYwMTA1Mjg5N2UxOS4uNzg1NDc2NGUyZTViNGYzYzNkNjFjMzFmY2ZlY2Ix YWUzZjBiOWQ1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAxLTA3ICBUaW0g Tmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjg3NjgzKTog PGRpYWxvZz4gZWxlbWVudHMgaW5zaWRlIGNsaXBwZWQvb3ZlcmZsb3dlZCBlbGVtZW50cyBhcmUg bm8gbG9uZ2VyIHNob3duCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMzQ5ODQKKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAg ICAgICAgUGFpbnQgYXQgdGhlIHJpZ2h0IHBsYWNlIGJ5IGZpeGluZyBpc0NvbnRhaW5lckZvclBv c2l0aW9uZWQsIGFsc28gZml4IGNsaXAgcmVjdHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6aXNDb250YWluZXJGb3JQb3NpdGlvbmVk KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjplbmNsb3NpbmdBbmNlc3RvckZvclBv c2l0aW9uIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OmFjY3VtdWxhdGVPZmZzZXRUb3dhcmRz QW5jZXN0b3IpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmNhbGN1bGF0ZUNsaXBS ZWN0cyBjb25zdCk6CisKIDIwMjItMDEtMTAgIFNhbSBXZWluaWcgIDx3ZWluaWdAYXBwbGUuY29t PgogCiAgICAgICAgIFtDU1MgQ29sb3IgNF0gQ1NTIGNvbG9yKCkgZnVuY3Rpb24gc2hvdWxkIG5v dCBjbGFtcCBjaGFubmVscyB0byB0aGUgMC0xIHJhbmdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyLmNwcAppbmRleCAyZjFiMTllNmI2MTBkNzBmODdhZWVhNDY2MGRmNDQwMjcy MWIyZTAzLi5lNTlkMDc3M2FhYzI0OWMwNGIzYWZmZDcyNjM1OGNiYWVmZmE0YTcxIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKQEAgLTE3NzcsOCArMTc3NywxMSBA QCBGbG9hdFBvaW50IFJlbmRlckxheWVyOjpwZXJzcGVjdGl2ZU9yaWdpbigpIGNvbnN0CiAgICAg cmV0dXJuIGZsb2F0UG9pbnRGb3JMZW5ndGhQb2ludChyZW5kZXJlcigpLnN0eWxlKCkucGVyc3Bl Y3RpdmVPcmlnaW4oKSwgYm9yZGVyQm94LnNpemUoKSk7CiB9CiAKLXN0YXRpYyBpbmxpbmUgYm9v bCBpc0NvbnRhaW5lckZvclBvc2l0aW9uZWQoUmVuZGVyTGF5ZXImIGxheWVyLCBQb3NpdGlvblR5 cGUgcG9zaXRpb24pCitzdGF0aWMgaW5saW5lIGJvb2wgaXNDb250YWluZXJGb3JQb3NpdGlvbmVk KFJlbmRlckxheWVyJiBsYXllciwgUG9zaXRpb25UeXBlIHBvc2l0aW9uLCBib29sIGVzdGFibGlz aGVzVG9wTGF5ZXIpCiB7CisgICAgaWYgKGVzdGFibGlzaGVzVG9wTGF5ZXIpCisgICAgICAgIHJl dHVybiBsYXllci5pc1JlbmRlclZpZXdMYXllcigpOworCiAgICAgc3dpdGNoIChwb3NpdGlvbikg ewogICAgIGNhc2UgUG9zaXRpb25UeXBlOjpGaXhlZDoKICAgICAgICAgcmV0dXJuIGxheWVyLnJl bmRlcmVyKCkuY2FuQ29udGFpbkZpeGVkUG9zaXRpb25PYmplY3RzKCk7CkBAIC0xODE1LDcgKzE4 MTgsNyBAQCBSZW5kZXJMYXllciogUmVuZGVyTGF5ZXI6OmVuY2xvc2luZ0FuY2VzdG9yRm9yUG9z aXRpb24oUG9zaXRpb25UeXBlIHBvc2l0aW9uKSBjbwogICAgICAgICByZXR1cm4gcmVuZGVyZXIo KS52aWV3KCkubGF5ZXIoKTsKIAogICAgIFJlbmRlckxheWVyKiBjdXJyID0gcGFyZW50KCk7Ci0g ICAgd2hpbGUgKGN1cnIgJiYgIWlzQ29udGFpbmVyRm9yUG9zaXRpb25lZCgqY3VyciwgcG9zaXRp b24pKQorICAgIHdoaWxlIChjdXJyICYmICFpc0NvbnRhaW5lckZvclBvc2l0aW9uZWQoKmN1cnIs IHBvc2l0aW9uLCBlc3RhYmxpc2hlc1RvcExheWVyKCkpKQogICAgICAgICBjdXJyID0gY3Vyci0+ cGFyZW50KCk7CiAKICAgICByZXR1cm4gY3VycjsKQEAgLTIyOTIsNyArMjI5NSw3IEBAIHN0YXRp YyBpbmxpbmUgY29uc3QgUmVuZGVyTGF5ZXIqIGFjY3VtdWxhdGVPZmZzZXRUb3dhcmRzQW5jZXN0 b3IoY29uc3QgUmVuZGVyTGF5CiAgICAgICAgICAgICBpZiAoY3VyckxheWVyID09IGFuY2VzdG9y TGF5ZXIpCiAgICAgICAgICAgICAgICAgZm91bmRBbmNlc3RvciA9IHRydWU7CiAKLSAgICAgICAg ICAgIGlmIChpc0NvbnRhaW5lckZvclBvc2l0aW9uZWQoKmN1cnJMYXllciwgUG9zaXRpb25UeXBl OjpGaXhlZCkpIHsKKyAgICAgICAgICAgIGlmIChpc0NvbnRhaW5lckZvclBvc2l0aW9uZWQoKmN1 cnJMYXllciwgUG9zaXRpb25UeXBlOjpGaXhlZCwgbGF5ZXItPmVzdGFibGlzaGVzVG9wTGF5ZXIo KSkpIHsKICAgICAgICAgICAgICAgICBmaXhlZFBvc2l0aW9uQ29udGFpbmVyTGF5ZXIgPSBjdXJy TGF5ZXI7CiAgICAgICAgICAgICAgICAgQVNTRVJUX1VOVVNFRChmb3VuZEFuY2VzdG9yLCBmb3Vu ZEFuY2VzdG9yKTsKICAgICAgICAgICAgICAgICBicmVhazsKQEAgLTIzMzEsNyArMjMzNCw3IEBA IHN0YXRpYyBpbmxpbmUgY29uc3QgUmVuZGVyTGF5ZXIqIGFjY3VtdWxhdGVPZmZzZXRUb3dhcmRz QW5jZXN0b3IoY29uc3QgUmVuZGVyTGF5CiAgICAgICAgICAgICAvLyBSZW5kZXJGcmFnbWVudGVk RmxvdyBpcyBhIHBvc2l0aW9uZWQgY29udGFpbmVyLCBjaGlsZCBvZiBSZW5kZXJWaWV3LCBwb3Np dGlvbmVkIGF0ICgwLDApLgogICAgICAgICAgICAgLy8gVGhpcyBpbXBsaWVzIHRoYXQsIGZvciBv dXQtb2YtZmxvdyBwb3NpdGlvbmVkIGVsZW1lbnRzIGluc2lkZSBhIFJlbmRlckZyYWdtZW50ZWRG bG93LAogICAgICAgICAgICAgLy8gd2UgYXJlIGJhaWxpbmcgb3V0IGJlZm9yZSByZWFjaGluZyBy b290IGxheWVyLgotICAgICAgICAgICAgaWYgKGlzQ29udGFpbmVyRm9yUG9zaXRpb25lZCgqcGFy ZW50TGF5ZXIsIHBvc2l0aW9uKSkKKyAgICAgICAgICAgIGlmIChpc0NvbnRhaW5lckZvclBvc2l0 aW9uZWQoKnBhcmVudExheWVyLCBwb3NpdGlvbiwgbGF5ZXItPmVzdGFibGlzaGVzVG9wTGF5ZXIo KSkpCiAgICAgICAgICAgICAgICAgYnJlYWs7CiAKICAgICAgICAgICAgIGlmIChwYXJlbnRMYXll ciA9PSBhbmNlc3RvckxheWVyKSB7CkBAIC00NTQxLDExICs0NTQ0LDEyIEBAIHZvaWQgUmVuZGVy TGF5ZXI6OmNhbGN1bGF0ZUNsaXBSZWN0cyhjb25zdCBDbGlwUmVjdHNDb250ZXh0JiBjbGlwUmVj dHNDb250ZXh0LCBDCiAKIFJlZjxDbGlwUmVjdHM+IFJlbmRlckxheWVyOjpwYXJlbnRDbGlwUmVj dHMoY29uc3QgQ2xpcFJlY3RzQ29udGV4dCYgY2xpcFJlY3RzQ29udGV4dCkgY29uc3QKIHsKLSAg ICBBU1NFUlQocGFyZW50KCkpOworICAgIEFTU0VSVChwYXJlbnQoKSB8fCBlc3RhYmxpc2hlc1Rv cExheWVyKCkpOwogCisgICAgYXV0byBjb250YWluZXJMYXllciA9IGVzdGFibGlzaGVzVG9wTGF5 ZXIoKSA/IHJlbmRlcmVyKCkudmlldygpLmxheWVyKCkgOiBwYXJlbnQoKTsKICAgICBhdXRvIHRl bXBvcmFyeVBhcmVudENsaXBSZWN0cyA9IFsmXShjb25zdCBDbGlwUmVjdHNDb250ZXh0JiBjbGlw Q29udGV4dCkgewogICAgICAgICBhdXRvIHBhcmVudENsaXBSZWN0cyA9IENsaXBSZWN0czo6Y3Jl YXRlKCk7Ci0gICAgICAgIHBhcmVudCgpLT5jYWxjdWxhdGVDbGlwUmVjdHMoY2xpcENvbnRleHQs IHBhcmVudENsaXBSZWN0cyk7CisgICAgICAgIGNvbnRhaW5lckxheWVyLT5jYWxjdWxhdGVDbGlw UmVjdHMoY2xpcENvbnRleHQsIHBhcmVudENsaXBSZWN0cyk7CiAgICAgICAgIHJldHVybiBwYXJl bnRDbGlwUmVjdHM7CiAgICAgfTsKIApAQCAtNDU1OCw3ICs0NTYyLDcgQEAgUmVmPENsaXBSZWN0 cz4gUmVuZGVyTGF5ZXI6OnBhcmVudENsaXBSZWN0cyhjb25zdCBDbGlwUmVjdHNDb250ZXh0JiBj bGlwUmVjdHNDb24KICAgICAgICAgcmV0dXJuIHRlbXBvcmFyeVBhcmVudENsaXBSZWN0cyh0ZW1w Q2xpcFJlY3RzQ29udGV4dCk7CiAgICAgfQogCi0gICAgcmV0dXJuIHBhcmVudCgpLT51cGRhdGVD bGlwUmVjdHMoY2xpcFJlY3RzQ29udGV4dCk7CisgICAgcmV0dXJuIGNvbnRhaW5lckxheWVyLT51 cGRhdGVDbGlwUmVjdHMoY2xpcFJlY3RzQ29udGV4dCk7CiB9CiAKIHN0YXRpYyBpbmxpbmUgQ2xp cFJlY3QgYmFja2dyb3VuZENsaXBSZWN0Rm9yUG9zaXRpb24oY29uc3QgQ2xpcFJlY3RzJiBwYXJl bnRSZWN0cywgUG9zaXRpb25UeXBlIHBvc2l0aW9uKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDA1NWVhYjNkYTk2NzAzYzUz YjYxNDIzZGI5ZGQ1MjZmZDVkNWE2NzYuLjQ5MDc2Mzk0NThmMTBmOTA1M2VmN2IyMWMyNTdhNmNk YTAwOWE3MjMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMi0wMS0wNyAgVGltIE5ndXllbiAg PG50aW1AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI4NzY4Myk6IDxkaWFsb2c+ IGVsZW1lbnRzIGluc2lkZSBjbGlwcGVkL292ZXJmbG93ZWQgZWxlbWVudHMgYXJlIG5vIGxvbmdl ciBzaG93bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjM0OTg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAgICAgIEVu YWJsZSByZWxldmFudCB0ZXN0cy4gU2V0IHRoZSBhc3NlcnRpbmcgdGVzdCBhcyBDcmFzaCBpbnN0 ZWFkIG9mIFNraXBwaW5nLgorCisgICAgICAgICogVGVzdEV4cGVjdGF0aW9uczoKKwogMjAyMi0w MS0xMCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBS RUdSRVNTSU9OIChyMjg3NDMxKTogW0JpZyBTdXIgV0sxXSBmYXN0L3Njcm9sbGluZy9sYXRjaGlu Zy9pZnJhbWUtbGF0Y2gtc21hbGwtZGVsdGFzLmh0bWwgaXMgY29uc2lzdGVudGx5IGZhaWxpbmcK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9U ZXN0RXhwZWN0YXRpb25zCmluZGV4IDZjNWFkMWU3MDRjZmYyOGNlYjM4YTEyNjc0OGY2YTc3NGQx NjgyYTkuLjUzMjc1MWE1OGZlNWYwYzIyNGVmOTRhMzIwNmNjNTE1YjQ2ODI5NzIgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvVGVzdEV4 cGVjdGF0aW9ucwpAQCAtMjM1OCwxMiArMjM1OCw4IEBAIGZhc3QvbXVsdGljb2wvbXVsdGljb2wt d2l0aC1jaGlsZC1yZW5kZXJMYXllci1mb3ItaW5wdXQuaHRtbCBbIEltYWdlT25seUZhaWx1cmUK ICMgVG9wIGxheWVyIHRlc3RzCiB3ZWJraXQub3JnL2IvMjI5MzE1IGltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvaW50ZXJhY3RpdmUtZWxlbWVudHMvdGhlLWRp YWxvZy1lbGVtZW50L21vZGFsLWRpYWxvZy1pbi1yZXBsYWNlZC1yZW5kZXJlci5odG1sIFsgSW1h Z2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMjI5MzE1IGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvaW50ZXJhY3RpdmUtZWxlbWVudHMvdGhlLWRpYWxv Zy1lbGVtZW50L21vZGFsLWRpYWxvZy1pbi10YWJsZS1jb2x1bW4uaHRtbCBbIEltYWdlT25seUZh aWx1cmUgXQotd2Via2l0Lm9yZy9iLzIzMTI5MiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2h0bWwvc2VtYW50aWNzL2ludGVyYWN0aXZlLWVsZW1lbnRzL3RoZS1kaWFsb2ctZWxlbWVu dC90b3AtbGF5ZXItY29udGFpbmluZy1ibG9jay5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCi13 ZWJraXQub3JnL2IvMjMxMjkyIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9z ZW1hbnRpY3MvaW50ZXJhY3RpdmUtZWxlbWVudHMvdGhlLWRpYWxvZy1lbGVtZW50L3RvcC1sYXll ci1zdGFja2luZy5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMjMxMjky IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvaW50ZXJhY3Rp dmUtZWxlbWVudHMvdGhlLWRpYWxvZy1lbGVtZW50L3RvcC1sYXllci1wYXJlbnQtb3ZlcmZsb3ct Y2xpcC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMjMxMjkyIGltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvaW50ZXJhY3RpdmUtZWxl bWVudHMvdGhlLWRpYWxvZy1lbGVtZW50L3RvcC1sYXllci1wYXJlbnQtb3ZlcmZsb3ctc2Nyb2xs Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KICMgTmVlZHMgbGF5ZXIgcmUtcGFyZW50aW5nCi13 ZWJraXQub3JnL2IvMjMxMjkyIFsgRGVidWcgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2h0bWwvc2VtYW50aWNzL2ludGVyYWN0aXZlLWVsZW1lbnRzL3RoZS1kaWFsb2ctZWxlbWVu dC90b3AtbGF5ZXItcGFyZW50LXRyYW5zZm9ybS5odG1sIFsgU2tpcCBdCit3ZWJraXQub3JnL2Iv MjM0OTgwIFsgRGVidWcgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2Vt YW50aWNzL2ludGVyYWN0aXZlLWVsZW1lbnRzL3RoZS1kaWFsb2ctZWxlbWVudC90b3AtbGF5ZXIt cGFyZW50LXRyYW5zZm9ybS5odG1sIFsgQ3Jhc2ggXQogCiAjIEFzc2VydGlvbiBmYWlsdXJlIGlu IE1lc3NhZ2VQb3J0Ojpjb250ZXh0RGVzdHJveWVkLCB1c3VhbGx5IGF0dHJpYnV0ZWQgdG8gbGF0 ZXIgdGVzdHMKIHdlYmtpdC5vcmcvYi85NDQ1OCBodHRwL3Rlc3RzL3NlY3VyaXR5L01lc3NhZ2VQ b3J0L2V2ZW50LWxpc3RlbmVyLWNvbnRleHQuaHRtbCBbIFNraXAgXQo=