234980 2022-01-07 13:02:15 -0800 Various RenderLayer issue with <dialog> 2022-01-19 12:26:20 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 84635 1 ntim webkit-unassigned bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1829041 0 ntim 2022-01-07 13:02:15 -0800 Why? - Avoid a myriad of establishesTopLayer() checks over the place - Avoids needing to think about top layer later on Tasks: - Make RenderLayer::addChild/updateLayerPosition and anything else that relies on renderer hierarchy - Need to look into a bunch of new assertions - Fix visibility code to not be affected by layer reparenting (DOM/flat tree hierarchy should be followed for visibility, like for display) 1830638 1 webkit-bug-importer 2022-01-13 11:08:30 -0800 <rdar://problem/87560426> 1830991 2 simon.fraser 2022-01-14 11:44:54 -0800 These are the ancestor tree walks I've found that need thinking about in terms of top layer: setAncestorChainHasSelfPaintingLayerDescendant setAncestorChainHasVisibleDescendant SVGRenderingContext::calculateTransformationToOutermostCoordinateSystem enclosingScrollableLayer() RenderElement::moveLayers RenderElement::findNextLayer traverseAncestorLayers enclosingFragmentedFlowAncestor 1832137 3 simon.fraser 2022-01-19 12:08:24 -0800 I think all the examples above are taken care of by RenderLayer reparenting (fixed in bug 235194). So the only remaining issue is an incorrect opacity computation in ContentChangeObserver::isVisuallyHidden() (bug 235240). 1832143 4 simon.fraser 2022-01-19 12:20:56 -0800 Closing since this is covered by other bugs.