234978 2022-01-07 12:36:03 -0800 Remove obsolete DOM Level 2 "DOMFocusIn" / "DOMFocusOut" events 2022-07-30 13:29:02 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=235036 InRadar P2 Normal --- 234928 1 ashvayka ashvayka ap cdumez darin enrica ggaren ntim webkit-bug-importer oldest_to_newest 1829033 0 ashvayka 2022-01-07 12:36:03 -0800 Only 0.04% of page loads use them (https://chromestatus.com/metrics/feature/timeline/popularity/211). 1829061 1 448629 ashvayka 2022-01-07 14:00:12 -0800 Created attachment 448629 Patch for landing 1829063 2 448629 ashvayka 2022-01-07 14:00:44 -0800 Comment on attachment 448629 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=448629&action=review > Source/WebCore/ChangeLog:6 > + Reviewed by Geoff Garen. In https://bugs.webkit.org/show_bug.cgi?id=234928. 1829095 3 ews-feeder 2022-01-07 14:52:56 -0800 Committed r287787 (245847@main): <https://commits.webkit.org/245847@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448629. 1829096 4 webkit-bug-importer 2022-01-07 14:53:24 -0800 <rdar://problem/87273766> 1829154 5 ap 2022-01-07 17:43:57 -0800 > Only 0.04% of page loads use them (https://chromestatus.com/metrics/feature/timeline/popularity/211). 0.04% is much smaller than 16% discussed in the other bug, but isn't that a huge number too, given the scale of the web? I vaguely recall that even Chrome has a lower threshold for removing unpopular features. But not sure where to find their exact policy; or if ours should be informed by Chrome's. 1829158 6 darin 2022-01-07 17:48:00 -0800 (In reply to Alexey Proskuryakov from comment #5) > I vaguely recall that even Chrome has a lower threshold for removing > unpopular features. But not sure where to find their exact policy; or if > ours should be informed by Chrome's. I wasn’t convinced by the 0.04% number alone, but also by the fact that Firefox has never implemented this. 1829160 7 ashvayka 2022-01-07 17:52:56 -0800 Also, all other features with usage around 0.04% that I've checked on Chrome stats, have a few thousand "top sites using them" list, but for "DOMFocusIn" / "DOMFocusOut" it's 5 dead sites, which kinda sparks confidence? 1829171 8 ap 2022-01-07 18:10:55 -0800 > Firefox has never implemented this That's more convincing indeed. I didn't see that discussed, perhaps it was in Slack. > it's 5 dead sites, which kinda sparks confidence googlevideo.com is not exactly dead (redirects to a modern URL), but it doesn't appear to use these events now. I am not familiar with Chrome's popularity website enough to know if the fact that timeline starts in 2017 means that data aggregation code is lacking, or that the events haven't been used by any sites since 2017. 1829174 9 ashvayka 2022-01-07 18:19:26 -0800 (In reply to Alexey Proskuryakov from comment #8) > I am not familiar with Chrome's popularity website enough to know if the fact that timeline starts in 2017 > means that data aggregation code is lacking, or that the events haven't been used by any sites since 2017. They've changed data collection around 2017. There is "Show all historical data" checkbox at the top for metrics up to 2014, which seem steadily declining. 1829187 10 ntim 2022-01-07 19:12:29 -0800 Can you please create a WPT PR to replace usages of these: - https://github.com/web-platform-tests/wpt/search?q=DOMFocusOut - https://github.com/web-platform-tests/wpt/search?q=DOMFocusIn 1829551 11 ashvayka 2022-01-10 10:55:41 -0800 (In reply to Alexey Proskuryakov from comment #8) > > Firefox has never implemented this I'm rolling out this change, please see https://bugs.webkit.org/show_bug.cgi?id=235036 for details. In short: quite popular JS library used to do browser detection and relied on WebKit browsers emitting "DOMFocusIn" / "DOMFocusOut" events rather than actually testing the feature. > That's more convincing indeed. I didn't see that discussed, perhaps it was > in Slack. No, just the ChangeLog. For future, should I start a Slack / mail list discussion when removing a feature? 1829615 12 ap 2022-01-10 13:26:03 -0800 I was just particularly curious because the bug description was so short and somewhat unconvincing - and I failed to check the ChangeLog. > For future, should I start a Slack / mail list discussion when removing a feature? That can be a good idea if you are looking for some insight specific to the feature in question, but there is no such expectation in general. A reviewer can always suggest that if appropriate, too. 1887893 13 rniwa 2022-07-30 13:29:02 -0700 *** Bug 47014 has been marked as a duplicate of this bug. *** 448629 2022-01-07 14:00:12 -0800 2022-01-07 14:52:58 -0800 Patch for landing bug-234978-20220107220010.patch text/plain 14085 ashvayka SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4Nzc3NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDIyLTAxLTA3ICBBbGV4ZXkg U2h2YXlrYSAgPGFzaHZheWthQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgb2Jzb2xldGUg RE9NIExldmVsIDIgIkRPTUZvY3VzSW4iIC8gIkRPTUZvY3VzT3V0IiBldmVudHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDk3OAorCisgICAgICAg IFJldmlld2VkIGJ5IEdlb2ZmIEdhcmVuLgorCisgICAgICAgIFRoaXMgcGF0Y2ggcmVtb3ZlcyB0 aGVzZSBldmVudHMgYmVjYXVzZSBhY2NvcmRpbmcgdG8gQ2hyb21lIHN0YXRzLCBvbmx5IDAuMDQl CisgICAgICAgIG9mIHBhZ2UgbG9hZHMgdXNlIHRoZW0gWzFdLCB3aGljaCBpcyBiZWxvdyB0aGUg QmxpbmsncyByZW1vdmFsIHRocmVzaG9sZCBvZiAwLjEwJS4KKworICAgICAgICBBbGwgdGhlICJ0 b3Agc2l0ZXMiIGxpc3RlZCBhcyAiRE9NRm9jdXNJbiIgLyAiRE9NRm9jdXNPdXQiIGFkb3B0ZXJz LCBhcmUgbm93IGRlYWQuCisgICAgICAgIEFsc28sIHRoZXNlIGV2ZW50cyB3ZXJlIG5ldmVyIGlt cGxlbWVudGVkIGluIEZpcmVmb3guCisKKyAgICAgICAgWzFdIGh0dHBzOi8vY2hyb21lc3RhdHVz LmNvbS9tZXRyaWNzL2ZlYXR1cmUvdGltZWxpbmUvcG9wdWxhcml0eS8yMTEKKworICAgICAgICBO byBuZXcgdGVzdHMgYmVjYXVzZSBpdCdzIGEgZmVhdHVyZSByZW1vdmFsLgorCisgICAgICAgICog ZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpzZXRGb2N1c2Vk RWxlbWVudCk6CisgICAgICAgICogZG9tL0RvY3VtZW50Lmg6CisgICAgICAgICogZG9tL0VsZW1l bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6ZGlzcGF0Y2hGb2N1c0luRXZlbnQp OgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6ZGlzcGF0Y2hGb2N1c091dEV2ZW50KToKKyAg ICAgICAgKiBkb20vRWxlbWVudC5oOgorICAgICAgICAqIGRvbS9FdmVudE5hbWVzLmg6CisKIDIw MjItMDEtMDcgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIE1h a2Ugc2VwYXJhdGUgaW52YWxpZGF0aW9uIHJ1bGVzZXRzIGZvciBuZWdhdGVkIHNlbGVjdG9ycyAo aW5zaWRlIDpub3QoKSkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkocmV2aXNpb24gMjg3 Nzc2KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkod29ya2luZyBjb3B5KQpA QCAtNDY1OCwxMCArNDY1OCw3IEBAIGJvb2wgRG9jdW1lbnQ6OnNldEZvY3VzZWRFbGVtZW50KEVs ZW1lbnQKICAgICAgICAgICAgICAgICBuZXdGb2N1c2VkRWxlbWVudCA9IG51bGxwdHI7CiAgICAg ICAgICAgICB9CiAKLSAgICAgICAgICAgIG9sZEZvY3VzZWRFbGVtZW50LT5kaXNwYXRjaEZvY3Vz T3V0RXZlbnQoZXZlbnROYW1lcygpLmZvY3Vzb3V0RXZlbnQsIG5ld0ZvY3VzZWRFbGVtZW50LmNv cHlSZWYoKSk7IC8vIERPTSBsZXZlbCAzIG5hbWUgZm9yIHRoZSBidWJibGluZyBibHVyIGV2ZW50 LgotICAgICAgICAgICAgLy8gRklYTUU6IFdlIHNob3VsZCByZW1vdmUgZmlyaW5nIERPTUZvY3Vz T3V0RXZlbnQgZXZlbnQgd2hlbiB3ZSBhcmUgc3VyZSBubyBjb250ZW50IGRlcGVuZHMKLSAgICAg ICAgICAgIC8vIG9uIGl0LCBwcm9iYWJseSB3aGVuIDxyZGFyOi8vcHJvYmxlbS84NTAzOTU4PiBp cyByZXNvbHZlZC4KLSAgICAgICAgICAgIG9sZEZvY3VzZWRFbGVtZW50LT5kaXNwYXRjaEZvY3Vz T3V0RXZlbnQoZXZlbnROYW1lcygpLkRPTUZvY3VzT3V0RXZlbnQsIG5ld0ZvY3VzZWRFbGVtZW50 LmNvcHlSZWYoKSk7IC8vIERPTSBsZXZlbCAyIG5hbWUgZm9yIGNvbXBhdGliaWxpdHkuCisgICAg ICAgICAgICBvbGRGb2N1c2VkRWxlbWVudC0+ZGlzcGF0Y2hGb2N1c091dEV2ZW50KG5ld0ZvY3Vz ZWRFbGVtZW50LmNvcHlSZWYoKSk7IC8vIERPTSBsZXZlbCAzIGJ1YmJsaW5nIGJsdXIgZXZlbnQu CiAKICAgICAgICAgICAgIGlmIChtX2ZvY3VzZWRFbGVtZW50KSB7CiAgICAgICAgICAgICAgICAg Ly8gaGFuZGxlciBzaGlmdGVkIGZvY3VzCkBAIC00NzI2LDE2ICs0NzIzLDcgQEAgYm9vbCBEb2N1 bWVudDo6c2V0Rm9jdXNlZEVsZW1lbnQoRWxlbWVudAogICAgICAgICAgICAgcmV0dXJuIGZhbHNl OwogICAgICAgICB9CiAKLSAgICAgICAgbV9mb2N1c2VkRWxlbWVudC0+ZGlzcGF0Y2hGb2N1c0lu RXZlbnQoZXZlbnROYW1lcygpLmZvY3VzaW5FdmVudCwgb2xkRm9jdXNlZEVsZW1lbnQuY29weVJl ZigpKTsgLy8gRE9NIGxldmVsIDMgYnViYmxpbmcgZm9jdXMgZXZlbnQuCi0KLSAgICAgICAgaWYg KG1fZm9jdXNlZEVsZW1lbnQgIT0gbmV3Rm9jdXNlZEVsZW1lbnQpIHsKLSAgICAgICAgICAgIC8v IGhhbmRsZXIgc2hpZnRlZCBmb2N1cwotICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgICAg ICB9Ci0KLSAgICAgICAgLy8gRklYTUU6IFdlIHNob3VsZCByZW1vdmUgZmlyaW5nIERPTUZvY3Vz SW5FdmVudCBldmVudCB3aGVuIHdlIGFyZSBzdXJlIG5vIGNvbnRlbnQgZGVwZW5kcwotICAgICAg ICAvLyBvbiBpdCwgcHJvYmFibHkgd2hlbiA8cmRhcjovL3Byb2JsZW0vODUwMzk1OD4gaXMgbS4K LSAgICAgICAgbV9mb2N1c2VkRWxlbWVudC0+ZGlzcGF0Y2hGb2N1c0luRXZlbnQoZXZlbnROYW1l cygpLkRPTUZvY3VzSW5FdmVudCwgb2xkRm9jdXNlZEVsZW1lbnQuY29weVJlZigpKTsgLy8gRE9N IGxldmVsIDIgZm9yIGNvbXBhdGliaWxpdHkuCisgICAgICAgIG1fZm9jdXNlZEVsZW1lbnQtPmRp c3BhdGNoRm9jdXNJbkV2ZW50KG9sZEZvY3VzZWRFbGVtZW50LmNvcHlSZWYoKSk7IC8vIERPTSBs ZXZlbCAzIGJ1YmJsaW5nIGZvY3VzIGV2ZW50LgogCiAgICAgICAgIGlmIChtX2ZvY3VzZWRFbGVt ZW50ICE9IG5ld0ZvY3VzZWRFbGVtZW50KSB7CiAgICAgICAgICAgICAvLyBoYW5kbGVyIHNoaWZ0 ZWQgZm9jdXMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAJKHJldmlzaW9uIDI4Nzc3NikKKysr IFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzE4Miwx OCArMzE4MiwxNiBAQCB2b2lkIEVsZW1lbnQ6OnJ1bkZvY3VzaW5nU3RlcHNGb3JBdXRvZm9jCiAg ICAgZm9jdXMoKTsKIH0KIAotdm9pZCBFbGVtZW50OjpkaXNwYXRjaEZvY3VzSW5FdmVudChjb25z dCBBdG9tU3RyaW5nJiBldmVudFR5cGUsIFJlZlB0cjxFbGVtZW50PiYmIG9sZEZvY3VzZWRFbGVt ZW50KQordm9pZCBFbGVtZW50OjpkaXNwYXRjaEZvY3VzSW5FdmVudChSZWZQdHI8RWxlbWVudD4m JiBvbGRGb2N1c2VkRWxlbWVudCkKIHsKICAgICBSRUxFQVNFX0FTU0VSVF9XSVRIX1NFQ1VSSVRZ X0lNUExJQ0FUSU9OKFNjcmlwdERpc2FsbG93ZWRTY29wZTo6SW5NYWluVGhyZWFkOjppc1Njcmlw dEFsbG93ZWQoKSB8fCAhaXNJbldlYlByb2Nlc3MoKSk7Ci0gICAgQVNTRVJUKGV2ZW50VHlwZSA9 PSBldmVudE5hbWVzKCkuZm9jdXNpbkV2ZW50IHx8IGV2ZW50VHlwZSA9PSBldmVudE5hbWVzKCku RE9NRm9jdXNJbkV2ZW50KTsKLSAgICBkaXNwYXRjaFNjb3BlZEV2ZW50KEZvY3VzRXZlbnQ6OmNy ZWF0ZShldmVudFR5cGUsIEV2ZW50OjpDYW5CdWJibGU6OlllcywgRXZlbnQ6OklzQ2FuY2VsYWJs ZTo6Tm8sIGRvY3VtZW50KCkud2luZG93UHJveHkoKSwgMCwgV1RGTW92ZShvbGRGb2N1c2VkRWxl bWVudCkpKTsKKyAgICBkaXNwYXRjaFNjb3BlZEV2ZW50KEZvY3VzRXZlbnQ6OmNyZWF0ZShldmVu dE5hbWVzKCkuZm9jdXNpbkV2ZW50LCBFdmVudDo6Q2FuQnViYmxlOjpZZXMsIEV2ZW50OjpJc0Nh bmNlbGFibGU6Ok5vLCBkb2N1bWVudCgpLndpbmRvd1Byb3h5KCksIDAsIFdURk1vdmUob2xkRm9j dXNlZEVsZW1lbnQpKSk7CiB9CiAKLXZvaWQgRWxlbWVudDo6ZGlzcGF0Y2hGb2N1c091dEV2ZW50 KGNvbnN0IEF0b21TdHJpbmcmIGV2ZW50VHlwZSwgUmVmUHRyPEVsZW1lbnQ+JiYgbmV3Rm9jdXNl ZEVsZW1lbnQpCit2b2lkIEVsZW1lbnQ6OmRpc3BhdGNoRm9jdXNPdXRFdmVudChSZWZQdHI8RWxl bWVudD4mJiBuZXdGb2N1c2VkRWxlbWVudCkKIHsKICAgICBSRUxFQVNFX0FTU0VSVF9XSVRIX1NF Q1VSSVRZX0lNUExJQ0FUSU9OKFNjcmlwdERpc2FsbG93ZWRTY29wZTo6SW5NYWluVGhyZWFkOjpp c1NjcmlwdEFsbG93ZWQoKSB8fCAhaXNJbldlYlByb2Nlc3MoKSk7Ci0gICAgQVNTRVJUKGV2ZW50 VHlwZSA9PSBldmVudE5hbWVzKCkuZm9jdXNvdXRFdmVudCB8fCBldmVudFR5cGUgPT0gZXZlbnRO YW1lcygpLkRPTUZvY3VzT3V0RXZlbnQpOwotICAgIGRpc3BhdGNoU2NvcGVkRXZlbnQoRm9jdXNF dmVudDo6Y3JlYXRlKGV2ZW50VHlwZSwgRXZlbnQ6OkNhbkJ1YmJsZTo6WWVzLCBFdmVudDo6SXND YW5jZWxhYmxlOjpObywgZG9jdW1lbnQoKS53aW5kb3dQcm94eSgpLCAwLCBXVEZNb3ZlKG5ld0Zv Y3VzZWRFbGVtZW50KSkpOworICAgIGRpc3BhdGNoU2NvcGVkRXZlbnQoRm9jdXNFdmVudDo6Y3Jl YXRlKGV2ZW50TmFtZXMoKS5mb2N1c291dEV2ZW50LCBFdmVudDo6Q2FuQnViYmxlOjpZZXMsIEV2 ZW50OjpJc0NhbmNlbGFibGU6Ok5vLCBkb2N1bWVudCgpLndpbmRvd1Byb3h5KCksIDAsIFdURk1v dmUobmV3Rm9jdXNlZEVsZW1lbnQpKSk7CiB9CiAKIHZvaWQgRWxlbWVudDo6ZGlzcGF0Y2hGb2N1 c0V2ZW50KFJlZlB0cjxFbGVtZW50PiYmIG9sZEZvY3VzZWRFbGVtZW50LCBGb2N1c0RpcmVjdGlv bikKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaAkocmV2aXNpb24gMjg3Nzc2KQorKysgU291cmNlL1dl YkNvcmUvZG9tL0VsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNTY5LDggKzU2OSwxMCBAQCBw dWJsaWM6CiAgICAgYm9vbCBkaXNwYXRjaFdoZWVsRXZlbnQoY29uc3QgUGxhdGZvcm1XaGVlbEV2 ZW50JiwgT3B0aW9uU2V0PEV2ZW50SGFuZGxpbmc+JiwgRXZlbnRJc0NhbmNlbGFibGUgPSBFdmVu dElzQ2FuY2VsYWJsZTo6WWVzKTsKICAgICBib29sIGRpc3BhdGNoS2V5RXZlbnQoY29uc3QgUGxh dGZvcm1LZXlib2FyZEV2ZW50Jik7CiAgICAgYm9vbCBkaXNwYXRjaFNpbXVsYXRlZENsaWNrKEV2 ZW50KiB1bmRlcmx5aW5nRXZlbnQsIFNpbXVsYXRlZENsaWNrTW91c2VFdmVudE9wdGlvbnMgPSBT ZW5kTm9FdmVudHMsIFNpbXVsYXRlZENsaWNrVmlzdWFsT3B0aW9ucyA9IFNob3dQcmVzc2VkTG9v ayk7Ci0gICAgdm9pZCBkaXNwYXRjaEZvY3VzSW5FdmVudChjb25zdCBBdG9tU3RyaW5nJiBldmVu dFR5cGUsIFJlZlB0cjxFbGVtZW50PiYmIG9sZEZvY3VzZWRFbGVtZW50KTsKLSAgICB2b2lkIGRp c3BhdGNoRm9jdXNPdXRFdmVudChjb25zdCBBdG9tU3RyaW5nJiBldmVudFR5cGUsIFJlZlB0cjxF bGVtZW50PiYmIG5ld0ZvY3VzZWRFbGVtZW50KTsKKworICAgIC8vIEZJWE1FOiBDb25zaWRlciBj aGFuZ2luZyBzaWduYXR1cmUgdG8gYWNjZXB0IEVsZW1lbnQqIGJlY2F1c2UgYWxsIGNhbGxlcnMg cGVyZm9ybSBjb3B5UmVmKCkuCisgICAgdm9pZCBkaXNwYXRjaEZvY3VzSW5FdmVudChSZWZQdHI8 RWxlbWVudD4mJiBvbGRGb2N1c2VkRWxlbWVudCk7CisgICAgdm9pZCBkaXNwYXRjaEZvY3VzT3V0 RXZlbnQoUmVmUHRyPEVsZW1lbnQ+JiYgbmV3Rm9jdXNlZEVsZW1lbnQpOwogICAgIHZpcnR1YWwg dm9pZCBkaXNwYXRjaEZvY3VzRXZlbnQoUmVmUHRyPEVsZW1lbnQ+JiYgb2xkRm9jdXNlZEVsZW1l bnQsIEZvY3VzRGlyZWN0aW9uKTsKICAgICB2aXJ0dWFsIHZvaWQgZGlzcGF0Y2hCbHVyRXZlbnQo UmVmUHRyPEVsZW1lbnQ+JiYgbmV3Rm9jdXNlZEVsZW1lbnQpOwogICAgIHZvaWQgZGlzcGF0Y2hX ZWJLaXRJbWFnZVJlYWR5RXZlbnRGb3JUZXN0aW5nKCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9k b20vRXZlbnROYW1lcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9FdmVudE5h bWVzLmgJKHJldmlzaW9uIDI4Nzc3NikKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9FdmVudE5hbWVz LmgJKHdvcmtpbmcgY29weSkKQEAgLTQ0LDggKzQ0LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog ICAgIG1hY3JvKERPTUFjdGl2YXRlKSBcCiAgICAgbWFjcm8oRE9NQ2hhcmFjdGVyRGF0YU1vZGlm aWVkKSBcCiAgICAgbWFjcm8oRE9NQ29udGVudExvYWRlZCkgXAotICAgIG1hY3JvKERPTUZvY3Vz SW4pIFwKLSAgICBtYWNybyhET01Gb2N1c091dCkgXAogICAgIG1hY3JvKERPTU5vZGVJbnNlcnRl ZCkgXAogICAgIG1hY3JvKERPTU5vZGVJbnNlcnRlZEludG9Eb2N1bWVudCkgXAogICAgIG1hY3Jv KERPTU5vZGVSZW1vdmVkKSBcCkluZGV4OiBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cJKHJldmlzaW9u IDI4Nzc3NikKKysrIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxMyBAQAorMjAyMi0wMS0wNyAgQWxleGV5IFNodmF5a2EgIDxhc2h2YXlr YUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIG9ic29sZXRlIERPTSBMZXZlbCAyICJET01G b2N1c0luIiAvICJET01Gb2N1c091dCIgZXZlbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQ5NzgKKworICAgICAgICBSZXZpZXdlZCBieSBHZW9m ZiBHYXJlbi4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL1NjcmlwdFRpbWVsaW5l UmVjb3JkLmpzOgorICAgICAgICAoV0kuU2NyaXB0VGltZWxpbmVSZWNvcmQuRXZlbnRUeXBlLmRp c3BsYXlOYW1lKToKKwogMjAyMi0wMS0wNyAgUGF0cmljayBBbmdsZSAgPHBhbmdsZUBhcHBsZS5j b20+CiAKICAgICAgICAgVW5jYXVnaHQgRXhjZXB0aW9uOiBDYW5ub3Qgc3RlcCBvdmVyIGJlY2F1 c2UgZGVidWdnZXIgaXMgbm90IHBhdXNlZApJbmRleDogU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvTW9kZWxzL1NjcmlwdFRpbWVsaW5lUmVjb3JkLmpzCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHRUaW1lbGlu ZVJlY29yZC5qcwkocmV2aXNpb24gMjg3Nzc2KQorKysgU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvTW9kZWxzL1NjcmlwdFRpbWVsaW5lUmVjb3JkLmpzCSh3b3JraW5nIGNvcHkp CkBAIC0yMTIsOCArMjEyLDYgQEAgV0kuU2NyaXB0VGltZWxpbmVSZWNvcmQuRXZlbnRUeXBlLmRp c3BsYQogICAgICAgICBuYW1lTWFwLnNldCgiRE9NQWN0aXZhdGUiLCAiRE9NIEFjdGl2YXRlIik7 CiAgICAgICAgIG5hbWVNYXAuc2V0KCJET01DaGFyYWN0ZXJEYXRhTW9kaWZpZWQiLCAiRE9NIENo YXJhY3RlciBEYXRhIE1vZGlmaWVkIik7CiAgICAgICAgIG5hbWVNYXAuc2V0KCJET01Db250ZW50 TG9hZGVkIiwgIkRPTSBDb250ZW50IExvYWRlZCIpOwotICAgICAgICBuYW1lTWFwLnNldCgiRE9N Rm9jdXNJbiIsICJET00gRm9jdXMgSW4iKTsKLSAgICAgICAgbmFtZU1hcC5zZXQoIkRPTUZvY3Vz T3V0IiwgIkRPTSBGb2N1cyBPdXQiKTsKICAgICAgICAgbmFtZU1hcC5zZXQoIkRPTU5vZGVJbnNl cnRlZCIsICJET00gTm9kZSBJbnNlcnRlZCIpOwogICAgICAgICBuYW1lTWFwLnNldCgiRE9NTm9k ZUluc2VydGVkSW50b0RvY3VtZW50IiwgIkRPTSBOb2RlIEluc2VydGVkIEludG8gRG9jdW1lbnQi KTsKICAgICAgICAgbmFtZU1hcC5zZXQoIkRPTU5vZGVSZW1vdmVkIiwgIkRPTSBOb2RlIFJlbW92 ZWQiKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4Nzc3NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAxLTA3ICBBbGV4ZXkgU2h2 YXlrYSAgPGFzaHZheWthQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgb2Jzb2xldGUgRE9N IExldmVsIDIgIkRPTUZvY3VzSW4iIC8gIkRPTUZvY3VzT3V0IiBldmVudHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDk3OAorCisgICAgICAgIFJl dmlld2VkIGJ5IEdlb2ZmIEdhcmVuLgorCisgICAgICAgICogZWRpdGluZy9kZWxldGluZy9pbnNl cnQtaW4tb3JwaGFuZWQtc2VsZWN0aW9uLWNyYXNoLmh0bWw6CisgICAgICAgICogZmFzdC9ldmVu dHMvZm9jdXNpbm91dC1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9ldmVudHMvZm9jdXNp bm91dC5odG1sOgorICAgICAgICAqIGZhc3QvZXZlbnRzL3Njb3BlZC9lZGl0aW5nLWNvbW1hbmRz Lmh0bWw6CisgICAgICAgICogZmFzdC9mb3Jtcy90ZXh0YXJlYS90ZXh0YXJlYS1hdXRvZm9jdXMt cmVtb3ZhbC13aGlsZS1mb2N1c2luZy13aXRoLXN0eWxlLmh0bWw6CisgICAgICAgICogZmFzdC9m b3Jtcy90ZXh0YXJlYS90ZXh0YXJlYS1hdXRvZm9jdXMtcmVtb3ZhbC13aGlsZS1mb2N1c2luZy5o dG1sOgorCiAyMDIyLTAxLTA3ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAog ICAgICAgICBFeHBvc2UgcnZmYyBwcm9jZXNzaW5nRHVyYXRpb24gZm9yIHRoZSBXZWJSVEMgY29k ZSBwYXRoCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL2RlbGV0aW5nL2luc2VydC1pbi1vcnBo YW5lZC1zZWxlY3Rpb24tY3Jhc2guaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0 aW5nL2RlbGV0aW5nL2luc2VydC1pbi1vcnBoYW5lZC1zZWxlY3Rpb24tY3Jhc2guaHRtbAkocmV2 aXNpb24gMjg3Nzc2KQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9kZWxldGluZy9pbnNlcnQtaW4t b3JwaGFuZWQtc2VsZWN0aW9uLWNyYXNoLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTgsNyArOCw3 IEBAIGRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoIkRPTU5vZGVSZW1vdmUKICAgICBkb2N1bWVu dC5kZXNpZ25Nb2RlID0gZG9jdW1lbnQuZGVzaWduTW9kZSA9PSAib24iID8gIm9mZiIgOiAib24i OwogICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJTZWxlY3RBbGwiKTsKIH0pOwotZG9jdW1lbnQu YWRkRXZlbnRMaXN0ZW5lcigiRE9NRm9jdXNJbiIsICBmdW5jdGlvbiAoKSB7Citkb2N1bWVudC5h ZGRFdmVudExpc3RlbmVyKCJmb2N1c2luIiwgIGZ1bmN0aW9uICgpIHsKICAgICBkb2N1bWVudC5l eGVjQ29tbWFuZCgnSW5zZXJ0VGV4dCcpOwogICAgIGNvbnNvbGUubG9nKCJUaGUgdGVzdCBQQVNT IGlmIGl0IGRvZXMgbm90IENSQVNILiIpOwogfSk7CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2V2 ZW50cy9mb2N1c2lub3V0LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9m YXN0L2V2ZW50cy9mb2N1c2lub3V0LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMjg3Nzc2KQorKysg TGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvZm9jdXNpbm91dC1leHBlY3RlZC50eHQJKHdvcmtpbmcg Y29weSkKQEAgLTMsNSArMywzIEBAIFBBU1MKIFBBU1MKIFBBU1MKIFBBU1MKLVBBU1MKLVBBU1MK SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2ZvY3VzaW5vdXQuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9mb2N1c2lub3V0Lmh0bWwJKHJldmlzaW9uIDI4 Nzc3NikKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2ZvY3VzaW5vdXQuaHRtbAkod29ya2lu ZyBjb3B5KQpAQCAtMjksMjIgKzI5LDYgQEAgZnVuY3Rpb24gYmx1ckhhbmRsZXIoZXZlbnQpCiAg ICAgZWxzZQogICAgICAgICB3cml0ZUZhaWxlZCgncmVzdWx0MicsICJXcm9uZyBldmVudCB0eXBl Iik7CiB9Ci0KLWZ1bmN0aW9uIGZvY3VzSGFuZGxlclR3byhldmVudCkKLXsKLSAgICBpZiAoZXZl bnQudHlwZSA9PSAiRE9NRm9jdXNJbiIpCi0gICAgICAgIHdyaXRlUGFzcygncmVzdWx0MycpOwot ICAgIGVsc2UKLSAgICAgICAgd3JpdGVGYWlsZWQoJ3Jlc3VsdDMnLCAiV3JvbmcgZXZlbnQgdHlw ZSIpOwotfQotCi1mdW5jdGlvbiBibHVySGFuZGxlclR3byhldmVudCkKLXsKLSAgICBpZiAoZXZl bnQudHlwZSA9PSAiRE9NRm9jdXNPdXQiKQotICAgICAgICB3cml0ZVBhc3MoJ3Jlc3VsdDQnKTsK LSAgICBlbHNlCi0gICAgICAgIHdyaXRlRmFpbGVkKCdyZXN1bHQ0JywgIldyb25nIGV2ZW50IHR5 cGUiKTsKLX0KIDwvc2NyaXB0PgogPC9oZWFkPgogPGJvZHkgb25sb2FkPSJkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgnZmllbGQnKS5mb2N1cygpO2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdmaWVs ZCcpLmJsdXIoKSI+CkBAIC01NSwxNSArMzksMTEgQEAgZnVuY3Rpb24gYmx1ckhhbmRsZXJUd28o ZXZlbnQpCiAKIDxkaXYgaWQ9InJlc3VsdDEiPkZBSUw8L2Rpdj4KIDxkaXYgaWQ9InJlc3VsdDIi PkZBSUw8L2Rpdj4KLTxkaXYgaWQ9InJlc3VsdDMiPkZBSUw8L2Rpdj4KLTxkaXYgaWQ9InJlc3Vs dDQiPkZBSUw8L2Rpdj4KIDxkaXYgaWQ9InJlc3VsdDUiPkZBSUw8L2Rpdj4KIDxkaXYgaWQ9InJl c3VsdDYiPkZBSUw8L2Rpdj4KIAogPHNjcmlwdD4KIGRvY3VtZW50LmRvY3VtZW50RWxlbWVudC5h ZGRFdmVudExpc3RlbmVyKCJmb2N1c2luIiwgZm9jdXNIYW5kbGVyLCBmYWxzZSk7CiBkb2N1bWVu dC5kb2N1bWVudEVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiZm9jdXNvdXQiLCBibHVySGFuZGxl ciwgZmFsc2UpOwotZG9jdW1lbnQuZG9jdW1lbnRFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoIkRP TUZvY3VzSW4iLCBmb2N1c0hhbmRsZXJUd28sIGZhbHNlKTsKLWRvY3VtZW50LmRvY3VtZW50RWxl bWVudC5hZGRFdmVudExpc3RlbmVyKCJET01Gb2N1c091dCIsIGJsdXJIYW5kbGVyVHdvLCBmYWxz ZSk7CiA8L3NjcmlwdD4KIApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc2NvcGVkL2Vk aXRpbmctY29tbWFuZHMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50 cy9zY29wZWQvZWRpdGluZy1jb21tYW5kcy5odG1sCShyZXZpc2lvbiAyODc3NzYpCisrKyBMYXlv dXRUZXN0cy9mYXN0L2V2ZW50cy9zY29wZWQvZWRpdGluZy1jb21tYW5kcy5odG1sCSh3b3JraW5n IGNvcHkpCkBAIC01Myw4ICs1Myw2IEBAIHZhciBldmVudHMgPSB7CiAgICAgJ0RPTU5vZGVSZW1v dmVkJzogZmFsc2UsCiAgICAgJ0RPTU5vZGVSZW1vdmVkRnJvbURvY3VtZW50JzogZmFsc2UsCiAg ICAgJ0RPTU5vZGVJbnNlcnRlZEludG9Eb2N1bWVudCc6IHRydWUsIC8vIHRoaXMgZXZlbnQgY2Fu IG5ldmVyIGJlIG9ic2VydmVkLgotICAgICdET01Gb2N1c0luJzogZmFsc2UsCi0gICAgJ0RPTUZv Y3VzT3V0JzogZmFsc2UsCiAgICAgJ2ZvY3VzaW4nOiBmYWxzZSwKICAgICAnZm9jdXNvdXQnOiBm YWxzZSwKIH07CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RleHRhcmVhL3RleHRhcmVh LWF1dG9mb2N1cy1yZW1vdmFsLXdoaWxlLWZvY3VzaW5nLXdpdGgtc3R5bGUuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RleHRhcmVhL3RleHRhcmVhLWF1dG9mb2N1 cy1yZW1vdmFsLXdoaWxlLWZvY3VzaW5nLXdpdGgtc3R5bGUuaHRtbAkocmV2aXNpb24gMjg3Nzc2 KQorKysgTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90ZXh0YXJlYS90ZXh0YXJlYS1hdXRvZm9jdXMt cmVtb3ZhbC13aGlsZS1mb2N1c2luZy13aXRoLXN0eWxlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAg LTksNyArOSw3IEBAIHZhciBkb2NFbGVtZW50ID0gZG9jdW1lbnQuZG9jdW1lbnRFbGVtZW4KIHRl eHRBcmVhID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgidGV4dGFyZWEiKTsKIHRleHRBcmVhLnNl dEF0dHJpYnV0ZSgiYXV0b2ZvY3VzIiwgIiIpOwogdGV4dEFyZWEuYXBwZW5kQ2hpbGQoZG9jdW1l bnQuaGVhZCk7Ci10ZXh0QXJlYS5hZGRFdmVudExpc3RlbmVyKCJET01Gb2N1c0luIiwgZnVuY3Rp b24gKCkgeyBkb2NFbGVtZW50LmlubmVySFRNTCA9ICIiOyB9LCBmYWxzZSk7Cit0ZXh0QXJlYS5h ZGRFdmVudExpc3RlbmVyKCJmb2N1c2luIiwgZnVuY3Rpb24gKCkgeyBkb2NFbGVtZW50LmlubmVy SFRNTCA9ICIiOyB9LCBmYWxzZSk7CiBkb2NFbGVtZW50LmFwcGVuZENoaWxkKHRleHRBcmVhKTsK IGRvY3VtZW50LmltcGxlbWVudGF0aW9uLmNyZWF0ZURvY3VtZW50KCJodHRwOi8vd3d3LnczLm9y Zy8xOTk5L3hodG1sIiwgImh0bWwiLCBudWxsKS5hZG9wdE5vZGUodGV4dEFyZWEpOwogd2luZG93 LnNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Rl eHRhcmVhL3RleHRhcmVhLWF1dG9mb2N1cy1yZW1vdmFsLXdoaWxlLWZvY3VzaW5nLmh0bWwKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90ZXh0YXJlYS90ZXh0YXJlYS1hdXRv Zm9jdXMtcmVtb3ZhbC13aGlsZS1mb2N1c2luZy5odG1sCShyZXZpc2lvbiAyODc3NzYpCisrKyBM YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RleHRhcmVhL3RleHRhcmVhLWF1dG9mb2N1cy1yZW1vdmFs LXdoaWxlLWZvY3VzaW5nLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTgsNyArOCw3IEBAIGlmICh3 aW5kb3cudGVzdFJ1bm5lcikgewogfQogY29uc3QgdGV4dGFyZWEgPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCJ0ZXh0YXJlYSIpOwogdGV4dGFyZWEuc2V0QXR0cmlidXRlKCJhdXRvZm9jdXMiLCAi Iik7Ci10ZXh0YXJlYS5hZGRFdmVudExpc3RlbmVyKCJET01Gb2N1c0luIiwgZnVuY3Rpb24gKCkg eyBkb2N1bWVudC5kb2N1bWVudEVsZW1lbnQuaW5uZXJIVE1MID0gIiI7IH0sIGZhbHNlKTsKK3Rl eHRhcmVhLmFkZEV2ZW50TGlzdGVuZXIoImZvY3VzaW4iLCBmdW5jdGlvbiAoKSB7IGRvY3VtZW50 LmRvY3VtZW50RWxlbWVudC5pbm5lckhUTUwgPSAiIjsgfSwgZmFsc2UpOwogZG9jdW1lbnQuZG9j dW1lbnRFbGVtZW50LmFwcGVuZENoaWxkKHRleHRhcmVhKTsKIHJlcXVlc3RBbmltYXRpb25GcmFt ZSgoKSA9PiB7CiAgICAgZG9jdW1lbnQuYm9keS5pbm5lckhUTUwgPSAiUEFTUyB1bmxlc3MgY3Jh c2guIjsK