234976 2022-01-07 11:57:56 -0800 webkitRequestFullscreen fulfils but will not go into fullscreen with click handler that creates MediaStream and plays video 2022-01-10 09:48:31 -0800 1 1 1 Unclassified WebKit Media Safari 15 Unspecified Unspecified NEW InRadar P2 Normal --- 1 will.morgan webkit-unassigned bfulgham jer.noble mark.burrett peng.liu6 simon.fraser webkit-bug-importer zalan oldest_to_newest 1829025 0 448616 will.morgan 2022-01-07 11:57:56 -0800 Created attachment 448616 fs.html testbed When I click a button that creates a MediaStream with getUserMedia, then plays a video that satisfies the autoplay criteria, then performs webkitRequestFullscreen (WRFS), the WRFS call return but no fullscreen resize event happens. For compatibility with other browsers, especially with regard to anti-abuse and user activation, the advice is to first getUserMedia, then play a video, then finally requestFullscreen. This is because requestFullscreen clears user activation flags, which means that you can't getUserMedia afterwards. This is the approach suggested here: https://github.com/whatwg/fullscreen/issues/152#issuecomment-494840412 My expected behaviour here would be for webkitRequestFullscreen to actually go into fullscreen, or at the very minimum if the WebKit team disagree with the WHATWG user activation approach, it should at least throw with a NotAllowedError. This has downstream implications - sindresorhus's screenfull library returns a promise that never fulfils because WRFS doesn't throw and no change events happen. This effectively deadlocks any application that relies on entering fullscreen unless an arbitrary timeout is used. I'm discussing the same issue with the team at Mozilla: https://bugzilla.mozilla.org/show_bug.cgi?id=957558 1829386 1 mark.burrett 2022-01-10 00:24:17 -0800 Is this issue common to macOS and iOS? And is it new in Safari 15? Are all minor versions affected? We would also appreciate feedback on whether the current behaviour is intended, and if so some guidance around avoiding the described deadlock. If not, is a fix already in the pipeline? 1829510 2 webkit-bug-importer 2022-01-10 09:48:31 -0800 <rdar://problem/87346180> 448616 2022-01-07 11:57:56 -0800 2022-01-07 11:57:56 -0800 fs.html testbed file_234976.txt text/plain 2341 will.morgan PCFET0NUWVBFIGh0bWw+DQo8aHRtbD4NCiAgPGhlYWQ+DQogICAgPHRpdGxlPkZ1bGxzY3JlZW4g KyBWaWRlbyBUZXN0PC90aXRsZT4NCiAgICA8c3R5bGU+DQogICAgICBib2R5IHsNCiAgICAgICAg Zm9udC1mYW1pbHk6IHNhbnMtc2VyaWY7DQogICAgICAgIGJhY2tncm91bmQ6IHdoaXRlOw0KICAg ICAgICBtaW4taGVpZ2h0OiAxMDB2aDsNCiAgICAgICAgbWluLXdpZHRoOiAxMDB2dzsNCiAgICAg ICAgcGFkZGluZzogNXJlbTsNCiAgICAgIH0NCiAgICAgIGJ1dHRvbiB7DQogICAgICAgIHBhZGRp bmc6IDFyZW07DQogICAgICB9DQogICAgICBmaWVsZHNldCB7DQogICAgICAgIG1hcmdpbjogMXJl bSAwOw0KICAgICAgICBiYWNrZ3JvdW5kOiB3aGl0ZTsNCiAgICAgICAgY29sb3I6IGJsYWNrOw0K ICAgICAgfQ0KICAgICAgdmlkZW8gew0KICAgICAgICAgIGJvcmRlcjogMXB4IHNvbGlkIHJlZDsN CiAgICAgICAgICBtYXJnaW46IDFyZW0gMDsNCiAgICAgIH0NCiAgICA8L3N0eWxlPg0KICA8L2hl YWQ+DQogIDxib2R5Pg0KICAgIDxidXR0b24+UGxheSBWaWRlbyArIEdvIEZ1bGxzY3JlZW48L2J1 dHRvbj4NCiAgICA8ZmllbGRzZXQ+DQogICAgICA8bGVnZW5kPkxvZyAobmV3ZXN0IGZpcnN0KTwv bGVnZW5kPg0KICAgICAgPHRleHRhcmVhIHJvd3M9IjIwIiBjb2xzPSIxNDAiPjwvdGV4dGFyZWE+ DQogICAgPC9maWVsZHNldD4NCiAgICA8dmlkZW8gaWQ9IndlYmNhbSIgd2lkdGg9IjY0MCIgaGVp Z2h0PSI0ODAiIG11dGVkIHBsYXlzaW5saW5lIGF1dG9wbGF5PjwvdmlkZW8+DQogICAgPHNjcmlw dD4NCiAgICAgIGNvbnN0IGxvZyA9IChtc2cpID0+IHsNCiAgICAgICAgY29uc3QgdGEgPSBkb2N1 bWVudC5xdWVyeVNlbGVjdG9yKCJ0ZXh0YXJlYSIpDQogICAgICAgIHRhLmlubmVySFRNTCA9IG1z ZyArICJcbiIgKyB0YS5pbm5lckhUTUwNCiAgICAgICAgY29uc29sZS5sb2cobXNnKQ0KICAgICAg fQ0KICAgICAgY29uc3QgaXNGcyA9ICgpID0+ICEhZG9jdW1lbnQuZnVsbHNjcmVlbkVsZW1lbnQg fHwgISFkb2N1bWVudC53ZWJraXRGdWxsc2NyZWVuRWxlbWVudA0KICAgICAgY29uc3QgcmVxdWVz dEZ1bGxzY3JlZW4gPSBhc3luYyAoKSA9PiB7DQogICAgICAgIGlmIChkb2N1bWVudC5ib2R5LnJl cXVlc3RGdWxsc2NyZWVuKSB7DQogICAgICAgICAgYXdhaXQgZG9jdW1lbnQuYm9keS5yZXF1ZXN0 RnVsbHNjcmVlbigpDQogICAgICAgICAgbG9nKCJyZXF1ZXN0RnVsbHNjcmVlbiBjb21wbGV0ZWQs IGFyZSB3ZSBmdWxsc2NyZWVuPyAiICsgaXNGcygpKQ0KICAgICAgICB9IGVsc2UgaWYgKGRvY3Vt ZW50LmJvZHkud2Via2l0UmVxdWVzdEZ1bGxzY3JlZW4pIHsNCiAgICAgICAgICBhd2FpdCBkb2N1 bWVudC5ib2R5LndlYmtpdFJlcXVlc3RGdWxsc2NyZWVuKCkNCiAgICAgICAgICBsb2coIndlYmtp dFJlcXVlc3RGdWxsc2NyZWVuIGNvbXBsZXRlZCwgYXJlIHdlIGZ1bGxzY3JlZW4/ICIgKyBpc0Zz KCkpDQogICAgICAgIH0gZWxzZSB7DQogICAgICAgICAgbG9nKCJUaGlzIGJyb3dzZXIgZG9lc24n dCBzZWVtIGZ1bGxzY3JlZW4gY2FwYWJsZSIpDQogICAgICAgIH0NCiAgICAgIH0NCiAgICAgIHdp bmRvdy5hZGRFdmVudExpc3RlbmVyKCJyZXNpemUiLCAoKSA9PiB7DQogICAgICAgIHNldFRpbWVv dXQoKCkgPT4gbG9nKCJXaW5kb3cgcmVzaXplZCwgZnVsbHNjcmVlbiBpcyAiICsgaXNGcygpKSwg MjApDQogICAgICB9KQ0KICAgICAgO1siZnVsbHNjcmVlbmNoYW5nZSIsICJvbndlYmtpdGZ1bGxz Y3JlZW5jaGFuZ2UiXS5mb3JFYWNoKChldikgPT4gew0KICAgICAgICBkb2N1bWVudC5ib2R5LmFk ZEV2ZW50TGlzdGVuZXIoZXYsICgpID0+IHsNCiAgICAgICAgICBsb2coZXYgKyAiIGZpcmVkLCBm dWxsc2NyZWVuIGlzOiAiICsgaXNGcygpKQ0KICAgICAgICB9KQ0KICAgICAgfSkNCiAgICAgIGRv Y3VtZW50LnF1ZXJ5U2VsZWN0b3IoImJ1dHRvbiIpLmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwg YXN5bmMgKCkgPT4gew0KICAgICAgICBjb25zdCBtZWRpYVN0cmVhbSA9IGF3YWl0IG5hdmlnYXRv ci5tZWRpYURldmljZXMuZ2V0VXNlck1lZGlhKHsgdmlkZW86IHRydWUgfSkNCiAgICAgICAgY29u c3QgdmlkZW8gPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgid2ViY2FtIikNCiAgICAgICAgdmlk ZW8uc3JjT2JqZWN0ID0gbWVkaWFTdHJlYW0NCiAgICAgICAgYXdhaXQgdmlkZW8ucGxheSgpDQog ICAgICAgIGF3YWl0IHJlcXVlc3RGdWxsc2NyZWVuKCkNCiAgICAgICAgbG9nKCJDbGljayBoYW5k bGVyIGNvbXBsZXRlIikNCiAgICAgIH0pDQogICAgPC9zY3JpcHQ+DQogIDwvYm9keT4NCjwvaHRt bD4NCg==