234975 2022-01-07 11:55:59 -0800 WebKit::DownloadProxy::publishProgress() falls through ASSERT_NOT_REACHED() 2022-01-20 21:00:06 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 228875 234932 1 ddkilzer cdumez achristensen cdumez darin kkinnunen webkit-bug-importer oldest_to_newest 1829021 0 ddkilzer 2022-01-07 11:55:59 -0800 WebKit::DownloadProxy::publishProgress() falls through ASSERT_NOT_REACHED(). There should be an early return in the `else` block after ASSERT_NOT_REACHED(). #if PLATFORM(COCOA) void DownloadProxy::publishProgress(const URL& URL) { if (!m_dataStore) return; SandboxExtension::Handle handle; if (auto createdHandle = SandboxExtension::createHandle(URL.fileSystemPath(), SandboxExtension::Type::ReadWrite)) handle = WTFMove(*createdHandle); else ASSERT_NOT_REACHED(); m_dataStore->networkProcess().send(Messages::NetworkProcess::PublishDownloadProgress(m_downloadID, URL, handle), 0); } #endif // PLATFORM(COCOA) See Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp. 1829022 1 webkit-bug-importer 2022-01-07 11:56:18 -0800 <rdar://problem/87265153> 1832063 2 449491 cdumez 2022-01-19 10:00:44 -0800 Created attachment 449491 Patch 1832179 3 ews-feeder 2022-01-19 12:39:51 -0800 Committed r288232 (246189@main): <https://commits.webkit.org/246189@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449491. 449491 2022-01-19 10:00:44 -0800 2022-01-19 12:39:53 -0800 Patch bug-234975-20220119100043.patch text/plain 2078 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4MjAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFhNDYyY2IyYzgxMTVlMzJj NjFiOGUwNjY2Zjc3ODg1ZTQyZDczYzMuLjIwMTQxYTk0NWI3NWM5YzQ3YTAzNWExOTBlZjhjNjRh MTkzMTQxYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjItMDEtMTkgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBXZWJLaXQ6OkRvd25sb2FkUHJveHk6 OnB1Ymxpc2hQcm9ncmVzcygpIGZhbGxzIHRocm91Z2ggQVNTRVJUX05PVF9SRUFDSEVEKCkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDk3NQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vODcyNjUxNTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkUHJv eHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpEb3dubG9hZFByb3h5OjpwdWJsaXNoUHJvZ3Jlc3Mp OgorICAgICAgICBMZXQncyBub3Qgc2VuZCB0aGUgSVBDIGlmIHdlIGZhaWxlZCB0byBjcmVhdGUg dGhlIGhhbmRsZSBzaW5jZSB0aGUgcmVjaXBpZW50IGNvZGUgZWFybHkgcmV0dXJucyB3aGVuIHRo ZSBoYW5kbGUgaXMKKyAgICAgICAgaW52YWxpZC4KKwogMjAyMi0wMS0xOSAgQ2hyaXMgRHVtZXog IDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYnNpdGVEYXRhU3RvcmUuY3BwIHVzZXMg c3dpdGNoIHN0YXRlbWVudHMgZm9yIFdlYktpdDo6UHJvY2Vzc0FjY2Vzc1R5cGUgZW51bSB0aGF0 IGZhbGwgdGhyb3VnaCBBU1NFUlRfTk9UX1JFQUNIRUQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkUHJveHkuY3BwIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkUHJveHkuY3BwCmluZGV4IGU5OTBiMWQwYzQ0 NWNhN2IzNDI0YTUzZDM3YTg4ZTRiNjViZTk2ZGIuLjdmNTg2ODU3N2ZkNWJiMjUxYmQ5ZWIyNWYy ZWRlYWEyMjVlZTA4NDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0Rvd25s b2Fkcy9Eb3dubG9hZFByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Eb3du bG9hZHMvRG93bmxvYWRQcm94eS5jcHAKQEAgLTEwNiwxMyArMTA2LDEyIEBAIHZvaWQgRG93bmxv YWRQcm94eTo6cHVibGlzaFByb2dyZXNzKGNvbnN0IFVSTCYgVVJMKQogICAgIGlmICghbV9kYXRh U3RvcmUpCiAgICAgICAgIHJldHVybjsKIAotICAgIFNhbmRib3hFeHRlbnNpb246OkhhbmRsZSBo YW5kbGU7Ci0gICAgaWYgKGF1dG8gY3JlYXRlZEhhbmRsZSA9IFNhbmRib3hFeHRlbnNpb246OmNy ZWF0ZUhhbmRsZShVUkwuZmlsZVN5c3RlbVBhdGgoKSwgU2FuZGJveEV4dGVuc2lvbjo6VHlwZTo6 UmVhZFdyaXRlKSkKLSAgICAgICAgaGFuZGxlID0gV1RGTW92ZSgqY3JlYXRlZEhhbmRsZSk7Ci0g ICAgZWxzZQotICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICBhdXRvIGhhbmRsZSA9 IFNhbmRib3hFeHRlbnNpb246OmNyZWF0ZUhhbmRsZShVUkwuZmlsZVN5c3RlbVBhdGgoKSwgU2Fu ZGJveEV4dGVuc2lvbjo6VHlwZTo6UmVhZFdyaXRlKTsKKyAgICBBU1NFUlQoaGFuZGxlKTsKKyAg ICBpZiAoIWhhbmRsZSkKKyAgICAgICAgcmV0dXJuOwogCi0gICAgbV9kYXRhU3RvcmUtPm5ldHdv cmtQcm9jZXNzKCkuc2VuZChNZXNzYWdlczo6TmV0d29ya1Byb2Nlc3M6OlB1Ymxpc2hEb3dubG9h ZFByb2dyZXNzKG1fZG93bmxvYWRJRCwgVVJMLCBoYW5kbGUpLCAwKTsKKyAgICBtX2RhdGFTdG9y ZS0+bmV0d29ya1Byb2Nlc3MoKS5zZW5kKE1lc3NhZ2VzOjpOZXR3b3JrUHJvY2Vzczo6UHVibGlz aERvd25sb2FkUHJvZ3Jlc3MobV9kb3dubG9hZElELCBVUkwsICpoYW5kbGUpLCAwKTsKIH0KICNl bmRpZiAvLyBQTEFURk9STShDT0NPQSkKIAo=