234974 2022-01-07 11:52:34 -0800 A/B comparison tests fail trying to look up fuzzy match tolerance 2022-01-07 15:21:24 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton akeerthi dino ews-watchlist glenn jbedard simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1829018 0 thorton 2022-01-07 11:52:34 -0800 A/B comparison tests fail trying to look up fuzzy match tolerance 1829019 1 448615 thorton 2022-01-07 11:53:22 -0800 Created attachment 448615 Patch 1829080 2 448615 akeerthi 2022-01-07 14:38:25 -0800 Comment on attachment 448615 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448615&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:416 > + fuzzy_tolerance = None > + if allow_fuzzy_tolerance: > + fuzzy_tolerance = self._fuzzy_tolerance_for_reference(reference_filename) Not sure what our Python style guide says, but ternary might be nice: `fuzzy_tolerance = self._fuzzy_tolerance_for_reference(reference_filename) if allow_fuzzy_tolerance else None`. 1829086 3 thorton 2022-01-07 14:45:40 -0800 Not sure about our Python style guide either, but personally I'm not a big fan of the out-of-order-shortcutting in the trailing style ternary operator. 1829108 4 ews-feeder 2022-01-07 15:20:41 -0800 Committed r287790 (245850@main): <https://commits.webkit.org/245850@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448615. 1829110 5 webkit-bug-importer 2022-01-07 15:21:24 -0800 <rdar://problem/87275180> 448615 2022-01-07 11:53:22 -0800 2022-01-07 15:20:43 -0800 Patch bug-234974-20220107115321.patch text/plain 4422 thorton SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI4Nzc3MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDIyLTAxLTA3ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUu Y29tPgorCisgICAgICAgIEEvQiBjb21wYXJpc29uIHRlc3RzIGZhaWwgdHJ5aW5nIHRvIGxvb2sg dXAgZnV6enkgbWF0Y2ggdG9sZXJhbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMzQ5NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xs ZXJzL3NpbmdsZV90ZXN0X3J1bm5lci5weToKKyAgICAgICAgKFNpbmdsZVRlc3RSdW5uZXIuX3J1 bl9zZWxmX2NvbXBhcmlzb25fdGVzdCk6CisgICAgICAgIChTaW5nbGVUZXN0UnVubmVyLl9jb21w YXJlX291dHB1dF93aXRoX3JlZmVyZW5jZSk6CisgICAgICAgIERpc2FibGUgZnV6enkgbWF0Y2hp bmcgZm9yIEEvQiB0ZXN0cywgYmVjYXVzZSBBKSB3ZSBkb24ndCByZWFsbHkgd2FudCBpdAorICAg ICAgICBhbmQgQikgaXQgY3Jhc2hlcyBydW4td2Via2l0LXRlc3RzIGJlY2F1c2UgdGhlcmUgaXMg bm8gYWN0dWFsIHJlZmVyZW5jZSBmaWxlCisgICAgICAgIGluIHdoaWNoIHRvIGZpbmQgdGhlIHRv bGVyYW5jZSB2YWx1ZS4KKwogMjAyMi0wMS0wNyAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3Rl bnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjg3Njk4 LgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMv c2luZ2xlX3Rlc3RfcnVubmVyLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL3NpbmdsZV90ZXN0X3J1bm5lci5weQkocmV2aXNp b24gMjg3NzcwKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJv bGxlcnMvc2luZ2xlX3Rlc3RfcnVubmVyLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zNDksNyArMzQ5 LDcgQEAgY2xhc3MgU2luZ2xlVGVzdFJ1bm5lcihvYmplY3QpOgogICAgICAgICB0ZXN0X291dHB1 dCA9IHNlbGYuX2RyaXZlci5ydW5fdGVzdChkcml2ZXJfaW5wdXQsIHNlbGYuX3N0b3Bfd2hlbl9k b25lKQogCiAgICAgICAgIHRlc3RfZnVsbF9wYXRoID0gc2VsZi5fcG9ydC5hYnNwYXRoX2Zvcl90 ZXN0KHNlbGYuX3Rlc3RfbmFtZSkKLSAgICAgICAgdGVzdF9yZXN1bHQgPSBzZWxmLl9jb21wYXJl X291dHB1dF93aXRoX3JlZmVyZW5jZShyZWZlcmVuY2Vfb3V0cHV0LCB0ZXN0X291dHB1dCwgdGVz dF9mdWxsX3BhdGgsIEZhbHNlKQorICAgICAgICB0ZXN0X3Jlc3VsdCA9IHNlbGYuX2NvbXBhcmVf b3V0cHV0X3dpdGhfcmVmZXJlbmNlKHJlZmVyZW5jZV9vdXRwdXQsIHRlc3Rfb3V0cHV0LCB0ZXN0 X2Z1bGxfcGF0aCwgRmFsc2UsIGFsbG93X2Z1enp5X3RvbGVyYW5jZT1GYWxzZSkKIAogICAgICAg ICBhc3NlcnQocmVmZXJlbmNlX291dHB1dCkKICAgICAgICAgdGVzdF9yZXN1bHRfd3JpdGVyLndy aXRlX3Rlc3RfcmVzdWx0KHNlbGYuX2ZpbGVzeXN0ZW0sIHNlbGYuX3BvcnQsIHNlbGYuX3Jlc3Vs dHNfZGlyZWN0b3J5LCBzZWxmLl90ZXN0X25hbWUsIHRlc3Rfb3V0cHV0LCByZWZlcmVuY2Vfb3V0 cHV0LCB0ZXN0X3Jlc3VsdC5mYWlsdXJlcykKQEAgLTM5NSw3ICszOTUsNyBAQCBjbGFzcyBTaW5n bGVUZXN0UnVubmVyKG9iamVjdCk6CiAgICAgICAgICMgaHR0cHM6Ly93ZWItcGxhdGZvcm0tdGVz dHMub3JnL3dyaXRpbmctdGVzdHMvcmVmdGVzdHMuaHRtbCBzYXlzICJpbiB0aGUgcmFuZ2UiIGJ1 dCBpc24ndCBwcmVjaXNlIGFib3V0IHdoZXRoZXIgdGhlIHVwcGVyIGJvdW5kIGlzIGluY2x1ZGVk LgogICAgICAgICByZXR1cm4gYWN0dWFsTWF4RGlmZmVyZW5jZSA+PSBtYXhEaWZmZXJlbmNlTWlu IGFuZCBhY3R1YWxNYXhEaWZmZXJlbmNlIDw9IG1heERpZmZlcmVuY2VNYXggYW5kIGFjdHVhbFRv dGFsUGl4ZWxzID49IHRvdGFsUGl4ZWxzTWluIGFuZCBhY3R1YWxUb3RhbFBpeGVscyA8PSB0b3Rh bFBpeGVsc01heAogCi0gICAgZGVmIF9jb21wYXJlX291dHB1dF93aXRoX3JlZmVyZW5jZShzZWxm LCByZWZlcmVuY2VfZHJpdmVyX291dHB1dCwgYWN0dWFsX2RyaXZlcl9vdXRwdXQsIHJlZmVyZW5j ZV9maWxlbmFtZSwgbWlzbWF0Y2gpOgorICAgIGRlZiBfY29tcGFyZV9vdXRwdXRfd2l0aF9yZWZl cmVuY2Uoc2VsZiwgcmVmZXJlbmNlX2RyaXZlcl9vdXRwdXQsIGFjdHVhbF9kcml2ZXJfb3V0cHV0 LCByZWZlcmVuY2VfZmlsZW5hbWUsIG1pc21hdGNoLCBhbGxvd19mdXp6eV90b2xlcmFuY2U9VHJ1 ZSk6CiAgICAgICAgIHRvdGFsX3Rlc3RfdGltZSA9IHJlZmVyZW5jZV9kcml2ZXJfb3V0cHV0LnRl c3RfdGltZSArIGFjdHVhbF9kcml2ZXJfb3V0cHV0LnRlc3RfdGltZQogICAgICAgICBoYXNfc3Rk ZXJyID0gcmVmZXJlbmNlX2RyaXZlcl9vdXRwdXQuaGFzX3N0ZGVycigpIG9yIGFjdHVhbF9kcml2 ZXJfb3V0cHV0Lmhhc19zdGRlcnIoKQogICAgICAgICBmYWlsdXJlcyA9IFtdCkBAIC00MTEsNyAr NDExLDkgQEAgY2xhc3MgU2luZ2xlVGVzdFJ1bm5lcihvYmplY3QpOgogICAgICAgICBpZiBub3Qg cmVmZXJlbmNlX2RyaXZlcl9vdXRwdXQuaW1hZ2VfaGFzaCBhbmQgbm90IGFjdHVhbF9kcml2ZXJf b3V0cHV0LmltYWdlX2hhc2g6CiAgICAgICAgICAgICBmYWlsdXJlcy5hcHBlbmQodGVzdF9mYWls dXJlcy5GYWlsdXJlUmVmdGVzdE5vSW1hZ2VzR2VuZXJhdGVkKHJlZmVyZW5jZV9maWxlbmFtZSkp CiAgICAgICAgIGVsaWYgbWlzbWF0Y2g6Ci0gICAgICAgICAgICBmdXp6eV90b2xlcmFuY2UgPSBz ZWxmLl9mdXp6eV90b2xlcmFuY2VfZm9yX3JlZmVyZW5jZShyZWZlcmVuY2VfZmlsZW5hbWUpCisg ICAgICAgICAgICBmdXp6eV90b2xlcmFuY2UgPSBOb25lCisgICAgICAgICAgICBpZiBhbGxvd19m dXp6eV90b2xlcmFuY2U6CisgICAgICAgICAgICAgICAgZnV6enlfdG9sZXJhbmNlID0gc2VsZi5f ZnV6enlfdG9sZXJhbmNlX2Zvcl9yZWZlcmVuY2UocmVmZXJlbmNlX2ZpbGVuYW1lKQogICAgICAg ICAgICAgaWYgZnV6enlfdG9sZXJhbmNlOgogICAgICAgICAgICAgICAgIGRpZmZfcmVzdWx0ID0g c2VsZi5fcG9ydC5kaWZmX2ltYWdlKHJlZmVyZW5jZV9kcml2ZXJfb3V0cHV0LmltYWdlLCBhY3R1 YWxfZHJpdmVyX291dHB1dC5pbWFnZSwgdG9sZXJhbmNlPTApCiAgICAgICAgICAgICAgICAgbWF0 Y2hfd2l0aGluX3RvbGVyYW5jZSA9IHNlbGYuX3Rlc3RfcGFzc2VzX2Z1enp5X21hdGNoaW5nKGZ1 enp5X3RvbGVyYW5jZSwgZGlmZl9yZXN1bHQuZnV6enlfZGF0YSkKQEAgLTQyOCw3ICs0MzAsOSBA QCBjbGFzcyBTaW5nbGVUZXN0UnVubmVyKG9iamVjdCk6CiAgICAgICAgICAgICAjIEltYWdlRGlm ZiBoYXMgYSBoYXJkIGNvZGVkIGNvbG9yIGRpc3RhbmNlIHRocmVzaG9sZCBldmVuIHRob3VnaCB0 b2xlcmFuY2U9MCBpcyBzcGVjaWZpZWQuCiAgICAgICAgICAgICBkaWZmX3Jlc3VsdCA9IHNlbGYu X3BvcnQuZGlmZl9pbWFnZShyZWZlcmVuY2VfZHJpdmVyX291dHB1dC5pbWFnZSwgYWN0dWFsX2Ry aXZlcl9vdXRwdXQuaW1hZ2UsIHRvbGVyYW5jZT0wKQogCi0gICAgICAgICAgICBmdXp6eV90b2xl cmFuY2UgPSBzZWxmLl9mdXp6eV90b2xlcmFuY2VfZm9yX3JlZmVyZW5jZShyZWZlcmVuY2VfZmls ZW5hbWUpCisgICAgICAgICAgICBmdXp6eV90b2xlcmFuY2UgPSBOb25lCisgICAgICAgICAgICBp ZiBhbGxvd19mdXp6eV90b2xlcmFuY2U6CisgICAgICAgICAgICAgICAgZnV6enlfdG9sZXJhbmNl ID0gc2VsZi5fZnV6enlfdG9sZXJhbmNlX2Zvcl9yZWZlcmVuY2UocmVmZXJlbmNlX2ZpbGVuYW1l KQogICAgICAgICAgICAgaWYgZnV6enlfdG9sZXJhbmNlOgogICAgICAgICAgICAgICAgIGRpZmZf cmVzdWx0LnBhc3NlZCA9IHNlbGYuX3Rlc3RfcGFzc2VzX2Z1enp5X21hdGNoaW5nKGZ1enp5X3Rv bGVyYW5jZSwgZGlmZl9yZXN1bHQuZnV6enlfZGF0YSkKICAgICAgICAgICAgICAgICBfbG9nLmRl YnVnKCd7fSBhbGxvd2VkIGZ1enppbmVzcyB7fSwgYWN0dWFsIGRpZmZlcmVuY2Uge306IHBhc3Mg e30nLmZvcm1hdChzZWxmLl90ZXN0X25hbWUsIGZ1enp5X3RvbGVyYW5jZSwgZGlmZl9yZXN1bHQu ZnV6enlfZGF0YSwgZGlmZl9yZXN1bHQucGFzc2VkKSkK