234968 2022-01-07 10:41:02 -0800 REGRESSION(r286498): Web Inspector: Inspector^2 fails to load in release builds and crashes with an assertion in debug builds 2022-01-07 14:48:06 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 pangle pangle bburg ews-watchlist hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1828972 0 pangle 2022-01-07 10:41:02 -0800 Steps to reproduce: 1. Enable Inspector^2 2. Right click in inspector and choose Inspect Element. 3a. A debug build will crash here. 3b. A release build will show an inspector window with no title, and with no information in it (e.g. sources, elements, etc.) For debug builds, the assertion/crash is: ASSERTION FAILED: destinationID Source/WebKit/Platform/IPC/MessageReceiverMap.cpp(52) : void IPC::MessageReceiverMap::addMessageReceiver(IPC::ReceiverName, uint64_t, IPC::MessageReceiver &) 1 0x10f082cc9 WTFCrash 2 0x12abafddb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x12bff4ed6 IPC::MessageReceiverMap::addMessageReceiver(IPC::ReceiverName, unsigned long long, IPC::MessageReceiver&) 4 0x12c3ef358 WebKit::AuxiliaryProcessProxy::addMessageReceiver(IPC::ReceiverName, unsigned long long, IPC::MessageReceiver&) 5 0x12c8c29c7 void WebKit::AuxiliaryProcessProxy::addMessageReceiver<WebKit::WebPageProxyIdentifierType>(IPC::ReceiverName, WTF::ObjectIdentifier<WebKit::WebPageProxyIdentifierType>, IPC::MessageReceiver&) 6 0x12c8c148a WebKit::WebInspectorUIProxy::createFrontendPage() 7 0x12c8c2a79 WebKit::WebInspectorUIProxy::openLocalInspectorFrontend(bool, bool) 8 0x12d0d9f9e void IPC::callMemberFunctionImpl<WebKit::WebInspectorUIProxy, void (WebKit::WebInspectorUIProxy::*)(bool, bool), std::__1::tuple<bool, bool>, 0ul, 1ul>(WebKit::WebInspectorUIProxy*, void (WebKit::WebInspectorUIProxy::*)(bool, bool), std::__1::tuple<bool, bool>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) 9 0x12d0d9ecd void IPC::callMemberFunction<WebKit::WebInspectorUIProxy, void (WebKit::WebInspectorUIProxy::*)(bool, bool), std::__1::tuple<bool, bool>, std::__1::integer_sequence<unsigned long, 0ul, 1ul> >(std::__1::tuple<bool, bool>&&, WebKit::WebInspectorUIProxy*, void (WebKit::WebInspectorUIProxy::*)(bool, bool)) 10 0x12d0d87e9 void IPC::handleMessage<Messages::WebInspectorUIProxy::OpenLocalInspectorFrontend, WebKit::WebInspectorUIProxy, void (WebKit::WebInspectorUIProxy::*)(bool, bool)>(IPC::Connection&, IPC::Decoder&, WebKit::WebInspectorUIProxy*, void (WebKit::WebInspectorUIProxy::*)(bool, bool)) 11 0x12d0d7b32 WebKit::WebInspectorUIProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 12 0x12bff67a3 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 13 0x12c3ef3fc WebKit::AuxiliaryProcessProxy::dispatchMessage(IPC::Connection&, IPC::Decoder&) 14 0x12c68b8c9 WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 15 0x12bfb6b5e IPC::Connection::dispatchMessage(IPC::Decoder&) 16 0x12bfb72c5 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 17 0x12bfb5c3c IPC::Connection::dispatchIncomingMessages() 18 0x12bfd34ef IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14::operator()() 19 0x12bfd3419 WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14, void>::call() 20 0x10f0aca22 WTF::Function<void ()>::operator()() const 21 0x10f1305ae WTF::RunLoop::performWork() 22 0x10f133e7e WTF::RunLoop::performWork(void*) 23 0x7ff80284ff4b __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 24 0x7ff80284feb3 __CFRunLoopDoSource0 25 0x7ff80284fc2d __CFRunLoopDoSources0 26 0x7ff80284e648 __CFRunLoopRun 27 0x7ff80284dc0c CFRunLoopRunSpecific 28 0x7ff80b540906 RunCurrentEventLoopInMode 29 0x7ff80b54066a ReceiveNextEventCommon 30 0x7ff80b540405 _BlockUntilNextEventMatchingListInModeWithFilter 31 0x7ff8052609c5 _DPSNextEvent <rdar://86782432> 1828992 1 448610 pangle 2022-01-07 10:59:31 -0800 Created attachment 448610 Patch v1.0 1828993 2 448610 hi 2022-01-07 11:03:19 -0800 Comment on attachment 448610 Patch v1.0 r=me nice :) 1829093 3 ews-feeder 2022-01-07 14:48:02 -0800 Committed r287786 (245846@main): <https://commits.webkit.org/245846@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448610. 448610 2022-01-07 10:59:31 -0800 2022-01-07 14:48:04 -0800 Patch v1.0 bug-234968-20220107105930.patch text/plain 2762 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZhMjlkMjY0YTBiNmY0ZWVh MDc4OGZkMmJhZWViNWY0ZTM4OTY3NDMuLjJmODNjYzkwZmE4MTk3NmJjNDcwOWVlZjhkMTdlZTc3 MWU3MTljZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjItMDEtMDcgIFBhdHJpY2sg QW5nbGUgIDxwYW5nbGVAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI4NjQ5OCk6 IFdlYiBJbnNwZWN0b3I6IEluc3BlY3Rvcl4yIGZhaWxzIHRvIGxvYWQgaW4gcmVsZWFzZSBidWls ZHMgYW5kIGNyYXNoZXMgd2l0aCBhbiBhc3NlcnRpb24gaW4gZGVidWcgYnVpbGRzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQ5NjgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnNwZWN0b3JeMiB3b3Vs ZCBmYWlsIHRvIG9wZW4gYSBsb2NhbCBpbnNwZWN0b3IgZnJvbnRlbmQgYmVjYXVzZSBtX2luc3Bl Y3RlZFBhZ2VJZGVudGlmaWVyIHdhcyBub3Qgc2V0IGJlZm9yZQorICAgICAgICBpdCB3YXMgdXNl ZCBpbiBgV2ViSW5zcGVjdG9yVUlQcm94eTo6Y3JlYXRlRnJvbnRlbmRQYWdlYC4gVG8gY29ycmVj dCB0aGlzLCB3ZSBub3cgY2FjaGUgdGhlIGluc3BlY3RlZCBwYWdlCisgICAgICAgIGlkZW50aWZp ZXIgaW1tZWRpYXRlbHkgdXBvbiBjcmVhdGluZyB0aGUgV2ViSW5zcGVjdG9yVUlQcm94eSwgaW5z dGVhZCBvZiBvbmx5IGluCisgICAgICAgIGBXZWJJbnNwZWN0b3JVSVByb3h5Ojp1cGRhdGVGb3JO ZXdQYWdlUHJvY2Vzc2AuIFRoaXMgYWxzbyBhbGxvd3MgdXMgdG8gdXNlIHRoZSBjYWNoZWQgaWRl bnRpZmllciBpbgorICAgICAgICBgV2ViSW5zcGVjdG9yVUlQcm94eTo6b3BlbkxvY2FsSW5zcGVj dG9yRnJvbnRlbmRgIGFzIGRpc2N1c3NlZCBpbiA8aHR0cDovL3dlYmtpdC5vcmcvYi8yMzMyOTMj YzU+LgorCisgICAgICAgICogVUlQcm9jZXNzL0luc3BlY3Rvci9XZWJJbnNwZWN0b3JVSVByb3h5 LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yVUlQcm94eTo6V2ViSW5zcGVjdG9y VUlQcm94eSk6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclVJUHJveHk6Om9wZW5Mb2Nh bEluc3BlY3RvckZyb250ZW5kKToKKwogMjAyMi0wMS0wMyAgUGVyIEFybmUgVm9sbGFuICA8cHZv bGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW21hY09TXSBJbml0aWFsaXplIHNhbmRib3ggYmVm b3JlIGluaXRpYWxpemluZyBXZWJLaXQgcHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvSW5zcGVjdG9yL1dlYkluc3BlY3RvclVJUHJveHkuY3BwIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvSW5zcGVjdG9yL1dlYkluc3BlY3RvclVJUHJveHkuY3BwCmluZGV4IDkz ZmQ1YWJlNzk4OWNjYzIyMDNlYzk1YWQ0YWQ1MDUzZTFiODE1ODAuLjdkNzQ2YWY2MTIyZjhhODk0 ZGE0YTcxMzZmYTdhMDY5NTZlNDRjYjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0luc3BlY3Rvci9XZWJJbnNwZWN0b3JVSVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9JbnNwZWN0b3IvV2ViSW5zcGVjdG9yVUlQcm94eS5jcHAKQEAgLTY3LDYgKzY3 LDcgQEAgY29uc3QgdW5zaWduZWQgV2ViSW5zcGVjdG9yVUlQcm94eTo6aW5pdGlhbFdpbmRvd0hl aWdodCA9IDY1MDsKIFdlYkluc3BlY3RvclVJUHJveHk6OldlYkluc3BlY3RvclVJUHJveHkoV2Vi UGFnZVByb3h5JiBpbnNwZWN0ZWRQYWdlKQogICAgIDogbV9pbnNwZWN0ZWRQYWdlKCZpbnNwZWN0 ZWRQYWdlKQogICAgICwgbV9pbnNwZWN0b3JDbGllbnQobWFrZVVuaXF1ZTxBUEk6Okluc3BlY3Rv ckNsaWVudD4oKSkKKyAgICAsIG1faW5zcGVjdGVkUGFnZUlkZW50aWZpZXIoaW5zcGVjdGVkUGFn ZS5pZGVudGlmaWVyKCkpCiAjaWYgUExBVEZPUk0oTUFDKQogICAgICwgbV9jbG9zZUZyb250ZW5k QWZ0ZXJJbmFjdGl2aXR5VGltZXIoUnVuTG9vcDo6bWFpbigpLCB0aGlzLCAmV2ViSW5zcGVjdG9y VUlQcm94eTo6Y2xvc2VGcm9udGVuZEFmdGVySW5hY3Rpdml0eVRpbWVyRmlyZWQpCiAjZW5kaWYK QEAgLTQ0OCw3ICs0NDksNyBAQCB2b2lkIFdlYkluc3BlY3RvclVJUHJveHk6Om9wZW5Mb2NhbElu c3BlY3RvckZyb250ZW5kKGJvb2wgY2FuQXR0YWNoLCBib29sIHVuZGVyVAogICAgIGlmICghbV9p bnNwZWN0b3JQYWdlKQogICAgICAgICByZXR1cm47CiAKLSAgICBtX2luc3BlY3RvclBhZ2UtPnNl bmQoTWVzc2FnZXM6OldlYkluc3BlY3RvclVJOjpFc3RhYmxpc2hDb25uZWN0aW9uKG1faW5zcGVj dGVkUGFnZS0+aWRlbnRpZmllcigpLCBpbmZvRm9yTG9jYWxEZWJ1Z2dhYmxlKCksIG1fdW5kZXJU ZXN0LCBpbnNwZWN0aW9uTGV2ZWwoKSkpOworICAgIG1faW5zcGVjdG9yUGFnZS0+c2VuZChNZXNz YWdlczo6V2ViSW5zcGVjdG9yVUk6OkVzdGFibGlzaENvbm5lY3Rpb24obV9pbnNwZWN0ZWRQYWdl SWRlbnRpZmllciwgaW5mb0ZvckxvY2FsRGVidWdnYWJsZSgpLCBtX3VuZGVyVGVzdCwgaW5zcGVj dGlvbkxldmVsKCkpKTsKIAogICAgIEFTU0VSVCghbV9pc0FjdGl2ZUZyb250ZW5kKTsKICAgICBt X2lzQWN0aXZlRnJvbnRlbmQgPSB0cnVlOwo=