234965 2022-01-07 10:33:40 -0800 Web Inspector: Inspector::RemoteInspector::receivedSetupMessage() falls through ASSERT_NOT_REACHED() 2022-01-07 11:13:57 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All NEW https://bugs.webkit.org/show_bug.cgi?id=234971 InRadar P2 Normal --- 234932 1 ddkilzer webkit-unassigned inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1828965 0 ddkilzer 2022-01-07 10:33:40 -0800 Inspector::RemoteInspector::receivedSetupMessage() falls through ASSERT_NOT_REACHED(). Since there are many other early returns in this method, it seems like there should be an early return after ASSERT_NOT_REACHED() as well. void RemoteInspector::receivedSetupMessage(NSDictionary *userInfo) { [...] if (is<RemoteInspectionTarget>(target)) { bool isAutomaticInspection = m_automaticInspectionCandidateTargetIdentifier == target->targetIdentifier(); if (!connectionToTarget->setup(isAutomaticInspection, automaticallyPause)) { connectionToTarget->close(); return; } m_targetConnectionMap.set(targetIdentifier, WTFMove(connectionToTarget)); } else if (is<RemoteAutomationTarget>(target)) { if (!connectionToTarget->setup()) { connectionToTarget->close(); return; } m_targetConnectionMap.set(targetIdentifier, WTFMove(connectionToTarget)); } else ASSERT_NOT_REACHED(); updateHasActiveDebugSession(); } See Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm. 1828966 1 webkit-bug-importer 2022-01-07 10:33:54 -0800 <rdar://problem/87260301>