234956 2022-01-07 07:30:02 -0800 Cache the Widget associated with an AXObject on its AXIsolatedObject. 2022-01-07 12:03:05 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 1 andresg_22 andresg_22 aboxhall andresg_22 apinheiro cfleizach darin dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1828891 0 andresg_22 2022-01-07 07:30:02 -0800 Cache the Widget associated with an AXObject on its AXIsolatedObject. 1828892 1 webkit-bug-importer 2022-01-07 07:30:15 -0800 <rdar://problem/87250274> 1828897 2 448590 andresg_22 2022-01-07 07:48:27 -0800 Created attachment 448590 Patch 1828935 3 448590 darin 2022-01-07 09:31:34 -0800 Comment on attachment 448590 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448590&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:2097 > + [] (WeakPtr<Widget>& typedValue) -> Widget* { return typedValue.get(); }, I don’t think we need the "-> Widget*" on this line of code 1829017 4 andresg_22 2022-01-07 11:51:57 -0800 In further discussion we concluded that it is problematic to store the Widget pointer in the cache since the object can be accessed from both thread with undefined behavior. The alternative solution is done in https://bugs.webkit.org/show_bug.cgi?id=234973. Closing this bug since it is not longer applicable. 448590 2022-01-07 07:48:27 -0800 2022-01-07 09:54:06 -0800 Patch bug-234956-20220107104826.patch text/plain 4272 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjNjZmQ4MTg0OTEwM2M1 ZTQxMjJjYzg5MzZjNmFlNjhmMzI3MDUxZC4uZDQ4NjZhNGMyNTQ4MTVlNzBiNjUzMzg2ZGRhODJk NWRjZGVmYThmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDIyLTAxLTA3ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBDYWNoZSB0aGUg V2lkZ2V0IGFzc29jaWF0ZWQgd2l0aCBhbiBBWE9iamVjdCBvbiBpdHMgQVhJc29sYXRlZE9iamVj dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDk1 NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODcyNTAyNzQ+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwcm9wZXJ0eSB3YXMgbm90IGJlaW5n IGNhY2hlZCBpbiB0aGUgaXNvbGF0ZWQgb2JqZWN0LCBhbmQgdGh1cworICAgICAgICBuZWVkZWQg dG8gYmUgcmV0cmlldmVkIG9uIGRlbWFuZCBmcm9tIHRoZSBBWE9iamVjdCBhbmQgdGhlcmVmb3Jl IGhpdHRpbmcKKyAgICAgICAgdGhlIG1haW4gdGhyZWFkLiBNb3Jlb3ZlciwgdGhlIGltcGxlbWVu dGF0aW9uIG9mCisgICAgICAgIEFYSXNvbGF0ZWRPYmplY3Q6OndpZGdldCgpIHdhcyBub3QgZGlz cGF0Y2hpbmcgdG8gdGhlIG1haW4gdGhyZWFkIHdoaWNoCisgICAgICAgIHdvdWxkIGZvcmNlIGFs bCBjYWxsZXJzIHRvIGRpc3BhdGNoIHRoZSBjYWxsIHRvIHRoZSBtYWluIHRocmVhZC4KKyAgICAg ICAgW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyIGFjY2Vzc2liaWxpdHlIaXRUZXN0XSBk b2VzIG5vdCBkaXNwYXRjaAorICAgICAgICB0aGlzIGNhbGwgdG8gdGhlIG1haW4gdGhyZWFkIGFu ZCBoZW5jZSBtYWtlIHRoZSBwcm9ibGVtIGV2aWRlbnQuCisgICAgICAgIENhY2hpbmcgdGhlIFdp ZGdldCBpbiB0aGUgQVhJc29sYXRlZE9iamVjdCBvbiBjb25zdHJ1Y3Rpb24gc29sdmVzIHRoZXNl CisgICAgICAgIHByb2JsZW1zLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRy ZWUvQVhJc29sYXRlZE9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBWElzb2xhdGVkT2Jq ZWN0Ojppbml0aWFsaXplQXR0cmlidXRlRGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpBWElzb2xh dGVkT2JqZWN0Ojp3aWRnZXQgY29uc3QpOgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvaXNvbGF0 ZWR0cmVlL0FYSXNvbGF0ZWRUcmVlLmg6CisKIDIwMjItMDEtMDQgIEplciBOb2JsZSAgPGplci5u b2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBIYW5nIGluIEFWVHJhY2tQcml2YXRl QVZGT2JqQ0ltcGw6OmJpdHJhdGUoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmNwcAppbmRleCAz ODdlMWJjYjhiMTU0ZDY1MGIwNTA4MTliMzdlMjA2ODM2MTNjNmM5Li5jZDBiYjczMWI2MWQzMDEy MjAxODAxNTBjNjI2YzJlYjA1ODQ0ZDQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmNwcApA QCAtNDMwLDggKzQzMCwxMCBAQCB2b2lkIEFYSXNvbGF0ZWRPYmplY3Q6OmluaXRpYWxpemVBdHRy aWJ1dGVEYXRhKEFYQ29yZU9iamVjdCYgY29yZU9iamVjdCwgYm9vbCBpcwogICAgIGlmIChvYmpl Y3QuaXNXZWJBcmVhKCkpCiAgICAgICAgIHNldE9iamVjdFZlY3RvclByb3BlcnR5KEFYUHJvcGVy dHlOYW1lOjpEb2N1bWVudExpbmtzLCBvYmplY3QuZG9jdW1lbnRMaW5rcygpKTsKIAotICAgIGlm IChvYmplY3QuaXNXaWRnZXQoKSkKKyAgICBpZiAoYXV0byogd2lkZ2V0ID0gb2JqZWN0LndpZGdl dCgpKSB7CiAgICAgICAgIHNldFByb3BlcnR5KEFYUHJvcGVydHlOYW1lOjpJc1dpZGdldCwgdHJ1 ZSk7CisgICAgICAgIHNldFByb3BlcnR5KEFYUHJvcGVydHlOYW1lOjpXaWRnZXQsIHdpZGdldCk7 CisgICAgfQogCiAgICAgaW5pdGlhbGl6ZVBsYXRmb3JtUHJvcGVydGllcyhvYmplY3QsIGlzUm9v dCk7CiB9CkBAIC0yMDkwLDggKzIwOTIsMTEgQEAgVGV4dEl0ZXJhdG9yQmVoYXZpb3JzIEFYSXNv bGF0ZWRPYmplY3Q6OnRleHRJdGVyYXRvckJlaGF2aW9yRm9yVGV4dFJhbmdlKCkgY29uc3QKIAog V2lkZ2V0KiBBWElzb2xhdGVkT2JqZWN0Ojp3aWRnZXQoKSBjb25zdAogewotICAgIGF1dG8qIG9i amVjdCA9IGFzc29jaWF0ZWRBWE9iamVjdCgpOwotICAgIHJldHVybiBvYmplY3QgPyBvYmplY3Qt PndpZGdldCgpIDogbnVsbHB0cjsKKyAgICBhdXRvIHZhbHVlID0gbV9wcm9wZXJ0eU1hcC5nZXQo QVhQcm9wZXJ0eU5hbWU6OldpZGdldCk7CisgICAgcmV0dXJuIFdURjo6c3dpdGNoT24odmFsdWUs CisgICAgICAgIFtdIChXZWFrUHRyPFdpZGdldD4mIHR5cGVkVmFsdWUpIC0+IFdpZGdldCogeyBy ZXR1cm4gdHlwZWRWYWx1ZS5nZXQoKTsgfSwKKyAgICAgICAgW10gKGF1dG8mKSAtPiBXaWRnZXQq IHsgcmV0dXJuIG51bGxwdHI7IH0KKyAgICApOwogfQogCiBQbGF0Zm9ybVdpZGdldCBBWElzb2xh dGVkT2JqZWN0OjpwbGF0Zm9ybVdpZGdldCgpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkVHJlZS5oIGIvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZFRyZWUuaAppbmRl eCAzYTJjZWM5M2ZiMzk2MTIxZmRkZDEzNDZiYWY5YTk0ZDkyZDczMTZkLi5mM2U2OTgyMjUyNWZk YjExYTFiMmNkNjA0YzQyNzY4NTVhYmM3MGJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkVHJlZS5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRUcmVlLmgKQEAgLTMx Niw5ICszMTYsMTAgQEAgZW51bSBjbGFzcyBBWFByb3BlcnR5TmFtZSA6IHVpbnQxNl90IHsKICAg ICBWaXNpYmxlQ2hpbGRyZW4sCiAgICAgVmlzaWJsZVJvd3MsCiAgICAgV2ViQXJlYSwKKyAgICBX aWRnZXQsCiB9OwogCi11c2luZyBBWFByb3BlcnR5VmFsdWVWYXJpYW50ID0gc3RkOjp2YXJpYW50 PHN0ZDo6bnVsbHB0cl90LCBBWElELCBTdHJpbmcsIGJvb2wsIGludCwgdW5zaWduZWQsIGRvdWJs ZSwgZmxvYXQsIHVpbnQ2NF90LCBDb2xvciwgVVJMLCBMYXlvdXRSZWN0LCBGbG9hdFJlY3QsIFBB TDo6U2Vzc2lvbklELCBJbnRQb2ludCwgT3B0aW9uU2V0PFNwZWFrQXM+LCBzdGQ6OnBhaXI8dW5z aWduZWQsIHVuc2lnbmVkPiwgVmVjdG9yPEFjY2Vzc2liaWxpdHlUZXh0PiwgVmVjdG9yPEFYSUQ+ LCBWZWN0b3I8c3RkOjpwYWlyPEFYSUQsIEFYSUQ+PiwgVmVjdG9yPFN0cmluZz4sIFBhdGgsIE9w dGlvblNldDxBWEFuY2VzdG9yRmxhZz4+OwordXNpbmcgQVhQcm9wZXJ0eVZhbHVlVmFyaWFudCA9 IHN0ZDo6dmFyaWFudDxzdGQ6Om51bGxwdHJfdCwgQVhJRCwgU3RyaW5nLCBib29sLCBpbnQsIHVu c2lnbmVkLCBkb3VibGUsIGZsb2F0LCB1aW50NjRfdCwgQ29sb3IsIFVSTCwgTGF5b3V0UmVjdCwg RmxvYXRSZWN0LCBQQUw6OlNlc3Npb25JRCwgSW50UG9pbnQsIE9wdGlvblNldDxTcGVha0FzPiwg c3RkOjpwYWlyPHVuc2lnbmVkLCB1bnNpZ25lZD4sIFZlY3RvcjxBY2Nlc3NpYmlsaXR5VGV4dD4s IFZlY3RvcjxBWElEPiwgVmVjdG9yPHN0ZDo6cGFpcjxBWElELCBBWElEPj4sIFZlY3RvcjxTdHJp bmc+LCBQYXRoLCBPcHRpb25TZXQ8QVhBbmNlc3RvckZsYWc+LCBXZWFrUHRyPFdpZGdldD4+Owog dXNpbmcgQVhQcm9wZXJ0eU1hcCA9IEhhc2hNYXA8QVhQcm9wZXJ0eU5hbWUsIEFYUHJvcGVydHlW YWx1ZVZhcmlhbnQsIEludEhhc2g8QVhQcm9wZXJ0eU5hbWU+LCBXVEY6OlN0cm9uZ0VudW1IYXNo VHJhaXRzPEFYUHJvcGVydHlOYW1lPj47CiAKIHN0cnVjdCBBWFByb3BlcnR5Q2hhbmdlIHsK