234941 2022-01-06 17:55:22 -0800 postprocess-headers.sh: Avoid redundant processing to speed up incremental Xcode builds 2022-01-10 09:11:22 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 emw webkit-unassigned ap ews-watchlist jbedard keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1828791 0 emw 2022-01-06 17:55:22 -0800 postprocess-headers.sh: Avoid redundant processing to speed up incremental Xcode builds 1828792 1 448552 emw 2022-01-06 18:01:16 -0800 Created attachment 448552 Patch 1829149 2 emw 2022-01-07 17:23:07 -0800 Alexey <ap@webkit.org> pointed me to similar patches in the past that have caused problems. I don't think they invalidate my approach here, but am curious to hear if you think otherwise: - https://bugs.webkit.org/show_bug.cgi?id=220239 - https://bugs.webkit.org/show_bug.cgi?id=166810 These involved conditionally skipping a write to a file when its prerequisites changed. Skipping writes meant not updating an output file's modification time, which caused the respective scripts to execute on every rebuild after it had decided to skip writing an output file. This patch determines whether *Xcode* skipped a copy, and only skips postprocessing if Xcode skipped copying. Skipping postprocessing should not lead to situations where Xcode tries to copy a header repeatedly, since Xcode's build system is not interested in whether this script runs at all. - https://bugs.webkit.org/show_bug.cgi?id=77510 I'm not sure how this one is related -- seems like it ultimately caused problems because of complex Make logic that broke rebuilds. -- It's worth noting that we only have postprocess-headers.sh because APPLY_RULES_IN_COPY_FILES is not supported by the legacy build system. Changing it to only process a file once per copy matches behavior we get from the copy file build rule in XCBuild. 1829492 3 ews-feeder 2022-01-10 09:10:31 -0800 Committed r287837 (245889@main): <https://commits.webkit.org/245889@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448552. 1829493 4 webkit-bug-importer 2022-01-10 09:11:22 -0800 <rdar://problem/87343965> 448552 2022-01-06 18:01:16 -0800 2022-01-10 09:10:33 -0800 Patch bug-234941-20220106180115.patch text/plain 3818 emw U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 OTJmZjgzYmJiZDYzYzc1NDg3MDg5MmEwNjhhZGZkYjViOWQ3YmJjLi4yZGNlNzBiOTE4YjZmNWNl ZGZjNDQyYTVhNWFhNzY1OTU4NTBhOWJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMi0wMS0wNiAgRWxsaW90dCBXaWxsaWFtcyAgPGVtd0BhcHBsZS5jb20+ CisKKyAgICAgICAgcG9zdHByb2Nlc3MtaGVhZGVycy5zaDogQXZvaWQgcmVkdW5kYW50IHByb2Nl c3NpbmcgdG8gc3BlZWQgdXAgaW5jcmVtZW50YWwgWGNvZGUgYnVpbGRzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQ5NDEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbiBidWlsZHMgbWFkZSB3aXRoIHRo ZSBsZWdhY3kgYnVpbGQgc3lzdGVtIChjdXJyZW50bHkgYW55IENMSSBidWlsZCBmb3IgQXBwbGUg cGxhdGZvcm1zKSwKKyAgICAgICAgcG9zdHByb2Nlc3MtaGVhZGVycy5zaCBhbHdheXMgcnVucywg ZXZlbiB3aGVuIG5vIGhlYWRlcnMgaGF2ZSBiZWVuIGNvcGllZC4gUEJYQnVpbGQgZG9lc24ndAor ICAgICAgICBoYXZlIHRoZSBuZWNlc3NhcnkgZ3JhbnVsYXJpdHkgdG8gbGV0IHVzIGF2b2lkIHJ1 bm5pbmcgaXQgd2hlbiB0aGVyZSBhcmUgbm8gaGVhZGVycyB0byBjb3B5LAorICAgICAgICBob3dl dmVyLCB0aGlzIHBhdGNoIGltcHJvdmVzIGV4ZWN1dGlvbiB0aW1lIGJ5IG9ubHkgcnVubmluZyB0 aGUgcG9zdHByb2Nlc3MgcnVsZSB3aGVuIGEKKyAgICAgICAgaGVhZGVyIGhhcyBjaGFuZ2VkIHNp bmNlIHRoZSBsYXN0IHRpbWUgaXQgcmFuLgorCisgICAgICAgIFRoaXMgY2hhbmdlIHJlZHVjZXMg SmF2YVNjcmlwdENvcmUncyBudWxsIGJ1aWxkIHRpbWUgZnJvbSB+MTguM3MgdG8gfjUuMzJzLgor CisgICAgICAgICogcG9zdHByb2Nlc3MtaGVhZGVycy5zaDogQWRkZWQgdGltZXN0YW1wIGNoZWNr CisKIDIwMjItMDEtMDQgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAg ICAgICBbSlNDXSBSZW1vdmUgbV9jYWxsZWVTYXZlUmVnaXN0ZXJzIGZyb20gQ29kZUJsb2NrOjpK SVREYXRhIGFuZCByZW5hbWUgaXQgdG8gQmFzZWxpbmVKSVREYXRhCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9D aGFuZ2VMb2cKaW5kZXggMTdjZGE1YWM3NzBhN2NkMDc5ZDhkYjY2NjlhNjdmYTI1MzhmMmIwYi4u ZWNiZjQyYzFjN2I1NmM3ZGViMmRkMzIxZTdhZDE5NWM0MWIyMjk3NyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kv bWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIyLTAxLTA2ICBFbGxpb3R0IFdpbGxp YW1zICA8ZW13QGFwcGxlLmNvbT4KKworICAgICAgICBwb3N0cHJvY2Vzcy1oZWFkZXJzLnNoOiBB dm9pZCByZWR1bmRhbnQgcHJvY2Vzc2luZyB0byBzcGVlZCB1cCBpbmNyZW1lbnRhbCBYY29kZSBi dWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIz NDk0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog cG9zdHByb2Nlc3MtaGVhZGVycy5zaDoKKwogMjAyMi0wMS0wMiAgV2Vuc29uIEhzaWVoICA8d2Vu c29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViS2l0Ml0gQ2FtZXJhIGNvbnRpbnVp dHkgaXMgZGlzYWJsZWQgaW4gcmljaGx5IGVkaXRhYmxlIGNvbnRlbnQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9wb3N0cHJvY2Vzcy1oZWFkZXJzLnNoIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3Bvc3Rwcm9jZXNzLWhlYWRlcnMuc2gKaW5kZXggYmI0MGUwZGRhYjkzNDY1NGNi YThjYTFiZWFlMDNhZDQ0NGVmOTYxNi4uM2I0ODMzOTc5N2RiODRjMzkwMWJlZTc3MGQzOTMwMTIx MWNmOTczZiAxMDA3NTUKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3Bvc3Rwcm9jZXNzLWhl YWRlcnMuc2gKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Bvc3Rwcm9jZXNzLWhlYWRlcnMu c2gKQEAgLTI2LDEwICsyNiwxMiBAQAogCiBQT1NUUFJPQ0VTU19IRUFERVJfUlVMRT0iJHtTUkNS T09UfS9TY3JpcHRzL3Bvc3Rwcm9jZXNzLWhlYWRlci1ydWxlIgogW1sgLXggIiR7UE9TVFBST0NF U1NfSEVBREVSX1JVTEV9IiBdXSB8fCB7IGVjaG8gIiMjIyBVbmFibGUgdG8gZmluZCAke1BPU1RQ Uk9DRVNTX0hFQURFUl9SVUxFfSI7IGV4aXQgMTsgfQorVElNRVNUQU1QPSIke1RBUkdFVF9URU1Q X0RJUn0vcG9zdHByb2Nlc3MtaGVhZGVycy10aW1lc3RhbXAiCiAKIGZ1bmN0aW9uIHJld3JpdGVf aGVhZGVycyAoKQogewogICAgIGZvciBIRUFERVJfUEFUSCBpbiAiJHsxfS8iKi5oOyBkbworICAg ICAgICBbICIke1RJTUVTVEFNUH0iIC1udCAiJHtIRUFERVJfUEFUSH0iIF0gfHwgXAogICAgICAg ICBTQ1JJUFRfSEVBREVSX1ZJU0lCSUxJVFk9IiR7Mn0iIFwKICAgICAgICAgU0NSSVBUX0lOUFVU X0ZJTEU9IiR7SEVBREVSX1BBVEh9IiBcCiAgICAgICAgIFNDUklQVF9PVVRQVVRfRklMRV8wPSIk e0hFQURFUl9QQVRIfSIgXApAQCAtMzksMyArNDEsNCBAQCBmdW5jdGlvbiByZXdyaXRlX2hlYWRl cnMgKCkKIAogcmV3cml0ZV9oZWFkZXJzICIke1RBUkdFVF9CVUlMRF9ESVJ9LyR7UFVCTElDX0hF QURFUlNfRk9MREVSX1BBVEh9IiBQdWJsaWMKIHJld3JpdGVfaGVhZGVycyAiJHtUQVJHRVRfQlVJ TERfRElSfS8ke1BSSVZBVEVfSEVBREVSU19GT0xERVJfUEFUSH0iIFByaXZhdGUKK3RvdWNoICIk e1RJTUVTVEFNUH0iClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdExlZ2FjeS9tYWMvcG9zdHByb2Nlc3MtaGVhZGVycy5zaCBiL1NvdXJjZS9XZWJL aXRMZWdhY3kvbWFjL3Bvc3Rwcm9jZXNzLWhlYWRlcnMuc2gKaW5kZXggOTE1YmFkYjE3YzgzMzI2 Y2YxNjc4ZWQ4ZDQ3OTZiMGEwNWE4NTdkMy4uYTY5ZjNkYTNmOTk1NGNlMGZkYTA0MDIwNzk0NzQ2 ZjgwNzZhNGFhOSAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvcG9zdHByb2Nl c3MtaGVhZGVycy5zaAorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9wb3N0cHJvY2Vzcy1o ZWFkZXJzLnNoCkBAIC0yNiw2ICsyNiw3IEBACiAKIFBPU1RQUk9DRVNTX0hFQURFUl9SVUxFPSIk e1NSQ1JPT1R9L3NjcmlwdHMvcG9zdHByb2Nlc3MtaGVhZGVyLXJ1bGUiCiBbWyAteCAiJHtQT1NU UFJPQ0VTU19IRUFERVJfUlVMRX0iIF1dIHx8IHsgZWNobyAiIyMjIFVuYWJsZSB0byBmaW5kICR7 UE9TVFBST0NFU1NfSEVBREVSX1JVTEV9IjsgZXhpdCAxOyB9CitUSU1FU1RBTVA9IiR7VEFSR0VU X1RFTVBfRElSfS9wb3N0cHJvY2Vzcy1oZWFkZXJzLXRpbWVzdGFtcCIKIAogZnVuY3Rpb24gcmV3 cml0ZV9oZWFkZXJzICgpCiB7CkBAIC0zOCwzICszOSw0IEBAIGZ1bmN0aW9uIHJld3JpdGVfaGVh ZGVycyAoKQogfQogCiByZXdyaXRlX2hlYWRlcnMgIiR7VEFSR0VUX0JVSUxEX0RJUn0vJHtQUklW QVRFX0hFQURFUlNfRk9MREVSX1BBVEh9IiBQcml2YXRlCit0b3VjaCAiJHtUSU1FU1RBTVB9Igo=