23490 2009-01-22 18:34:22 -0800 Remove initialRefCount argument from RefCounted class 2009-01-29 05:10:52 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer darin fishd kevino oldest_to_newest 106672 0 ddkilzer 2009-01-22 18:34:22 -0800 * SUMMARY Now that nearly all classes(*) have switched to starting with a ref count of 1, the argument to the RefCounted class may be removed. (*) There are two classes remaining that haven't been converted: $ grep -r ': RefCounted<' WebCore | grep '(0)' WebCore/page/chromium/AccessibilityObjectWrapper.h: : RefCounted<AccessibilityObjectWrapper>(0), m_object(obj) { } $ grep -r ': RefCounted<' WebKit | grep '(0)' WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp: : RefCounted<FrameLoaderClientWx>(0) 107143 1 27063 ddkilzer 2009-01-26 19:18:09 -0800 Created attachment 27063 Patch v1 Proposed fix. 107146 2 27063 darin 2009-01-26 19:37:28 -0800 Comment on attachment 27063 Patch v1 > + static PassRefPtr<AccessibilityObjectWrapper> create(PassRefPtr<AccessibilityObject> obj) > + { > + return adoptRef(new AccessibilityObjectWrapper(obj)); > + } > + static PassRefPtr<AccessibilityObjectWrapper> create() > + { > + return adoptRef(new AccessibilityObjectWrapper()); > + } This is an abstract class which can't be instantiated, because of the pure virtual detach function, so these create functions won't do anyone any good. Presumably the code that calls new and needs to do adoptRef is somewhere else in the Chromium project, not checked into the WebKit source tree. So you can't make this change without creating a Chrome-specific storage leak unless the Chrome team checks in some more of their code! > + AccessibilityObjectWrapper(PassRefPtr<AccessibilityObject> obj) : m_object(obj) { } How about "object" instead of "obj"? > - AccessibilityObject* m_object; > + RefPtr<AccessibilityObject> m_object; Are you sure it's right to change this to a RefPtr? This doesn't seem related to your RefCounted initial reference count fix. Maybe the Chrome folks have a reason to not use a RefPtr here? > + return adoptRef(new FrameLoaderClientWx()); No need for the parentheses here. Why not take the initial reference count argument out of RefCountedBase too, while you're at it? The only client for that is in ByteArray.h and it passes a 1 too. review- for now, but this looks mostly fine. 107149 3 kevino 2009-01-26 20:25:28 -0800 Actually, it doesn't look like the other ports use RefCounted with FrameLoaderClient, and I think this is mostly just a relic of how things were done some time ago, so I wonder if it isn't good to just remove it and just use a straight pointer like the rest of the ports? (I had a patch for that in the works, but you beat me to it ;-) 107197 4 fishd 2009-01-27 09:15:31 -0800 Yeah, we haven't begun upstreaming chromium's WebKit layer. We are still a ways from being able to separate it from our tree. I think we used an initial ref count of 0 to be compatible with some existing code that hadn't yet been translated over to the new hotness. Please don't worry about breaking our port in cases like this where you don't have access to all of the related code. 107244 5 27084 ddkilzer 2009-01-27 13:34:25 -0800 Created attachment 27084 Patch v2 (requires more work) Changes since Patch v1: - Removed changes to AccessibilityObject stuff. Chromium can't be fixed until their full tree lands. (Comment #2 and Comment #4) I'll land the mac header guard fix separately. - Also removed the argument to RefCountedBase and updated ByteArray. (Comment #2) - Made FrameLoaderClientWx not RefCounted. (Comment #3) 107249 6 27084 darin 2009-01-27 13:54:27 -0800 Comment on attachment 27084 Patch v2 (requires more work) > - RefCounted(int initialRefCount = 1) > - : RefCountedBase(initialRefCount) > + RefCounted() > { > } This entire constructor definition could be removed! We don't need it at all any more. r=me 107365 7 ddkilzer 2009-01-28 12:08:09 -0800 $ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/wtf/ByteArray.h M JavaScriptCore/wtf/RefCounted.h M WebKit/wx/ChangeLog M WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp M WebKit/wx/WebKitSupport/FrameLoaderClientWx.h Committed r40319 http://trac.webkit.org/changeset/40319 107366 8 ddkilzer 2009-01-28 12:09:08 -0800 (In reply to comment #6) > (From update of attachment 27084 [review]) > > - RefCounted(int initialRefCount = 1) > > - : RefCountedBase(initialRefCount) > > + RefCounted() > > { > > } > > This entire constructor definition could be removed! We don't need it at all > any more. This change was made for the final patch. 107368 9 ddkilzer 2009-01-28 12:27:08 -0800 $ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M WebKit/wx/ChangeLog Committed r40320 Fixed ChangeLog dates. :( http://trac.webkit.org/changeset/40320 107512 10 ddkilzer 2009-01-29 05:10:52 -0800 Follow-up build fix for Wx: $ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/wx/ChangeLog M WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp M WebKit/wx/WebKitSupport/FrameLoaderClientWx.h Committed r40361 http://trac.webkit.org/changeset/40361 27063 2009-01-26 19:18:09 -0800 2009-01-27 13:34:25 -0800 Patch v1 bug-23490-v1.diff text/plain 9046 ddkilzer Y29tbWl0IGE0ZWU4ZTlhZDI5NzIyYzFkZmI2MDBhNmU4MmQ0MTJiNDY0ZDA3OGYKQXV0aG9yOiBE YXZpZCBLaWx6ZXIgPGRka2lsemVyQGFwcGxlLmNvbT4KRGF0ZTogICBNb24gSmFuIDI2IDE2OjM1 OjA5IDIwMDkgLTA4MDAKCiAgICAgICAgICAgIEJ1ZyAyMzQ5MDogUmVtb3ZlIGluaXRpYWxSZWZD b3VudCBhcmd1bWVudCBmcm9tIFJlZkNvdW50ZWQgY2xhc3MKICAgIAogICAgICAgICAgICA8aHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDkwPgogICAgCiAgICAgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogICAgCiAgICBKYXZhU2NyaXB0Q29yZToK ICAgIAogICAgICAgICAgICAqIHd0Zi9SZWZDb3VudGVkLmg6CiAgICAgICAgICAgIChXVEY6OlJl ZkNvdW50ZWQ6OlJlZkNvdW50ZWQpOiBSZW1vdmVkIGluaXRpYWxSZWZDb3VudCBhcmd1bWVudAog ICAgICAgICAgICBhbmQgY2FsbCBSZWZDb3VudGVkQmFzZSgxKS4KICAgIAogICAgV2ViQ29yZToK ICAgIAogICAgICAgICAgICAqIHBhZ2UvY2hyb21pdW0vQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBw ZXIuaDogS2VlcCBhIHJlZmVyZW5jZSB0bwogICAgICAgICAgICB0aGUgQWNjZXNzaWJpbGl0eU9i amVjdCB1c2luZyBhIFJlZlB0ci4KICAgICAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlP YmplY3RXcmFwcGVyOjpjcmVhdGUpOiBBZGRlZC4KICAgICAgICAgICAgKFdlYkNvcmU6OkFjY2Vz c2liaWxpdHlPYmplY3RXcmFwcGVyOjpBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcik6CiAgICAg ICAgICAgIENoYW5nZWQgb3ZlcmxvYWRlZCBtZXRob2QgdGhhdCB0YWtlcyBhbiBhcmd1bWVudCB0 byB1c2UgYSBQYXNzUmVmUHRyCiAgICAgICAgICAgIHNpbmNlIHRoaXMgb2JqZWN0IHRha2VzIG93 bmVyc2hpcCBvZiB0aGUgQWNjZXNzaWJpbGl0eU9iamVjdC4KICAgIAogICAgICAgICAgICAqIHBh Z2UvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyLmg6IEFkZGVkIG1pc3NpbmcgaGVhZGVy IGd1YXJkcy4KICAgIAogICAgV2ViS2l0L3d4OgogICAgCiAgICAgICAgICAgICogV2ViRnJhbWUu Y3BwOgogICAgICAgICAgICAod3hXZWJGcmFtZTo6d3hXZWJGcmFtZSk6IFVzZSBGcmFtZUxvYWRl ckNsaWVudFd4OjpjcmVhdGUoKSBhbmQgc3RvcmUKICAgICAgICAgICAgaW5zdGFuY2Ugb2YgRnJh bWVMb2FkZXJDbGllbnRXeCBpbiBhIFJlZlB0ci4KICAgICAgICAgICAgKiBXZWJLaXRTdXBwb3J0 L0ZyYW1lTG9hZGVyQ2xpZW50V3guY3BwOgogICAgICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2Fk ZXJDbGllbnRXeDo6RnJhbWVMb2FkZXJDbGllbnRXeCk6IFJlbW92ZSBjYWxsIHRvCiAgICAgICAg ICAgIFJlZkNvdW50ZWQ8RnJhbWVMb2FkZXJDbGllbnRXeD4oMCkgc3VwZXIgY29uc3RydWN0b3Iu CiAgICAgICAgICAgICogV2ViS2l0U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFd4Lmg6CiAgICAg ICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudFd4OjpjcmVhdGUpOiBBZGRlZC4KICAg ICAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50V3g6OkZyYW1lTG9hZGVyQ2xpZW50 V3gpOiBNYWRlIHByaXZhdGUuCgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n IGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGU2YjdmZDcuLjQ0NThlNzEgMTAwNjQ0 Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wMS0yNiAgRGF2aWQgS2lsemVyICA8ZGRraWx6 ZXJAYXBwbGUuY29tPgorCisgICAgICAgIEJ1ZyAyMzQ5MDogUmVtb3ZlIGluaXRpYWxSZWZDb3Vu dCBhcmd1bWVudCBmcm9tIFJlZkNvdW50ZWQgY2xhc3MKKworICAgICAgICA8aHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDkwPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1JlZkNvdW50ZWQuaDoKKyAgICAgICAg KFdURjo6UmVmQ291bnRlZDo6UmVmQ291bnRlZCk6IFJlbW92ZWQgaW5pdGlhbFJlZkNvdW50IGFy Z3VtZW50CisgICAgICAgIGFuZCBjYWxsIFJlZkNvdW50ZWRCYXNlKDEpLgorCiAyMDA5LTAxLTI2 ICBBZGVsZSBQZXRlcnNvbiAgPGFkZWxlQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXgu ICAKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9SZWZDb3VudGVkLmggYi9KYXZhU2Ny aXB0Q29yZS93dGYvUmVmQ291bnRlZC5oCmluZGV4IGFjOGUxNjcuLjEzNDVjMGEgMTAwNjQ0Ci0t LSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9SZWZDb3VudGVkLmgKKysrIGIvSmF2YVNjcmlwdENvcmUv d3RmL1JlZkNvdW50ZWQuaApAQCAtODUsOCArODUsOCBAQCBwcm90ZWN0ZWQ6CiAKIHRlbXBsYXRl PGNsYXNzIFQ+IGNsYXNzIFJlZkNvdW50ZWQgOiBwdWJsaWMgUmVmQ291bnRlZEJhc2UgewogcHVi bGljOgotICAgIFJlZkNvdW50ZWQoaW50IGluaXRpYWxSZWZDb3VudCA9IDEpCi0gICAgICAgIDog UmVmQ291bnRlZEJhc2UoaW5pdGlhbFJlZkNvdW50KQorICAgIFJlZkNvdW50ZWQoKQorICAgICAg ICA6IFJlZkNvdW50ZWRCYXNlKDEpCiAgICAgewogICAgIH0KIApkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhY2U2MTAwLi4xNmIyMDI3IDEw MDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDIwIEBACisyMDA5LTAxLTI2ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5j b20+CisKKyAgICAgICAgQnVnIDIzNDkwOiBSZW1vdmUgaW5pdGlhbFJlZkNvdW50IGFyZ3VtZW50 IGZyb20gUmVmQ291bnRlZCBjbGFzcworCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjM0OTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBwYWdlL2Nocm9taXVtL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFw cGVyLmg6IEtlZXAgYSByZWZlcmVuY2UgdG8KKyAgICAgICAgdGhlIEFjY2Vzc2liaWxpdHlPYmpl Y3QgdXNpbmcgYSBSZWZQdHIuCisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0 V3JhcHBlcjo6Y3JlYXRlKTogQWRkZWQuCisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5 T2JqZWN0V3JhcHBlcjo6QWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIpOgorICAgICAgICBDaGFu Z2VkIG92ZXJsb2FkZWQgbWV0aG9kIHRoYXQgdGFrZXMgYW4gYXJndW1lbnQgdG8gdXNlIGEgUGFz c1JlZlB0cgorICAgICAgICBzaW5jZSB0aGlzIG9iamVjdCB0YWtlcyBvd25lcnNoaXAgb2YgdGhl IEFjY2Vzc2liaWxpdHlPYmplY3QuCisKKyAgICAgICAgKiBwYWdlL21hYy9BY2Nlc3NpYmlsaXR5 T2JqZWN0V3JhcHBlci5oOiBBZGRlZCBtaXNzaW5nIGhlYWRlciBndWFyZHMuCisKIDIwMDktMDEt MjYgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YW4gQmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL2Nocm9taXVtL0FjY2Vzc2li aWxpdHlPYmplY3RXcmFwcGVyLmggYi9XZWJDb3JlL3BhZ2UvY2hyb21pdW0vQWNjZXNzaWJpbGl0 eU9iamVjdFdyYXBwZXIuaAppbmRleCA5OTIwZTRkLi5jMzEwNmYzIDEwMDY0NAotLS0gYS9XZWJD b3JlL3BhZ2UvY2hyb21pdW0vQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIuaAorKysgYi9XZWJD b3JlL3BhZ2UvY2hyb21pdW0vQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIuaApAQCAtMjcsMjIg KzI3LDMyIEBACiAjaWZuZGVmIEFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyX2gKICNkZWZpbmUg QWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJfaAogCisjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQu aD4KKyNpbmNsdWRlIDx3dGYvUmVmUHRyLmg+CisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAg IGNsYXNzIEFjY2Vzc2liaWxpdHlPYmplY3Q7CiAgICAgY2xhc3MgQWNjZXNzaWJpbGl0eU9iamVj dFdyYXBwZXIgOiBwdWJsaWMgUmVmQ291bnRlZDxBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcj4g ewogICAgIHB1YmxpYzoKKyAgICAgICAgc3RhdGljIFBhc3NSZWZQdHI8QWNjZXNzaWJpbGl0eU9i amVjdFdyYXBwZXI+IGNyZWF0ZShQYXNzUmVmUHRyPEFjY2Vzc2liaWxpdHlPYmplY3Q+IG9iaikK KyAgICAgICAgeworICAgICAgICAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBBY2Nlc3NpYmlsaXR5 T2JqZWN0V3JhcHBlcihvYmopKTsKKyAgICAgICAgfQorICAgICAgICBzdGF0aWMgUGFzc1JlZlB0 cjxBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcj4gY3JlYXRlKCkKKyAgICAgICAgeworICAgICAg ICAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcigpKTsK KyAgICAgICAgfQogICAgICAgICB2aXJ0dWFsIH5BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcigp IHt9CiAgICAgICAgIHZpcnR1YWwgdm9pZCBkZXRhY2goKSA9IDA7CiAgICAgICAgIGJvb2wgYXR0 YWNoZWQoKSBjb25zdCB7IHJldHVybiBtX29iamVjdDsgfQogICAgICAgICBBY2Nlc3NpYmlsaXR5 T2JqZWN0KiBhY2Nlc3NpYmlsaXR5T2JqZWN0KCkgY29uc3QgeyByZXR1cm4gbV9vYmplY3Q7IH0K IAogICAgIHByb3RlY3RlZDoKLSAgICAgICAgQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIoQWNj ZXNzaWJpbGl0eU9iamVjdCogb2JqKQotICAgICAgICAgICAgOiBSZWZDb3VudGVkPEFjY2Vzc2li aWxpdHlPYmplY3RXcmFwcGVyPigwKSwgbV9vYmplY3Qob2JqKSB7IH0KKyAgICAgICAgQWNjZXNz aWJpbGl0eU9iamVjdFdyYXBwZXIoUGFzc1JlZlB0cjxBY2Nlc3NpYmlsaXR5T2JqZWN0PiBvYmop IDogbV9vYmplY3Qob2JqKSB7IH0KICAgICAgICAgQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIo KSA6IG1fb2JqZWN0KDApIHsgfQogCi0gICAgICAgIEFjY2Vzc2liaWxpdHlPYmplY3QqIG1fb2Jq ZWN0OworICAgICAgICBSZWZQdHI8QWNjZXNzaWJpbGl0eU9iamVjdD4gbV9vYmplY3Q7CiAgICAg fTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL21h Yy9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlci5oIGIvV2ViQ29yZS9wYWdlL21hYy9BY2Nlc3Np YmlsaXR5T2JqZWN0V3JhcHBlci5oCmluZGV4IDVhNTVmZTAuLjNiNTg0YTkgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGFnZS9tYWMvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIuaAorKysgYi9XZWJD b3JlL3BhZ2UvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyLmgKQEAgLTI1LDggKzI1LDEx IEBACiAgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFO WSBXQVkgT1VUIE9GIFRIRSBVU0UgT0YKICAqIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNF RCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAgKi8KLSAKLSNpbXBvcnQgPHd0 Zi9SZWZQdHIuaD4gCisKKyNpZm5kZWYgQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJfaAorI2Rl ZmluZSBBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcl9oCisKKyNpbXBvcnQgPHd0Zi9SZWZQdHIu aD4KIAogI2lmZGVmIF9fT0JKQ19fCiBAY2xhc3MgV2ViQ29yZVRleHRNYXJrZXI7CkBAIC01Mywz ICs1Niw1IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIC0gKE5TVmlldyopYXR0YWNobWVudFZpZXc7 CiAKIEBlbmQKKworI2VuZGlmIC8vIEFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyX2gKZGlmZiAt LWdpdCBhL1dlYktpdC93eC9DaGFuZ2VMb2cgYi9XZWJLaXQvd3gvQ2hhbmdlTG9nCmluZGV4IDdl MTI2MTIuLmVkN2JlM2EgMTAwNjQ0Ci0tLSBhL1dlYktpdC93eC9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0L3d4L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDA5LTAxLTI2ICBEYXZpZCBLaWx6 ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgQnVnIDIzNDkwOiBSZW1vdmUgaW5p dGlhbFJlZkNvdW50IGFyZ3VtZW50IGZyb20gUmVmQ291bnRlZCBjbGFzcworCisgICAgICAgIDxo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0OTA+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJGcmFtZS5jcHA6Cisg ICAgICAgICh3eFdlYkZyYW1lOjp3eFdlYkZyYW1lKTogVXNlIEZyYW1lTG9hZGVyQ2xpZW50V3g6 OmNyZWF0ZSgpIGFuZCBzdG9yZQorICAgICAgICBpbnN0YW5jZSBvZiBGcmFtZUxvYWRlckNsaWVu dFd4IGluIGEgUmVmUHRyLgorICAgICAgICAqIFdlYktpdFN1cHBvcnQvRnJhbWVMb2FkZXJDbGll bnRXeC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudFd4OjpGcmFtZUxv YWRlckNsaWVudFd4KTogUmVtb3ZlIGNhbGwgdG8KKyAgICAgICAgUmVmQ291bnRlZDxGcmFtZUxv YWRlckNsaWVudFd4PigwKSBzdXBlciBjb25zdHJ1Y3Rvci4KKyAgICAgICAgKiBXZWJLaXRTdXBw b3J0L0ZyYW1lTG9hZGVyQ2xpZW50V3guaDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVy Q2xpZW50V3g6OmNyZWF0ZSk6IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXJD bGllbnRXeDo6RnJhbWVMb2FkZXJDbGllbnRXeCk6IE1hZGUgcHJpdmF0ZS4KKwogMjAwOS0wMS0y MyAgS2V2aW4gT2xsaXZpZXIgIDxrZXZpbm9AdGhlb2xsaXZpZXJzLmNvbT4KIAogICAgICAgICB3 eCBidWlsZCBmaXgsIGFkZCBtaXNzaW5nIGluY2x1ZGUgZGlyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0 L3d4L1dlYkZyYW1lLmNwcCBiL1dlYktpdC93eC9XZWJGcmFtZS5jcHAKaW5kZXggN2JmY2M1ZC4u NGU0ZDQ5NCAxMDA2NDQKLS0tIGEvV2ViS2l0L3d4L1dlYkZyYW1lLmNwcAorKysgYi9XZWJLaXQv d3gvV2ViRnJhbWUuY3BwCkBAIC04Myw5ICs4Myw5IEBAIHd4V2ViRnJhbWU6Ond4V2ViRnJhbWUo d3hXZWJWaWV3KiBjb250YWluZXIsIHd4V2ViRnJhbWUqIHBhcmVudCwgV2ViVmlld0ZyYW1lRGF0 CiAgICAgICAgIHBhcmVudEZyYW1lID0gZGF0YS0+b3duZXJFbGVtZW50OwogICAgIH0KICAgICAK LSAgICBXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudFd4KiBsb2FkZXJDbGllbnQgPSBuZXcgV2Vi Q29yZTo6RnJhbWVMb2FkZXJDbGllbnRXeCgpOworICAgIFJlZlB0cjxXZWJDb3JlOjpGcmFtZUxv YWRlckNsaWVudFd4PiBsb2FkZXJDbGllbnQgPSBXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudFd4 OjpjcmVhdGUoKTsKICAgICAKLSAgICBtX2ltcGwtPmZyYW1lID0gV2ViQ29yZTo6RnJhbWU6OmNy ZWF0ZShjb250YWluZXItPm1faW1wbC0+cGFnZSwgcGFyZW50RnJhbWUsIGxvYWRlckNsaWVudCk7 CisgICAgbV9pbXBsLT5mcmFtZSA9IFdlYkNvcmU6OkZyYW1lOjpjcmVhdGUoY29udGFpbmVyLT5t X2ltcGwtPnBhZ2UsIHBhcmVudEZyYW1lLCBsb2FkZXJDbGllbnQuZ2V0KCkpOwogICAgIG1faW1w bC0+ZnJhbWUtPmRlcmVmKCk7CiAKICAgICBsb2FkZXJDbGllbnQtPnNldEZyYW1lKG1faW1wbC0+ ZnJhbWUuZ2V0KCkpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0L3d4L1dlYktpdFN1cHBvcnQvRnJhbWVM b2FkZXJDbGllbnRXeC5jcHAgYi9XZWJLaXQvd3gvV2ViS2l0U3VwcG9ydC9GcmFtZUxvYWRlckNs aWVudFd4LmNwcAppbmRleCAzOGY5YTFkLi45Mjc2ZTRlIDEwMDY0NAotLS0gYS9XZWJLaXQvd3gv V2ViS2l0U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFd4LmNwcAorKysgYi9XZWJLaXQvd3gvV2Vi S2l0U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFd4LmNwcApAQCAtNzAsOCArNzAsNyBAQCBpbmxp bmUgaW50IHd4TmF2VHlwZUZyb21XZWJOYXZUeXBlKE5hdmlnYXRpb25UeXBlIHR5cGUpewogfQog CiBGcmFtZUxvYWRlckNsaWVudFd4OjpGcmFtZUxvYWRlckNsaWVudFd4KCkKLSAgICA6IFJlZkNv dW50ZWQ8RnJhbWVMb2FkZXJDbGllbnRXeD4oMCkKLSAgICAsIG1fZnJhbWUoMCkKKyAgICA6IG1f ZnJhbWUoMCkKIHsKIH0KIApkaWZmIC0tZ2l0IGEvV2ViS2l0L3d4L1dlYktpdFN1cHBvcnQvRnJh bWVMb2FkZXJDbGllbnRXeC5oIGIvV2ViS2l0L3d4L1dlYktpdFN1cHBvcnQvRnJhbWVMb2FkZXJD bGllbnRXeC5oCmluZGV4IGM4MTExNTUuLjdkZDQ1MGEgMTAwNjQ0Ci0tLSBhL1dlYktpdC93eC9X ZWJLaXRTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50V3guaAorKysgYi9XZWJLaXQvd3gvV2ViS2l0 U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFd4LmgKQEAgLTUwLDcgKzUwLDEwIEBAIG5hbWVzcGFj ZSBXZWJDb3JlIHsKIAogICAgIGNsYXNzIEZyYW1lTG9hZGVyQ2xpZW50V3ggOiBwdWJsaWMgRnJh bWVMb2FkZXJDbGllbnQsIHB1YmxpYyBSZWZDb3VudGVkPEZyYW1lTG9hZGVyQ2xpZW50V3g+IHsK ICAgICBwdWJsaWM6Ci0gICAgICAgIEZyYW1lTG9hZGVyQ2xpZW50V3goKTsKKyAgICAgICAgc3Rh dGljIFBhc3NSZWZQdHI8RnJhbWVMb2FkZXJDbGllbnRXeD4gY3JlYXRlKCkKKyAgICAgICAgewor ICAgICAgICAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBGcmFtZUxvYWRlckNsaWVudFd4KCkpOwor ICAgICAgICB9CiAgICAgICAgIH5GcmFtZUxvYWRlckNsaWVudFd4KCk7CiAgICAgICAgIHZvaWQg c2V0RnJhbWUoRnJhbWUgKmZyYW1lKTsKICAgICAgICAgdm9pZCBzZXRXZWJWaWV3KHd4V2ViVmll dyAqd2Vidmlldyk7CkBAIC0yMTAsNiArMjEzLDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAg ICAgICB2aXJ0dWFsIHZvaWQgcmVnaXN0ZXJGb3JJY29uTm90aWZpY2F0aW9uKGJvb2wgbGlzdGVu ID0gdHJ1ZSk7CiAKICAgICBwcml2YXRlOgorICAgICAgICBGcmFtZUxvYWRlckNsaWVudFd4KCk7 CisKICAgICAgICAgRnJhbWUgKm1fZnJhbWU7CiAgICAgICAgIHd4V2ViVmlldyAqbV93ZWJWaWV3 OwogICAgICAgICBSZXNvdXJjZVJlc3BvbnNlIG1fcmVzcG9uc2U7Cg== 27084 2009-01-27 13:34:25 -0800 2009-01-27 13:54:27 -0800 Patch v2 (requires more work) bug-23490-v2.diff text/plain 5380 ddkilzer Y29tbWl0IGI3YmFlZjcyNzk4NzIwNmM1MDNjYjFiZjE4Njg5NDIzMjYzZDJhMzIKQXV0aG9yOiBE YXZpZCBLaWx6ZXIgPGRka2lsemVyQGFwcGxlLmNvbT4KRGF0ZTogICBUdWUgSmFuIDI3IDEzOjI5 OjE2IDIwMDkgLTA4MDAKCiAgICAgICAgICAgIEJ1ZyAyMzQ5MDogUmVtb3ZlIGluaXRpYWxSZWZD b3VudCBhcmd1bWVudCBmcm9tIFJlZkNvdW50ZWQgY2xhc3MKICAgIAogICAgICAgICAgICA8aHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDkwPgogICAgCiAgICAgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogICAgCiAgICBKYXZhU2NyaXB0Q29yZToK ICAgIAogICAgICAgICAgICBSZWZDb3VudGVkQmFzZSBub3cgYWx3YXlzIHN0YXJ0cyB3aXRoIGEg cmVmIGNvdW50IG9mIDEsIHNvIHRoZXJlCiAgICAgICAgICAgIGlzIG5vIG5lZWQgdG8gcGFzcyB0 aGUgaW5pdGlhbFJlZkNvdW50IGludG8gdGhlIGNsYXNzIGFueW1vcmUuCiAgICAKICAgICAgICAg ICAgKiB3dGYvQnl0ZUFycmF5Lmg6CiAgICAgICAgICAgIChXVEY6OkJ5dGVBcnJheTo6Qnl0ZUFy cmF5KTogUmVtb3ZlZCBjYWxsIHRvIFJlZkNvdW50ZWQoMSkuCiAgICAgICAgICAgICogd3RmL1Jl ZkNvdW50ZWQuaDoKICAgICAgICAgICAgKFdURjo6UmVmQ291bnRlZEJhc2U6OlJlZkNvdW50ZWRC YXNlKTogQ2hhbmdlZCB0byBzdGFydCB3aXRoIGEKICAgICAgICAgICAgcmVmIGNvdW50IG9mIDEu CiAgICAgICAgICAgIChXVEY6OlJlZkNvdW50ZWQ6OlJlZkNvdW50ZWQpOiBSZW1vdmVkIGluaXRp YWxSZWZDb3VudCBhcmd1bWVudAogICAgICAgICAgICBhbmQgcmVtb3ZlZCBjYWxsIHRvIFJlZkNv dW50ZWQoMSkuCiAgICAKICAgIFdlYktpdC93eDoKICAgIAogICAgICAgICAgICBGcmFtZUxvYWRl ckNsaWVudFd4IGlzIG5vIGxvbmdlciBhIFJlZkNvdW50ZWQgY2xhc3MuCiAgICAKICAgICAgICAg ICAgKiBXZWJLaXRTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50V3guY3BwOgogICAgICAgICAgICAo V2ViQ29yZTo6RnJhbWVMb2FkZXJDbGllbnRXeDo6RnJhbWVMb2FkZXJDbGllbnRXeCk6IFJlbW92 ZWQgY2FsbAogICAgICAgICAgICB0byB0aGUgUmVmQ291bnRlZDxGcmFtZUxvYWRlckNsaWVudFd4 PigwKSBzdXBlciBjb25zdHJ1Y3Rvci4KICAgICAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0ZyYW1l TG9hZGVyQ2xpZW50V3guaDogRG9uJ3QgaW5jbHVkZSBSZWZDb3VudGVkLmgKICAgICAgICAgICAg YW5kIHN0b3AgaW5oZXJpdGluZyBmcm9tIFJlZkNvdW50ZWQ8RnJhbWVMb2FkZXJDbGllbnRXeD4u CgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvSmF2YVNjcmlwdENvcmUv Q2hhbmdlTG9nCmluZGV4IGU2YjdmZDcuLjk4ZGQ0ZDIgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZworKysgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwy MiBAQAorMjAwOS0wMS0yNyAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCisg ICAgICAgIEJ1ZyAyMzQ5MDogUmVtb3ZlIGluaXRpYWxSZWZDb3VudCBhcmd1bWVudCBmcm9tIFJl ZkNvdW50ZWQgY2xhc3MKKworICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIzNDkwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFJlZkNvdW50ZWRCYXNlIG5vdyBhbHdheXMgc3RhcnRzIHdpdGggYSByZWYgY291 bnQgb2YgMSwgc28gdGhlcmUKKyAgICAgICAgaXMgbm8gbmVlZCB0byBwYXNzIHRoZSBpbml0aWFs UmVmQ291bnQgaW50byB0aGUgY2xhc3MgYW55bW9yZS4KKworICAgICAgICAqIHd0Zi9CeXRlQXJy YXkuaDoKKyAgICAgICAgKFdURjo6Qnl0ZUFycmF5OjpCeXRlQXJyYXkpOiBSZW1vdmVkIGNhbGwg dG8gUmVmQ291bnRlZCgxKS4KKyAgICAgICAgKiB3dGYvUmVmQ291bnRlZC5oOgorICAgICAgICAo V1RGOjpSZWZDb3VudGVkQmFzZTo6UmVmQ291bnRlZEJhc2UpOiBDaGFuZ2VkIHRvIHN0YXJ0IHdp dGggYQorICAgICAgICByZWYgY291bnQgb2YgMS4KKyAgICAgICAgKFdURjo6UmVmQ291bnRlZDo6 UmVmQ291bnRlZCk6IFJlbW92ZWQgaW5pdGlhbFJlZkNvdW50IGFyZ3VtZW50CisgICAgICAgIGFu ZCByZW1vdmVkIGNhbGwgdG8gUmVmQ291bnRlZCgxKS4KKwogMjAwOS0wMS0yNiAgQWRlbGUgUGV0 ZXJzb24gIDxhZGVsZUBhcHBsZS5jb20+CiAKICAgICAgICAgQnVpbGQgZml4LiAgCmRpZmYgLS1n aXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvQnl0ZUFycmF5LmggYi9KYXZhU2NyaXB0Q29yZS93dGYv Qnl0ZUFycmF5LmgKaW5kZXggODY1YzMwZS4uMzNmMDg3NyAxMDA2NDQKLS0tIGEvSmF2YVNjcmlw dENvcmUvd3RmL0J5dGVBcnJheS5oCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi9CeXRlQXJyYXku aApAQCAtNjksOCArNjksNyBAQCBuYW1lc3BhY2UgV1RGIHsKIAogICAgIHByaXZhdGU6CiAgICAg ICAgIEJ5dGVBcnJheShzaXplX3Qgc2l6ZSkKLSAgICAgICAgICAgIDogUmVmQ291bnRlZEJhc2Uo MSkKLSAgICAgICAgICAgICwgbV9zaXplKHNpemUpCisgICAgICAgICAgICA6IG1fc2l6ZShzaXpl KQogICAgICAgICB7CiAgICAgICAgIH0KICAgICAgICAgc2l6ZV90IG1fc2l6ZTsKZGlmZiAtLWdp dCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9SZWZDb3VudGVkLmggYi9KYXZhU2NyaXB0Q29yZS93dGYv UmVmQ291bnRlZC5oCmluZGV4IGFjOGUxNjcuLjA1Nzc5YTMgMTAwNjQ0Ci0tLSBhL0phdmFTY3Jp cHRDb3JlL3d0Zi9SZWZDb3VudGVkLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL1JlZkNvdW50 ZWQuaApAQCAtNDksOCArNDksOCBAQCBwdWJsaWM6CiAgICAgfQogCiBwcm90ZWN0ZWQ6Ci0gICAg UmVmQ291bnRlZEJhc2UoaW50IGluaXRpYWxSZWZDb3VudCkKLSAgICAgICAgOiBtX3JlZkNvdW50 KGluaXRpYWxSZWZDb3VudCkKKyAgICBSZWZDb3VudGVkQmFzZSgpCisgICAgICAgIDogbV9yZWZD b3VudCgxKQogI2lmbmRlZiBOREVCVUcKICAgICAgICAgLCBtX2RlbGV0aW9uSGFzQmVndW4oZmFs c2UpCiAjZW5kaWYKQEAgLTg1LDggKzg1LDcgQEAgcHJvdGVjdGVkOgogCiB0ZW1wbGF0ZTxjbGFz cyBUPiBjbGFzcyBSZWZDb3VudGVkIDogcHVibGljIFJlZkNvdW50ZWRCYXNlIHsKIHB1YmxpYzoK LSAgICBSZWZDb3VudGVkKGludCBpbml0aWFsUmVmQ291bnQgPSAxKQotICAgICAgICA6IFJlZkNv dW50ZWRCYXNlKGluaXRpYWxSZWZDb3VudCkKKyAgICBSZWZDb3VudGVkKCkKICAgICB7CiAgICAg fQogCmRpZmYgLS1naXQgYS9XZWJLaXQvd3gvQ2hhbmdlTG9nIGIvV2ViS2l0L3d4L0NoYW5nZUxv ZwppbmRleCA3ZTEyNjEyLi5lMmU2NjkxIDEwMDY0NAotLS0gYS9XZWJLaXQvd3gvQ2hhbmdlTG9n CisrKyBiL1dlYktpdC93eC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0wMS0yNyAg RGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCisgICAgICAgIEJ1ZyAyMzQ5MDog UmVtb3ZlIGluaXRpYWxSZWZDb3VudCBhcmd1bWVudCBmcm9tIFJlZkNvdW50ZWQgY2xhc3MKKwor ICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDkwPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZyYW1lTG9h ZGVyQ2xpZW50V3ggaXMgbm8gbG9uZ2VyIGEgUmVmQ291bnRlZCBjbGFzcy4KKworICAgICAgICAq IFdlYktpdFN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRXeC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpGcmFtZUxvYWRlckNsaWVudFd4OjpGcmFtZUxvYWRlckNsaWVudFd4KTogUmVtb3ZlZCBjYWxs CisgICAgICAgIHRvIHRoZSBSZWZDb3VudGVkPEZyYW1lTG9hZGVyQ2xpZW50V3g+KDApIHN1cGVy IGNvbnN0cnVjdG9yLgorICAgICAgICAqIFdlYktpdFN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRX eC5oOiBEb24ndCBpbmNsdWRlIFJlZkNvdW50ZWQuaAorICAgICAgICBhbmQgc3RvcCBpbmhlcml0 aW5nIGZyb20gUmVmQ291bnRlZDxGcmFtZUxvYWRlckNsaWVudFd4Pi4KKwogMjAwOS0wMS0yMyAg S2V2aW4gT2xsaXZpZXIgIDxrZXZpbm9AdGhlb2xsaXZpZXJzLmNvbT4KIAogICAgICAgICB3eCBi dWlsZCBmaXgsIGFkZCBtaXNzaW5nIGluY2x1ZGUgZGlyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3d4 L1dlYktpdFN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRXeC5jcHAgYi9XZWJLaXQvd3gvV2ViS2l0 U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFd4LmNwcAppbmRleCAzOGY5YTFkLi45Mjc2ZTRlIDEw MDY0NAotLS0gYS9XZWJLaXQvd3gvV2ViS2l0U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFd4LmNw cAorKysgYi9XZWJLaXQvd3gvV2ViS2l0U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFd4LmNwcApA QCAtNzAsOCArNzAsNyBAQCBpbmxpbmUgaW50IHd4TmF2VHlwZUZyb21XZWJOYXZUeXBlKE5hdmln YXRpb25UeXBlIHR5cGUpewogfQogCiBGcmFtZUxvYWRlckNsaWVudFd4OjpGcmFtZUxvYWRlckNs aWVudFd4KCkKLSAgICA6IFJlZkNvdW50ZWQ8RnJhbWVMb2FkZXJDbGllbnRXeD4oMCkKLSAgICAs IG1fZnJhbWUoMCkKKyAgICA6IG1fZnJhbWUoMCkKIHsKIH0KIApkaWZmIC0tZ2l0IGEvV2ViS2l0 L3d4L1dlYktpdFN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRXeC5oIGIvV2ViS2l0L3d4L1dlYktp dFN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRXeC5oCmluZGV4IGM4MTExNTUuLjYzN2E2OWIgMTAw NjQ0Ci0tLSBhL1dlYktpdC93eC9XZWJLaXRTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50V3guaAor KysgYi9XZWJLaXQvd3gvV2ViS2l0U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFd4LmgKQEAgLTMx LDcgKzMxLDYgQEAKICNpbmNsdWRlICJGcmFtZUxvYWRlckNsaWVudC5oIgogI2luY2x1ZGUgIkZy YW1lTG9hZGVyLmgiCiAjaW5jbHVkZSAiS1VSTC5oIgotI2luY2x1ZGUgIlJlZkNvdW50ZWQuaCIK ICNpbmNsdWRlICJSZXNvdXJjZVJlc3BvbnNlLmgiCiAKIGNsYXNzIHd4V2ViVmlldzsKQEAgLTQ4 LDcgKzQ3LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgc3RydWN0IExvYWRFcnJvclJl c2V0VG9rZW47CiAKLSAgICBjbGFzcyBGcmFtZUxvYWRlckNsaWVudFd4IDogcHVibGljIEZyYW1l TG9hZGVyQ2xpZW50LCBwdWJsaWMgUmVmQ291bnRlZDxGcmFtZUxvYWRlckNsaWVudFd4PiB7Cisg ICAgY2xhc3MgRnJhbWVMb2FkZXJDbGllbnRXeCA6IHB1YmxpYyBGcmFtZUxvYWRlckNsaWVudCB7 CiAgICAgcHVibGljOgogICAgICAgICBGcmFtZUxvYWRlckNsaWVudFd4KCk7CiAgICAgICAgIH5G cmFtZUxvYWRlckNsaWVudFd4KCk7Cg==