234884 2022-01-05 08:28:11 -0800 ServiceWorkerNavigationPreloader::didComplete should make sure to call its bodyCallback 2022-01-06 02:24:57 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen cdumez webkit-bug-importer oldest_to_newest 1828287 0 youennf 2022-01-05 08:28:11 -0800 ServiceWorkerNavigationPreloader::didComplete should make sure to call its bodyCallback 1828289 1 webkit-bug-importer 2022-01-05 08:30:55 -0800 <rdar://problem/87146589> 1828290 2 448391 youennf 2022-01-05 08:33:05 -0800 Created attachment 448391 Patch 1828345 3 448391 achristensen 2022-01-05 11:43:58 -0800 Comment on attachment 448391 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448391&action=review > Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.cpp:207 > + // After that point, |this| might be destroyed. which point? "After calling responseCallback, |this| may be destroyed." 1828521 4 448470 youennf 2022-01-06 01:27:31 -0800 Created attachment 448470 Patch for landing 1828533 5 ews-feeder 2022-01-06 02:24:53 -0800 Committed r287676 (245773@main): <https://commits.webkit.org/245773@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448470. 448391 2022-01-05 08:33:05 -0800 2022-01-06 01:27:27 -0800 Patch bug-234884-20220105173304.patch text/plain 1987 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdmYTU2NDFiNWRlYjM1YTg2 MGNhMDlmYjQ5YmI3OTVmNjY1Y2M1MjAuLmFhNGM1ZDZlYTAwY2Q3ZjgxMTlkNzU3Yzc2NzRlZjE1 ODIwYjhlODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjItMDEtMDUgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFNlcnZpY2VXb3JrZXJOYXZpZ2F0 aW9uUHJlbG9hZGVyOjpkaWRDb21wbGV0ZSBzaG91bGQgbWFrZSBzdXJlIHRvIGNhbGwgaXRzIGJv ZHlDYWxsYmFjaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjM0ODg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNz L1NlcnZpY2VXb3JrZXIvU2VydmljZVdvcmtlck5hdmlnYXRpb25QcmVsb2FkZXIuY3BwOgorICAg ICAgICBDYWxsIHRvIHJlc3BvbnNlQ2FsbGJhY2sgbWF5IGRlc3Ryb3kgdGhlIFNlcnZpY2VXb3Jr ZXJOYXZpZ2F0aW9uUHJlbG9hZGVyLgorICAgICAgICBUbyBtYWtlIHN1cmUgdG8gY2FsbCBpdHMg Ym9keUNhbGxiYWNrLCB3ZSBtb3ZlIGl0IGluIHRoZSBzdGFjayBiZWZvcmUgY2FsbGluZyByZXNw b25zZUNhbGxiYWNrLgorCiAyMDIyLTAxLTA1ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxl LmNvbT4KIAogICAgICAgICBFbmFibGUgV2ViUlRDIGZvciBNYWMgQ2F0YWx5c3QKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvU2VydmljZVdvcmtlci9TZXJ2aWNlV29y a2VyTmF2aWdhdGlvblByZWxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNz L1NlcnZpY2VXb3JrZXIvU2VydmljZVdvcmtlck5hdmlnYXRpb25QcmVsb2FkZXIuY3BwCmluZGV4 IDVkOWJkMzMzMzkyMTFjYTFjZDQ0N2I4NzkyZjU0NjFlYTg3ZWRkZjQuLjIyMTdlMTJmZDA5ODYy MmFlZGM2ZmQ5ZmFmNGY2Yzg1NTBlZDBhNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0 d29ya1Byb2Nlc3MvU2VydmljZVdvcmtlci9TZXJ2aWNlV29ya2VyTmF2aWdhdGlvblByZWxvYWRl ci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9TZXJ2aWNlV29ya2VyL1Nl cnZpY2VXb3JrZXJOYXZpZ2F0aW9uUHJlbG9hZGVyLmNwcApAQCAtMjAxLDExICsyMDEsMTUgQEAg dm9pZCBTZXJ2aWNlV29ya2VyTmF2aWdhdGlvblByZWxvYWRlcjo6ZGlkQ29tcGxldGUoKQogewog ICAgIG1fbmV0d29ya0xvYWQgPSBudWxscHRyOwogCi0gICAgaWYgKGF1dG8gY2FsbGJhY2sgPSBz dGQ6OmV4Y2hhbmdlKG1fcmVzcG9uc2VDYWxsYmFjaywgeyB9KSkKLSAgICAgICAgY2FsbGJhY2so KTsKKyAgICBhdXRvIHJlc3BvbnNlQ2FsbGJhY2sgPSBzdGQ6OmV4Y2hhbmdlKG1fcmVzcG9uc2VD YWxsYmFjaywgeyB9KTsKKyAgICBhdXRvIGJvZHlDYWxsYmFjayA9IHN0ZDo6ZXhjaGFuZ2UobV9i b2R5Q2FsbGJhY2ssIHsgfSk7CiAKLSAgICBpZiAobV9ib2R5Q2FsbGJhY2spCi0gICAgICAgIG1f Ym9keUNhbGxiYWNrKHsgfSwgMCk7CisgICAgLy8gQWZ0ZXIgdGhhdCBwb2ludCwgfHRoaXN8IG1p Z2h0IGJlIGRlc3Ryb3llZC4KKyAgICBpZiAocmVzcG9uc2VDYWxsYmFjaykKKyAgICAgICAgcmVz cG9uc2VDYWxsYmFjaygpOworCisgICAgaWYgKGJvZHlDYWxsYmFjaykKKyAgICAgICAgYm9keUNh bGxiYWNrKHsgfSwgMCk7CiB9CiAKIHZvaWQgU2VydmljZVdvcmtlck5hdmlnYXRpb25QcmVsb2Fk ZXI6OndhaXRGb3JSZXNwb25zZShSZXNwb25zZUNhbGxiYWNrJiYgY2FsbGJhY2spCg== 448470 2022-01-06 01:27:31 -0800 2022-01-06 02:24:55 -0800 Patch for landing bug-234884-20220106102730.patch text/plain 2019 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdmYTU2NDFiNWRlYjM1YTg2 MGNhMDlmYjQ5YmI3OTVmNjY1Y2M1MjAuLmViZWQ0ZGQyMWZjN2U5YTM5M2NiYjhkNWEyMWFkZThm NzI0ZGEyNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjItMDEtMDUgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFNlcnZpY2VXb3JrZXJOYXZpZ2F0 aW9uUHJlbG9hZGVyOjpkaWRDb21wbGV0ZSBzaG91bGQgbWFrZSBzdXJlIHRvIGNhbGwgaXRzIGJv ZHlDYWxsYmFjaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjM0ODg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWxleCBDaHJpc3RlbnNlbi4KKworICAg ICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogTmV0d29ya1Byb2Nl c3MvU2VydmljZVdvcmtlci9TZXJ2aWNlV29ya2VyTmF2aWdhdGlvblByZWxvYWRlci5jcHA6Cisg ICAgICAgIENhbGwgdG8gcmVzcG9uc2VDYWxsYmFjayBtYXkgZGVzdHJveSB0aGUgU2VydmljZVdv cmtlck5hdmlnYXRpb25QcmVsb2FkZXIuCisgICAgICAgIFRvIG1ha2Ugc3VyZSB0byBjYWxsIGl0 cyBib2R5Q2FsbGJhY2ssIHdlIG1vdmUgaXQgaW4gdGhlIHN0YWNrIGJlZm9yZSBjYWxsaW5nIHJl c3BvbnNlQ2FsbGJhY2suCisKIDIwMjItMDEtMDUgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBw bGUuY29tPgogCiAgICAgICAgIEVuYWJsZSBXZWJSVEMgZm9yIE1hYyBDYXRhbHlzdApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9TZXJ2aWNlV29ya2VyL1NlcnZpY2VX b3JrZXJOYXZpZ2F0aW9uUHJlbG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvU2VydmljZVdvcmtlci9TZXJ2aWNlV29ya2VyTmF2aWdhdGlvblByZWxvYWRlci5jcHAKaW5k ZXggNWQ5YmQzMzMzOTIxMWNhMWNkNDQ3Yjg3OTJmNTQ2MWVhODdlZGRmNC4uZTRkOWFjZGRiNGI2 OGYzYTg5NmI5NTkxYTE2MGRlYzI3Y2Y1NWU0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9TZXJ2aWNlV29ya2VyL1NlcnZpY2VXb3JrZXJOYXZpZ2F0aW9uUHJlbG9h ZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1NlcnZpY2VXb3JrZXIv U2VydmljZVdvcmtlck5hdmlnYXRpb25QcmVsb2FkZXIuY3BwCkBAIC0yMDEsMTEgKzIwMSwxNSBA QCB2b2lkIFNlcnZpY2VXb3JrZXJOYXZpZ2F0aW9uUHJlbG9hZGVyOjpkaWRDb21wbGV0ZSgpCiB7 CiAgICAgbV9uZXR3b3JrTG9hZCA9IG51bGxwdHI7CiAKLSAgICBpZiAoYXV0byBjYWxsYmFjayA9 IHN0ZDo6ZXhjaGFuZ2UobV9yZXNwb25zZUNhbGxiYWNrLCB7IH0pKQotICAgICAgICBjYWxsYmFj aygpOworICAgIGF1dG8gcmVzcG9uc2VDYWxsYmFjayA9IHN0ZDo6ZXhjaGFuZ2UobV9yZXNwb25z ZUNhbGxiYWNrLCB7IH0pOworICAgIGF1dG8gYm9keUNhbGxiYWNrID0gc3RkOjpleGNoYW5nZSht X2JvZHlDYWxsYmFjaywgeyB9KTsKIAotICAgIGlmIChtX2JvZHlDYWxsYmFjaykKLSAgICAgICAg bV9ib2R5Q2FsbGJhY2soeyB9LCAwKTsKKyAgICAvLyBBZnRlciBjYWxsaW5nIHJlc3BvbnNlQ2Fs bGJhY2sgb3IgYm9keUNhbGxiYWNrLCB8dGhpc3wgbWlnaHQgYmUgZGVzdHJveWVkLgorICAgIGlm IChyZXNwb25zZUNhbGxiYWNrKQorICAgICAgICByZXNwb25zZUNhbGxiYWNrKCk7CisKKyAgICBp ZiAoYm9keUNhbGxiYWNrKQorICAgICAgICBib2R5Q2FsbGJhY2soeyB9LCAwKTsKIH0KIAogdm9p ZCBTZXJ2aWNlV29ya2VyTmF2aWdhdGlvblByZWxvYWRlcjo6d2FpdEZvclJlc3BvbnNlKFJlc3Bv bnNlQ2FsbGJhY2smJiBjYWxsYmFjaykK