234870 2022-01-04 22:38:14 -0800 [Win][DumpRenderTree] dumpHistoryItem leaks a SafeArray 2022-01-05 00:04:31 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii darin don.olmstead fujii pvollan ross.kirsling webkit-bug-importer oldest_to_newest 1828185 0 fujii 2022-01-04 22:38:14 -0800 [Win][DumpRenderTree] dumpHistoryItem leaks a SafeArray r23462 added the following code. > if (arrPtr && SUCCEEDED(::SafeArrayUnlock(arrPtr))) > ::SafeArrayDestroy(arrPtr); However, the array isn't locked. Thus, SafeArrayUnlock fails. SafeArrayDestroy isn't called. 1828186 1 fujii 2022-01-04 22:42:50 -0800 r23321 added the code. 1828187 2 448360 fujii 2022-01-04 22:52:20 -0800 Created attachment 448360 Patch 1828200 3 ews-feeder 2022-01-05 00:03:55 -0800 Committed r287605 (245732@main): <https://commits.webkit.org/245732@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448360. 1828201 4 webkit-bug-importer 2022-01-05 00:04:31 -0800 <rdar://problem/87133401> 448360 2022-01-04 22:52:20 -0800 2022-01-05 00:03:56 -0800 Patch bug-234870-20220105155219.patch text/plain 2016 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NjAwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDI3N2I3ZmU0NDFmOWUyNjA3YmIxYWE0NzBhM2M2NTVh ZTMyYTQzZC4uOWEyNTQyMTE4NDQwNzU1Y2E3MzYxMjYzYTgxMTUyNDBhOTJkNThmZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIyLTAxLTA0ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5dW0R1bXBSZW5kZXJUcmVlXSBkdW1wSGlzdG9yeUl0ZW0gbGVha3Mg YSBTYWZlQXJyYXkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIzNDg3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIHIyMzQ2MiBhZGRlZCB0aGUgZm9sbG93aW5nIGNvZGUuCisgICAgICAgID4gaWYgKGFyclB0 ciAmJiBTVUNDRUVERUQoOjpTYWZlQXJyYXlVbmxvY2soYXJyUHRyKSkpCisgICAgICAgID4gICAg IDo6U2FmZUFycmF5RGVzdHJveShhcnJQdHIpOworICAgICAgICBIb3dldmVyLCB0aGUgYXJyYXkg d2Fzbid0IGxvY2tlZC4gU2FmZUFycmF5VW5sb2NrIGFsd2F5cyBmYWlsZWQuCisgICAgICAgIFRo dXMsIFNhZmVBcnJheURlc3Ryb3kgd2Fzbid0IGNhbGxlZC4KKworICAgICAgICAqIER1bXBSZW5k ZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHA6CisgICAgICAgIChkdW1wSGlzdG9yeUl0ZW0p OiBEb24ndCB1c2UgU2FmZUFycmF5VW5sb2NrLiBGaXhlZCBhIHR5cG8gJ2FycmFyeScuCisKIDIw MjItMDEtMDQgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyODczNzQuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVu ZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvd2lu L0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCA5ZTBkNTRlZGQxNWM0NzU3ZGU0MTI4MGRlZTQyOWM3 NmI3YmJhODQ5Li5jODkzYjIzMjYwODNlN2MxMGU1YTg2MWE5ZDgxMzEzYjI4MmNhMGRiIDEwMDY0 NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwCisrKyBi L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTU5NCwxNSAr NTk0LDExIEBAIHN0YXRpYyB2b2lkIGR1bXBIaXN0b3J5SXRlbShJV2ViSGlzdG9yeUl0ZW0qIGl0 ZW0sIGludCBpbmRlbnQsIGJvb2wgY3VycmVudCkKICAgICBmcHV0YygnXG4nLCB0ZXN0UmVzdWx0 KTsKIAogICAgIHVuc2lnbmVkIGtpZHNDb3VudDsKLSAgICBTQUZFQVJSQVkqIGFycmFyeVB0cjsK LSAgICBpZiAoRkFJTEVEKGl0ZW1Qcml2YXRlLT5jaGlsZHJlbigma2lkc0NvdW50LCAmYXJyYXJ5 UHRyKSkgfHwgIWtpZHNDb3VudCkKKyAgICBTQUZFQVJSQVkqIGFycmF5UHRyOworICAgIGlmIChG QUlMRUQoaXRlbVByaXZhdGUtPmNoaWxkcmVuKCZraWRzQ291bnQsICZhcnJheVB0cikpIHx8ICFr aWRzQ291bnQpCiAgICAgICAgIHJldHVybjsKIAotICAgIGF1dG8gZGVsZXRlciA9IFtdKFNBRkVB UlJBWSogYXJyYXJ5UHRyKSB7Ci0gICAgICAgIGlmIChhcnJhcnlQdHIgJiYgU1VDQ0VFREVEKDo6 U2FmZUFycmF5VW5sb2NrKGFycmFyeVB0cikpKQotICAgICAgICAgICAgOjpTYWZlQXJyYXlEZXN0 cm95KGFycmFyeVB0cik7Ci0gICAgfTsKLSAgICBzdGQ6OnVuaXF1ZV9wdHI8U0FGRUFSUkFZLCBk ZWNsdHlwZShkZWxldGVyKT4gYXJyYXkoYXJyYXJ5UHRyLCBkZWxldGVyKTsKKyAgICBzdGQ6OnVu aXF1ZV9wdHI8U0FGRUFSUkFZLCBkZWNsdHlwZSgmOjpTYWZlQXJyYXlEZXN0cm95KT4gYXJyYXko YXJyYXlQdHIsIDo6U2FmZUFycmF5RGVzdHJveSk7CiAKICAgICBWZWN0b3I8Q09NUHRyPElVbmtu b3duPiA+IGtpZHNWZWN0b3I7CiAK