23486 2009-01-22 16:58:31 -0800 WebKit execCommand bold/italic should remove strong/em tags (since IE inserts them) 2009-02-04 11:44:51 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric jparent justin.garcia ojan oldest_to_newest 106663 0 eric 2009-01-22 16:58:31 -0800 WebKit execCommand bold/italic should remove strong/em tags (since IE inserts them) Our current behavior can be seen here: http://trac.webkit.org/browser/trunk/LayoutTests/editing/execCommand/toggle-styles-expected.txt?rev=40139 FAIL italic removing em -- <em><span class="Apple-style-span" style="font-style: normal;">test</span></em> The problem is that IE inserts <em> for the "italic" execCommand and <strong> for the "bold" command. So we should remove them if we want to interoperate nicely. FF3 does not remove either of these tags. Ojan has strongly recommended that we diverge from FF here and remove the tags just like we currently remove <b> and <i>. 106665 1 26948 eric 2009-01-22 17:34:49 -0800 Created attachment 26948 Remove <strong>/<em> when toggling bold/italic to match IE (not FF) LayoutTests/ChangeLog | 9 +++++++++ .../editing/execCommand/toggle-styles-expected.txt | 4 ++-- WebCore/ChangeLog | 12 ++++++++++++ WebCore/editing/ApplyStyleCommand.cpp | 6 ++++-- 4 files changed, 27 insertions(+), 4 deletions(-) 106666 2 oliver 2009-01-22 17:48:41 -0800 Why do we want to diverge from ffx? "<insert name here> recommends" is not valid justification 106668 3 eric 2009-01-22 18:02:01 -0800 Actually, I didn't give the right information. FF's current behavior is clearly wrong IMO. So we're not really diverging. We're diverging from our old behavior, which if you're a semantic web lover, is possibly more "correct" than this new behavior... but less useful, and less IE-compatible. <strong>foo</strong> document.execCommand("bold") produces: WebKit trunk: <strong><span class="Apple-style-span" style="font-weight: normal;">test</span></strong> IE: test FF <strong>test</strong> // clearly wrong IMO after patch: test 106830 4 26948 darin 2009-01-23 17:54:14 -0800 Comment on attachment 26948 Remove <strong>/<em> when toggling bold/italic to match IE (not FF) Seems OK. r=me 108308 5 eric 2009-02-04 11:44:51 -0800 Landed. 26948 2009-01-22 17:34:49 -0800 2009-01-23 17:54:14 -0800 Remove <strong>/<em> when toggling bold/italic to match IE (not FF) Remove-strong-em-when-toggling-bold-italic-to-match-IE-not-FF-.patch text/plain 3536 eric ODM3YzY2MTY3YzZkMjQ5OWM1ZWRlMWIyNzMwMmY0ODkyNTA1NGYwNQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDg0MTlhZmMu LjgwZDg3NjAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNCBAQAogMjAwOS0wMS0yMiAgRXJpYyBTZWlkZWwg IDxlcmljQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUmVtb3ZlIDxzdHJvbmc+LzxlbT4gdGFncyB3aGVuIHRvZ2dsaW5nIGJvbGQv aXRhbGljIHNpbmNlIElFIGluc2VydHMgdGhlbSBpbnN0ZWFkIG9mIDxiPi88aT4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDg2CisKKyAgICAgICAg KiBlZGl0aW5nL2V4ZWNDb21tYW5kL3RvZ2dsZS1zdHlsZXMtZXhwZWN0ZWQudHh0OiBwYXNzIHR3 byBtb3JlIGNhc2VzIQorCisyMDA5LTAxLTIyICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9y Zz4KKwogICAgICAgICBSZXZpZXdlZCBieSBKdXN0aW4gR2FyY2lhLgogCiAgICAgICAgIFJlbW92 ZSA8c3Bhbj4gdHVyZHMgbGVmdCBieSBlZGl0aW5nIGNvbW1hbmRzCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3RvZ2dsZS1zdHlsZXMtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC90b2dnbGUtc3R5bGVzLWV4cGVjdGVkLnR4 dAppbmRleCAzODVmMjQ1Li41YzJlMjhmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9lZGl0aW5n L2V4ZWNDb21tYW5kL3RvZ2dsZS1zdHlsZXMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3Rz L2VkaXRpbmcvZXhlY0NvbW1hbmQvdG9nZ2xlLXN0eWxlcy1leHBlY3RlZC50eHQKQEAgLTcsMTEg KzcsMTEgQEAgUEFTUyBkb2N1bWVudC5jb21wYXRNb2RlIGlzICJCYWNrQ29tcGF0IgogUEFTUyBi b2xkIHRvZ2dsZQogUEFTUyBib2xkIHJlbW92aW5nIGIKIFBBU1MgYm9sZCByZW1vdmluZyBmb250 LXdlaWdodDogYm9sZAotRkFJTCBib2xkIHJlbW92aW5nIHN0cm9uZyAtLSA8c3Ryb25nPjxzcGFu IGNsYXNzPSJBcHBsZS1zdHlsZS1zcGFuIiBzdHlsZT0iZm9udC13ZWlnaHQ6IG5vcm1hbDsiPnRl c3Q8L3NwYW4+PC9zdHJvbmc+CitQQVNTIGJvbGQgcmVtb3Zpbmcgc3Ryb25nCiBQQVNTIGl0YWxp YyB0b2dnbGUKIFBBU1MgaXRhbGljIHJlbW92aW5nIGkKIFBBU1MgaXRhbGljIHJlbW92aW5nIGZv bnQtc3R5bGU6IGl0YWxpYwotRkFJTCBpdGFsaWMgcmVtb3ZpbmcgZW0gLS0gPGVtPjxzcGFuIGNs YXNzPSJBcHBsZS1zdHlsZS1zcGFuIiBzdHlsZT0iZm9udC1zdHlsZTogbm9ybWFsOyI+dGVzdDwv c3Bhbj48L2VtPgorUEFTUyBpdGFsaWMgcmVtb3ZpbmcgZW0KIFBBU1Mgc3Vic2NyaXB0IHRvZ2ds ZQogUEFTUyBzdWJzY3JpcHQgcmVtb3Zpbmcgc3ViCiBQQVNTIHN1YnNjcmlwdCByZW1vdmluZyB2 ZXJ0aWNhbC1hbGlnbjogc3ViCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNv cmUvQ2hhbmdlTG9nCmluZGV4IDdjOGVmZjMuLjE2OGIzNTMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMDkt MDEtMjIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSA8c3Ryb25nPi88ZW0+IHRhZ3Mg d2hlbiB0b2dnbGluZyBib2xkL2l0YWxpYyBzaW5jZSBJRSBpbnNlcnRzIHRoZW0gaW5zdGVhZCBv ZiA8Yj4vPGk+CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzQ4NgorCisgICAgICAgIFRlc3Q6IGVkaXRpbmcvZXhlY0NvbW1hbmQvdG9nZ2xlLXN0eWxl cy5odG1sCisKKyAgICAgICAgKiBlZGl0aW5nL0FwcGx5U3R5bGVDb21tYW5kLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkFwcGx5U3R5bGVDb21tYW5kOjppc0hUTUxTdHlsZU5vZGUpOgorCisyMDA5 LTAxLTIyICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKwogICAgICAgICBSZXZpZXdl ZCBieSBKdXN0aW4gR2FyY2lhLgogCiAgICAgICAgIFJlbW92ZSA8c3Bhbj4gdHVyZHMgbGVmdCBi eSBlZGl0aW5nIGNvbW1hbmRzCmRpZmYgLS1naXQgYS9XZWJDb3JlL2VkaXRpbmcvQXBwbHlTdHls ZUNvbW1hbmQuY3BwIGIvV2ViQ29yZS9lZGl0aW5nL0FwcGx5U3R5bGVDb21tYW5kLmNwcAppbmRl eCBlY2EyOTk5Li43YmY3ODk5IDEwMDY0NAotLS0gYS9XZWJDb3JlL2VkaXRpbmcvQXBwbHlTdHls ZUNvbW1hbmQuY3BwCisrKyBiL1dlYkNvcmUvZWRpdGluZy9BcHBseVN0eWxlQ29tbWFuZC5jcHAK QEAgLTk1OCw3ICs5NTgsOCBAQCBib29sIEFwcGx5U3R5bGVDb21tYW5kOjppc0hUTUxTdHlsZU5v ZGUoQ1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24qIHN0eWxlLCBIVE1MRQogICAgIGZvciAoQ1NT TXV0YWJsZVN0eWxlRGVjbGFyYXRpb246OmNvbnN0X2l0ZXJhdG9yIGl0ID0gc3R5bGUtPmJlZ2lu KCk7IGl0ICE9IGVuZDsgKytpdCkgewogICAgICAgICBzd2l0Y2ggKCgqaXQpLmlkKCkpIHsKICAg ICAgICAgY2FzZSBDU1NQcm9wZXJ0eUZvbnRXZWlnaHQ6Ci0gICAgICAgICAgICBpZiAoZWxlbS0+ aGFzTG9jYWxOYW1lKGJUYWcpKQorICAgICAgICAgICAgLy8gSUUgaW5zZXJ0cyAic3Ryb25nIiB0 YWdzIGZvciBleGVjQ29tbWFuZCgiYm9sZCIpLCBzbyB3ZSByZW1vdmUgdGhlbSwgZXZlbiB0aG91 Z2ggdGhleSdyZSBub3Qgc3RyaWN0bHkgcHJlc2VudGF0aW9uYWwKKyAgICAgICAgICAgIGlmIChl bGVtLT5oYXNMb2NhbE5hbWUoYlRhZykgfHwgZWxlbS0+aGFzTG9jYWxOYW1lKHN0cm9uZ1RhZykp CiAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgY2FzZSBDU1NQcm9wZXJ0eVZlcnRpY2FsQWxpZ246CkBAIC05NjYsNyArOTY3LDggQEAgYm9v bCBBcHBseVN0eWxlQ29tbWFuZDo6aXNIVE1MU3R5bGVOb2RlKENTU011dGFibGVTdHlsZURlY2xh cmF0aW9uKiBzdHlsZSwgSFRNTEUKICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIENTU1Byb3BlcnR5Rm9udFN0eWxlOgotICAgICAg ICAgICAgaWYgKGVsZW0tPmhhc0xvY2FsTmFtZShpVGFnKSkKKyAgICAgICAgICAgIC8vIElFIGlu c2VydHMgImVtIiB0YWdzIGZvciBleGVjQ29tbWFuZCgiaXRhbGljIiksIHNvIHdlIHJlbW92ZSB0 aGVtLCBldmVuIHRob3VnaCB0aGV5J3JlIG5vdCBzdHJpY3RseSBwcmVzZW50YXRpb25hbAorICAg ICAgICAgICAgaWYgKGVsZW0tPmhhc0xvY2FsTmFtZShpVGFnKSB8fCBlbGVtLT5oYXNMb2NhbE5h bWUoZW1UYWcpKQogICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICB9CiAgICAg fQo=