234835 2022-01-04 00:41:05 -0800 [GTK][a11y] Use invalid as role for detached objects in ATSPI 2022-01-04 07:09:50 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 230253 1 cgarcia webkit-unassigned aboxhall andresg_22 apinheiro bugs-noreply cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white oldest_to_newest 1827872 0 cgarcia 2022-01-04 00:41:05 -0800 We are using unknown by mistake. 1827873 1 448269 cgarcia 2022-01-04 00:42:38 -0800 Created attachment 448269 Patch 1827927 2 448269 jdiggs 2022-01-04 06:59:13 -0800 Comment on attachment 448269 Patch r+ but with a question: Is there any way to know what the role of the detached object used to be? (if nothing else as a TODO for the future). FWIW, INVALID and UNKNOWN have the same degree of usefulness (read "none whatsoever") to Orca. Knowing the role of something in the process of being destroyed improves the likelihood that Orca can recover / clean up stored state, etc. 1827929 3 cgarcia 2022-01-04 07:07:26 -0800 (In reply to Joanmarie Diggs from comment #2) > Comment on attachment 448269 [details] > Patch > > r+ but with a question: Is there any way to know what the role of the > detached object used to be? (if nothing else as a TODO for the future). I don't think so, we have layout tests to check the role of a detached object is invalid. > FWIW, INVALID and UNKNOWN have the same degree of usefulness (read "none > whatsoever") to Orca. Knowing the role of something in the process of being > destroyed improves the likelihood that Orca can recover / clean up stored > state, etc. Invalid is what layout tests expect and what atk uses. 1827930 4 cgarcia 2022-01-04 07:09:50 -0800 Committed r287564 (245699@trunk): <https://commits.webkit.org/245699@trunk> 448269 2022-01-04 00:42:38 -0800 2022-01-04 06:59:13 -0800 Patch wcore-atspi-detached-role.diff text/plain 1318 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxMDI4ZjAxNDcxYjIuLmZmZDgxOTVjYTlmOSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDIyLTAxLTA0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVthMTF5XSBVc2UgaW52YWxpZCBhcyByb2xlIGZv ciBkZXRhY2hlZCBvYmplY3RzIGluIEFUU1BJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQ4MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZSBhcmUgdXNpbmcgdW5rbm93biBieSBtaXN0YWtlLgorCisg ICAgICAgICogYWNjZXNzaWJpbGl0eS9hdHNwaS9BY2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGkuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU9iamVjdEF0c3BpOjpyb2xlIGNvbnN0 KToKKwogMjAyMi0wMS0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0dUS11bYTExeV0gRW5zdXJlIEFUU1BJIHdyYXBwZXJzIGFyZSBkZXN0 cm95ZWQgaW4gdGhlIG1haW4gdGhyZWFkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L2F0c3BpL0FjY2Vzc2liaWxpdHlPYmplY3RBdHNwaS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L2F0c3BpL0FjY2Vzc2liaWxpdHlPYmplY3RBdHNwaS5jcHAKaW5k ZXggMmNkMzY5ZGNlNjUyLi4yMTYxZWUyZDU5YmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvYXRzcGkvQWNjZXNzaWJpbGl0eU9iamVjdEF0c3BpLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0c3BpL0FjY2Vzc2liaWxpdHlPYmplY3RBdHNw aS5jcHAKQEAgLTEzNzEsNyArMTM3MSw3IEBAIHVuc2lnbmVkIEFjY2Vzc2liaWxpdHlPYmplY3RB dHNwaTo6cm9sZSgpIGNvbnN0CiB7CiAgICAgUkVMRUFTRV9BU1NFUlQoIWlzTWFpblRocmVhZCgp KTsKICAgICBpZiAoIW1fYXhPYmplY3QpCi0gICAgICAgIHJldHVybiBBdHNwaTo6Um9sZTo6VW5r bm93bjsKKyAgICAgICAgcmV0dXJuIEF0c3BpOjpSb2xlOjpJbnZhbGlkUm9sZTsKIAogICAgIGlm IChhdXRvIGVmZmVjdGl2ZSA9IGVmZmVjdGl2ZVJvbGUoKSkKICAgICAgICAgcmV0dXJuICplZmZl Y3RpdmU7Cg==