234834 2022-01-03 19:20:09 -0800 [LFC][IFC] fast/text/combining-mark-paint.html is failing (complex text) 2022-01-04 15:07:21 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1827857 0 zalan 2022-01-03 19:20:09 -0800 ssia 1827858 1 448264 zalan 2022-01-03 19:34:43 -0800 Created attachment 448264 Patch 1827923 2 448264 koivisto 2022-01-04 06:28:18 -0800 Comment on attachment 448264 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448264&action=review > Source/WebCore/ChangeLog:8 > + Apparently it's perfectly valid to have zero width unicode character (e.g. macron) and French again :( > Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:105 > + && (!canUseSimpleFontCodePath || glyphData.font->widthForGlyph(glyphData.glyph))) Weird that this is code path specific rather than based which glyph it is. 1828044 3 448325 zalan 2022-01-04 12:39:41 -0800 Created attachment 448325 Patch 1828114 4 ews-feeder 2022-01-04 15:06:53 -0800 Committed r287591 (245720@main): <https://commits.webkit.org/245720@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448325. 1828115 5 webkit-bug-importer 2022-01-04 15:07:21 -0800 <rdar://problem/87116969> 448264 2022-01-03 19:34:43 -0800 2022-01-04 12:39:38 -0800 Patch bug-234834-20220103193442.patch text/plain 3985 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDA3ZTVmZDVmNzA1MzY1 MTNiNDI4OGVhNDc5MzU5MGM0ZjdmZTQ4MC4uNDZhZTUzMjU4ZTljYmE0ZmYxNTFiZGQ3OTNiNjc2 ODM4MmQwNzY4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAxLTAzICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbTEZDXVtJRkNdIGZhc3QvdGV4 dC9jb21iaW5pbmctbWFyay1wYWludC5odG1sIGlzIGZhaWxpbmcgKGNvbXBsZXggdGV4dCkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDgzNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFwcGFyZW50bHkg aXQncyBwZXJmZWN0bHkgdmFsaWQgdG8gaGF2ZSB6ZXJvIHdpZHRoIHVuaWNvZGUgY2hhcmFjdGVy IChlLmcuIG1hY3JvbikgYW5kCisgICAgICAgIHN0aWxsIGFmZmVjdCB0aGUgbGluZSBoZWlnaHQu CisKKyAgICAgICAgKiBsYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS90ZXh0L1RleHRV dGlsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6ZmFsbGJhY2tGb250c0ZvclJ1bldp dGhJdGVyYXRvcik6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OlRleHRVdGlsOjpmYWxsYmFj a0ZvbnRzRm9yUnVuKToKKwogMjAyMi0wMS0wMyAgQWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5j b20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBJbmNvcnJlY3Qgd29yZC1zcGFjaW5nIGdhcHMgd2hl biBsb2dpY2FsIG9yZGVyICE9IHZpc3VhbCBvcmRlciAoYmlkaSkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL3RleHQvVGV4dFV0aWwu Y3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvdGV4 dC9UZXh0VXRpbC5jcHAKaW5kZXggZTA0YTRkNjdkZTliMjY5MTNlNmVmNmY4OTdjZWM1Yzg5MzMy NzkxZC4uOGMxNDYxNzU0NDY5NjA0NTFjNmY3MjZmMTEwZjM1NjZjZmVkNzQ0NiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvdGV4dC9U ZXh0VXRpbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0 cy9pbmxpbmUvdGV4dC9UZXh0VXRpbC5jcHAKQEAgLTg2LDcgKzg2LDcgQEAgSW5saW5lTGF5b3V0 VW5pdCBUZXh0VXRpbDo6d2lkdGgoY29uc3QgSW5saW5lVGV4dEJveCYgaW5saW5lVGV4dEJveCwg Y29uc3QgRm9udEMKIH0KIAogdGVtcGxhdGUgPHR5cGVuYW1lIFRleHRJdGVyYXRvcj4KLXN0YXRp YyB2b2lkIGZhbGxiYWNrRm9udHNGb3JSdW5XaXRoSXRlcmF0b3IoSGFzaFNldDxjb25zdCBGb250 Kj4mIGZhbGxiYWNrRm9udHMsIGNvbnN0IEZvbnRDYXNjYWRlJiBmb250Q2FzY2FkZSwgY29uc3Qg VGV4dFJ1biYgcnVuLCBUZXh0SXRlcmF0b3ImIHRleHRJdGVyYXRvcikKK3N0YXRpYyB2b2lkIGZh bGxiYWNrRm9udHNGb3JSdW5XaXRoSXRlcmF0b3IoSGFzaFNldDxjb25zdCBGb250Kj4mIGZhbGxi YWNrRm9udHMsIGNvbnN0IEZvbnRDYXNjYWRlJiBmb250Q2FzY2FkZSwgY29uc3QgVGV4dFJ1biYg cnVuLCBib29sIGNhblVzZVNpbXBsZUZvbnRDb2RlUGF0aCwgVGV4dEl0ZXJhdG9yJiB0ZXh0SXRl cmF0b3IpCiB7CiAgICAgYXV0byBpc1JUTCA9IHJ1bi5ydGwoKTsKICAgICBhdXRvIGlzU21hbGxD YXBzID0gZm9udENhc2NhZGUuaXNTbWFsbENhcHMoKTsKQEAgLTEwMSw4ICsxMDEsOSBAQCBzdGF0 aWMgdm9pZCBmYWxsYmFja0ZvbnRzRm9yUnVuV2l0aEl0ZXJhdG9yKEhhc2hTZXQ8Y29uc3QgRm9u dCo+JiBmYWxsYmFja0ZvbnRzLAogICAgICAgICAgICAgICAgIGNoYXJhY3RlciA9IHVfdG91cHBl cihjaGFyYWN0ZXIpOwogCiAgICAgICAgICAgICBhdXRvIGdseXBoRGF0YSA9IGZvbnRDYXNjYWRl LmdseXBoRGF0YUZvckNoYXJhY3RlcihjaGFyYWN0ZXIsIGlzUlRMKTsKLSAgICAgICAgICAgIGlm IChnbHlwaERhdGEuZ2x5cGggJiYgZ2x5cGhEYXRhLmZvbnQgJiYgZ2x5cGhEYXRhLmZvbnQgIT0g JnByaW1hcnlGb250ICYmIGdseXBoRGF0YS5mb250LT53aWR0aEZvckdseXBoKGdseXBoRGF0YS5n bHlwaCkpCi0gICAgICAgICAgICAgICAgZmFsbGJhY2tGb250cy5hZGQoZ2x5cGhEYXRhLmZvbnQp OworICAgICAgICAgICAgaWYgKGdseXBoRGF0YS5nbHlwaCAmJiBnbHlwaERhdGEuZm9udCAmJiBn bHlwaERhdGEuZm9udCAhPSAmcHJpbWFyeUZvbnQKKyAgICAgICAgICAgICAgICAmJiAoIWNhblVz ZVNpbXBsZUZvbnRDb2RlUGF0aCB8fCBnbHlwaERhdGEuZm9udC0+d2lkdGhGb3JHbHlwaChnbHlw aERhdGEuZ2x5cGgpKSkKKyAgICAgICAgICAgICAgICAgICAgZmFsbGJhY2tGb250cy5hZGQoZ2x5 cGhEYXRhLmZvbnQpOwogICAgICAgICB9OwogICAgICAgICBhZGRGYWxsYmFja0ZvbnRGb3JDaGFy YWN0ZXJJZkFwcGxpY2FibGUoY3VycmVudENoYXJhY3Rlcik7CiAgICAgICAgIHRleHRJdGVyYXRv ci5hZHZhbmNlKGNsdXN0ZXJMZW5ndGgpOwpAQCAtMTE5LDYgKzEyMCw3IEBAIFRleHRVdGlsOjpG YWxsYmFja0ZvbnRMaXN0IFRleHRVdGlsOjpmYWxsYmFja0ZvbnRzRm9yUnVuKGNvbnN0IExpbmU6 OlJ1biYgcnVuLCBjCiAgICAgfQogCiAgICAgVGV4dFV0aWw6OkZhbGxiYWNrRm9udExpc3QgZmFs bGJhY2tGb250czsKKyAgICBhdXRvIGNhblVzZVNpbXBsZUZvbnRDb2RlUGF0aCA9IGRvd25jYXN0 PElubGluZVRleHRCb3g+KHJ1bi5sYXlvdXRCb3goKSkuY2FuVXNlU2ltcGxlRm9udENvZGVQYXRo KCk7CiAKICAgICBhdXRvIGNvbGxlY3RGYWxsYmFja0ZvbnRzID0gWyZdKGNvbnN0IGF1dG8mIHRl eHRSdW4pIHsKICAgICAgICAgaWYgKHRleHRSdW4udGV4dCgpLmlzRW1wdHkoKSkKQEAgLTEyNiwx MSArMTI4LDExIEBAIFRleHRVdGlsOjpGYWxsYmFja0ZvbnRMaXN0IFRleHRVdGlsOjpmYWxsYmFj a0ZvbnRzRm9yUnVuKGNvbnN0IExpbmU6OlJ1biYgcnVuLCBjCiAKICAgICAgICAgaWYgKHRleHRS dW4uaXM4Qml0KCkpIHsKICAgICAgICAgICAgIGF1dG8gdGV4dEl0ZXJhdG9yID0gTGF0aW4xVGV4 dEl0ZXJhdG9yIHsgdGV4dFJ1bi5kYXRhOCgwKSwgMCwgdGV4dFJ1bi5sZW5ndGgoKSwgdGV4dFJ1 bi5sZW5ndGgoKSB9OwotICAgICAgICAgICAgZmFsbGJhY2tGb250c0ZvclJ1bldpdGhJdGVyYXRv cihmYWxsYmFja0ZvbnRzLCBzdHlsZS5mb250Q2FzY2FkZSgpLCB0ZXh0UnVuLCB0ZXh0SXRlcmF0 b3IpOworICAgICAgICAgICAgZmFsbGJhY2tGb250c0ZvclJ1bldpdGhJdGVyYXRvcihmYWxsYmFj a0ZvbnRzLCBzdHlsZS5mb250Q2FzY2FkZSgpLCB0ZXh0UnVuLCBjYW5Vc2VTaW1wbGVGb250Q29k ZVBhdGgsIHRleHRJdGVyYXRvcik7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAg ICAgICAgYXV0byB0ZXh0SXRlcmF0b3IgPSBTdXJyb2dhdGVQYWlyQXdhcmVUZXh0SXRlcmF0b3Ig eyB0ZXh0UnVuLmRhdGExNigwKSwgMCwgdGV4dFJ1bi5sZW5ndGgoKSwgdGV4dFJ1bi5sZW5ndGgo KSB9OwotICAgICAgICBmYWxsYmFja0ZvbnRzRm9yUnVuV2l0aEl0ZXJhdG9yKGZhbGxiYWNrRm9u dHMsIHN0eWxlLmZvbnRDYXNjYWRlKCksIHRleHRSdW4sIHRleHRJdGVyYXRvcik7CisgICAgICAg IGZhbGxiYWNrRm9udHNGb3JSdW5XaXRoSXRlcmF0b3IoZmFsbGJhY2tGb250cywgc3R5bGUuZm9u dENhc2NhZGUoKSwgdGV4dFJ1biwgY2FuVXNlU2ltcGxlRm9udENvZGVQYXRoLCB0ZXh0SXRlcmF0 b3IpOwogICAgIH07CiAKICAgICBhdXRvIHRleHQgPSAqcnVuLnRleHRDb250ZW50KCk7Cg== 448325 2022-01-04 12:39:41 -0800 2022-01-04 15:06:55 -0800 Patch bug-234834-20220104123940.patch text/plain 2166 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTk5M2ZmNzU2NzM0MjY5 NjFkOWI2NjhhNmM3NTExNDY4MWE3YTM3Ni4uMzI2Yjc0NDkzYTkyNTk0ZmI1Mzk3YTc5NDRkMDU4 MWQ4NmRjYTczMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAxLTAzICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbTEZDXVtJRkNdIGZhc3QvdGV4 dC9jb21iaW5pbmctbWFyay1wYWludC5odG1sIGlzIGZhaWxpbmcgKGNvbXBsZXggdGV4dCkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDgzNAorCisg ICAgICAgIFJldmlld2VkIGJ5IEFudHRpIEtvaXZpc3RvLgorCisgICAgICAgIEFwcGFyZW50bHkg aXQncyBwZXJmZWN0bHkgdmFsaWQgdG8gaGF2ZSB6ZXJvIHdpZHRoIHVuaWNvZGUgY2hhcmFjdGVy IChlLmcuIG1hY3JvbikgYW5kCisgICAgICAgIHN0aWxsIGFmZmVjdCB0aGUgbGluZSBoZWlnaHQu CisKKyAgICAgICAgKiBsYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS90ZXh0L1RleHRV dGlsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6ZmFsbGJhY2tGb250c0ZvclJ1bldp dGhJdGVyYXRvcik6CisKIDIwMjItMDEtMDMgIEFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29t PgogCiAgICAgICAgIFtMRkNdW0lGQ10gSW5jb3JyZWN0IHdvcmQtc3BhY2luZyBnYXBzIHdoZW4g bG9naWNhbCBvcmRlciAhPSB2aXN1YWwgb3JkZXIgKGJpZGkpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS90ZXh0L1RleHRVdGlsLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL3RleHQv VGV4dFV0aWwuY3BwCmluZGV4IDA1NjUxOWRhYzk2YWVjZWRkNWViNmFhYjk4Yzc4MWE3ZmI2OTcw ZTIuLmIxMWNmYjEzNWFiOGFlNDMyMThhMDNhMjI0MGRlYzhjNzFmNDg3NzUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL3RleHQvVGV4 dFV0aWwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMv aW5saW5lL3RleHQvVGV4dFV0aWwuY3BwCkBAIC0xMDEsOCArMTAxLDExIEBAIHN0YXRpYyB2b2lk IGZhbGxiYWNrRm9udHNGb3JSdW5XaXRoSXRlcmF0b3IoSGFzaFNldDxjb25zdCBGb250Kj4mIGZh bGxiYWNrRm9udHMsCiAgICAgICAgICAgICAgICAgY2hhcmFjdGVyID0gdV90b3VwcGVyKGNoYXJh Y3Rlcik7CiAKICAgICAgICAgICAgIGF1dG8gZ2x5cGhEYXRhID0gZm9udENhc2NhZGUuZ2x5cGhE YXRhRm9yQ2hhcmFjdGVyKGNoYXJhY3RlciwgaXNSVEwpOwotICAgICAgICAgICAgaWYgKGdseXBo RGF0YS5nbHlwaCAmJiBnbHlwaERhdGEuZm9udCAmJiBnbHlwaERhdGEuZm9udCAhPSAmcHJpbWFy eUZvbnQgJiYgZ2x5cGhEYXRhLmZvbnQtPndpZHRoRm9yR2x5cGgoZ2x5cGhEYXRhLmdseXBoKSkK LSAgICAgICAgICAgICAgICBmYWxsYmFja0ZvbnRzLmFkZChnbHlwaERhdGEuZm9udCk7CisgICAg ICAgICAgICBpZiAoZ2x5cGhEYXRhLmdseXBoICYmIGdseXBoRGF0YS5mb250ICYmIGdseXBoRGF0 YS5mb250ICE9ICZwcmltYXJ5Rm9udCkgeworICAgICAgICAgICAgICAgIGF1dG8gaXNOb25TcGFj aW5nTWFyayA9IFVfTUFTSyh1X2NoYXJUeXBlKGNoYXJhY3RlcikpICYgVV9HQ19NTl9NQVNLOwor ICAgICAgICAgICAgICAgIGlmIChpc05vblNwYWNpbmdNYXJrIHx8IGdseXBoRGF0YS5mb250LT53 aWR0aEZvckdseXBoKGdseXBoRGF0YS5nbHlwaCkpCisgICAgICAgICAgICAgICAgICAgIGZhbGxi YWNrRm9udHMuYWRkKGdseXBoRGF0YS5mb250KTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfTsK ICAgICAgICAgYWRkRmFsbGJhY2tGb250Rm9yQ2hhcmFjdGVySWZBcHBsaWNhYmxlKGN1cnJlbnRD aGFyYWN0ZXIpOwogICAgICAgICB0ZXh0SXRlcmF0b3IuYWR2YW5jZShjbHVzdGVyTGVuZ3RoKTsK