234823 2022-01-03 08:40:17 -0800 [Web Animations] changing the timing of a transition such that it's finished should no longer have it marked as running 2022-01-12 12:38:59 -0800 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar, WebExposed P2 Normal --- 234829 235130 1 graouts graouts commit-queue darin dino graouts webkit-bug-importer oldest_to_newest 1827757 0 graouts 2022-01-03 08:40:17 -0800 [Web Animations] changing the effect of a transition should no longer have it marked as running 1827758 1 448244 graouts 2022-01-03 08:40:51 -0800 Created attachment 448244 Patch 1827759 2 448244 dino 2022-01-03 08:43:05 -0800 Comment on attachment 448244 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448244&action=review > Source/WebCore/animation/DeclarativeAnimation.cpp:242 > + auto effectChanged = effect() != newEffect; > + > + WebAnimation::setEffect(WTFMove(newEffect)); Why would you call setEffect if !effectChanged? 1827761 3 graouts 2022-01-03 08:44:49 -0800 (In reply to Dean Jackson from comment #2) > Comment on attachment 448244 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448244&action=review > > > Source/WebCore/animation/DeclarativeAnimation.cpp:242 > > + auto effectChanged = effect() != newEffect; > > + > > + WebAnimation::setEffect(WTFMove(newEffect)); > > Why would you call setEffect if !effectChanged? Yeah, I suppose we could return early here, but the idea was that it made no assumption as to what WebAnimation::setEffect() did with that value. 1827788 4 graouts 2022-01-03 10:49:37 -0800 Committed r287550 (245685@trunk): <https://commits.webkit.org/245685@trunk> 1827789 5 webkit-bug-importer 2022-01-03 10:50:22 -0800 <rdar://problem/87069661> 1827815 6 commit-queue 2022-01-03 13:45:07 -0800 Re-opened since this is blocked by bug 234829 1827822 7 448257 graouts 2022-01-03 14:25:33 -0800 Created attachment 448257 Patch 1827826 8 darin 2022-01-03 14:44:13 -0800 Where’s the explanation of why we had to revert? It says "caused a regression"? 1827829 9 graouts 2022-01-03 14:59:55 -0800 (In reply to Darin Adler from comment #8) > Where’s the explanation of why we had to revert? It says "caused a > regression"? This was due not knowing how to use webkitbot correctly on the slack channel. The reason the original patch was wrong was that it regressed another sub test in this WPT test. 1827952 10 ews-feeder 2022-01-04 08:12:30 -0800 Committed r287568 (245703@main): <https://commits.webkit.org/245703@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448257. 448244 2022-01-03 08:40:51 -0800 2022-01-03 14:25:30 -0800 Patch bug-234823-20220103174050.patch text/plain 5221 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDgyNTlkZjQ1ZWM3ODBl ZmVkOGVmNWU0M2RiMGM5YWExMWIxNDIxMy4uNjE2ZjdjYTIwYjkyZjJjMmVjY2M2M2RjZWNhZGU2 MjdkN2Y4YzRiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTAxLTAzICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgorCisgICAgICAgIFtXZWIgQW5pbWF0aW9u c10gY2hhbmdpbmcgdGhlIGVmZmVjdCBvZiBhIHRyYW5zaXRpb24gc2hvdWxkIG5vIGxvbmdlciBo YXZlIGl0IG1hcmtlZCBhcyBydW5uaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMzQ4MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGFuaW1hdGlvbi9EZWNsYXJhdGl2ZUFuaW1hdGlvbi5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpEZWNsYXJhdGl2ZUFuaW1hdGlvbjo6c2V0RWZmZWN0KToKKyAgICAg ICAgKiBhbmltYXRpb24vRGVjbGFyYXRpdmVBbmltYXRpb24uaDoKKyAgICAgICAgKiBhbmltYXRp b24vV2ViQW5pbWF0aW9uLmg6CisKIDIwMjItMDEtMDMgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRz QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVmYWN0b3IgY29kZSBjcmVhdGluZyBjc3MgdmFsdWVz IGFuZCBsaXN0cyBmb3IgYW5pbWF0aW9uIGFuZCB0cmFuc2l0aW9uIHByb3BlcnRpZXMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9EZWNsYXJhdGl2ZUFuaW1hdGlvbi5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vRGVjbGFyYXRpdmVBbmltYXRpb24uY3BwCmluZGV4 IDRhNGNjNzg0NTg0MGIxNGQ4MTY1M2M0ZjBhNGZmOGUxYjk4NzFlNGUuLjhiNjJjNjkwYzQ4NTMx N2U0NjRkMzk3MGQ3ZWFmODc3NDdmZjk4MDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Fu aW1hdGlvbi9EZWNsYXJhdGl2ZUFuaW1hdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYW5p bWF0aW9uL0RlY2xhcmF0aXZlQW5pbWF0aW9uLmNwcApAQCAtMjM1LDYgKzIzNSwxOCBAQCB2b2lk IERlY2xhcmF0aXZlQW5pbWF0aW9uOjpjYW5jZWxGcm9tU3R5bGUoKQogICAgIGRpc2Fzc29jaWF0 ZUZyb21Pd25pbmdFbGVtZW50KCk7CiB9CiAKK3ZvaWQgRGVjbGFyYXRpdmVBbmltYXRpb246OnNl dEVmZmVjdChSZWZQdHI8QW5pbWF0aW9uRWZmZWN0PiYmIG5ld0VmZmVjdCkKK3sKKyAgICBhdXRv IGVmZmVjdENoYW5nZWQgPSBlZmZlY3QoKSAhPSBuZXdFZmZlY3Q7CisKKyAgICBXZWJBbmltYXRp b246OnNldEVmZmVjdChXVEZNb3ZlKG5ld0VmZmVjdCkpOworCisgICAgaWYgKGVmZmVjdENoYW5n ZWQpIHsKKyAgICAgICAgaWYgKGF1dG8gc3R5bGVhYmxlID0gb3duaW5nRWxlbWVudCgpKQorICAg ICAgICAgICAgc3R5bGVhYmxlLT5yZW1vdmVEZWNsYXJhdGl2ZUFuaW1hdGlvbkZyb21MaXN0c0Zv ck93bmluZ0VsZW1lbnQoKnRoaXMpOworICAgIH0KK30KKwogQW5pbWF0aW9uRWZmZWN0UGhhc2Ug RGVjbGFyYXRpdmVBbmltYXRpb246OnBoYXNlV2l0aG91dEVmZmVjdCgpIGNvbnN0CiB7CiAgICAg Ly8gVGhpcyBzaG91bGRuJ3QgYmUgY2FsbGVkIGlmIHdlIGFjdHVhbGx5IGhhdmUgYW4gZWZmZWN0 LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0RlY2xhcmF0aXZlQW5pbWF0 aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vRGVjbGFyYXRpdmVBbmltYXRpb24uaApp bmRleCAxZmJhYjY3YTkzOGU5N2VkZTNiMTlhYTU1Yjg3M2EyNDI2Nzc1NjY2Li5kNzFhNTQwZjc2 ZDg4NjIxZWZiY2Q3ZWVlNDEwMWMxMmQ1NmM1OWZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9hbmltYXRpb24vRGVjbGFyYXRpdmVBbmltYXRpb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9h bmltYXRpb24vRGVjbGFyYXRpdmVBbmltYXRpb24uaApAQCAtNjQsNiArNjQsNyBAQCBwdWJsaWM6 CiAgICAgRXhjZXB0aW9uT3I8dm9pZD4gYmluZGluZ3NQYXVzZSgpIG92ZXJyaWRlOwogCiAgICAg dm9pZCBzZXRUaW1lbGluZShSZWZQdHI8QW5pbWF0aW9uVGltZWxpbmU+JiYpIGZpbmFsOworICAg IHZvaWQgc2V0RWZmZWN0KFJlZlB0cjxBbmltYXRpb25FZmZlY3Q+JiYpIGZpbmFsOwogICAgIHZv aWQgY2FuY2VsKCkgZmluYWw7CiAKICAgICB2b2lkIHRpY2soKSBvdmVycmlkZTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9XZWJBbmltYXRpb24uaCBiL1NvdXJjZS9XZWJD b3JlL2FuaW1hdGlvbi9XZWJBbmltYXRpb24uaAppbmRleCA0OGYwNWE5YjM5YzdmMGRkNTczMDUy NzBlMDQ5Y2JmOGFlY2M4NjMxLi4yZWJhMDY5YzAwYzVkMzIyZGY2Yjg1Mjg3Njg0NDAzNDBiZTYy YjgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vV2ViQW5pbWF0aW9uLmgK KysrIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL1dlYkFuaW1hdGlvbi5oCkBAIC03Myw3ICs3 Myw3IEBAIHB1YmxpYzoKICAgICBBbmltYXRpb25FZmZlY3QqIGJpbmRpbmdzRWZmZWN0KCkgY29u c3QgeyByZXR1cm4gZWZmZWN0KCk7IH0KICAgICB2aXJ0dWFsIHZvaWQgc2V0QmluZGluZ3NFZmZl Y3QoUmVmUHRyPEFuaW1hdGlvbkVmZmVjdD4mJik7CiAgICAgQW5pbWF0aW9uRWZmZWN0KiBlZmZl Y3QoKSBjb25zdCB7IHJldHVybiBtX2VmZmVjdC5nZXQoKTsgfQotICAgIHZvaWQgc2V0RWZmZWN0 KFJlZlB0cjxBbmltYXRpb25FZmZlY3Q+JiYpOworICAgIHZpcnR1YWwgdm9pZCBzZXRFZmZlY3Qo UmVmUHRyPEFuaW1hdGlvbkVmZmVjdD4mJik7CiAgICAgQW5pbWF0aW9uVGltZWxpbmUqIHRpbWVs aW5lKCkgY29uc3QgeyByZXR1cm4gbV90aW1lbGluZS5nZXQoKTsgfQogICAgIHZpcnR1YWwgdm9p ZCBzZXRUaW1lbGluZShSZWZQdHI8QW5pbWF0aW9uVGltZWxpbmU+JiYpOwogCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL0NoYW5nZUxvZwppbmRleCBhMjRjMjdmYWFmNTYzNTJhN2Q4ZDViMWRjMTdjZDBkYjgz NGMwZTY4Li5jODhmZjRiNWQxZWNiM2NjYzdlYTJmNjhkOTQ2ZjdmNDRkOTA3ZDI2IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMi0wMS0wMyAgQW50 b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9yZz4KKworICAgICAgICBbV2ViIEFuaW1hdGlv bnNdIGNoYW5naW5nIHRoZSBlZmZlY3Qgb2YgYSB0cmFuc2l0aW9uIHNob3VsZCBubyBsb25nZXIg aGF2ZSBpdCBtYXJrZWQgYXMgcnVubmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjM0ODIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTWFyayBXUFQgcHJvZ3Jlc3Npb24uCisKKyAgICAgICAgKiB3ZWIt cGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy10cmFuc2l0aW9ucy9DU1NUcmFuc2l0aW9uLWVmZmVjdC50 ZW50YXRpdmUtZXhwZWN0ZWQudHh0OgorCiAyMDIyLTAxLTAzICBBbnRvaW5lIFF1aW50ICA8Z3Jh b3V0c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFN1cHBvcnQgdGhlICJhbmltYXRpb24iIHNob3J0 aGFuZCBwcm9wZXJ0eSBpbiB0aGUgY29tcHV0ZWQgc3R5bGUKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy10cmFuc2l0aW9ucy9D U1NUcmFuc2l0aW9uLWVmZmVjdC50ZW50YXRpdmUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLXRyYW5zaXRpb25zL0NTU1Ry YW5zaXRpb24tZWZmZWN0LnRlbnRhdGl2ZS1leHBlY3RlZC50eHQKaW5kZXggNDI2MDU1OWYxODVk NWFkNGEzZWVjNTU3MzRkM2E1ZjI3ODZjMWUzNC4uZDc2ODg1YzcxNTRiMzY3MTkxNWU0OTI0ZDc5 OTY1MjFlOTI3ZTZhOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9jc3MvY3NzLXRyYW5zaXRpb25zL0NTU1RyYW5zaXRpb24tZWZmZWN0LnRl bnRhdGl2ZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9jc3MvY3NzLXRyYW5zaXRpb25zL0NTU1RyYW5zaXRpb24tZWZmZWN0LnRl bnRhdGl2ZS1leHBlY3RlZC50eHQKQEAgLTIsNyArMiw3IEBACiBQQVNTIEFmdGVyIHNldHRpbmcg YSB0cmFuc2l0aW9uJ3MgZWZmZWN0IHRvIG51bGwsIGl0IHN0aWxsIHJlcG9ydHMgdGhlIG9yaWdp bmFsIHRyYW5zaXRpb24gcHJvcGVydHkKIFBBU1MgQWZ0ZXIgc2V0dGluZyBhIHRyYW5zaXRpb24n cyBlZmZlY3QgdG8gbnVsbCwgaXQgYmVjb21lcyBmaW5pc2hlZAogUEFTUyBBZnRlciBzZXR0aW5n IGEgdHJhbnNpdGlvbidzIGVmZmVjdCB0byBudWxsLCBzdHlsZSBpcyB1cGRhdGVkCi1GQUlMIEFm dGVyIHNldHRpbmcgYSB0cmFuc2l0aW9uJ3MgZWZmZWN0IHRvIG51bGwsIGEgbmV3IHRyYW5zaXRp b24gY2FuIGJlIHN0YXJ0ZWQgYXNzZXJ0X2VxdWFsczogZXhwZWN0ZWQgIjEwMHB4IiBidXQgZ290 ICIwcHgiCitQQVNTIEFmdGVyIHNldHRpbmcgYSB0cmFuc2l0aW9uJ3MgZWZmZWN0IHRvIG51bGws IGEgbmV3IHRyYW5zaXRpb24gY2FuIGJlIHN0YXJ0ZWQKIFBBU1MgQWZ0ZXIgc2V0dGluZyBhIHRy YW5zaXRpb24ncyBlZmZlY3QgdG8gbnVsbCwgaXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGludGVy cnVwdCB0aGF0IHRyYW5zaXRpb24KIFBBU1MgQWZ0ZXIgc2V0dGluZyBhIG5ldyBrZXlmcmFtZSBl ZmZlY3Qgd2l0aCBhIHNob3J0ZXIgZHVyYXRpb24sIHRoZSB0cmFuc2l0aW9uIGJlY29tZXMgZmlu aXNoZWQKIFBBU1MgQWZ0ZXIgc2V0dGluZyBhIG5ldyBrZXlmcmFtZSBlZmZlY3QgdGFyZ2V0aW5n IGRpZmZlcmVudCBwcm9wZXJ0aWVzLCB0aGUgdHJhbnNpdGlvbiBjb250aW51ZXMgdG8gcmVwb3J0 IHRoZSBvcmlnaW5hbCB0cmFuc2l0aW9uIHByb3BlcnR5Cg== 448257 2022-01-03 14:25:33 -0800 2022-01-04 08:12:32 -0800 Patch bug-234823-20220103232532.patch text/plain 6361 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjY0MjgyMzNkNDNiZDVh ODIwOGZhMWZmMWUxMjVmZDA4OThiNTQ4Ny4uODBiN2U4ODUxYzVkNjQ5ZTYyOGE3NTBiOWFhMjMw YzFiMWY5NjFhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIyLTAxLTAzICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgorCisgICAgICAgIFtXZWIgQW5pbWF0aW9u c10gY2hhbmdpbmcgdGhlIHRpbWluZyBvZiBhIHRyYW5zaXRpb24gc3VjaCB0aGF0IGl0J3MgZmlu aXNoZWQgc2hvdWxkIG5vIGxvbmdlciBoYXZlIGl0IG1hcmtlZCBhcyBydW5uaW5nCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQ4MjMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYW55IGZhY3RvcnMgY291 bGQgY29udHJpYnV0ZSB0byBhbiBhbmltYXRpb24gZW50ZXJpbmcgaXRzIGZpbmlzaGVkIHN0YXRl LiBJbiBjYXNlIGl0J3MgYSB0cmFuc2l0aW9uLAorICAgICAgICB3ZSBtdXN0IHJlbW92ZSBpdCBm cm9tIHRoZSBsaXN0IG9mIHJ1bm5pbmcgdHJhbnNpdGlvbnMgaW1tZWRpYXRlbHksIHNvIHdlIGFk ZCBhIG5ldyB2aXJ0dWFsIG1ldGhvZCB3aGVuCisgICAgICAgIHRoZSBmaW5pc2hlZCBzdGF0ZSBp cyBlbnRlcmVkIHN1Y2ggdGhhdCBDU1NUcmFuc2l0aW9uIGNhbiBpbXBsZW1lbnQgdGhpcyBtZXRo b2QgYW5kIGRvIHRoZSBuZWNlc3NhcnkKKyAgICAgICAgY2xlYW51cC4KKworICAgICAgICAqIGFu aW1hdGlvbi9DU1NUcmFuc2l0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1RyYW5zaXRp b246OmFuaW1hdGlvbkRpZEZpbmlzaCk6CisgICAgICAgICogYW5pbWF0aW9uL0NTU1RyYW5zaXRp b24uaDoKKyAgICAgICAgKiBhbmltYXRpb24vV2ViQW5pbWF0aW9uLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OldlYkFuaW1hdGlvbjo6dXBkYXRlRmluaXNoZWRTdGF0ZSk6CisgICAgICAgICogYW5p bWF0aW9uL1dlYkFuaW1hdGlvbi5oOgorICAgICAgICAoV2ViQ29yZTo6V2ViQW5pbWF0aW9uOjph bmltYXRpb25EaWRGaW5pc2gpOgorCiAyMDIyLTAxLTAzICBDb21taXQgUXVldWUgIDxjb21taXQt cXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByZXZlcnRpbmcgcjI4NzU1 MC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9DU1NUcmFuc2l0aW9uLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9DU1NUcmFuc2l0aW9uLmNwcAppbmRleCAyNzky MWI2MDliMDcxN2IwNTVhMzdkZDljOGFlNGI1YjY3MGVhYmM3Li4yNmJhNTg2OTIwM2IwZmQ5NzU5 Mjg4ZTg1Yzc1MTkyNTU2YmNiODNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRp b24vQ1NTVHJhbnNpdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0NTU1Ry YW5zaXRpb24uY3BwCkBAIC02OCw2ICs2OCwxMiBAQCB2b2lkIENTU1RyYW5zaXRpb246OnJlc29s dmUoUmVuZGVyU3R5bGUmIHRhcmdldFN0eWxlLCBjb25zdCBTdHlsZTo6UmVzb2x1dGlvbkNvbgog ICAgIG1fY3VycmVudFN0eWxlID0gUmVuZGVyU3R5bGU6OmNsb25lUHRyKHRhcmdldFN0eWxlKTsK IH0KIAordm9pZCBDU1NUcmFuc2l0aW9uOjphbmltYXRpb25EaWRGaW5pc2goKQoreworICAgIGlm IChhdXRvIG93bmluZ0VsZW1lbnQgPSB0aGlzLT5vd25pbmdFbGVtZW50KCkpCisgICAgICAgIG93 bmluZ0VsZW1lbnQtPnJlbW92ZURlY2xhcmF0aXZlQW5pbWF0aW9uRnJvbUxpc3RzRm9yT3duaW5n RWxlbWVudCgqdGhpcyk7Cit9CisKIHZvaWQgQ1NTVHJhbnNpdGlvbjo6c2V0VGltaW5nUHJvcGVy dGllcyhTZWNvbmRzIGRlbGF5LCBTZWNvbmRzIGR1cmF0aW9uKQogewogICAgIHN1c3BlbmRFZmZl Y3RJbnZhbGlkYXRpb24oKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9D U1NUcmFuc2l0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vQ1NTVHJhbnNpdGlvbi5o CmluZGV4IDk4ZjZiNGIwNGZiOTY2MDJjM2RhNDhlMjM4MDA0OGYzMTYwODI0YTcuLjc4YWZkZTcx ZjU3ZjI1NTNlNGNjNTBhNzdlNDlhZTkxNjFiNTQ0YTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2FuaW1hdGlvbi9DU1NUcmFuc2l0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0 aW9uL0NTU1RyYW5zaXRpb24uaApAQCAtNTksNiArNTksNyBAQCBwcml2YXRlOgogICAgIHZvaWQg c2V0VGltaW5nUHJvcGVydGllcyhTZWNvbmRzIGRlbGF5LCBTZWNvbmRzIGR1cmF0aW9uKTsKICAg ICBSZWY8QW5pbWF0aW9uRXZlbnRCYXNlPiBjcmVhdGVFdmVudChjb25zdCBBdG9tU3RyaW5nJiBl dmVudFR5cGUsIGRvdWJsZSBlbGFwc2VkVGltZSwgY29uc3QgU3RyaW5nJiBwc2V1ZG9JZCwgc3Rk OjpvcHRpb25hbDxTZWNvbmRzPiB0aW1lbGluZVRpbWUpIGZpbmFsOwogICAgIHZvaWQgcmVzb2x2 ZShSZW5kZXJTdHlsZSYgdGFyZ2V0U3R5bGUsIGNvbnN0IFN0eWxlOjpSZXNvbHV0aW9uQ29udGV4 dCYsIHN0ZDo6b3B0aW9uYWw8U2Vjb25kcz4pIGZpbmFsOworICAgIHZvaWQgYW5pbWF0aW9uRGlk RmluaXNoKCkgZmluYWw7CiAKICAgICBDU1NQcm9wZXJ0eUlEIG1fcHJvcGVydHk7CiAgICAgTW9u b3RvbmljVGltZSBtX2dlbmVyYXRpb25UaW1lOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YW5pbWF0aW9uL1dlYkFuaW1hdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vV2Vi QW5pbWF0aW9uLmNwcAppbmRleCBiZjZkYTg3N2JhMzRlN2RkMDQyYjkyNjI3ODM2ZGVkYWM4ZmY0 OTlhLi4wNWU0YWUwZDEzOGZhYmQyOWFlNWEyYjA0NGQ0YTY4MTRkNzdmYTVlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vV2ViQW5pbWF0aW9uLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9hbmltYXRpb24vV2ViQW5pbWF0aW9uLmNwcApAQCAtOTA5LDYgKzkwOSw3IEBAIHZv aWQgV2ViQW5pbWF0aW9uOjp1cGRhdGVGaW5pc2hlZFN0YXRlKERpZFNlZWsgZGlkU2VlaywgU3lu Y2hyb25vdXNseU5vdGlmeSBzeW5jCiAKICAgICAvLyA1LiBJZiBjdXJyZW50IGZpbmlzaGVkIHN0 YXRlIGlzIHRydWUgYW5kIHRoZSBjdXJyZW50IGZpbmlzaGVkIHByb21pc2UgaXMgbm90IHlldCBy ZXNvbHZlZCwgcGVyZm9ybSB0aGUgZm9sbG93aW5nIHN0ZXBzOgogICAgIGlmIChjdXJyZW50Rmlu aXNoZWRTdGF0ZSAmJiAhbV9maW5pc2hlZFByb21pc2UtPmlzRnVsZmlsbGVkKCkpIHsKKyAgICAg ICAgYW5pbWF0aW9uRGlkRmluaXNoKCk7CiAgICAgICAgIGlmIChzeW5jaHJvbm91c2x5Tm90aWZ5 ID09IFN5bmNocm9ub3VzbHlOb3RpZnk6OlllcykgewogICAgICAgICAgICAgLy8gSWYgc3luY2hy b25vdXNseSBub3RpZnkgaXMgdHJ1ZSwgY2FuY2VsIGFueSBxdWV1ZWQgbWljcm90YXNrIHRvIHJ1 biB0aGUgZmluaXNoIG5vdGlmaWNhdGlvbiBzdGVwcyBmb3IgdGhpcyBhbmltYXRpb24sCiAgICAg ICAgICAgICAvLyBhbmQgcnVuIHRoZSBmaW5pc2ggbm90aWZpY2F0aW9uIHN0ZXBzIGltbWVkaWF0 ZWx5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL1dlYkFuaW1hdGlvbi5o IGIvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL1dlYkFuaW1hdGlvbi5oCmluZGV4IDQ4ZjA1YTli MzljN2YwZGQ1NzMwNTI3MGUwNDljYmY4YWVjYzg2MzEuLjU0YTBlZTY4NTIwNWEwOWMyZjM0NDYw MmRmZDkyZjlmMDQ1YTM4ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9X ZWJBbmltYXRpb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vV2ViQW5pbWF0aW9u LmgKQEAgLTE2Myw2ICsxNjMsNyBAQCBwcm90ZWN0ZWQ6CiAKICAgICB2b2lkIGluaXRpYWxpemUo KTsKICAgICB2b2lkIGVucXVldWVBbmltYXRpb25FdmVudChSZWY8QW5pbWF0aW9uRXZlbnRCYXNl PiYmKTsKKyAgICB2aXJ0dWFsIHZvaWQgYW5pbWF0aW9uRGlkRmluaXNoKCkgeyB9OwogCiBwcml2 YXRlOgogICAgIGVudW0gY2xhc3MgRGlkU2VlayA6IHVpbnQ4X3QgeyBZZXMsIE5vIH07CmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCBjNTY4MmZjNTA2OWY2NTM1Yjg1NzE1OTBjMjFj NjNmY2U3NzBiNjc4Li41ZjVjNDcxYmQyZDk0NDE4MDExNjE1MWExYzUwMTRkYWRiZmEwZmEyIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91 dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMi0wMS0w MyAgQW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9yZz4KKworICAgICAgICBbV2ViIEFu aW1hdGlvbnNdIGNoYW5naW5nIHRoZSB0aW1pbmcgb2YgYSB0cmFuc2l0aW9uIHN1Y2ggdGhhdCBp dCdzIGZpbmlzaGVkIHNob3VsZCBubyBsb25nZXIgaGF2ZSBpdCBtYXJrZWQgYXMgcnVubmluZwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0ODIzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFyayBXUFQg cHJvZ3Jlc3Npb24uCisKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy10cmFu c2l0aW9ucy9DU1NUcmFuc2l0aW9uLWVmZmVjdC50ZW50YXRpdmUtZXhwZWN0ZWQudHh0OgorCiAy MDIyLTAxLTAzICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAg ICAgICBVbnJldmlld2VkLCByZXZlcnRpbmcgcjI4NzU1MC4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy10cmFuc2l0aW9ucy9D U1NUcmFuc2l0aW9uLWVmZmVjdC50ZW50YXRpdmUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLXRyYW5zaXRpb25zL0NTU1Ry YW5zaXRpb24tZWZmZWN0LnRlbnRhdGl2ZS1leHBlY3RlZC50eHQKaW5kZXggYTFmYmQ3OTY3ZTUy NGJkZTgzMmRjYTY4NjE5OTQzYWY0Y2U0M2NmMS4uMjM4YjcyMDVhNzQyNGI4M2I0NGYxODA3NzA5 OWNlYWVjYTEzODBiZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9jc3MvY3NzLXRyYW5zaXRpb25zL0NTU1RyYW5zaXRpb24tZWZmZWN0LnRl bnRhdGl2ZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9jc3MvY3NzLXRyYW5zaXRpb25zL0NTU1RyYW5zaXRpb24tZWZmZWN0LnRl bnRhdGl2ZS1leHBlY3RlZC50eHQKQEAgLTIsNyArMiw3IEBACiBQQVNTIEFmdGVyIHNldHRpbmcg YSB0cmFuc2l0aW9uJ3MgZWZmZWN0IHRvIG51bGwsIGl0IHN0aWxsIHJlcG9ydHMgdGhlIG9yaWdp bmFsIHRyYW5zaXRpb24gcHJvcGVydHkKIFBBU1MgQWZ0ZXIgc2V0dGluZyBhIHRyYW5zaXRpb24n cyBlZmZlY3QgdG8gbnVsbCwgaXQgYmVjb21lcyBmaW5pc2hlZAogUEFTUyBBZnRlciBzZXR0aW5n IGEgdHJhbnNpdGlvbidzIGVmZmVjdCB0byBudWxsLCBzdHlsZSBpcyB1cGRhdGVkCi1GQUlMIEFm dGVyIHNldHRpbmcgYSB0cmFuc2l0aW9uJ3MgZWZmZWN0IHRvIG51bGwsIGEgbmV3IHRyYW5zaXRp b24gY2FuIGJlIHN0YXJ0ZWQgYXNzZXJ0X2VxdWFsczogZXhwZWN0ZWQgIjEwMHB4IiBidXQgZ290 ICIwcHgiCitQQVNTIEFmdGVyIHNldHRpbmcgYSB0cmFuc2l0aW9uJ3MgZWZmZWN0IHRvIG51bGws IGEgbmV3IHRyYW5zaXRpb24gY2FuIGJlIHN0YXJ0ZWQKIFBBU1MgQWZ0ZXIgc2V0dGluZyBhIHRy YW5zaXRpb24ncyBlZmZlY3QgdG8gbnVsbCwgaXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGludGVy cnVwdCB0aGF0IHRyYW5zaXRpb24KIFBBU1MgQWZ0ZXIgc2V0dGluZyBhIG5ldyBrZXlmcmFtZSBl ZmZlY3Qgd2l0aCBhIHNob3J0ZXIgZHVyYXRpb24sIHRoZSB0cmFuc2l0aW9uIGJlY29tZXMgZmlu aXNoZWQKIFBBU1MgQWZ0ZXIgc2V0dGluZyBhIG5ldyBrZXlmcmFtZSBlZmZlY3QgdGFyZ2V0aW5n IGRpZmZlcmVudCBwcm9wZXJ0aWVzLCB0aGUgdHJhbnNpdGlvbiBjb250aW51ZXMgdG8gcmVwb3J0 IHRoZSBvcmlnaW5hbCB0cmFuc2l0aW9uIHByb3BlcnR5Cg==