234801 2022-01-02 12:08:39 -0800 [LFC][IFC] Add ASSERT(middle >= left && middle < right) to TextUtil::breakWord 2022-01-02 16:51:18 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1827532 0 zalan 2022-01-02 12:08:39 -0800 in 8bit world, middle = (left + right) / 2 always guaranteed it. 1827537 1 448183 zalan 2022-01-02 12:24:34 -0800 Created attachment 448183 Patch 1827562 2 ews-feeder 2022-01-02 16:50:38 -0800 Committed r287525 (245660@main): <https://commits.webkit.org/245660@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448183. 1827563 3 webkit-bug-importer 2022-01-02 16:51:18 -0800 <rdar://problem/87054708> 448183 2022-01-02 12:24:34 -0800 2022-01-02 16:50:40 -0800 Patch bug-234801-20220102122433.patch text/plain 5044 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzFmYzE1MzI4YWMxZWYz NWQ3MTI3M2JiZjNlNDQ3MzFiYjk2OTIzZS4uNmU4MDk2M2JiZjM1MDNkZjhiYjAwOWU2NGY0NTA2 MTBmYTA0ODc4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIyLTAxLTAyICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbTEZDXVtJRkNdIEFkZCBBU1NF UlQobWlkZGxlID49IGxlZnQgJiYgbWlkZGxlIDwgcmlnaHQpIHRvIFRleHRVdGlsOjpicmVha1dv cmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDgw MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJlZm9y ZSBhZGRpbmcgc3VwcG9ydCBmb3Igc3Vycm9nYXRlIHBhaXJzLCB0aGUgaW1wbGljaXQgaW50ZWdy YWwgZmxvb3JpbmcgZ3VhcmFudGVlZCB0aGF0CisgICAgICAgIChsZWZ0ICsgcmlnaHQpIC8gMiBh bHdheXMgcHJvZHVjZWQgYSBtaWRkbGUgcG9pbnQgd2hlcmUgbGVmdCA+PSBtaWRkbGUgYW5kIG1p ZGRsZSA8IHJpZ2h0LgorICAgICAgICBXaXRoIGludHJvZHVjaW5nIHN1cnJvZ2F0ZSBwYWlyIHN1 cHBvcnQsIHRoZSBtaWRkbGUgcG9pbnQgbWF5IGVuZCB1cCBiZWluZyBlcXVhbCB0byB0aGUgcmln aHQgcG9zaXRpb24uCisgICAgICAgICh3aGVuIHRoZSAobGVmdCArIHJpZ2h0KSAvIDIgZmFsbHMg cmlnaHQgaW4gdGhlIG1pZGRsZSBvZiBhIHN1cnJvZ2F0ZSBwYWlyLCB3ZSBhZHZhbmNlIHRoZSBp bmRleAorICAgICAgICB0byB0aGUgX2VuZF8gb2YgdGhlIHBhaXIgKGFuZCBsYXRlciB3ZSBhZGp1 c3QgaXQgYnkgY2FsbGluZyBVMTZfU0VUX0NQX1NUQVJUKSkuCisKKyAgICAgICAgSW4gdGhpcyBw YXRjaCwgd2UgcmV2ZXJ0IHRoaXMgYmVoYXZpb3IgYmFjayBzbyB0aGF0IHRoZSBtaWRkbGUgcG9p bnQgaXMgYWx3YXlzIDwgcmlnaHQuCisgICAgICAgIFdlIGFsc28gbWFrZSBzdXJlIHRoYXQgbGVm dC9yaWdodC9taWRkbGUgYXJlIGFsbCBmYWxsIG9uIGNsdXN0ZXIgYm91bmRhcnkgYnkgY2FsbGlu ZyBuZXh0VXNlclBlcmNlaXZlZENoYXJhY3RlckluZGV4LgorICAgICAgICBUaGlzIHBhdGNoIGlz IGFsc28gaW4gcHJlcGFyYXRpb24gZm9yIGludHJvZHVjaW5nIGdyYXBoZW1lIGNsdXN0ZXIgc3Vw cG9ydC4KKworICAgICAgICAqIGxheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL3RleHQv VGV4dFV0aWwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpUZXh0VXRpbDo6YnJlYWtX b3JkKToKKwogMjAyMi0wMS0wMiAgQW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9yZz4K IAogICAgICAgICBbV2ViIEFuaW1hdGlvbnNdIGdldEtleWZyYW1lcygpIHNob3VsZCBlbnN1cmUg dGhhdCBhbGwgcHJvcGVydGllcyBhcmUgcHJlc2VudCBvbiAwJSBhbmQgMTAwJSBrZXlmcmFtZXMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5s aW5lL3RleHQvVGV4dFV0aWwuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdD b250ZXh0cy9pbmxpbmUvdGV4dC9UZXh0VXRpbC5jcHAKaW5kZXggZWQ1MDNhYmE4ZmZiYmVhNmNk OWUxNDlmZTU2NjQ3MjhjOGRiMGEwMC4uZTA0YTRkNjdkZTliMjY5MTNlNmVmNmY4OTdjZWM1Yzg5 MzMyNzkxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250 ZXh0cy9pbmxpbmUvdGV4dC9UZXh0VXRpbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvdGV4dC9UZXh0VXRpbC5jcHAKQEAgLTE1MSwxMyAr MTUxLDIwIEBAIFRleHRVdGlsOjpXb3JkQnJlYWtMZWZ0IFRleHRVdGlsOjpicmVha1dvcmQoY29u c3QgSW5saW5lVGV4dEJveCYgaW5saW5lVGV4dEJveCwKICAgICBBU1NFUlQobGVuZ3RoKTsKIAog ICAgIGF1dG8gdGV4dCA9IGlubGluZVRleHRCb3guY29udGVudCgpOwotICAgIGF1dG8gc3Vycm9n YXRlUGFpckF3YXJlSW5kZXggPSBbJl0gKGF1dG8gaW5kZXgpIHsKLSAgICAgICAgLy8gV2Ugc2hv dWxkIG5ldmVyIGJyZWFrIGluIHRoZSBtaWRkbGUgb2YgYSBzdXJyb2dhdGUgcGFpci4gVGhleSBh cmUgY29uc2lkZXJlZCBvbmUgam9pbnQgZW50aXR5LgotICAgICAgICBhdXRvIG9mZnNldCA9IGlu ZGV4ICsgMTsKLSAgICAgICAgVTE2X1NFVF9DUF9MSU1JVCh0ZXh0LCAwLCBvZmZzZXQsIHRleHQu bGVuZ3RoKCkpOworICAgIGF1dG8gdXNlclBlcmNlaXZlZENoYXJhY3RlckJvdW5kYXJ5QWxpZ25l ZEluZGV4ID0gWyZdIChhdXRvIGluZGV4KSB7CisgICAgICAgIGlmICh0ZXh0LmlzOEJpdCgpKQor ICAgICAgICAgICAgcmV0dXJuIGluZGV4OworICAgICAgICBhdXRvIGFsaWduZWRTdGFydEluZGV4 ID0gaW5kZXg7CisgICAgICAgIFUxNl9TRVRfQ1BfU1RBUlQodGV4dCwgc3RhcnRQb3NpdGlvbiwg YWxpZ25lZFN0YXJ0SW5kZXgpOworICAgICAgICBBU1NFUlQoYWxpZ25lZFN0YXJ0SW5kZXggPj0g c3RhcnRQb3NpdGlvbik7CisgICAgICAgIHJldHVybiBhbGlnbmVkU3RhcnRJbmRleDsKKyAgICB9 OwogCi0gICAgICAgIC8vIFJldHVybnMgdGhlIGluZGV4IGF0IHRyYWlsLgotICAgICAgICByZXR1 cm4gb2Zmc2V0IC0gMTsKKyAgICBhdXRvIG5leHRVc2VyUGVyY2VpdmVkQ2hhcmFjdGVySW5kZXgg PSBbJl0gKGF1dG8gaW5kZXgpIHsKKyAgICAgICAgaWYgKHRleHQuaXM4Qml0KCkpCisgICAgICAg ICAgICByZXR1cm4gaW5kZXggKyAxOworICAgICAgICBVMTZfRldEXzEodGV4dCwgaW5kZXgsIGxl bmd0aCk7CisgICAgICAgIHJldHVybiBpbmRleDsKICAgICB9OwogCiAgICAgYXV0byBsZWZ0ID0g c3RhcnRQb3NpdGlvbjsKQEAgLTE2NSwyMiArMTcyLDIxIEBAIFRleHRVdGlsOjpXb3JkQnJlYWtM ZWZ0IFRleHRVdGlsOjpicmVha1dvcmQoY29uc3QgSW5saW5lVGV4dEJveCYgaW5saW5lVGV4dEJv eCwKICAgICAvLyBBZGp1c3QgdGhlIHJhbmdlIHNvIHRoYXQgd2UgY2FuIHBpY2sgYSByZWFzb25h YmxlIG1pZHBvaW50LgogICAgIGF1dG8gYXZlcmFnZUNoYXJhY3RlcldpZHRoID0gSW5saW5lTGF5 b3V0VW5pdCB7IHRleHRXaWR0aCAvIGxlbmd0aCB9OwogICAgIHVuc2lnbmVkIG9mZnNldCA9IHRv TGF5b3V0VW5pdCgyICogYXZhaWxhYmxlV2lkdGggLyBhdmVyYWdlQ2hhcmFjdGVyV2lkdGgpLnRv VW5zaWduZWQoKTsKLSAgICBhdXRvIHJpZ2h0ID0gc3Vycm9nYXRlUGFpckF3YXJlSW5kZXgoc3Rk OjptaW48dW5zaWduZWQ+KGxlZnQgKyBvZmZzZXQsIChzdGFydFBvc2l0aW9uICsgbGVuZ3RoIC0g MSkpKTsKKyAgICBhdXRvIHJpZ2h0ID0gdXNlclBlcmNlaXZlZENoYXJhY3RlckJvdW5kYXJ5QWxp Z25lZEluZGV4KHN0ZDo6bWluPHVuc2lnbmVkPihsZWZ0ICsgb2Zmc2V0LCAoc3RhcnRQb3NpdGlv biArIGxlbmd0aCAtIDEpKSk7CiAgICAgLy8gUHJlc2VydmUgdGhlIGxlZnQgd2lkdGggZm9yIHRo ZSBmaW5hbCBzcGxpdCBwb3NpdGlvbiBzbyB0aGF0IHdlIGRvbid0IG5lZWQgdG8gcmVtZWFzdXJl IHRoZSBsZWZ0IHNpZGUgYWdhaW4uCiAgICAgYXV0byBsZWZ0U2lkZVdpZHRoID0gSW5saW5lTGF5 b3V0VW5pdCB7IDAgfTsKICAgICB3aGlsZSAobGVmdCA8IHJpZ2h0KSB7Ci0gICAgICAgIGF1dG8g bWlkZGxlID0gc3Vycm9nYXRlUGFpckF3YXJlSW5kZXgoKGxlZnQgKyByaWdodCkgLyAyKTsKLSAg ICAgICAgYXV0byB3aWR0aCA9IFRleHRVdGlsOjp3aWR0aChpbmxpbmVUZXh0Qm94LCBmb250Q2Fz Y2FkZSwgc3RhcnRQb3NpdGlvbiwgbWlkZGxlICsgMSwgY29udGVudExvZ2ljYWxMZWZ0KTsKKyAg ICAgICAgYXV0byBtaWRkbGUgPSB1c2VyUGVyY2VpdmVkQ2hhcmFjdGVyQm91bmRhcnlBbGlnbmVk SW5kZXgoKGxlZnQgKyByaWdodCkgLyAyKTsKKyAgICAgICAgQVNTRVJUKG1pZGRsZSA+PSBsZWZ0 ICYmIG1pZGRsZSA8IHJpZ2h0KTsKKyAgICAgICAgYXV0byBlbmRPZk1pZGRsZUNoYXJhY3RlciA9 IG5leHRVc2VyUGVyY2VpdmVkQ2hhcmFjdGVySW5kZXgobWlkZGxlKTsKKyAgICAgICAgYXV0byB3 aWR0aCA9IFRleHRVdGlsOjp3aWR0aChpbmxpbmVUZXh0Qm94LCBmb250Q2FzY2FkZSwgc3RhcnRQ b3NpdGlvbiwgZW5kT2ZNaWRkbGVDaGFyYWN0ZXIsIGNvbnRlbnRMb2dpY2FsTGVmdCk7CiAgICAg ICAgIGlmICh3aWR0aCA8IGF2YWlsYWJsZVdpZHRoKSB7Ci0gICAgICAgICAgICBsZWZ0ID0gbWlk ZGxlICsgMTsKKyAgICAgICAgICAgIGxlZnQgPSBlbmRPZk1pZGRsZUNoYXJhY3RlcjsKICAgICAg ICAgICAgIGxlZnRTaWRlV2lkdGggPSB3aWR0aDsKLSAgICAgICAgfSBlbHNlIGlmICh3aWR0aCA+ IGF2YWlsYWJsZVdpZHRoKSB7Ci0gICAgICAgICAgICAvLyBXaGVuIHRoZSBzdWJzdHJpbmcgZG9l cyBub3QgZml0LCB0aGUgcmlnaHQgc2lkZSBpcyBzdXBwb3NlZCB0byBiZSB0aGUgc3RhcnQgb2Yg dGhlIHN1cnJvZ2F0ZSBwYWlyIGlmIGFwcGxpY2FibGUsIHVubGVzcyBzdGFydFBvc2l0aW9uIGZh bGxzIGJldHdlZW4gc3Vycm9nYXRlIHBhaXIuCisgICAgICAgIH0gZWxzZSBpZiAod2lkdGggPiBh dmFpbGFibGVXaWR0aCkKICAgICAgICAgICAgIHJpZ2h0ID0gbWlkZGxlOwotICAgICAgICAgICAg VTE2X1NFVF9DUF9TVEFSVCh0ZXh0LCAwLCByaWdodCk7Ci0gICAgICAgICAgICBBU1NFUlQocmln aHQgPj0gc3RhcnRQb3NpdGlvbik7Ci0gICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICByaWdo dCA9IG1pZGRsZSArIDE7CisgICAgICAgIGVsc2UgeworICAgICAgICAgICAgcmlnaHQgPSBlbmRP Zk1pZGRsZUNoYXJhY3RlcjsKICAgICAgICAgICAgIGxlZnRTaWRlV2lkdGggPSB3aWR0aDsKICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICB9Cg==