23480 2009-01-22 10:35:41 -0800 Add missing method stubs to BackForwardListChromium 2009-01-26 08:46:05 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 23384 1 dglazkov webkit-unassigned oldest_to_newest 106617 0 dglazkov 2009-01-22 10:35:41 -0800 It turns out that two methods are being called by Page::goBack and Page::goForward, respectively -- it's the respective callsites that are never being called. For more information, see bug 23384. 106618 1 26931 dglazkov 2009-01-22 10:40:02 -0800 Created attachment 26931 v1 submitted for review WebCore/history/BackForwardListChromium.cpp | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) 106619 2 26932 dglazkov 2009-01-22 10:40:51 -0800 Created attachment 26932 v1 submitted for review WebCore/ChangeLog | 11 +++++++++++ WebCore/history/BackForwardListChromium.cpp | 12 ++++++++++++ 2 files changed, 23 insertions(+), 0 deletions(-) 106815 3 26932 darin 2009-01-23 16:06:14 -0800 Comment on attachment 26932 v1 submitted for review Darin Fisher and I discussed leaving out unneeded functions intentionally, using the linker to find the error. Since you're submitting a patch to add these back, I guess there must be some code that's calling these. So I don't understand why ASSERT_NOT_REACHED is OK. You should check with Darin. But r=me 106867 4 fishd 2009-01-24 10:38:07 -0800 Hi Darin, see comment #0. It turns out that two of the "not reached" methods are needed because they are referenced by other code that we compile. See Page::goBack() and Page::goForward(). So, the linker requires us to define those methods. However, goBack and goForward are never called by WebCore or our WebKit layer, so we can get away with not implementing them. 107035 5 dglazkov 2009-01-26 08:46:05 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/history/BackForwardListChromium.cpp Committed r40249 http://trac.webkit.org/changeset/40249. 26931 2009-01-22 10:40:02 -0800 2009-01-22 10:41:03 -0800 v1 submitted for review v1-submitted-for-review.patch text/plain 651 dglazkov N2EzMGYyMzk5YmRkZWQzOTAyMGMzMTI1ZDVmMzg1N2I1ZmUzMDllMwpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9oaXN0b3J5L0JhY2tGb3J3YXJkTGlzdENocm9taXVtLmNwcCBiL1dlYkNvcmUvaGlzdG9y eS9CYWNrRm9yd2FyZExpc3RDaHJvbWl1bS5jcHAKaW5kZXggYzcyYjZiOS4uMDExZjk4NyAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9oaXN0b3J5L0JhY2tGb3J3YXJkTGlzdENocm9taXVtLmNwcAorKysg Yi9XZWJDb3JlL2hpc3RvcnkvQmFja0ZvcndhcmRMaXN0Q2hyb21pdW0uY3BwCkBAIC02Myw2ICs2 MywxOCBAQCB2b2lkIEJhY2tGb3J3YXJkTGlzdDo6Z29Ub0l0ZW0oSGlzdG9yeUl0ZW0qIGl0ZW0p CiAgICAgbV9jbGllbnQtPmdvVG9JdGVtKGl0ZW0pOwogfQogCitIaXN0b3J5SXRlbSogQmFja0Zv cndhcmRMaXN0OjpiYWNrSXRlbSgpCit7CisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAg cmV0dXJuIDA7Cit9CisKK0hpc3RvcnlJdGVtKiBCYWNrRm9yd2FyZExpc3Q6OmZvcndhcmRJdGVt KCkKK3sKKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4gMDsKK30KKwogSGlz dG9yeUl0ZW0qIEJhY2tGb3J3YXJkTGlzdDo6Y3VycmVudEl0ZW0oKQogewogICAgIHJldHVybiBt X2NsaWVudC0+Y3VycmVudEl0ZW0oKTsK 26932 2009-01-22 10:40:51 -0800 2009-01-23 16:06:14 -0800 v1 submitted for review v1-submitted-for-review.patch text/plain 1265 dglazkov ZGE5M2Y2MjJiN2Y5MTczYjIxY2NkYTQ2NTQ1YzRkZDZjMjQwZDc2ZQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkZGY0YjU2Li43YzdlNTc3 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDA5LTAxLTIyICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDgwCisgICAg ICAgIEFkZCBtaXNzaW5nIG1ldGhvZCBzdHVicyB0byBCYWNrRm9yd2FyZExpc3RDaHJvbWl1bS4K KworICAgICAgICAqIGhpc3RvcnkvQmFja0ZvcndhcmRMaXN0Q2hyb21pdW0uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6QmFja0ZvcndhcmRMaXN0OjpiYWNrSXRlbSk6CisgICAgICAgIChXZWJDb3Jl OjpCYWNrRm9yd2FyZExpc3Q6OmZvcndhcmRJdGVtKToKKwogMjAwOS0wMS0yMiAgQWRhbSBUcmVh dCAgPGFkYW0udHJlYXRAdG9yY2htb2JpbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgUXQgYnVp bGQgYWZ0ZXIgUmVuZGVyQm94IGNoYW5nZXMuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2hpc3Rvcnkv QmFja0ZvcndhcmRMaXN0Q2hyb21pdW0uY3BwIGIvV2ViQ29yZS9oaXN0b3J5L0JhY2tGb3J3YXJk TGlzdENocm9taXVtLmNwcAppbmRleCBjNzJiNmI5Li4wMTFmOTg3IDEwMDY0NAotLS0gYS9XZWJD b3JlL2hpc3RvcnkvQmFja0ZvcndhcmRMaXN0Q2hyb21pdW0uY3BwCisrKyBiL1dlYkNvcmUvaGlz dG9yeS9CYWNrRm9yd2FyZExpc3RDaHJvbWl1bS5jcHAKQEAgLTYzLDYgKzYzLDE4IEBAIHZvaWQg QmFja0ZvcndhcmRMaXN0Ojpnb1RvSXRlbShIaXN0b3J5SXRlbSogaXRlbSkKICAgICBtX2NsaWVu dC0+Z29Ub0l0ZW0oaXRlbSk7CiB9CiAKK0hpc3RvcnlJdGVtKiBCYWNrRm9yd2FyZExpc3Q6OmJh Y2tJdGVtKCkKK3sKKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4gMDsKK30K KworSGlzdG9yeUl0ZW0qIEJhY2tGb3J3YXJkTGlzdDo6Zm9yd2FyZEl0ZW0oKQoreworICAgIEFT U0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVybiAwOworfQorCiBIaXN0b3J5SXRlbSogQmFj a0ZvcndhcmRMaXN0OjpjdXJyZW50SXRlbSgpCiB7CiAgICAgcmV0dXJuIG1fY2xpZW50LT5jdXJy ZW50SXRlbSgpOwo=