234793 2022-01-02 03:37:00 -0800 [Web Animations] getKeyframes() should return an empty object when there are no animatable properties in @keyframes rule 2022-01-12 12:41:31 -0800 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar, WebExposed P2 Normal --- 235138 1 graouts graouts changseok dino esprehn+autocc ews-watchlist glenn graouts kondapallykalyan pdr webkit-bug-importer oldest_to_newest 1827493 0 graouts 2022-01-02 03:37:00 -0800 [Web Animations] getKeyframes() should return an empty object when there are no animatable properties in @keyframes rule 1827494 1 448172 graouts 2022-01-02 03:39:15 -0800 Created attachment 448172 Patch 1827497 2 448172 dino 2022-01-02 07:00:22 -0800 Comment on attachment 448172 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448172&action=review > Source/WebCore/rendering/style/KeyframeList.cpp:139 > + for (auto cssPropertyId : m_properties) { > + if (CSSPropertyAnimation::isPropertyAnimatable(cssPropertyId)) > + return true; Shame there isn't the equivalent of Array.some on Vector. 1827506 3 ews-feeder 2022-01-02 08:13:46 -0800 Committed r287517 (245652@main): <https://commits.webkit.org/245652@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448172. 1827507 4 webkit-bug-importer 2022-01-02 08:14:27 -0800 <rdar://problem/87049042> 448172 2022-01-02 03:39:15 -0800 2022-01-02 08:13:47 -0800 Patch bug-234793-20220102123914.patch text/plain 5716 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTExMmM2MGUxMDU0N2Vj ODgwY2ViODgyYTk2NDFjMzY5ZjBmY2VlZC4uNWM2YzJjM2E0M2I4YjgwYTJhMzc3Y2Q4OTRjMDUx Y2Q3Zjk5NmRmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIyLTAxLTAyICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgorCisgICAgICAgIFtXZWIgQW5pbWF0aW9u c10gZ2V0S2V5ZnJhbWVzKCkgc2hvdWxkIHJldHVybiBhbiBlbXB0eSBvYmplY3Qgd2hlbiB0aGVy ZSBhcmUgbm8gYW5pbWF0YWJsZSBwcm9wZXJ0aWVzIGluIEBrZXlmcmFtZXMgcnVsZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0NzkzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgdGhlIGtleWZyYW1l cyBmb3IgYW4gYW5pbWF0aW9uIHJlc3VsdCBmcm9tIGEgZGVjbGFyYXRpdmUgc291cmNlLCBsZXQn cyBub3Qgb3V0cHV0IGFueSBkYXRhIGlmIG5vbmUgb2YgdGhlIHByb3BlcnRpZXMKKyAgICAgICAg YXJlIGFuaW1hdGFibGUuCisKKyAgICAgICAgKiBhbmltYXRpb24vS2V5ZnJhbWVFZmZlY3QuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6S2V5ZnJhbWVFZmZlY3Q6OmdldEtleWZyYW1lcyk6CisgICAg ICAgICogcmVuZGVyaW5nL3N0eWxlL0tleWZyYW1lTGlzdC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpLZXlmcmFtZUxpc3Q6OmNvbnRhaW5zQW5pbWF0YWJsZVByb3BlcnR5IGNvbnN0KToKKyAgICAg ICAgKiByZW5kZXJpbmcvc3R5bGUvS2V5ZnJhbWVMaXN0Lmg6CisKIDIwMjItMDEtMDEgIEFudG9p bmUgUXVpbnQgIDxncmFvdXRzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgImFuaW1hdGlvbiIgc2hv cnRoYW5kIGRvZXMgbm90IHBhcnNlIHZhbHVlcyBpbiB0aGUgcmlnaHQgb3JkZXIKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9LZXlmcmFtZUVmZmVjdC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9hbmltYXRpb24vS2V5ZnJhbWVFZmZlY3QuY3BwCmluZGV4IGIwYWRlMWI1MjI3MGM2 OTg1NWNmZTM1YzIzODE3YWJmMzk5NWIxNjUuLjRmOTZiNmYxMmJlODhjODNkMjk3MjRlNGY1MmYx YTkyNjE1YzZhYmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9LZXlmcmFt ZUVmZmVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0 LmNwcApAQCAtNjMyLDcgKzYzMiw3IEBAIFZlY3RvcjxTdHJvbmc8SlNPYmplY3Q+PiBLZXlmcmFt ZUVmZmVjdDo6Z2V0S2V5ZnJhbWVzKEpTR2xvYmFsT2JqZWN0JiBsZXhpY2FsR2xvCiAgICAgLy8g Mi4gTGV0IGtleWZyYW1lcyBiZSB0aGUgcmVzdWx0IG9mIGFwcGx5aW5nIHRoZSBwcm9jZWR1cmUg dG8gY29tcHV0ZSBtaXNzaW5nIGtleWZyYW1lIG9mZnNldHMgdG8gdGhlIGtleWZyYW1lcyBmb3Ig dGhpcyBrZXlmcmFtZSBlZmZlY3QuCiAKICAgICAvLyAzLiBGb3IgZWFjaCBrZXlmcmFtZSBpbiBr ZXlmcmFtZXMgcGVyZm9ybSB0aGUgZm9sbG93aW5nIHN0ZXBzOgotICAgIGlmIChtX3BhcnNlZEtl eWZyYW1lcy5pc0VtcHR5KCkgJiYgbV9ibGVuZGluZ0tleWZyYW1lc1NvdXJjZSAhPSBCbGVuZGlu Z0tleWZyYW1lc1NvdXJjZTo6V2ViQW5pbWF0aW9uKSB7CisgICAgaWYgKG1fcGFyc2VkS2V5ZnJh bWVzLmlzRW1wdHkoKSAmJiBtX2JsZW5kaW5nS2V5ZnJhbWVzU291cmNlICE9IEJsZW5kaW5nS2V5 ZnJhbWVzU291cmNlOjpXZWJBbmltYXRpb24gJiYgbV9ibGVuZGluZ0tleWZyYW1lcy5jb250YWlu c0FuaW1hdGFibGVQcm9wZXJ0eSgpKSB7CiAgICAgICAgIGF1dG8qIHRhcmdldCA9IG1fdGFyZ2V0 LmdldCgpOwogICAgICAgICBhdXRvKiByZW5kZXJlciA9IHRoaXMtPnJlbmRlcmVyKCk7CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9LZXlmcmFtZUxpc3QuY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL0tleWZyYW1lTGlzdC5jcHAKaW5kZXgg ZTIzYTIxYzQ3YWYxMTcxNzJmZTJkNTU4MmYzOTBjZTFlMzAxNjMwOC4uN2NmZTE5YWFmMmU2Y2Q0 ZjY5YzYxZDkzNzIxOTc4ZmFjY2ViN2Y0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3N0eWxlL0tleWZyYW1lTGlzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL3N0eWxlL0tleWZyYW1lTGlzdC5jcHAKQEAgLTI0LDYgKzI0LDcgQEAKIAogI2luY2x1ZGUg IkFuaW1hdGlvbi5oIgogI2luY2x1ZGUgIkNTU0tleWZyYW1lUnVsZS5oIgorI2luY2x1ZGUgIkNT U1Byb3BlcnR5QW5pbWF0aW9uLmgiCiAjaW5jbHVkZSAiUmVuZGVyT2JqZWN0LmgiCiAjaW5jbHVk ZSAiU3R5bGVSZXNvbHZlci5oIgogCkBAIC0xMzEsNCArMTMyLDEzIEBAIHZvaWQgS2V5ZnJhbWVM aXN0OjpmaWxsSW1wbGljaXRLZXlmcmFtZXMoY29uc3QgRWxlbWVudCYgZWxlbWVudCwgU3R5bGU6 OlJlc29sdmVyCiAgICAgfQogfQogCitib29sIEtleWZyYW1lTGlzdDo6Y29udGFpbnNBbmltYXRh YmxlUHJvcGVydHkoKSBjb25zdAoreworICAgIGZvciAoYXV0byBjc3NQcm9wZXJ0eUlkIDogbV9w cm9wZXJ0aWVzKSB7CisgICAgICAgIGlmIChDU1NQcm9wZXJ0eUFuaW1hdGlvbjo6aXNQcm9wZXJ0 eUFuaW1hdGFibGUoY3NzUHJvcGVydHlJZCkpCisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAg ICB9CisgICAgcmV0dXJuIGZhbHNlOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvS2V5ZnJhbWVMaXN0LmggYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvS2V5ZnJhbWVMaXN0LmgKaW5kZXggZjllOGIw OThjOWZlYmUzZGNlMDM5NjEzYjE1YmIxYmFlZWQ4MjRjMi4uMWYzMDg3ODBmZWY2OTk2NWFhYTU0 MThlOTVlZmFmOTFlOWJjMTA5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L3N0eWxlL0tleWZyYW1lTGlzdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHls ZS9LZXlmcmFtZUxpc3QuaApAQCAtOTEsNyArOTEsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBhZGRQ cm9wZXJ0eShDU1NQcm9wZXJ0eUlEIHByb3ApIHsgbV9wcm9wZXJ0aWVzLmFkZChwcm9wKTsgfQog ICAgIGJvb2wgY29udGFpbnNQcm9wZXJ0eShDU1NQcm9wZXJ0eUlEIHByb3ApIGNvbnN0IHsgcmV0 dXJuIG1fcHJvcGVydGllcy5jb250YWlucyhwcm9wKTsgfQogICAgIGNvbnN0IEhhc2hTZXQ8Q1NT UHJvcGVydHlJRD4mIHByb3BlcnRpZXMoKSBjb25zdCB7IHJldHVybiBtX3Byb3BlcnRpZXM7IH0K LSAgICAKKyAgICBib29sIGNvbnRhaW5zQW5pbWF0YWJsZVByb3BlcnR5KCkgY29uc3Q7CisKICAg ICB2b2lkIGNsZWFyKCk7CiAgICAgYm9vbCBpc0VtcHR5KCkgY29uc3QgeyByZXR1cm4gbV9rZXlm cmFtZXMuaXNFbXB0eSgpOyB9CiAgICAgc2l6ZV90IHNpemUoKSBjb25zdCB7IHJldHVybiBtX2tl eWZyYW1lcy5zaXplKCk7IH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9D aGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IDU4NTM1 MmE3MTI1MmRmNzE1N2UxNzVlMjU5MDM3YjAxYWQ0ODVlYTAuLjUyYTQ3NDM3YTllNjM4ZTgxYWY1 ZmY1NmY3YmNlNmRhZWMyNWYzM2MgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE0IEBACisyMDIyLTAxLTAyICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQu b3JnPgorCisgICAgICAgIFtXZWIgQW5pbWF0aW9uc10gZ2V0S2V5ZnJhbWVzKCkgc2hvdWxkIHJl dHVybiBhbiBlbXB0eSBvYmplY3Qgd2hlbiB0aGVyZSBhcmUgbm8gYW5pbWF0YWJsZSBwcm9wZXJ0 aWVzIGluIEBrZXlmcmFtZXMgcnVsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjM0NzkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTWFyayBhIG5ldyBXUFQgcHJvZ3Jlc3Npb24uCisKKyAgICAgICAgKiB3 ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1hbmltYXRpb25zL0tleWZyYW1lRWZmZWN0LWdldEtl eWZyYW1lcy50ZW50YXRpdmUtZXhwZWN0ZWQudHh0OgorCiAyMDIyLTAxLTAxICBBbnRvaW5lIFF1 aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgogCiAgICAgICAgICJhbmltYXRpb24iIHNob3J0aGFu ZCBkb2VzIG5vdCBwYXJzZSB2YWx1ZXMgaW4gdGhlIHJpZ2h0IG9yZGVyCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtYW5pbWF0 aW9ucy9LZXlmcmFtZUVmZmVjdC1nZXRLZXlmcmFtZXMudGVudGF0aXZlLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1hbmlt YXRpb25zL0tleWZyYW1lRWZmZWN0LWdldEtleWZyYW1lcy50ZW50YXRpdmUtZXhwZWN0ZWQudHh0 CmluZGV4IGUyZDNhZjEyNWEyNThjNzcxNTg4N2Y1ODliYjI4MmYzOWFiN2EzOGQuLjkwMTlhODI0 MWI4MDVmYmVmODg3NWU5N2RmZDIyZTQ1ZDVjY2JiYmMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1hbmltYXRpb25zL0tleWZy YW1lRWZmZWN0LWdldEtleWZyYW1lcy50ZW50YXRpdmUtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91 dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1hbmltYXRpb25z L0tleWZyYW1lRWZmZWN0LWdldEtleWZyYW1lcy50ZW50YXRpdmUtZXhwZWN0ZWQudHh0CkBAIC0x LDUgKzEsNSBAQAogCi1GQUlMIEtleWZyYW1lRWZmZWN0LmdldEtleWZyYW1lcygpIHJldHVybnMg bm8gZnJhbWVzIGZvciB2YXJpb3VzIGtpbmRzIG9mIGVtcHR5IGVuaW1hdGlvbnMgYXNzZXJ0X2Vx dWFsczogbnVtYmVyIG9mIGZyYW1lcyB3aGVuIEBrZXlmcmFtZXMgaGFzIGVtcHR5IGtleWZyYW1l cyBleHBlY3RlZCAwIGJ1dCBnb3QgMgorUEFTUyBLZXlmcmFtZUVmZmVjdC5nZXRLZXlmcmFtZXMo KSByZXR1cm5zIG5vIGZyYW1lcyBmb3IgdmFyaW91cyBraW5kcyBvZiBlbXB0eSBlbmltYXRpb25z CiBQQVNTIEtleWZyYW1lRWZmZWN0LmdldEtleWZyYW1lcygpIHJldHVybnMgZXhwZWN0ZWQgZnJh bWVzIGZvciBhIHNpbXBsZSBhbmltYXRpb24KIFBBU1MgS2V5ZnJhbWVFZmZlY3QuZ2V0S2V5ZnJh bWVzKCkgcmV0dXJucyBmcmFtZXMgd2l0aCBleHBlY3RlZCBlYXNpbmcgdmFsdWVzLCB3aGVuIHRo ZSBlYXNpbmcgY29tZXMgZnJvbSBhbmltYXRpb24tdGltaW5nLWZ1bmN0aW9uIG9uIHRoZSBlbGVt ZW50CiBQQVNTIEtleWZyYW1lRWZmZWN0LmdldEtleWZyYW1lcygpIHJldHVybnMgZnJhbWVzIHdp dGggZXhwZWN0ZWQgZWFzaW5nIHZhbHVlcywgd2hlbiB0aGUgZWFzaW5nIGlzIHNwZWNpZmllZCBv biBlYWNoIGtleWZyYW1lCg==