234750 2021-12-30 04:22:27 -0800 [GTK][a11y] Avoid going to the main thread while serializing ATSPI objects for the cache 2022-01-17 00:21:25 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED Gtk P2 Normal --- 234740 230253 1 cgarcia webkit-unassigned aperez bugs-noreply oldest_to_newest 1827228 0 cgarcia 2021-12-30 04:22:27 -0800 We only ask the main thread for state and is defunct. We can cache the state and use an atomic member for the is defunct. 1827229 1 448093 cgarcia 2021-12-30 04:26:07 -0800 Created attachment 448093 Patch 1829408 2 448093 aperez 2022-01-10 03:40:48 -0800 Comment on attachment 448093 Patch Patch looks okay, but in need of a rebase. Could you please update it? 1829409 3 cgarcia 2022-01-10 03:46:48 -0800 Actually I forgot to update the depends on. 1831419 4 448093 cgarcia 2022-01-17 00:20:52 -0800 Comment on attachment 448093 Patch Clearing flags 1831420 5 cgarcia 2022-01-17 00:21:25 -0800 This doesn't make sense now that we don't use isolated tree. 448093 2021-12-30 04:26:07 -0800 2022-01-17 00:20:52 -0800 Patch wcore-atspi-no-main-thread-serialize.diff text/plain 7044 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NDMyNDJlMWE0MjkuLjkyM2MwMmI5M2ZhZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDI1IEBACisyMDIxLTEyLTMwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVthMTF5XSBBdm9pZCBnb2luZyB0byB0aGUgbWFp biB0aHJlYWQgd2hpbGUgc2VyaWFsaXppbmcgQVRTUEkgb2JqZWN0cyBmb3IgdGhlIGNhY2hlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQ3NTAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBvbmx5IGFz ayB0aGUgbWFpbiB0aHJlYWQgZm9yIHN0YXRlIGFuZCBpcyBkZWZ1bmN0LiBXZSBjYW4gY2FjaGUg dGhlIHN0YXRlIGFuZCB1c2UgYW4gYXRvbWljIG1lbWJlciBmb3IgdGhlIGlzCisgICAgICAgIGRl ZnVuY3QuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2F0c3BpL0FjY2Vzc2liaWxpdHlBdHNw aS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5QXRzcGk6OnBhcmVudENoYW5n ZWQpOiBEbyBub3QgZW1pdCBpZiBvYmplY3QgaXMgZGVmdW5jdC4KKyAgICAgICAgKFdlYkNvcmU6 OkFjY2Vzc2liaWxpdHlBdHNwaTo6Y2hpbGRyZW5DaGFuZ2VkKTogRG8gbm90IGVtaXQgaWYgb2pl Y3QgaXMgZGVmdW5jdCBvciBuZXcgYWRkZWQgY2hpbGQgaXMgZGVmdW5jdC4KKyAgICAgICAgKiBh Y2Nlc3NpYmlsaXR5L2F0c3BpL0FjY2Vzc2liaWxpdHlPYmplY3RBdHNwaS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGk6OmNhY2hlRGVzdHJveWVkKTogTWFy ayBhcyBkZWZ1bmN0LgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU9iamVjdEF0c3Bp OjplbGVtZW50RGVzdHJveWVkKTogRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmls aXR5T2JqZWN0QXRzcGk6OnNldFBhcmVudCk6IElmIHRyZWUgaXMgcmVnaXN0ZXJlZCBjYWxsIHN0 YXRlKCkgdG8gY2FjaGUgdGhlIGluaXRpYWwgc3RhdGUgdG8gYmUgdXNlZCBieSBzZXJpYWxpemUo KS4KKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlPYmplY3RBdHNwaTo6aW5kZXhJblBh cmVudCBjb25zdCk6IFJlbW92ZSB1bmVlZGVkIGNhbGwgdG8gdXBkYXRlQmFja2luZ1N0b3JlLgor ICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU9iamVjdEF0c3BpOjpzdGF0ZSBjb25zdCk6 IENhY2hlIHRoZSByZXN1bHQuCisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0 QXRzcGk6OnNlcmlhbGl6ZSBjb25zdCk6IFVzZSB0aGUgY2FjaGVkIHN0YXRlLgorICAgICAgICAq IGFjY2Vzc2liaWxpdHkvYXRzcGkvQWNjZXNzaWJpbGl0eU9iamVjdEF0c3BpLmg6CisKIDIwMjEt MTItMjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtHVEtdW2ExMXldIERlZmVyIHRoZSBlbWlzc2lvbiBvZiBBZGRBY2Nlc3NpYmxlIHNpZ25h bCB3aXRoIEFUU1BJCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0 c3BpL0FjY2Vzc2liaWxpdHlBdHNwaS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L2F0c3BpL0FjY2Vzc2liaWxpdHlBdHNwaS5jcHAKaW5kZXggY2YxNmY5OTg4MjdmLi4xMjNlNmIx YzllNzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRzcGkvQWNj ZXNzaWJpbGl0eUF0c3BpLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0 c3BpL0FjY2Vzc2liaWxpdHlBdHNwaS5jcHAKQEAgLTM1NCw2ICszNTQsOSBAQCB2b2lkIEFjY2Vz c2liaWxpdHlBdHNwaTo6cGFyZW50Q2hhbmdlZChBY2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGkmIGF0 c3BpT2JqZWN0KQogICAgICAgICBpZiAoIW1fY29ubmVjdGlvbikKICAgICAgICAgICAgIHJldHVy bjsKIAorICAgICAgICBpZiAoYXRzcGlPYmplY3QtPmlzRGVmdW5jdCgpKQorICAgICAgICAgICAg cmV0dXJuOworCiAgICAgICAgIC8vIEFsd2F5cyBlbWl0IHBhcmVudENoYW5nZWQgd2hlbiB0aGUg dHJlZSBpcyByZWdpc3RlcmVkIGJlY2F1c2UgdGhlIGF0c3BpIGNhY2hlIGFsd2F5cyBjb25zdW1l cyBpdC4KICAgICAgICAgaWYgKCFhdHNwaU9iamVjdC0+aXNUcmVlUmVnaXN0ZXJlZCgpKQogICAg ICAgICAgICAgcmV0dXJuOwpAQCAtMzkwLDYgKzM5Myw5IEBAIHZvaWQgQWNjZXNzaWJpbGl0eUF0 c3BpOjpjaGlsZHJlbkNoYW5nZWQoQWNjZXNzaWJpbGl0eU9iamVjdEF0c3BpJiBhdHNwaU9iamVj dCwKICAgICAgICAgaWYgKCFtX2Nvbm5lY3Rpb24pCiAgICAgICAgICAgICByZXR1cm47CiAKKyAg ICAgICAgaWYgKGF0c3BpT2JqZWN0LT5pc0RlZnVuY3QoKSB8fCAoY2hhbmdlID09IENoaWxkcmVu Q2hhbmdlZDo6QWRkZWQgJiYgY2hpbGQtPmlzRGVmdW5jdCgpKSkKKyAgICAgICAgICAgIHJldHVy bjsKKwogICAgICAgICAvLyBBbHdheXMgZW1pdCBDaGlsZHJlbkNoYW5nZWQgd2hlbiB0aGUgdHJl ZSBpcyByZWdpc3RlcmVkIGJlY2F1c2UgdGhlIGF0c3BpIGNhY2hlIGFsd2F5cyBjb25zdW1lcyBp dC4KICAgICAgICAgaWYgKCFhdHNwaU9iamVjdC0+aXNUcmVlUmVnaXN0ZXJlZCgpKQogICAgICAg ICAgICAgcmV0dXJuOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9h dHNwaS9BY2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGkuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9hdHNwaS9BY2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGkuY3BwCmluZGV4IGUzYjY3ZDkw NWMxMS4uYzMwMmQyMjI3Mjc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L2F0c3BpL0FjY2Vzc2liaWxpdHlPYmplY3RBdHNwaS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9hdHNwaS9BY2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGkuY3BwCkBAIC0x MzIsNiArMTMyLDcgQEAgdm9pZCBBY2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGk6OmRldGFjaCgpCiB2 b2lkIEFjY2Vzc2liaWxpdHlPYmplY3RBdHNwaTo6Y2FjaGVEZXN0cm95ZWQoKQogewogICAgIFJF TEVBU0VfQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKKyAgICBtX2lzRGVmdW5jdC5zdG9yZSh0cnVl KTsKICAgICBtX2NvcmVPYmplY3QgPSBudWxscHRyOwogICAgIGlmICghbV9pc1JlZ2lzdGVyZWQu bG9hZCgpKQogICAgICAgICByZXR1cm47CkBAIC0xNDUsNiArMTQ2LDcgQEAgdm9pZCBBY2Nlc3Np YmlsaXR5T2JqZWN0QXRzcGk6OmNhY2hlRGVzdHJveWVkKCkKIHZvaWQgQWNjZXNzaWJpbGl0eU9i amVjdEF0c3BpOjplbGVtZW50RGVzdHJveWVkKCkKIHsKICAgICBSRUxFQVNFX0FTU0VSVChpc01h aW5UaHJlYWQoKSk7CisgICAgbV9pc0RlZnVuY3Quc3RvcmUodHJ1ZSk7CiAgICAgbV9jb3JlT2Jq ZWN0ID0gbnVsbHB0cjsKICAgICBpZiAoIW1faXNSZWdpc3RlcmVkLmxvYWQoKSkKICAgICAgICAg cmV0dXJuOwpAQCAtNTc1LDYgKzU3NywxMSBAQCB2b2lkIEFjY2Vzc2liaWxpdHlPYmplY3RBdHNw aTo6c2V0UGFyZW50KHN0ZDo6b3B0aW9uYWw8QWNjZXNzaWJpbGl0eU9iamVjdEF0c3BpKgogICAg IGlmICghbV9jb3JlT2JqZWN0IHx8IG1fY29yZU9iamVjdC0+YWNjZXNzaWJpbGl0eUlzSWdub3Jl ZCgpIHx8ICFyb290KCkpCiAgICAgICAgIHJldHVybjsKIAorICAgIGlmIChtX3Jvb3QtPmlzVHJl ZVJlZ2lzdGVyZWQoKSkgeworICAgICAgICAvLyBDYWNoZSB0aGUgaW5pdGlhbCBzdGF0ZSBoZXJl IHRvIGJlIHVzZWQgYnkgc2VyaWFsaXplKCkuCisgICAgICAgIHN0YXRlKCk7CisgICAgfQorCiAg ICAgQWNjZXNzaWJpbGl0eUF0c3BpOjpjdXJyZW50KCkucGFyZW50Q2hhbmdlZCgqdGhpcyk7CiAg ICAgaWYgKG1fcGFyZW50KSB7CiAgICAgICAgIGlmICgqbV9wYXJlbnQpCkBAIC02NjMsOCArNjcw LDYgQEAgaW50IEFjY2Vzc2liaWxpdHlPYmplY3RBdHNwaTo6aW5kZXhJblBhcmVudCgpIGNvbnN0 CiAgICAgICAgIHJldHVybiBtX2luZGV4SW5QYXJlbnQ7CiAgICAgfQogCi0gICAgbV9heE9iamVj dC0+dXBkYXRlQmFja2luZ1N0b3JlKCk7Ci0KICAgICBhdXRvKiBheFBhcmVudCA9IG1fYXhPYmpl Y3QtPnBhcmVudE9iamVjdFVuaWdub3JlZCgpOwogICAgIGlmICghYXhQYXJlbnQpIHsKICAgICAg ICAgbV9pbmRleEluUGFyZW50ID0gMDsKQEAgLTc3OCw3ICs3ODMsNyBAQCBzdGF0aWMgYm9vbCBz aG91bGRJbmNsdWRlT3JpZW50YXRpb25TdGF0ZShjb25zdCBBWENvcmVPYmplY3QmIGNvcmVPYmpl Y3QpCiAKIHVpbnQ2NF90IEFjY2Vzc2liaWxpdHlPYmplY3RBdHNwaTo6c3RhdGUoKSBjb25zdAog ewotICAgIHJldHVybiBBY2Nlc3NpYmlsaXR5OjpyZXRyaWV2ZVZhbHVlRnJvbU1haW5UaHJlYWQ8 dWludDY0X3Q+KFt0aGlzXSgpIC0+IHVpbnQ2NF90IHsKKyAgICBhdXRvIHJldHVyblZhbHVlID0g QWNjZXNzaWJpbGl0eTo6cmV0cmlldmVWYWx1ZUZyb21NYWluVGhyZWFkPHVpbnQ2NF90PihbdGhp c10oKSAtPiB1aW50NjRfdCB7CiAgICAgICAgIHVpbnQ2NF90IHN0YXRlcyA9IDA7CiAKICAgICAg ICAgYXV0byBhZGRTdGF0ZSA9IFsmXShBdHNwaTo6U3RhdGUgYXRzcGlTdGF0ZSkgewpAQCAtODg2 LDEzICs4OTEsMTEgQEAgdWludDY0X3QgQWNjZXNzaWJpbGl0eU9iamVjdEF0c3BpOjpzdGF0ZSgp IGNvbnN0CiAKICAgICAgICAgcmV0dXJuIHN0YXRlczsKICAgICB9KTsKLX0KIAotYm9vbCBBY2Nl c3NpYmlsaXR5T2JqZWN0QXRzcGk6OmlzRGVmdW5jdCgpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIEFj Y2Vzc2liaWxpdHk6OnJldHJpZXZlVmFsdWVGcm9tTWFpblRocmVhZDxib29sPihbdGhpc10oKSAt PiBib29sIHsKLSAgICAgICAgcmV0dXJuICFtX2NvcmVPYmplY3Q7Ci0gICAgfSk7CisgICAgLy8g Q2FjaGUgdGhlIHN0YXRlIHRvIGF2b2lkIGdvaW5nIHRvIHRoZSBtYWluIHRocmVhZCBmcm9tIHNl cmlhbGl6ZSgpLgorICAgIG1fc3RhdGUuc3RvcmUocmV0dXJuVmFsdWUpOworCisgICAgcmV0dXJu IHJldHVyblZhbHVlOwogfQogCiBTdHJpbmcgQWNjZXNzaWJpbGl0eU9iamVjdEF0c3BpOjppZCgp IGNvbnN0CkBAIC0xMjQ4LDcgKzEyNTEsNyBAQCB2b2lkIEFjY2Vzc2liaWxpdHlPYmplY3RBdHNw aTo6c2VyaWFsaXplKEdWYXJpYW50QnVpbGRlciogYnVpbGRlcikgY29uc3QKICAgICBnX3Zhcmlh bnRfYnVpbGRlcl9hZGQoYnVpbGRlciwgInMiLCBkZXNjcmlwdGlvbigpLmRhdGEoKSk7CiAKICAg ICBHVmFyaWFudEJ1aWxkZXIgc3RhdGVzID0gR19WQVJJQU5UX0JVSUxERVJfSU5JVChHX1ZBUklB TlRfVFlQRSgiYXUiKSk7Ci0gICAgYXV0byBhdHNwaVN0YXRlcyA9IHN0YXRlKCk7CisgICAgYXV0 byBhdHNwaVN0YXRlcyA9IG1fc3RhdGUubG9hZCgpOwogICAgIGdfdmFyaWFudF9idWlsZGVyX2Fk ZCgmc3RhdGVzLCAidSIsIHN0YXRpY19jYXN0PHVpbnQzMl90PihhdHNwaVN0YXRlcyAmIDB4ZmZm ZmZmZmYpKTsKICAgICBnX3ZhcmlhbnRfYnVpbGRlcl9hZGQoJnN0YXRlcywgInUiLCBzdGF0aWNf Y2FzdDx1aW50MzJfdD4oYXRzcGlTdGF0ZXMgPj4gMzIpKTsKICAgICBnX3ZhcmlhbnRfYnVpbGRl cl9hZGQoYnVpbGRlciwgIkBhdSIsIGdfdmFyaWFudF9idWlsZGVyX2VuZCgmc3RhdGVzKSk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0c3BpL0FjY2Vzc2liaWxp dHlPYmplY3RBdHNwaS5oIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdHNwaS9BY2Nl c3NpYmlsaXR5T2JqZWN0QXRzcGkuaAppbmRleCBkZTEyNTBlZGE3YTAuLmQyMzlmNzcwMTVhMSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdHNwaS9BY2Nlc3NpYmls aXR5T2JqZWN0QXRzcGkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0c3Bp L0FjY2Vzc2liaWxpdHlPYmplY3RBdHNwaS5oCkBAIC04Niw3ICs4Niw3IEBAIHB1YmxpYzoKICAg ICBXRUJDT1JFX0VYUE9SVCBWZWN0b3I8UmVmUHRyPEFjY2Vzc2liaWxpdHlPYmplY3RBdHNwaT4+ IGNoaWxkcmVuKCkgY29uc3Q7CiAgICAgV0VCQ09SRV9FWFBPUlQgQWNjZXNzaWJpbGl0eU9iamVj dEF0c3BpKiBjaGlsZEF0KHVuc2lnbmVkKSBjb25zdDsKICAgICBXRUJDT1JFX0VYUE9SVCB1aW50 NjRfdCBzdGF0ZSgpIGNvbnN0OwotICAgIGJvb2wgaXNEZWZ1bmN0KCkgY29uc3Q7CisgICAgYm9v bCBpc0RlZnVuY3QoKSBjb25zdCB7IHJldHVybiBtX2lzRGVmdW5jdC5sb2FkKCk7IH0KICAgICB2 b2lkIHN0YXRlQ2hhbmdlZChjb25zdCBjaGFyKiwgYm9vbCk7CiAgICAgV0VCQ09SRV9FWFBPUlQg SGFzaE1hcDxTdHJpbmcsIFN0cmluZz4gYXR0cmlidXRlcygpIGNvbnN0OwogICAgIFdFQkNPUkVf RVhQT1JUIEhhc2hNYXA8dWludDMyX3QsIFZlY3RvcjxSZWZQdHI8QWNjZXNzaWJpbGl0eU9iamVj dEF0c3BpPj4+IHJlbGF0aW9uTWFwKCkgY29uc3Q7CkBAIC0yNDUsNyArMjQ1LDkgQEAgcHJpdmF0 ZToKICAgICBPcHRpb25TZXQ8SW50ZXJmYWNlPiBtX2ludGVyZmFjZXM7CiAgICAgQWNjZXNzaWJp bGl0eVJvb3RBdHNwaSogbV9yb290IHsgbnVsbHB0ciB9OwogICAgIHN0ZDo6b3B0aW9uYWw8QWNj ZXNzaWJpbGl0eU9iamVjdEF0c3BpKj4gbV9wYXJlbnQ7CisgICAgbXV0YWJsZSBBdG9taWM8dWlu dDY0X3Q+IG1fc3RhdGUgeyAwIH07CiAgICAgQXRvbWljPGJvb2w+IG1faXNSZWdpc3RlcmVkIHsg ZmFsc2UgfTsKKyAgICBBdG9taWM8Ym9vbD4gbV9pc0RlZnVuY3QgeyBmYWxzZSB9OwogICAgIFN0 cmluZyBtX3BhdGg7CiAgICAgU3RyaW5nIG1faHlwZXJsaW5rUGF0aDsKICAgICBpbnQ2NF90IG1f bGFzdFNlbGVjdGlvbkNoYW5nZWRUaW1lIHsgLTEgfTsK