234703 2021-12-27 13:00:56 -0800 Element::boundingAbsoluteRectWithoutLayout() should be marked `const` 2021-12-27 16:31:19 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bfulgham cdumez cmarcelo darin esprehn+autocc ews-watchlist kangil.han simon.fraser webkit-bug-importer zalan oldest_to_newest 1826970 0 wenson_hsieh 2021-12-27 13:00:56 -0800 This method doesn't trigger layout or mutate the element in any way, so it should be `const`. 1826971 1 448005 wenson_hsieh 2021-12-27 13:03:10 -0800 Created attachment 448005 Patch 1826991 2 448005 wenson_hsieh 2021-12-27 16:06:53 -0800 Comment on attachment 448005 Patch Thanks for the review! 1826994 3 ews-feeder 2021-12-27 16:30:14 -0800 Committed r287461 (245596@main): <https://commits.webkit.org/245596@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448005. 1826995 4 webkit-bug-importer 2021-12-27 16:31:19 -0800 <rdar://problem/86945721> 448005 2021-12-27 13:03:10 -0800 2021-12-27 16:30:16 -0800 Patch bug-234703-20211227130309.patch text/plain 3335 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjEzNmFhYzE0NzU4MDEw YTM0OWM3YmIwM2QwNGNlZjQ0MjAzZmNkYi4uMmVhYjU3NGVmNmVmZTJhMmVkOTNmZWMzOWE0YmUw MDkwZDI5ZWZkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTEyLTI3ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEVsZW1lbnQ6OmJv dW5kaW5nQWJzb2x1dGVSZWN0V2l0aG91dExheW91dCgpIHNob3VsZCBiZSBtYXJrZWQgYGNvbnN0 YAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0NzAz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFyayBh biBleGlzdGluZyBtZXRob2Qgb24gRWxlbWVudCBhcyBgY29uc3RgLCBzbyB0aGF0IGl0IGNhbiBi ZSBpbnZva2VkIHdpdGggYGNvbnN0IEVsZW1lbnQqYC9gY29uc3QgRWxlbWVudCZgLgorICAgICAg ICBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBkb20vRWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpsaXN0Qm94RWxlbWVudEJvdW5kaW5nQm94KToKKyAgICAgICAgKFdl YkNvcmU6OkVsZW1lbnQ6OmJvdW5kaW5nQWJzb2x1dGVSZWN0V2l0aG91dExheW91dCBjb25zdCk6 CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50Ojpib3VuZGluZ0Fic29sdXRlUmVjdFdpdGhvdXRM YXlvdXQpOiBEZWxldGVkLgorICAgICAgICAqIGRvbS9FbGVtZW50Lmg6CisKIDIwMjEtMTItMjcg IFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgTW9kYWwg Y29udGFpbmVyIG9ic2VydmVyIHNob3VsZCBkZXRlY3QgYW5kIHN1cHByZXNzIGVsZW1lbnRzIHRo YXQgcHJldmVudCB1c2VyIGludGVyYWN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9k b20vRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKaW5kZXggOWU0 Yjk1ZmZmOWFjNDFjMTRkYTUxN2IxNjRjN2JiODNhYjM3M2VjNi4uNDFkMmM0NjNmMTZlNTZhYTVl ZWMxOGY2MzZkYjg0MWViZGNjMzVjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0Vs ZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcApAQCAtMTY3OCw3 ICsxNjc4LDcgQEAgTGF5b3V0UmVjdCBFbGVtZW50OjphYnNvbHV0ZUV2ZW50SGFuZGxlckJvdW5k cyhib29sJiBpbmNsdWRlc0ZpeGVkUG9zaXRpb25FbGVtZW4KICAgICByZXR1cm4gYWJzb2x1dGVF dmVudEJvdW5kc09mRWxlbWVudEFuZERlc2NlbmRhbnRzKGluY2x1ZGVzRml4ZWRQb3NpdGlvbkVs ZW1lbnRzKTsKIH0KIAotc3RhdGljIHN0ZDo6b3B0aW9uYWw8c3RkOjpwYWlyPFJlbmRlck9iamVj dCosIExheW91dFJlY3Q+PiBsaXN0Qm94RWxlbWVudEJvdW5kaW5nQm94KEVsZW1lbnQmIGVsZW1l bnQpCitzdGF0aWMgc3RkOjpvcHRpb25hbDxzdGQ6OnBhaXI8UmVuZGVyT2JqZWN0KiwgTGF5b3V0 UmVjdD4+IGxpc3RCb3hFbGVtZW50Qm91bmRpbmdCb3goY29uc3QgRWxlbWVudCYgZWxlbWVudCkK IHsKICAgICBIVE1MU2VsZWN0RWxlbWVudCogc2VsZWN0RWxlbWVudDsKICAgICBib29sIGlzR3Jv dXA7CkBAIC0xNzQyLDE0ICsxNzQyLDEzIEBAIFJlZjxET01SZWN0TGlzdD4gRWxlbWVudDo6Z2V0 Q2xpZW50UmVjdHMoKQogICAgIHJldHVybiBET01SZWN0TGlzdDo6Y3JlYXRlKHF1YWRzKTsKIH0K IAotc3RkOjpvcHRpb25hbDxzdGQ6OnBhaXI8UmVuZGVyT2JqZWN0KiwgRmxvYXRSZWN0Pj4gRWxl bWVudDo6Ym91bmRpbmdBYnNvbHV0ZVJlY3RXaXRob3V0TGF5b3V0KCkKK3N0ZDo6b3B0aW9uYWw8 c3RkOjpwYWlyPFJlbmRlck9iamVjdCosIEZsb2F0UmVjdD4+IEVsZW1lbnQ6OmJvdW5kaW5nQWJz b2x1dGVSZWN0V2l0aG91dExheW91dCgpIGNvbnN0CiB7CiAgICAgUmVuZGVyT2JqZWN0KiByZW5k ZXJlciA9IHRoaXMtPnJlbmRlcmVyKCk7CiAgICAgVmVjdG9yPEZsb2F0UXVhZD4gcXVhZHM7CiAg ICAgaWYgKGlzU1ZHRWxlbWVudCgpICYmIHJlbmRlcmVyICYmICFyZW5kZXJlci0+aXNTVkdSb290 T3JMZWdhY3lTVkdSb290KCkpIHsKICAgICAgICAgLy8gR2V0IHRoZSBib3VuZGluZyByZWN0YW5n bGUgZnJvbSB0aGUgU1ZHIG1vZGVsLgotICAgICAgICBTVkdFbGVtZW50JiBzdmdFbGVtZW50ID0g ZG93bmNhc3Q8U1ZHRWxlbWVudD4oKnRoaXMpOwotICAgICAgICBpZiAoYXV0byBsb2NhbFJlY3Qg PSBzdmdFbGVtZW50LmdldEJvdW5kaW5nQm94KCkpCisgICAgICAgIGlmIChhdXRvIGxvY2FsUmVj dCA9IGRvd25jYXN0PFNWR0VsZW1lbnQ+KCp0aGlzKS5nZXRCb3VuZGluZ0JveCgpKQogICAgICAg ICAgICAgcXVhZHMuYXBwZW5kKHJlbmRlcmVyLT5sb2NhbFRvQWJzb2x1dGVRdWFkKCpsb2NhbFJl Y3QpKTsKICAgICB9IGVsc2UgaWYgKGF1dG8gcGFpciA9IGxpc3RCb3hFbGVtZW50Qm91bmRpbmdC b3goKnRoaXMpKSB7CiAgICAgICAgIHJlbmRlcmVyID0gcGFpci52YWx1ZSgpLmZpcnN0OwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9FbGVtZW50LmgKaW5kZXggZmFmY2Y2MWU0ODVlNjc0ZDY2ZWYzNjRjYWU0ODc0MjA4MzY2Zjdi Ni4uZmFkYzVmMGFkNTAxZTQzYjcyNGQ2NmZhY2VjNGNkOGE0N2ZjMTEyNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxl bWVudC5oCkBAIC0yMTMsNyArMjEzLDcgQEAgcHVibGljOgogICAgIC8vIFRoaXMgZG9lcyBub3Qg dXBkYXRlIGxheW91dCwgYW5kIHVzZXMgYWJzb2x1dGVCb3VuZGluZ0JveFJlY3QoKS4KICAgICBX RUJDT1JFX0VYUE9SVCBJbnRSZWN0IGJvdW5kaW5nQm94SW5Sb290Vmlld0Nvb3JkaW5hdGVzKCkg Y29uc3Q7CiAKLSAgICBzdGQ6Om9wdGlvbmFsPHN0ZDo6cGFpcjxSZW5kZXJPYmplY3QqLCBGbG9h dFJlY3Q+PiBib3VuZGluZ0Fic29sdXRlUmVjdFdpdGhvdXRMYXlvdXQoKTsKKyAgICBzdGQ6Om9w dGlvbmFsPHN0ZDo6cGFpcjxSZW5kZXJPYmplY3QqLCBGbG9hdFJlY3Q+PiBib3VuZGluZ0Fic29s dXRlUmVjdFdpdGhvdXRMYXlvdXQoKSBjb25zdDsKIAogICAgIFdFQkNPUkVfRVhQT1JUIEZsb2F0 UmVjdCBib3VuZGluZ0NsaWVudFJlY3QoKTsKIAo=