23469 2009-01-21 19:06:25 -0800 switch (-1 * 0) { default: print("FAIL!"); case 0: } 2009-01-28 14:52:02 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 barraclough barraclough zherczeg oldest_to_newest 106558 0 barraclough 2009-01-21 19:06:25 -0800 FAIL! 106560 1 mrowe 2009-01-21 19:14:38 -0800 Do we really add an exclamation point out of nowhere? 106565 2 26920 barraclough 2009-01-21 19:52:53 -0800 Created attachment 26920 The patch 106567 3 26921 barraclough 2009-01-21 20:01:44 -0800 Created attachment 26921 Typo fix 106568 4 26921 oliver 2009-01-21 20:09:03 -0800 Comment on attachment 26921 Typo fix r=me, as long as there is a testcase 106570 5 barraclough 2009-01-21 20:28:49 -0800 Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/interpreter/Interpreter.cpp Sending LayoutTests/ChangeLog Sending LayoutTests/fast/js/resources/switch-behaviour.js Sending LayoutTests/fast/js/switch-behaviour-expected.txt Transmitting file data ..... Committed revision 40111. 107171 6 zherczeg 2009-01-27 01:20:07 -0800 Hi, the fix of this bug introduces a new bug. Consider the following code: var a = 5.4 switch(val) { case 1: return 10 case 2: return 11 case 3: return 12 case 5: return 14 case 6: return 15 default: return 100 } The switch selects "case 5", because numberToInt32() converts 5.4 to 5, which is wrong in this case! The right test should be something like this in case of scrutinee is a double value: if ((double)((int)scrutinee) == scrutinee) ... ctiForValue((int)scrutinee) 107411 7 ap 2009-01-28 14:52:02 -0800 Could you please file a new bug for this? 26920 2009-01-21 19:52:53 -0800 2009-01-21 20:01:44 -0800 The patch patch.switch-0.txt text/plain 2204 barraclough SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQwMTA4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDEt MjEgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDY5LgorCisgICAgICAgIFdlIG5lZWQg dG8gY2hlY2sgYWxsIG51bWJlcnMgaW4gaW50ZWdlciBzd2l0Y2hlcywgbm90IGp1c3QgdGhvc2UK KyAgICAgICAgcmVwcmVzZW50ZWQgYXMgaW50ZWdlciBKU0ltbWVkaWF0ZXMuCisKKyAgICAgICAg KiBpbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHA6CisgICAgICAgIChKU0M6OkludGVycHJldGVy Ojpwcml2YXRlRXhlY3V0ZSk6CisgICAgICAgIChKU0M6OkludGVycHJldGVyOjpjdGlfb3Bfc3dp dGNoX2ltbSk6CisKIDIwMDktMDEtMjEgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmIEdhcmVuLgpJbmRleDogaW50 ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGludGVycHJldGVyL0ludGVy cHJldGVyLmNwcAkocmV2aXNpb24gNDAxMDgpCisrKyBpbnRlcnByZXRlci9JbnRlcnByZXRlci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTMxNDMsOCArMzE0MywxMyBAQCBKU1ZhbHVlUHRyIEludGVy cHJldGVyOjpwcml2YXRlRXhlY3V0ZShFCiAgICAgICAgIEpTVmFsdWVQdHIgc2NydXRpbmVlID0g Y2FsbEZyYW1lWygrK3ZQQyktPnUub3BlcmFuZF0uanNWYWx1ZShjYWxsRnJhbWUpOwogICAgICAg ICBpZiAoc2NydXRpbmVlLmlzSW50MzJGYXN0KCkpCiAgICAgICAgICAgICB2UEMgKz0gY2FsbEZy YW1lLT5jb2RlQmxvY2soKS0+aW1tZWRpYXRlU3dpdGNoSnVtcFRhYmxlKHRhYmxlSW5kZXgpLm9m ZnNldEZvclZhbHVlKHNjcnV0aW5lZS5nZXRJbnQzMkZhc3QoKSwgZGVmYXVsdE9mZnNldCk7Ci0g ICAgICAgIGVsc2UKLSAgICAgICAgICAgIHZQQyArPSBkZWZhdWx0T2Zmc2V0OworICAgICAgICBl bHNlIHsKKyAgICAgICAgICAgIGludDMyX3QgdmFsdWU7CisgICAgICAgICAgICBpZiAoc2NydXRp bmVlLm51bWJlclRvSW50MzIodmFsdWUpKQorICAgICAgICAgICAgICAgIHZQQyArPSBjYWxsRnJh bWUtPmNvZGVCbG9jaygpLT5pbW1lZGlhdGVTd2l0Y2hKdW1wVGFibGUodGFibGVJbmRleCkub2Zm c2V0Rm9yVmFsdWUodmFsdWUsIGRlZmF1bHRPZmZzZXQpOworICAgICAgICAgICAgZWxzZQorICAg ICAgICAgICAgICAgIHZQQyArPSBkZWZhdWx0T2Zmc2V0OworICAgICAgICB9CiAgICAgICAgIE5F WFRfSU5TVFJVQ1RJT04oKTsKICAgICB9CiAgICAgREVGSU5FX09QQ09ERShvcF9zd2l0Y2hfY2hh cikgewpAQCAtNTk2OCw4ICs1OTczLDEzIEBAIHZvaWQqIEludGVycHJldGVyOjpjdGlfb3Bfc3dp dGNoX2ltbShTVFUKIAogICAgIGlmIChzY3J1dGluZWUuaXNJbnQzMkZhc3QoKSkKICAgICAgICAg cmV0dXJuIGNvZGVCbG9jay0+aW1tZWRpYXRlU3dpdGNoSnVtcFRhYmxlKHRhYmxlSW5kZXgpLmN0 aUZvclZhbHVlKHNjcnV0aW5lZS5nZXRJbnQzMkZhc3QoKSk7Ci0KLSAgICByZXR1cm4gY29kZUJs b2NrLT5pbW1lZGlhdGVTd2l0Y2hKdW1wVGFibGUodGFibGVJbmRleCkuY3RpRGVmYXVsdDsKKyAg ICBlbHNlIHsKKyAgICAgICAgaW50MzJfdCB2YWx1ZTsKKyAgICAgICAgaWYgKHNjcnV0aW5lZS5u dW1iZXJUb0ludDMyKHZhbHVlKSkKKyAgICAgICAgICAgIHJldHVybiBjb2RlQmxvY2stPmltbWVk aWF0ZVN3aXRjaEp1bXBUYWJsZSh0YWJsZUluZGV4KS5jdGlGb3JWYWx1ZSh2YWx1ZXMpOworICAg ICAgICBlbHNlCisgICAgICAgICAgICByZXR1cm4gY29kZUJsb2NrLT5pbW1lZGlhdGVTd2l0Y2hK dW1wVGFibGUodGFibGVJbmRleCkuY3RpRGVmYXVsdDsKKyAgICB9CiB9CiAKIHZvaWQqIEludGVy cHJldGVyOjpjdGlfb3Bfc3dpdGNoX2NoYXIoU1RVQl9BUkdTKQo= 26921 2009-01-21 20:01:44 -0800 2009-01-21 20:09:03 -0800 Typo fix patch.switch-0b.txt text/plain 2203 barraclough SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQwMTA4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDEt MjEgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDY5LgorCisgICAgICAgIFdlIG5lZWQg dG8gY2hlY2sgYWxsIG51bWJlcnMgaW4gaW50ZWdlciBzd2l0Y2hlcywgbm90IGp1c3QgdGhvc2UK KyAgICAgICAgcmVwcmVzZW50ZWQgYXMgaW50ZWdlciBKU0ltbWVkaWF0ZXMuCisKKyAgICAgICAg KiBpbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHA6CisgICAgICAgIChKU0M6OkludGVycHJldGVy Ojpwcml2YXRlRXhlY3V0ZSk6CisgICAgICAgIChKU0M6OkludGVycHJldGVyOjpjdGlfb3Bfc3dp dGNoX2ltbSk6CisKIDIwMDktMDEtMjEgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmIEdhcmVuLgpJbmRleDogaW50 ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGludGVycHJldGVyL0ludGVy cHJldGVyLmNwcAkocmV2aXNpb24gNDAxMDgpCisrKyBpbnRlcnByZXRlci9JbnRlcnByZXRlci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTMxNDMsOCArMzE0MywxMyBAQCBKU1ZhbHVlUHRyIEludGVy cHJldGVyOjpwcml2YXRlRXhlY3V0ZShFCiAgICAgICAgIEpTVmFsdWVQdHIgc2NydXRpbmVlID0g Y2FsbEZyYW1lWygrK3ZQQyktPnUub3BlcmFuZF0uanNWYWx1ZShjYWxsRnJhbWUpOwogICAgICAg ICBpZiAoc2NydXRpbmVlLmlzSW50MzJGYXN0KCkpCiAgICAgICAgICAgICB2UEMgKz0gY2FsbEZy YW1lLT5jb2RlQmxvY2soKS0+aW1tZWRpYXRlU3dpdGNoSnVtcFRhYmxlKHRhYmxlSW5kZXgpLm9m ZnNldEZvclZhbHVlKHNjcnV0aW5lZS5nZXRJbnQzMkZhc3QoKSwgZGVmYXVsdE9mZnNldCk7Ci0g ICAgICAgIGVsc2UKLSAgICAgICAgICAgIHZQQyArPSBkZWZhdWx0T2Zmc2V0OworICAgICAgICBl bHNlIHsKKyAgICAgICAgICAgIGludDMyX3QgdmFsdWU7CisgICAgICAgICAgICBpZiAoc2NydXRp bmVlLm51bWJlclRvSW50MzIodmFsdWUpKQorICAgICAgICAgICAgICAgIHZQQyArPSBjYWxsRnJh bWUtPmNvZGVCbG9jaygpLT5pbW1lZGlhdGVTd2l0Y2hKdW1wVGFibGUodGFibGVJbmRleCkub2Zm c2V0Rm9yVmFsdWUodmFsdWUsIGRlZmF1bHRPZmZzZXQpOworICAgICAgICAgICAgZWxzZQorICAg ICAgICAgICAgICAgIHZQQyArPSBkZWZhdWx0T2Zmc2V0OworICAgICAgICB9CiAgICAgICAgIE5F WFRfSU5TVFJVQ1RJT04oKTsKICAgICB9CiAgICAgREVGSU5FX09QQ09ERShvcF9zd2l0Y2hfY2hh cikgewpAQCAtNTk2OCw4ICs1OTczLDEzIEBAIHZvaWQqIEludGVycHJldGVyOjpjdGlfb3Bfc3dp dGNoX2ltbShTVFUKIAogICAgIGlmIChzY3J1dGluZWUuaXNJbnQzMkZhc3QoKSkKICAgICAgICAg cmV0dXJuIGNvZGVCbG9jay0+aW1tZWRpYXRlU3dpdGNoSnVtcFRhYmxlKHRhYmxlSW5kZXgpLmN0 aUZvclZhbHVlKHNjcnV0aW5lZS5nZXRJbnQzMkZhc3QoKSk7Ci0KLSAgICByZXR1cm4gY29kZUJs b2NrLT5pbW1lZGlhdGVTd2l0Y2hKdW1wVGFibGUodGFibGVJbmRleCkuY3RpRGVmYXVsdDsKKyAg ICBlbHNlIHsKKyAgICAgICAgaW50MzJfdCB2YWx1ZTsKKyAgICAgICAgaWYgKHNjcnV0aW5lZS5u dW1iZXJUb0ludDMyKHZhbHVlKSkKKyAgICAgICAgICAgIHJldHVybiBjb2RlQmxvY2stPmltbWVk aWF0ZVN3aXRjaEp1bXBUYWJsZSh0YWJsZUluZGV4KS5jdGlGb3JWYWx1ZSh2YWx1ZSk7CisgICAg ICAgIGVsc2UKKyAgICAgICAgICAgIHJldHVybiBjb2RlQmxvY2stPmltbWVkaWF0ZVN3aXRjaEp1 bXBUYWJsZSh0YWJsZUluZGV4KS5jdGlEZWZhdWx0OworICAgIH0KIH0KIAogdm9pZCogSW50ZXJw cmV0ZXI6OmN0aV9vcF9zd2l0Y2hfY2hhcihTVFVCX0FSR1MpCg==