234657 2021-12-23 19:02:52 -0800 RemoteInspectorProtocolHandler::inspect() expects ConnectionID as uint32_t 2021-12-26 15:13:17 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 Yousuke.Kimoto webkit-unassigned basuke chris.reid don.olmstead ews-watchlist hi inspector-bugzilla-changes joepeck pangle ross.kirsling tomoki.imai webkit-bug-importer oldest_to_newest 1826680 0 Yousuke.Kimoto 2021-12-23 19:02:52 -0800 https://bugs.webkit.org/show_bug.cgi?id=197243 fixed connection and target identifier types. ConnectionID is using ConnectionID = uint32_t; But currently connectionID is given to RemoteInspectorProtocolHandler::inspect() as "int" by the commit https://github.com/WebKit/WebKit/commit/695e0888fe0472f49fdc27da5f57d0f5e4353e51 m_inspectorProtocolHandler.inspect(requestURL.hostAndPort(), parseInteger<int>(tokens[0]).value_or(0), parseInteger<int>(tokens[1]).value_or(0), tokens[2]); It should be "uint32_t". 1826682 1 447928 Yousuke.Kimoto 2021-12-23 19:25:20 -0800 Created attachment 447928 Patch 1826870 2 447976 Yousuke.Kimoto 2021-12-26 10:07:02 -0800 Created attachment 447976 Patch The previous patch was wrong. The second parseInteger() should also be casted with "uint32_t". 1826917 3 ews-feeder 2021-12-26 15:12:42 -0800 Committed r287450 (245585@main): <https://commits.webkit.org/245585@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447976. 1826918 4 webkit-bug-importer 2021-12-26 15:13:17 -0800 <rdar://problem/86923496> 447928 2021-12-23 19:25:20 -0800 2021-12-26 10:07:02 -0800 Patch patch.diff text/plain 1683 Yousuke.Kimoto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMTk3YmNjMTFmYmU0Li5mNGFmMmE1ZGJjYWMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMjEtMTItMjMgIFlvdXN1a2UgS2ltb3RvICA8WW91c3VrZS5LaW1vdG9Ac29u eS5jb20+CisKKyAgICAgICAgUmVtb3RlSW5zcGVjdG9yUHJvdG9jb2xIYW5kbGVyOjppbnNwZWN0 KCkgZXhwZWN0cyBDb25uZWN0aW9uSUQgYXMgdWludDMyX3QKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDY1NworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNvbm5lY3Rpb25JRCBhIHBhcmFtZXRlciBvZiBT Y3JpcHRNZXNzYWdlQ2xpZW50OjpkaWRQb3N0TWVzc2FnZSgpIGlzIGNhc3RlZWQgYXMgPGludD4u CisgICAgICAgIFNpbmNlIENvbm5lY3Rpb25JRCBpcyBkZWZpbmUgYXMgdWludDMyX3QsIGl0IHNo b3VsZCBiZSBjYXN0ZWQgYXMgPHVpbnQzMl90Pi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9JbnNw ZWN0b3Ivc29ja2V0L1JlbW90ZUluc3BlY3RvclByb3RvY29sSGFuZGxlci5jcHA6IEZpeGVkIGNh c3QgZm9yIGNvbm5lY3Rpb25JRC4KKwogMjAyMS0xMC0xNCAgQWxleCBDaHJpc3RlbnNlbiAgPGFj aHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBBZEF0dHJpYnV0aW9uRGFlbW9u IHBsaXN0IG9uIGlPUwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVj dG9yL3NvY2tldC9SZW1vdGVJbnNwZWN0b3JQcm90b2NvbEhhbmRsZXIuY3BwIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvSW5zcGVjdG9yL3NvY2tldC9SZW1vdGVJbnNwZWN0b3JQcm90b2NvbEhh bmRsZXIuY3BwCmluZGV4IGEwYWM5MmFiOTk5Yi4uMGM0ZWMzMDA1MDAxIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3Ivc29ja2V0L1JlbW90ZUluc3BlY3RvclBy b3RvY29sSGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9y L3NvY2tldC9SZW1vdGVJbnNwZWN0b3JQcm90b2NvbEhhbmRsZXIuY3BwCkBAIC02MCw3ICs2MCw3 IEBAIHB1YmxpYzoKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICBVUkwgcmVxdWVzdFVS TCB7IHsgfSwgcGFnZS5wYWdlTG9hZFN0YXRlKCkudXJsKCkgfTsKLSAgICAgICAgbV9pbnNwZWN0 b3JQcm90b2NvbEhhbmRsZXIuaW5zcGVjdChyZXF1ZXN0VVJMLmhvc3RBbmRQb3J0KCksIHBhcnNl SW50ZWdlcjxpbnQ+KHRva2Vuc1swXSkudmFsdWVfb3IoMCksIHBhcnNlSW50ZWdlcjxpbnQ+KHRv a2Vuc1sxXSkudmFsdWVfb3IoMCksIHRva2Vuc1syXSk7CisgICAgICAgIG1faW5zcGVjdG9yUHJv dG9jb2xIYW5kbGVyLmluc3BlY3QocmVxdWVzdFVSTC5ob3N0QW5kUG9ydCgpLCBwYXJzZUludGVn ZXI8dWludDMyX3Q+KHRva2Vuc1swXSkudmFsdWVfb3IoMCksIHBhcnNlSW50ZWdlcjxpbnQ+KHRv a2Vuc1sxXSkudmFsdWVfb3IoMCksIHRva2Vuc1syXSk7CiAgICAgfQogICAgIAogICAgIGJvb2wg c3VwcG9ydHNBc3luY1JlcGx5KCkgb3ZlcnJpZGUK 447976 2021-12-26 10:07:02 -0800 2021-12-26 15:12:44 -0800 Patch patch.diff text/plain 1688 Yousuke.Kimoto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMTk3YmNjMTFmYmU0Li5mNGFmMmE1ZGJjYWMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMjEtMTItMjMgIFlvdXN1a2UgS2ltb3RvICA8WW91c3VrZS5LaW1vdG9Ac29u eS5jb20+CisKKyAgICAgICAgUmVtb3RlSW5zcGVjdG9yUHJvdG9jb2xIYW5kbGVyOjppbnNwZWN0 KCkgZXhwZWN0cyBDb25uZWN0aW9uSUQgYXMgdWludDMyX3QKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDY1NworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNvbm5lY3Rpb25JRCBhIHBhcmFtZXRlciBvZiBT Y3JpcHRNZXNzYWdlQ2xpZW50OjpkaWRQb3N0TWVzc2FnZSgpIGlzIGNhc3RlZWQgYXMgPGludD4u CisgICAgICAgIFNpbmNlIENvbm5lY3Rpb25JRCBpcyBkZWZpbmUgYXMgdWludDMyX3QsIGl0IHNo b3VsZCBiZSBjYXN0ZWQgYXMgPHVpbnQzMl90Pi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9JbnNw ZWN0b3Ivc29ja2V0L1JlbW90ZUluc3BlY3RvclByb3RvY29sSGFuZGxlci5jcHA6IEZpeGVkIGNh c3QgZm9yIGNvbm5lY3Rpb25JRC4KKwogMjAyMS0xMC0xNCAgQWxleCBDaHJpc3RlbnNlbiAgPGFj aHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBBZEF0dHJpYnV0aW9uRGFlbW9u IHBsaXN0IG9uIGlPUwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVj dG9yL3NvY2tldC9SZW1vdGVJbnNwZWN0b3JQcm90b2NvbEhhbmRsZXIuY3BwIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvSW5zcGVjdG9yL3NvY2tldC9SZW1vdGVJbnNwZWN0b3JQcm90b2NvbEhh bmRsZXIuY3BwCmluZGV4IGEwYWM5MmFiOTk5Yi4uYzBkMDViNjliMDZhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3Ivc29ja2V0L1JlbW90ZUluc3BlY3RvclBy b3RvY29sSGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9y L3NvY2tldC9SZW1vdGVJbnNwZWN0b3JQcm90b2NvbEhhbmRsZXIuY3BwCkBAIC02MCw3ICs2MCw3 IEBAIHB1YmxpYzoKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICBVUkwgcmVxdWVzdFVS TCB7IHsgfSwgcGFnZS5wYWdlTG9hZFN0YXRlKCkudXJsKCkgfTsKLSAgICAgICAgbV9pbnNwZWN0 b3JQcm90b2NvbEhhbmRsZXIuaW5zcGVjdChyZXF1ZXN0VVJMLmhvc3RBbmRQb3J0KCksIHBhcnNl SW50ZWdlcjxpbnQ+KHRva2Vuc1swXSkudmFsdWVfb3IoMCksIHBhcnNlSW50ZWdlcjxpbnQ+KHRv a2Vuc1sxXSkudmFsdWVfb3IoMCksIHRva2Vuc1syXSk7CisgICAgICAgIG1faW5zcGVjdG9yUHJv dG9jb2xIYW5kbGVyLmluc3BlY3QocmVxdWVzdFVSTC5ob3N0QW5kUG9ydCgpLCBwYXJzZUludGVn ZXI8dWludDMyX3Q+KHRva2Vuc1swXSkudmFsdWVfb3IoMCksIHBhcnNlSW50ZWdlcjx1aW50MzJf dD4odG9rZW5zWzFdKS52YWx1ZV9vcigwKSwgdG9rZW5zWzJdKTsKICAgICB9CiAgICAgCiAgICAg Ym9vbCBzdXBwb3J0c0FzeW5jUmVwbHkoKSBvdmVycmlkZQo=