234655 2021-12-23 16:41:26 -0800 clang-format: Set SpaceAfterTemplateKeyword false 2022-01-04 12:59:47 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=183302 InRadar P2 Normal --- 1 fujii fujii don.olmstead heycam kkinnunen ross.kirsling webkit-bug-importer oldest_to_newest 1826666 0 fujii 2021-12-23 16:41:26 -0800 clang-format: Set SpaceAfterTemplateKeyword false Bug 183302 added the folowing setting to .clang-format. > SpaceAfterTemplateKeyword: true However, no space seems more commmon style. $ find Source/{WTF,WebCore,WebKitLegacy,WebKit} -name "*.cpp" -exec grep "template<" "{}" \+ | wc -l 1312 $ find Source/{WTF,WebCore,WebKitLegacy,WebKit} -name "*.cpp" -exec grep "template <" "{}" \+ | wc -l 318 1826668 1 447919 fujii 2021-12-23 16:49:05 -0800 Created attachment 447919 Patch 1826910 2 fujii 2021-12-26 13:09:53 -0800 grepping *.cpp and *.h: $ find Source/{WTF,WebCore,WebKitLegacy,WebKit} -name "*.cpp" -o -name "*.h" -exec grep "template<" "{}" \+ | wc -l 7913 $ find Source/{WTF,WebCore,WebKitLegacy,WebKit} -name "*.cpp" -o -name "*.h" -exec grep "template <" "{}" \+ | wc -l 1385 1827281 3 webkit-bug-importer 2021-12-30 16:42:17 -0800 <rdar://problem/87019846> 1828052 4 fujii 2022-01-04 12:59:47 -0800 Committed r287581 (245710@trunk): <https://commits.webkit.org/245710@trunk> 447919 2021-12-23 16:49:05 -0800 2021-12-24 19:20:04 -0800 Patch bug-234655-20211224094903.patch text/plain 1276 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NDEwCmRpZmYgLS1naXQgYS8uY2xhbmctZm9ybWF0IGIv LmNsYW5nLWZvcm1hdAppbmRleCAyZGMzYjM2ZGJiNmY2ZmI5ZGIyMjdlNGRhMWQzYzA0OTkzZjE1 MTAzLi4wZTdjMGQ1YTEzZTY2M2NjZDc1ZTU4ZDBkMzhlYjM0ZjUxMDRlMzVlIDEwMDY0NAotLS0g YS8uY2xhbmctZm9ybWF0CisrKyBiLy5jbGFuZy1mb3JtYXQKQEAgLTk1LDcgKzk1LDcgQEAgUmVm bG93Q29tbWVudHM6ICB0cnVlCiBTb3J0SW5jbHVkZXM6ICAgIHRydWUKIFNvcnRVc2luZ0RlY2xh cmF0aW9uczogdHJ1ZQogU3BhY2VBZnRlckNTdHlsZUNhc3Q6IGZhbHNlCi1TcGFjZUFmdGVyVGVt cGxhdGVLZXl3b3JkOiB0cnVlCitTcGFjZUFmdGVyVGVtcGxhdGVLZXl3b3JkOiBmYWxzZQogU3Bh Y2VCZWZvcmVBc3NpZ25tZW50T3BlcmF0b3JzOiB0cnVlCiBTcGFjZUJlZm9yZUNwcDExQnJhY2Vk TGlzdDogdHJ1ZQogU3BhY2VCZWZvcmVQYXJlbnM6IENvbnRyb2xTdGF0ZW1lbnRzCmRpZmYgLS1n aXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggYzhmMWIxMmVhMzk5ZmYwODBlNTUyYWI5 MDM1YjY3ZTRlNzc2MzY4NS4uYjZhZWM1NGJhZjI0YTdjN2Q5ODJmZmQzZWFmODRkZDdmY2FjOGY3 ZiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDIxLTEyLTIzICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgor CisgICAgICAgIGNsYW5nLWZvcm1hdDogU2V0IFNwYWNlQWZ0ZXJUZW1wbGF0ZUtleXdvcmQgZmFs c2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDY1 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAx ODMzMDIgYWRkZWQgdGhlIGluaXRpYWwgLmNsYW5nLWZvcm1hdCBmaWxlIHdoaWNoIHdlcmUKKyAg ICAgICAgaW5jbHVkaW5nIFNwYWNlQWZ0ZXJUZW1wbGF0ZUtleXdvcmQ6dHJ1ZS4gSG93ZXZlciwg ZXZlbiB0aG91Z2ggaXQKKyAgICAgICAgaXMgdW5kb2N1bWVudGVkLCB0eXBpY2FsIFdlYktpdCBj b2RlIGlzIHVzaW5nIGEgc3R5bGUgaGF2aW5nIG5vCisgICAgICAgIHNwYWNlIGF0ZXIgdGVtcGxh dGUga2V5d29yZC4KKworICAgICAgICAqIC5jbGFuZy1mb3JtYXQ6CisKIDIwMjEtMTItMjMgIENo YW5nU2VvayBPaCAgPGNoYW5nc2Vva0B3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBjaGFuZ3Nl b2sncyBnaXRodWIgdXNlcm5hbWUuCg==