234652 2021-12-23 15:21:24 -0800 Include a few more tag names to search when running modal container detection 2021-12-31 16:23:47 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 234651 234669 1 wenson_hsieh wenson_hsieh akeerthi bdakin darin hi megan_gardner thorton webkit-bug-importer oldest_to_newest 1826648 0 wenson_hsieh 2021-12-23 15:21:24 -0800 . 1826653 1 447914 wenson_hsieh 2021-12-23 15:32:27 -0800 Created attachment 447914 Depends on #234651 1827275 2 webkit-bug-importer 2021-12-30 15:22:19 -0800 <rdar://problem/87019110> 1827377 3 447914 wenson_hsieh 2021-12-31 15:59:45 -0800 Comment on attachment 447914 Depends on #234651 Thanks for the review! 1827378 4 ews-feeder 2021-12-31 16:23:45 -0800 Committed r287497 (245632@main): <https://commits.webkit.org/245632@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447914. 447914 2021-12-23 15:32:27 -0800 2021-12-31 16:23:46 -0800 Depends on #234651 bug-234652-20211223153226.patch text/plain 5446 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NDA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWU5M2UxYzJhNDk2NjI4 Y2U2OWYxZWZkNzNiNzJhYzRmNjU2ZmQ3MC4uMzFlNzg1NWU0YWQ4MTlhNDllMjFjYjk2YzljNjNk ZmFmM2JiZjk5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTEyLTIzICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEluY2x1ZGUgYSBm ZXcgbW9yZSB0YWcgbmFtZXMgdG8gc2VhcmNoIHdoZW4gcnVubmluZyBtb2RhbCBjb250YWluZXIg ZGV0ZWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzQ2NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCcm9hZGVuIHRoZSBsaXN0IG9mIHRhZyBuYW1lcyB0aGF0IHdlIGhldXJpc3RpY2FsbHkgc2Nh biBmb3IgdGhlIHNlYXJjaCB0ZXJtLiBUaGlzIHBhcnRpY3VsYXIgbW9kYWwgY29udGFpbmVyCisg ICAgICAgIGRldGVjdGlvbiBmYWlsdXJlIHdhcyBkdWUgdG8gdGhlIHNlYXJjaCB0ZXJtIGFwcGVh cmluZyBpbnNpZGUgYSBgYmAgZWxlbWVudCwgdGhvdWdoIEknbSBhZGRpbmcgYSBmZXcgYWRkaXRp b25hbAorICAgICAgICB0eXBlcyBqdXN0IHRvIGJlIHNhZmUuIFNpbmNlIHdlJ3JlIGNoZWNraW5n IG1vcmUgdGhhbiBqdXN0IGZldyB0YWcgbmFtZXMsIHdlIGFsc28gdGFrZSB0aGlzIG9wcG9ydHVu aXR5IHRvCisgICAgICAgIGNvbnZlcnQgdGhpcyBpbnRvIGEgY29tcGFjdCBBdG9tU3RyaW5nIGhh c2h0YWJsZSBvZiB0YWcgbmFtZXMgdGhhdCB3ZSBzaG91bGQgc2NhbiBpbiB0aGUgcHJvY2VzcyBv ZiBkZXRlY3RpbmcKKyAgICAgICAgbW9kYWwgY29udGFpbmVycy4KKworICAgICAgICBUZXN0OiBN b2RhbENvbnRhaW5lck9ic2VydmF0aW9uLkRldGVjdFNlYXJjaFRlcm1JbkJvbGRUYWcKKworICAg ICAgICAqIHBhZ2UvTW9kYWxDb250YWluZXJPYnNlcnZlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjptYXRjaGVzU2VhcmNoVGVybSk6CisKIDIwMjEtMTItMjMgIFdlbnNvbiBIc2llaCAgPHdlbnNv bl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIEFQSSB0ZXN0aW5nIHN1cHBvcnQgZm9y IG1vZGFsIGNvbnRhaW5lciBvYnNlcnZhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGFnZS9Nb2RhbENvbnRhaW5lck9ic2VydmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTW9k YWxDb250YWluZXJPYnNlcnZlci5jcHAKaW5kZXggZjBjZDU0ZTE4ZDdmMGE3NzEwZDVhMGE3Y2I4 ZDkxNTM0MGYwM2UxNi4uOTc5ODA2NzI3NzhkMmZhNTNmYzQ2OTNhNzFlYjhmOTMwN2UyODQxYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9Nb2RhbENvbnRhaW5lck9ic2VydmVyLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL01vZGFsQ29udGFpbmVyT2JzZXJ2ZXIuY3BwCkBA IC00OSw2ICs0OSw3IEBACiAjaW5jbHVkZSAiUmVuZGVyVmlldy5oIgogI2luY2x1ZGUgIlNpbXVs YXRlZENsaWNrT3B0aW9ucy5oIgogI2luY2x1ZGUgIlRleHQuaCIKKyNpbmNsdWRlIDx3dGYvUm9i aW5Ib29kSGFzaFNldC5oPgogI2luY2x1ZGUgPHd0Zi9TY29wZS5oPgogI2luY2x1ZGUgPHd0Zi9V UkwuaD4KIApAQCAtOTQsMTQgKzk1LDMzIEBAIE1vZGFsQ29udGFpbmVyT2JzZXJ2ZXI6On5Nb2Rh bENvbnRhaW5lck9ic2VydmVyKCkgPSBkZWZhdWx0Owogc3RhdGljIGJvb2wgbWF0Y2hlc1NlYXJj aFRlcm0oY29uc3QgVGV4dCYgdGV4dE5vZGUsIGNvbnN0IEF0b21TdHJpbmcmIHNlYXJjaFRlcm0p CiB7CiAgICAgUmVmUHRyIHBhcmVudCA9IHRleHROb2RlLnBhcmVudEVsZW1lbnRJbkNvbXBvc2Vk VHJlZSgpOwotICAgIGJvb2wgc2hvdWxkU2VhcmNoTm9kZSA9IChbJl0gewotICAgICAgICBpZiAo IWlzPEhUTUxFbGVtZW50PihwYXJlbnQuZ2V0KCkpKQotICAgICAgICAgICAgcmV0dXJuIGZhbHNl OwogCi0gICAgICAgIHJldHVybiBwYXJlbnQtPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjphVGFnKSB8 fCBwYXJlbnQtPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjpkaXZUYWcpIHx8IHBhcmVudC0+aGFzVGFn TmFtZShIVE1MTmFtZXM6OnBUYWcpIHx8IHBhcmVudC0+aGFzVGFnTmFtZShIVE1MTmFtZXM6OnNw YW5UYWcpIHx8IHBhcmVudC0+aGFzVGFnTmFtZShIVE1MTmFtZXM6OnNlY3Rpb25UYWcpOwotICAg IH0pKCk7Ci0KLSAgICBpZiAoIXNob3VsZFNlYXJjaE5vZGUpCisgICAgc3RhdGljIE5ldmVyRGVz dHJveWVkIHRhZ05hbWVzVG9TZWFyY2ggPSBbXSB7CisgICAgICAgIHN0YXRpYyBjb25zdGV4cHIg c3RkOjphcnJheSB0YWdzIHsKKyAgICAgICAgICAgICZIVE1MTmFtZXM6OmFUYWcsCisgICAgICAg ICAgICAmSFRNTE5hbWVzOjpkaXZUYWcsCisgICAgICAgICAgICAmSFRNTE5hbWVzOjpwVGFnLAor ICAgICAgICAgICAgJkhUTUxOYW1lczo6c3BhblRhZywKKyAgICAgICAgICAgICZIVE1MTmFtZXM6 OnNlY3Rpb25UYWcsCisgICAgICAgICAgICAmSFRNTE5hbWVzOjpiVGFnLAorICAgICAgICAgICAg JkhUTUxOYW1lczo6aVRhZywKKyAgICAgICAgICAgICZIVE1MTmFtZXM6OnVUYWcsCisgICAgICAg ICAgICAmSFRNTE5hbWVzOjpsaVRhZywKKyAgICAgICAgICAgICZIVE1MTmFtZXM6OmgxVGFnLAor ICAgICAgICAgICAgJkhUTUxOYW1lczo6aDJUYWcsCisgICAgICAgICAgICAmSFRNTE5hbWVzOjpo M1RhZywKKyAgICAgICAgICAgICZIVE1MTmFtZXM6Omg0VGFnLAorICAgICAgICAgICAgJkhUTUxO YW1lczo6aDVUYWcsCisgICAgICAgICAgICAmSFRNTE5hbWVzOjpoNlRhZywKKyAgICAgICAgfTsK KyAgICAgICAgTWVtb3J5Q29tcGFjdExvb2t1cE9ubHlSb2Jpbkhvb2RIYXNoU2V0PEF0b21TdHJp bmc+IHNldDsKKyAgICAgICAgc2V0LnJlc2VydmVJbml0aWFsQ2FwYWNpdHkoc3RkOjpzaXplKHRh Z3MpKTsKKyAgICAgICAgZm9yIChhdXRvJiB0YWcgOiB0YWdzKQorICAgICAgICAgICAgc2V0LmFk ZCh0YWctPmdldCgpLmxvY2FsTmFtZSgpKTsKKyAgICAgICAgcmV0dXJuIHNldDsKKyAgICB9KCk7 CisKKyAgICBpZiAoIWlzPEhUTUxFbGVtZW50PihwYXJlbnQuZ2V0KCkpIHx8ICF0YWdOYW1lc1Rv U2VhcmNoLmdldCgpLmNvbnRhaW5zKGRvd25jYXN0PEhUTUxFbGVtZW50PigqcGFyZW50KS5sb2Nh bE5hbWUoKSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIGlmIChMSUtFTFkoIXRleHRO b2RlLmRhdGEoKS5jb250YWluc0lnbm9yaW5nQVNDSUlDYXNlKHNlYXJjaFRlcm0pKSkKZGlmZiAt LWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2MDNlMDU5N2Zi ZGM1MTI2OGE0YjIzN2ZhMThkZTkwMmYyODA5YjQxLi4wZThkNzU0ZGY5YmEwZDhlODE3Y2U2N2Nm ODZmMDNiZmJiMmYwNzY5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMTItMjMgIFdlbnNvbiBIc2llaCAgPHdl bnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgSW5jbHVkZSBhIGZldyBtb3JlIHRhZyBu YW1lcyB0byBzZWFyY2ggd2hlbiBydW5uaW5nIG1vZGFsIGNvbnRhaW5lciBkZXRlY3Rpb24KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDY1MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhbiBBUEkg dGVzdCB0aGF0J3MgcmVwcmVzZW50YXRpdmUgb2YgdGhlIHdlYnNpdGUgd2hlcmUgbW9kYWwgY29u dGFpbmVyIG9ic2VydmF0aW9uIGZhaWxlZCAoZHVlIHRvIHRoZSBzZWFyY2gKKyAgICAgICAgdGVy bSBiZWluZyBpbnNpZGUgYSBgYmAgZWxlbWVudCkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdENvY29hL01vZGFsQ29udGFpbmVyT2JzZXJ2YXRpb24ubW06CisgICAgICAg IChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAyMS0xMi0yMyAgV2Vuc29uIEhzaWVoICA8d2Vu c29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBNb2RhbCBjb250YWluZXIgY29udHJvbCBj bGFzc2lmaWVyIGZhaWxzIG9uIHNvbWUgbmV1dHJhbCBjb250cm9scyB0aGF0IGNvbnRhaW4gbXVs dGlwbGljYXRpb24gc3ltYm9scwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXRDb2NvYS9Nb2RhbENvbnRhaW5lck9ic2VydmF0aW9uLm1tIGIvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Nb2RhbENvbnRhaW5lck9ic2VydmF0aW9uLm1tCmlu ZGV4IGVlNDQ5OTc3YmFhZDFlYWI3MTQ2ODI0ZTMwMGI0MGJjYWI0NDY0MDUuLjM0NWQ5N2I0OGM2 ZmE4YWUwMjgzM2E1NmU4NGUzMDVkNGEyOTAzMWIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvTW9kYWxDb250YWluZXJPYnNlcnZhdGlvbi5tbQorKysg Yi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL01vZGFsQ29udGFpbmVyT2Jz ZXJ2YXRpb24ubW0KQEAgLTIyMiw0ICsyMjIsMTQgQEAgVEVTVChNb2RhbENvbnRhaW5lck9ic2Vy dmF0aW9uLCBDbGFzc2lmeU11bHRpcGx5U3ltYm9sKQogICAgIEVYUEVDVF9FUShbd2ViVmlldyBs YXN0TW9kYWxDb250YWluZXJJbmZvXS5hdmFpbGFibGVUeXBlcywgX1dLTW9kYWxDb250YWluZXJD b250cm9sVHlwZU5ldXRyYWwpOwogfQogCitURVNUKE1vZGFsQ29udGFpbmVyT2JzZXJ2YXRpb24s IERldGVjdFNlYXJjaFRlcm1JbkJvbGRUYWcpCit7CisgICAgYXV0byB3ZWJWaWV3ID0gY3JlYXRl TW9kYWxDb250YWluZXJXZWJWaWV3KCk7CisgICAgW3dlYlZpZXcgbG9hZEJ1bmRsZVBhZ2U6QCJt b2RhbC1jb250YWluZXItY3VzdG9tIl07CisgICAgW3dlYlZpZXcgZXZhbHVhdGU6QCJzaG93KGA8 Yj5IZWxsbyB3b3JsZDwvYj48YSBocmVmPScjJz5ZZXM8L2E+PGEgaHJlZj0nIyc+Tm88L2E+YCki IGFuZERlY2lkZVBvbGljeTpfV0tNb2RhbENvbnRhaW5lckRlY2lzaW9uSGlkZUFuZElnbm9yZV07 CisKKyAgICBFWFBFQ1RfRkFMU0UoW1t3ZWJWaWV3IGNvbnRlbnRzQXNTdHJpbmddIGNvbnRhaW5z U3RyaW5nOkAiSGVsbG8gd29ybGQiXSk7CisgICAgRVhQRUNUX0VRKFt3ZWJWaWV3IGxhc3RNb2Rh bENvbnRhaW5lckluZm9dLmF2YWlsYWJsZVR5cGVzLCBfV0tNb2RhbENvbnRhaW5lckNvbnRyb2xU eXBlUG9zaXRpdmUgfCBfV0tNb2RhbENvbnRhaW5lckNvbnRyb2xUeXBlTmVnYXRpdmUpOworfQor CiB9IC8vIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJCg==