234638 2021-12-23 06:12:42 -0800 [GTK][a11y] WTR: handle xml-roles attributes to return the right role for landmark with ATSPI 2021-12-26 23:35:08 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 230253 1 cgarcia webkit-unassigned aperez bugs-noreply oldest_to_newest 1826541 0 cgarcia 2021-12-23 06:12:42 -0800 We are not handling xml-roles 1826542 1 447877 cgarcia 2021-12-23 06:13:41 -0800 Created attachment 447877 Patch 1826916 2 447877 aperez 2021-12-26 14:58:40 -0800 Comment on attachment 447877 Patch Patch LGTM, but please do fix the style checker issue before landing. 1826941 3 cgarcia 2021-12-26 23:35:08 -0800 Committed r287454 (245589@trunk): <https://commits.webkit.org/245589@trunk> 447877 2021-12-23 06:13:41 -0800 2021-12-26 14:58:40 -0800 Patch wtr-atspi-xml-roles.diff text/plain 3622 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3MmNl NWMxOGU3MWIuLjQ5MGUxNTAzNzBhOCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTEyLTIzICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVthMTF5XSBX VFI6IGhhbmRsZSB4bWwtcm9sZXMgYXR0cmlidXRlcyB0byByZXR1cm4gdGhlIHJpZ2h0IHJvbGUg Zm9yIGxhbmRtYXJrIHdpdGggQVRTUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIzNDYzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdHNwaS9B Y2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRzcGkuY3BwOgorICAgICAgICAoV1RSOjp4bWxSb2xlVmFs dWVTdHJpbmcpOgorICAgICAgICAoV1RSOjpBY2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojpyb2xlKToK KwogMjAyMS0xMi0yMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0dUS11bYTExeV0gRXhwb3NlIGxpdmUgcmVnaW9uIGF0dHJpYnV0ZXMgd2l0 aCBBVFNQSQpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRs ZS9hdHNwaS9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRzcGkuY3BwIGIvVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdHNwaS9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRzcGku Y3BwCmluZGV4IDAyZTBjY2RkZDViYy4uZTA0YzJlOGYyZTM2IDEwMDY0NAotLS0gYS9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL2F0c3BpL0FjY2Vzc2liaWxpdHlVSUVsZW1l bnRBdHNwaS5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9h dHNwaS9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRzcGkuY3BwCkBAIC0zNSw2ICszNSw4IEBACiAj aW5jbHVkZSA8V2ViQ29yZS9BY2Nlc3NpYmlsaXR5QXRzcGlFbnVtcy5oPgogI2luY2x1ZGUgPFdl YkNvcmUvQWNjZXNzaWJpbGl0eU9iamVjdEF0c3BpLmg+CiAjaW5jbHVkZSA8V2ViS2l0L1dLQnVu ZGxlRnJhbWUuaD4KKyNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KKyNpbmNsdWRlIDx3 dGYvSGFzaFNldC5oPgogI2luY2x1ZGUgPHd0Zi9VUkwuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9D U3RyaW5nLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nQnVpbGRlci5oPgpAQCAtNTY0LDYg KzU2Niw1MiBAQCBKU1JldGFpblB0cjxKU1N0cmluZ1JlZj4gQWNjZXNzaWJpbGl0eVVJRWxlbWVu dDo6cGFyYW1ldGVyaXplZEF0dHJpYnV0ZU5hbWVzKCkKICAgICByZXR1cm4gSlNTdHJpbmdDcmVh dGVXaXRoQ2hhcmFjdGVycyhudWxscHRyLCAwKTsKIH0KIAorc3RhdGljIFN0cmluZyB4bWxSb2xl VmFsdWVTdHJpbmcoY29uc3QgU3RyaW5nJiB4bWxSb2xlcykKK3sKKyAgICBzdGF0aWMgTmV2ZXJE ZXN0cm95ZWQ8SGFzaFNldDxTdHJpbmcsIEFTQ0lJQ2FzZUluc2Vuc2l0aXZlSGFzaD4+IHJlZ2lv blJvbGVzID0gSGFzaFNldDxTdHJpbmcsIEFTQ0lJQ2FzZUluc2Vuc2l0aXZlSGFzaD4oeworICAg ICAgICAiZG9jLWFja25vd2xlZGdtZW50cyIsCisgICAgICAgICJkb2MtYWZ0ZXJ3b3JkIiwKKyAg ICAgICAgImRvYy1hcHBlbmRpeCIsCisgICAgICAgICJkb2MtYmlibGlvZ3JhcGh5IiwKKyAgICAg ICAgImRvYy1jaGFwdGVyIiwKKyAgICAgICAgImRvYy1jb25jbHVzaW9uIiwKKyAgICAgICAgImRv Yy1jcmVkaXRzIiwKKyAgICAgICAgImRvYy1lbmRub3RlcyIsCisgICAgICAgICJkb2MtZXBpbG9n dWUiLAorICAgICAgICAiZG9jLWVycmF0YSIsCisgICAgICAgICJkb2MtZm9yZXdvcmQiLAorICAg ICAgICAiZG9jLWdsb3NzYXJ5IiwKKyAgICAgICAgImRvYy1nbG9zc3JlZiIsCisgICAgICAgICJk b2MtaW5kZXgiLAorICAgICAgICAiZG9jLWludHJvZHVjdGlvbiIsCisgICAgICAgICJkb2MtcGFn ZWxpc3QiLAorICAgICAgICAiZG9jLXBhcnQiLAorICAgICAgICAiZG9jLXByZWZhY2UiLAorICAg ICAgICAiZG9jLXByb2xvZ3VlIiwKKyAgICAgICAgImRvYy10b2MiLAorICAgICAgICAicmVnaW9u IgorICAgIH0pOworCisgICAgaWYgKHJlZ2lvblJvbGVzLT5jb250YWlucyh4bWxSb2xlcykpCisg ICAgICAgIHJldHVybiAiQVhMYW5kbWFya1JlZ2lvbiJfczsKKyAgICBpZiAoZXF1YWxMZXR0ZXJz SWdub3JpbmdBU0NJSUNhc2UoeG1sUm9sZXMsICJiYW5uZXIiKSkKKyAgICAgICAgcmV0dXJuICJB WExhbmRtYXJrQmFubmVyIl9zOworICAgIGlmIChlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2Fz ZSh4bWxSb2xlcywgImNvbXBsZW1lbnRhcnkiKSkKKyAgICAgICAgcmV0dXJuICJBWExhbmRtYXJr Q29tcGxlbWVudGFyeSJfczsKKyAgICBpZiAoZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2Uo eG1sUm9sZXMsICJjb250ZW50aW5mbyIpKQorICAgICAgICByZXR1cm4gIkFYTGFuZG1hcmtDb250 ZW50SW5mbyJfczsKKyAgICBpZiAoZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UoeG1sUm9s ZXMsICJmb3JtIikpCisgICAgICAgIHJldHVybiAiQVhMYW5kbWFya0Zvcm0iX3M7CisgICAgaWYg KGVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKHhtbFJvbGVzLCAibWFpbiIpKQorICAgICAg ICByZXR1cm4gIkFYTGFuZG1hcmtNYWluIl9zOworICAgIGlmIChlcXVhbExldHRlcnNJZ25vcmlu Z0FTQ0lJQ2FzZSh4bWxSb2xlcywgIm5hdmlnYXRpb24iKSkKKyAgICAgICAgcmV0dXJuICJBWExh bmRtYXJrTmF2aWdhdGlvbiJfczsKKyAgICBpZiAoZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNh c2UoeG1sUm9sZXMsICJzZWFyY2giKSkKKyAgICAgICAgcmV0dXJuICJBWExhbmRtYXJrU2VhcmNo Il9zOworCisgICAgcmV0dXJuIHsgfTsKK30KKwogc3RhdGljIFN0cmluZyByb2xlVmFsdWVUb1N0 cmluZyh1bnNpZ25lZCByb2xlVmFsdWUpCiB7CiAgICAgc3dpdGNoIChyb2xlVmFsdWUpIHsKQEAg LTc0Miw3ICs3OTAsOCBAQCBKU1JldGFpblB0cjxKU1N0cmluZ1JlZj4gQWNjZXNzaWJpbGl0eVVJ RWxlbWVudDo6cm9sZSgpCiAgICAgICAgIG1fZWxlbWVudC0+dXBkYXRlQmFja2luZ1N0b3JlKCk7 CiAgICAgICAgIHJvbGVWYWx1ZSA9IG1fZWxlbWVudC0+cm9sZSgpOwogICAgIH0pOwotICAgIGF1 dG8gcm9sZVZhbHVlU3RyaW5nID0gcm9sZVZhbHVlVG9TdHJpbmcocm9sZVZhbHVlKTsKKworICAg IGF1dG8gcm9sZVZhbHVlU3RyaW5nID0gcm9sZVZhbHVlID09IFdlYkNvcmU6OkF0c3BpOjpSb2xl OjpMYW5kbWFyayA/IHhtbFJvbGVWYWx1ZVN0cmluZyhtX2VsZW1lbnQtPmF0dHJpYnV0ZXMoKS5n ZXQoInhtbC1yb2xlcyIpKSA6IHJvbGVWYWx1ZVRvU3RyaW5nKHJvbGVWYWx1ZSk7CiAgICAgaWYg KHJvbGVWYWx1ZVN0cmluZy5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiBKU1N0cmluZ0NyZWF0 ZVdpdGhDaGFyYWN0ZXJzKG51bGxwdHIsIDApOwogCg==