234627 2021-12-22 19:06:28 -0800 Re-enable WebPushD.HandleInjectedPush API test 2021-12-22 23:02:16 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen beidson webkit-bug-importer oldest_to_newest 1826473 0 achristensen 2021-12-22 19:06:28 -0800 Re-enable WebPushD.HandleInjectedPush API test 1826476 1 447851 achristensen 2021-12-22 19:10:27 -0800 Created attachment 447851 Patch 1826489 2 447851 beidson 2021-12-22 21:03:56 -0800 Comment on attachment 447851 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447851&action=review > Source/WebKit/webpushd/PushClientConnection.mm:83 > + // This isn't great, but currently the only user of webpushd in open source builds is TestWebKitAPI and codeSigningIdentifier returns the null String on x86_64 Macs. Is this comment accurate? Are AppleSilicon Macs really different? If so, the difference isn't reflected in this code. 1826494 3 447851 achristensen 2021-12-22 22:35:51 -0800 Comment on attachment 447851 Patch The comment seems to be true, but this code makes all Macs behave the same when not using the internal SDK, independent of CPU architecture. 1826496 4 ews-feeder 2021-12-22 23:01:27 -0800 Committed r287384 (245524@main): <https://commits.webkit.org/245524@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447851. 1826497 5 webkit-bug-importer 2021-12-22 23:02:16 -0800 <rdar://problem/86840145> 447851 2021-12-22 19:10:27 -0800 2021-12-22 23:01:28 -0800 Patch bug-234627-20211222191026.patch text/plain 4002 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3Mzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ0MjM4ZjNkMmQ3MjFkZmEw MjFhZDhmNzIyYjQ2ODZkNmE1YjRmMTcuLmFhZWRjMmNjMGIxOTMyZDQ3ZDA4MjIzNTFlYzQwMTE3 MmExMjg4ZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMTItMjIgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZS1lbmFibGUg V2ViUHVzaEQuSGFuZGxlSW5qZWN0ZWRQdXNoIEFQSSB0ZXN0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQ2MjcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJIG5lZWRlZCB0byBtYWtlIGFuIGVudGl0bGVt ZW50IGNoZWNrIHJldHVybiB0cnVlIHdoZW4gdXNpbmcgdGhlIG5vbi1pbnRlcm5hbCBTREssCisg ICAgICAgIHdoaWNoIGNhbid0IHNpZ24gcHJpdmF0ZSBlbnRpdGxlbWVudHMgaW50byBhIGJpbmFy eS4gIEkgYWxzbyBuZWVkZWQgdG8gbWFrZSB0aGUgZmFrZQorICAgICAgICBUZXN0V2ViS2l0QVBJ IGNvZGUgc2lnbmluZyBpZGVudGlmaWVyIG1hdGNoIHRoZSBpZGVudGlmaWVyIHRoYXQgYXJtNjQg TWFjcyBhY3R1YWxseSBnZXQsCisgICAgICAgIG9yIGVsc2UgbV90ZXN0aW5nUHVzaE1lc3NhZ2Vz IHdvdWxkIG5vdCBjb250YWluIHRoZSByaWdodCBrZXkgaW4gRGFlbW9uOjpnZXRQZW5kaW5nUHVz aE1lc3NhZ2VzCisgICAgICAgIG9uIGFybTY0IE1hY3MuCisKKyAgICAgICAgKiB3ZWJwdXNoZC9Q dXNoQ2xpZW50Q29ubmVjdGlvbi5tbToKKyAgICAgICAgKFdlYlB1c2hEOjpDbGllbnRDb25uZWN0 aW9uOjpob3N0QXBwQ29kZVNpZ25pbmdJZGVudGlmaWVyKToKKyAgICAgICAgKFdlYlB1c2hEOjpD bGllbnRDb25uZWN0aW9uOjpob3N0SGFzRW50aXRsZW1lbnQpOgorCiAyMDIxLTEyLTIyICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmUtZW5h YmxlIEN1c3RvbURpc3BsYXlOYW1lIGFuZCBEZWZhdWx0RGlzcGxheU5hbWUgQVBJIHRlc3RzIG9u IE1vbnRlcmV5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3dlYnB1c2hkL1B1c2hDbGllbnRD b25uZWN0aW9uLm1tIGIvU291cmNlL1dlYktpdC93ZWJwdXNoZC9QdXNoQ2xpZW50Q29ubmVjdGlv bi5tbQppbmRleCBiZTRjYTBhYThjYmM2ZDQ4MDMwNjBlY2Q1ZWY2OTkwZDM2YmU5NWYyLi5jNzRj ZTgyZDA2NmI0M2JmZjQyODdhZDZkYTUxMTA3NWZkYmZmNzc5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L3dlYnB1c2hkL1B1c2hDbGllbnRDb25uZWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJL aXQvd2VicHVzaGQvUHVzaENsaWVudENvbm5lY3Rpb24ubW0KQEAgLTgwLDggKzgwLDggQEAgY29u c3QgU3RyaW5nJiBDbGllbnRDb25uZWN0aW9uOjpob3N0QXBwQ29kZVNpZ25pbmdJZGVudGlmaWVy KCkKIHsKICAgICBpZiAoIW1faG9zdEFwcENvZGVTaWduaW5nSWRlbnRpZmllcikgewogI2lmIFBM QVRGT1JNKE1BQykgJiYgIVVTRShBUFBMRV9JTlRFUk5BTF9TREspCi0gICAgICAgIC8vIFRoaXMg aXNuJ3QgZ3JlYXQsIGJ1dCBjdXJyZW50bHkgdGhlIG9ubHkgdXNlciBvZiB3ZWJwdXNoZCBpbiBv cGVuIHNvdXJjZSBidWlsZHMgaXMgVGVzdFdlYktpdEFQSSBhbmQgY29kZVNpZ25pbmdJZGVudGlm aWVyIHJldHVybnMgdGhlIG51bGwgU3RyaW5nLgotICAgICAgICBtX2hvc3RBcHBDb2RlU2lnbmlu Z0lkZW50aWZpZXIgPSAiVGVzdFdlYktpdEFQSSI7CisgICAgICAgIC8vIFRoaXMgaXNuJ3QgZ3Jl YXQsIGJ1dCBjdXJyZW50bHkgdGhlIG9ubHkgdXNlciBvZiB3ZWJwdXNoZCBpbiBvcGVuIHNvdXJj ZSBidWlsZHMgaXMgVGVzdFdlYktpdEFQSSBhbmQgY29kZVNpZ25pbmdJZGVudGlmaWVyIHJldHVy bnMgdGhlIG51bGwgU3RyaW5nIG9uIHg4Nl82NCBNYWNzLgorICAgICAgICBtX2hvc3RBcHBDb2Rl U2lnbmluZ0lkZW50aWZpZXIgPSAiY29tLmFwcGxlLldlYktpdC5UZXN0V2ViS2l0QVBJIjsKICNl bHNlCiAgICAgICAgIGlmICghbV9ob3N0QXBwQXVkaXRUb2tlbikKICAgICAgICAgICAgIG1faG9z dEFwcENvZGVTaWduaW5nSWRlbnRpZmllciA9IFN0cmluZygpOwpAQCAtMTEwLDcgKzExMCwxMSBA QCBib29sIENsaWVudENvbm5lY3Rpb246Omhvc3RIYXNFbnRpdGxlbWVudChjb25zdCBjaGFyKiBl bnRpdGxlbWVudCkKIHsKICAgICBpZiAoIW1faG9zdEFwcEF1ZGl0VG9rZW4pCiAgICAgICAgIHJl dHVybiBmYWxzZTsKKyNpZiAhUExBVEZPUk0oTUFDKSB8fCBVU0UoQVBQTEVfSU5URVJOQUxfU0RL KQogICAgIHJldHVybiBXVEY6Omhhc0VudGl0bGVtZW50KCptX2hvc3RBcHBBdWRpdFRva2VuLCBl bnRpdGxlbWVudCk7CisjZWxzZQorICAgIHJldHVybiB0cnVlOworI2VuZGlmCiB9CiAKIHZvaWQg Q2xpZW50Q29ubmVjdGlvbjo6c2V0RGVidWdNb2RlSXNFbmFibGVkKGJvb2wgZW5hYmxlZCkKZGlm ZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiNjI5Yzky YWRhYTJkNjA3MTMyZTU3YWViYzgzMWYwMzc1YjgyY2E4Li5hZWZjZWM1NzEwMjg3Y2MzNzY0MDI4 M2Y5ZDExZDM1NTdhMmM4ZjMzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9v bHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjEtMTItMjIgIEFsZXggQ2hyaXN0ZW5z ZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZS1lbmFibGUgV2ViUHVz aEQuSGFuZGxlSW5qZWN0ZWRQdXNoIEFQSSB0ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQ2MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2Ev V2ViUHVzaERhZW1vbi5tbToKKwogMjAyMS0xMi0yMiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJp c3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlLWVuYWJsZSBDdXN0b21EaXNwbGF5TmFt ZSBhbmQgRGVmYXVsdERpc3BsYXlOYW1lIEFQSSB0ZXN0cyBvbiBNb250ZXJleQpkaWZmIC0tZ2l0 IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XZWJQdXNoRGFlbW9uLm1t IGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XZWJQdXNoRGFlbW9uLm1t CmluZGV4IGNmMDE3NzI4N2QwMjQ1MDczNzVhNTg3ZWNhZjIzYWU5MWQ3NjY2NzkuLjZkOTJjZTk3 ODZhZjgxYzc4NGIxMjQ0NDE5ZTZkZTYyODAzY2U4MjAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV2ViUHVzaERhZW1vbi5tbQorKysgYi9Ub29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dlYlB1c2hEYWVtb24ubW0KQEAgLTQxOCwx MiArNDE4LDcgQEAgc3RhdGljIHZvaWQgY2xlYXJXZWJzaXRlRGF0YVN0b3JlKFdLV2Vic2l0ZURh dGFTdG9yZSAqc3RvcmUpCiAgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZjbGVhcmVkU3Rv cmUpOwogfQogCi0vLyBGSVhNRTogUmUtZW5hYmxlIHRoaXMgdGVzdCBvbiBNYWMgb25jZSB3ZWJr aXQub3JnLzIzMjg1NyBpcyByZXNvbHZlZC4KLSNpZiBQTEFURk9STShNQUMpICYmICFVU0UoQVBQ TEVfSU5URVJOQUxfU0RLKQotVEVTVChXZWJQdXNoRCwgRElTQUJMRURfSGFuZGxlSW5qZWN0ZWRQ dXNoKQotI2Vsc2UKIFRFU1QoV2ViUHVzaEQsIEhhbmRsZUluamVjdGVkUHVzaCkKLSNlbmRpZgog ewogICAgIFtXS1dlYnNpdGVEYXRhU3RvcmUgX2FsbG93V2Vic2l0ZURhdGFSZWNvcmRzRm9yQWxs T3JpZ2luc107CiAK