234626 2021-12-22 17:10:00 -0800 _paintBehaviorForDestinationContext should consider kCGContextTypeDisplayList type contexts as potentially being snapshots 2022-01-12 14:38:39 -0800 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mattwoodrow webkit-unassigned heycam sabouhallawa simon.fraser thorton webkit-bug-importer oldest_to_newest 1826453 0 mattwoodrow 2021-12-22 17:10:00 -0800 rdar://83501315 _paintBehaviorForDestinationContext currently always returns `Normal` for contexts that aren't a bitmap context. AppKit now provides a context that is of type kCGContextTypeDisplayList, and we want to still potentially consider it a snapshot draw (if the other conditions below are met). 1826456 1 447846 mattwoodrow 2021-12-22 17:14:02 -0800 Created attachment 447846 Patch 1826459 2 mattwoodrow 2021-12-22 17:15:32 -0800 No test yet, but happy to add one if anyone has ideas on how to test this. Ideally we'd test that images get sync decoded from AppKit, but it might be sufficient to have a unit test that passes a display list context, and confirms that the PaintBehavior::Snapshotting flag is set (if this is observable somehow). 1830349 3 ews-feeder 2022-01-12 14:38:35 -0800 Committed r287951 (245980@main): <https://commits.webkit.org/245980@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447846. 447846 2021-12-22 17:14:02 -0800 2022-01-12 14:38:37 -0800 Patch bug-234626-20211223141401.patch text/plain 2082 mattwoodrow U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3Mzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggNmU1MGQyYTg4MmVmYmQ2ODUxZWI5NTYzZGM2M2Q5M2ExZmRiZjFiYy4uNmFhZjQwMzJkZjI3 ODVmODMyMmUwMzZjZWY5YWRlYmRlMjQ5MmE1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTEyLTIyICBNYXR0IFdvb2Ryb3cgIDxtYXR0d29vZHJv d0BhcHBsZS5jb20+CisKKyAgICAgICAgX3BhaW50QmVoYXZpb3JGb3JEZXN0aW5hdGlvbkNvbnRl eHQgc2hvdWxkIGNvbnNpZGVyIGtDR0NvbnRleHRUeXBlRGlzcGxheUxpc3QgdHlwZSBjb250ZXh0 cyBhcyBwb3RlbnRpYWxseSBiZWluZyBzbmFwc2hvdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDYyNgorICAgICAgICA8cmRhcjovLzgzNTAxMzE1 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIF9wYWlu dEJlaGF2aW9yRm9yRGVzdGluYXRpb25Db250ZXh0IGN1cnJlbnRseSBhbHdheXMgcmV0dXJucyBg Tm9ybWFsYCBmb3IgY29udGV4dHMgdGhhdCBhcmVuJ3QgYSBiaXRtYXAgY29udGV4dC4KKyAgICAg ICAgQXBwS2l0IG5vdyBwcm92aWRlcyBhIGNvbnRleHQgdGhhdCBpcyBvZiB0eXBlIGtDR0NvbnRl eHRUeXBlRGlzcGxheUxpc3QsIGFuZCB3ZSB3YW50IHRvIHN0aWxsIHBvdGVudGlhbGx5IGNvbnNp ZGVyIGl0IGEKKyAgICAgICAgc25hcHNob3QgcGFpbnQgKGlmIHRoZSBvdGhlciBjb25kaXRpb25z IGJlbG93IGFyZSBtZXQpLiBUaGlzIGVuc3VyZSBpbWFnZXMgYXJlIHN5bmMgZGVjb2RlZCBmb3Ig Y29uc3VtZXJzIHRoYXQganVzdAorICAgICAgICB3YW50IGEgc2luZ2xlIHBhaW50LgorCisgICAg ICAgICogV2ViVmlldy9XZWJGcmFtZS5tbToKKyAgICAgICAgKC1bV2ViRnJhbWUgX3BhaW50QmVo YXZpb3JGb3JEZXN0aW5hdGlvbkNvbnRleHQ6XSk6CisKIDIwMjEtMTItMjEgIEJyYWR5IEVpZHNv biAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgTm90aWZpY2F0aW9uIGlkZW50 aWZpZXJzIGJlIGEgVVVJRCBzdHJpbmcgaW5zdGVhZCBvZiBhIHVpbnQ2NF90CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYkZyYW1lLm1tIGIvU291cmNlL1dl YktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJGcmFtZS5tbQppbmRleCAwZTA1YjE4ZDY5NjM5ODI4 ZDQzM2M0NmQ3OTIxY2Y3MGRlN2RmOWQxLi5hZTc3Yjk2YTJjYjA3NDMzMzI5ZTlkODYzMzQ4NTk2 MGE0Yzc2YjgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dl YkZyYW1lLm1tCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViRnJhbWUu bW0KQEAgLTU4NSw3ICs1ODUsNyBAQCBzdGF0aWMgTlNVUkwgKmNyZWF0ZVVuaXF1ZVdlYkRhdGFV UkwoKTsKICAgICAgICAgcmV0dXJuIE9wdGlvblNldDxXZWJDb3JlOjpQYWludEJlaGF2aW9yPihX ZWJDb3JlOjpQYWludEJlaGF2aW9yOjpGbGF0dGVuQ29tcG9zaXRpbmdMYXllcnMpIHwgV2ViQ29y ZTo6UGFpbnRCZWhhdmlvcjo6U25hcHNob3R0aW5nOwogI2VuZGlmCiAKLSAgICBpZiAoQ0dDb250 ZXh0R2V0VHlwZShjb250ZXh0KSAhPSBrQ0dDb250ZXh0VHlwZUJpdG1hcCkKKyAgICBpZiAoQ0dD b250ZXh0R2V0VHlwZShjb250ZXh0KSAhPSBrQ0dDb250ZXh0VHlwZUJpdG1hcCAmJiBDR0NvbnRl eHRHZXRUeXBlKGNvbnRleHQpICE9IGtDR0NvbnRleHRUeXBlRGlzcGxheUxpc3QpCiAgICAgICAg IHJldHVybiBXZWJDb3JlOjpQYWludEJlaGF2aW9yOjpOb3JtYWw7CiAKICAgICAvLyBJZiB3ZSdy ZSBkcmF3aW5nIGludG8gYSBiaXRtYXAsIHdlIGNvdWxkIGJlIHNuYXBzaG90dGluZyBvciBkcmF3 aW5nIGludG8gYSBsYXllci1iYWNrZWQgdmlldy4K