234622 2021-12-22 16:14:22 -0800 SharedBuffer::copy() should return a contiguous SharedBuffer 2022-01-01 16:10:28 -0800 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jean-yves.avenard jean-yves.avenard darin webkit-bug-importer oldest_to_newest 1826431 0 jean-yves.avenard 2021-12-22 16:14:22 -0800 Right now, when copying a SharedBuffer what is return is a FragmentedSharedBuffer; causing an unnecessry memory allocation when making it contiguous again. 1826433 1 webkit-bug-importer 2021-12-22 16:14:49 -0800 <rdar://problem/86829527> 1826452 2 447845 jean-yves.avenard 2021-12-22 17:01:50 -0800 Created attachment 447845 Patch 1827461 3 ews-feeder 2022-01-01 16:10:27 -0800 Committed r287506 (245641@main): <https://commits.webkit.org/245641@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447845. 447845 2021-12-22 17:01:50 -0800 2022-01-01 16:10:28 -0800 Patch bug-234622-20211223120148.patch text/plain 3352 jean-yves.avenard U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTg2ZTU5OWRkODEzZTg4 MWE1ZjliMmY1MmUxOTFhNzcyODE0MzM3Yy4uYjMyYjc2ZmRhMDliMmVjNDRlZDJiZmQ3MWJjNDlm ZTA3ZDU0MzM1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTEyLTIyICBKZWFu LVl2ZXMgQXZlbmFyZCAgPGp5YUBhcHBsZS5jb20+CisKKyAgICAgICAgbWFrZSBTaGFyZWRCdWZm ZXI6OmNvcHkoKSByZXR1cm4gYSBjb250aWd1b3VzIFNoYXJlZEJ1ZmZlcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0NjIyCisgICAgICAgIHJkYXI6 Ly9wcm9ibGVtLzg2ODI5NTI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgbWFrZSBTaGFyZWRCdWZmZXI6OmNvcHkoKSByZXR1cm4gYSBjb250aWd1b3Vz IFNoYXJlZEJ1ZmZlcgorCisgICAgICAgIEFQSSB0ZXN0cyBhZGRlZC4KKworICAgICAgICAqIHBs YXRmb3JtL1NoYXJlZEJ1ZmZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFnbWVudGVkU2hh cmVkQnVmZmVyOjpjb3B5IGNvbnN0KToKKwogMjAyMS0xMi0yMiAgSmVhbi1ZdmVzIEF2ZW5hcmQg IDxqeWFAYXBwbGUuY29tPgogCiAgICAgICAgIEhhdmUgQ2FjaGVkUmF3UmVzb3VyY2VDbGllbnQg YW5kIHJlbGF0ZWQgbmV0d29ya2luZyBhY3RvcnMgdXNlIFNoYXJlZEJ1ZmZlci4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJlZEJ1ZmZlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9TaGFyZWRCdWZmZXIuY3BwCmluZGV4IDQwMDRhOWQ2YzFiNGNkNWVhZjRm MzYyODc5YzhjNWU2MGQ4NDEyNGUuLjQzMGI0MzQ4OTgzZmE5MjQ5MTI1NjMxMjNhOTgzOGQ1MThm YjZlYmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJlZEJ1ZmZlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmNwcApAQCAtMjMx LDYgKzIzMSw4IEBAIHZvaWQgRnJhZ21lbnRlZFNoYXJlZEJ1ZmZlcjo6Y2xlYXIoKQogCiBSZWY8 RnJhZ21lbnRlZFNoYXJlZEJ1ZmZlcj4gRnJhZ21lbnRlZFNoYXJlZEJ1ZmZlcjo6Y29weSgpIGNv bnN0CiB7CisgICAgaWYgKG1fY29udGlndW91cykKKyAgICAgICAgcmV0dXJuIG1fc2VnbWVudHMu c2l6ZSgpID8gU2hhcmVkQnVmZmVyOjpjcmVhdGUobV9zZWdtZW50c1swXS5zZWdtZW50LmNvcHlS ZWYoKSkgOiBTaGFyZWRCdWZmZXI6OmNyZWF0ZSgpOwogICAgIFJlZjxGcmFnbWVudGVkU2hhcmVk QnVmZmVyPiBjbG9uZSA9IGFkb3B0UmVmKCpuZXcgRnJhZ21lbnRlZFNoYXJlZEJ1ZmZlcik7CiAg ICAgY2xvbmUtPm1fc2l6ZSA9IG1fc2l6ZTsKICAgICBjbG9uZS0+bV9zZWdtZW50cy5yZXNlcnZl SW5pdGlhbENhcGFjaXR5KG1fc2VnbWVudHMuc2l6ZSgpKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0No YW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3NDc5MjA5ZDZiMjVjNWQ1ZTM1MWEzOGEz MThjYjBkOWYyNTYzN2ExLi5hMjc5NmNhYjYzNGY2MDk2MzllMDE4YTBjMzQ2OWQ3ZTIzZWJjZTUw IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMjEtMTItMjIgIEplYW4tWXZlcyBBdmVuYXJkICA8anlhQGFwcGxlLmNv bT4KKworICAgICAgICBtYWtlIFNoYXJlZEJ1ZmZlcjo6Y29weSgpIHJldHVybiBhIGNvbnRpZ3Vv dXMgU2hhcmVkQnVmZmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMzQ2MjIKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vODY4Mjk1MjcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkv VGVzdHMvV2ViQ29yZS9TaGFyZWRCdWZmZXIuY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6 VEVTVF9GKToKKwogMjAyMS0xMi0xOCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3 ZWJraXQub3JnPgogCiAgICAgICAgIFtNb250ZXJleV0gVGVzdFdlYktpdEFQSS5Qcml2YXRlQ2xp Y2tNZWFzdXJlbWVudC5EYWVtb24qIHRlc3RzIHRpbWluZyBvdXQ6IEZhaWxlZCB0byBjb25uZWN0 IHRvIG1hY2ggc2VydmljZSBvcmcud2Via2l0LnBjbXRlc3RkYWVtb24uc2VydmljZQpkaWZmIC0t Z2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1NoYXJlZEJ1ZmZlci5jcHAg Yi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvU2hhcmVkQnVmZmVyLmNwcAppbmRl eCBmMTJiOWYwODM2MDU1ODk0Y2Q2NWE4MjNkNWZmNmUzNGI5OGFkNTk4Li4wNjY5ZDA3YzY0Zjlk ZjU0OWMzZTUxMDJlZDY3YjY5Y2MyOTU0MmY5IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYkNvcmUvU2hhcmVkQnVmZmVyLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYkNvcmUvU2hhcmVkQnVmZmVyLmNwcApAQCAtMzAzLDYgKzMwMywxNSBAQCBU RVNUX0YoRnJhZ21lbnRlZFNoYXJlZEJ1ZmZlclRlc3QsIHJlYWQpCiAgICAgY2hlY2soYnVpbGRl ci50YWtlKCkpOwogfQogCitURVNUX0YoRnJhZ21lbnRlZFNoYXJlZEJ1ZmZlclRlc3QsIGNvcHlJ c0NvbnRpZ3VvdXMpCit7CisgICAgRVhQRUNUX1RSVUUoU2hhcmVkQnVmZmVyOjpjcmVhdGUoKS0+ Y29weSgpLT5pc0NvbnRpZ3VvdXMoKSk7CisgICAgRVhQRUNUX0ZBTFNFKEZyYWdtZW50ZWRTaGFy ZWRCdWZmZXI6OmNyZWF0ZSgpLT5jb3B5KCktPmlzQ29udGlndW91cygpKTsKKyAgICBjb25zdCBj aGFyKiBjb25zdCBzaW1wbGVUZXh0ID0gIlRoaXMgaXMgYSBzaW1wbGUgdGVzdC4iOworICAgIEVY UEVDVF9UUlVFKFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlKHNpbXBsZVRleHQsIHN0cmxlbihzaW1wbGVU ZXh0KSktPmNvcHkoKS0+aXNDb250aWd1b3VzKCkpOworICAgIEVYUEVDVF9GQUxTRShGcmFnbWVu dGVkU2hhcmVkQnVmZmVyOjpjcmVhdGUoc2ltcGxlVGV4dCwgc3RybGVuKHNpbXBsZVRleHQpKS0+ Y29weSgpLT5pc0NvbnRpZ3VvdXMoKSk7Cit9CisKICNpZiBFTkFCTEUoTUhUTUwpCiAvLyBTaGFy ZWRCdWZmZXJDaHVua1JlYWRlciB1bml0LXRlc3RzIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0KIHRlbXBsYXRlPCB0eXBlbmFtZSBULCBzaXplX3QgTiA+Cg==