234619 2021-12-22 14:29:10 -0800 Hardening: decodeArrayBuffer is missing WARN_UNUSED_RETURN 2021-12-22 17:49:35 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham achristensen bfulgham ews-watchlist jiewen_tan pascoe oldest_to_newest 1826402 0 bfulgham 2021-12-22 14:29:10 -0800 We recently noticed that the template function decodeArrayBuffer is missing WARN_UNUSED_RETURN. This patch just adds the declaration to help us avoid misusing the method. 1826406 1 bfulgham 2021-12-22 14:30:18 -0800 <rdar://problem/62755159> 1826407 2 447834 bfulgham 2021-12-22 14:31:31 -0800 Created attachment 447834 Patch 1826443 3 447834 achristensen 2021-12-22 16:42:39 -0800 Comment on attachment 447834 Patch I see no reason not to do this. 1826454 4 447834 bfulgham 2021-12-22 17:11:08 -0800 Comment on attachment 447834 Patch Thank you for the review! 1826466 5 ews-feeder 2021-12-22 17:49:33 -0800 Committed r287380 (245520@main): <https://commits.webkit.org/245520@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447834. 447834 2021-12-22 14:31:31 -0800 2021-12-22 17:49:34 -0800 Patch bug-234619-20211222143130.patch text/plain 1478 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmZmNDg5OTEyMGI2ODU1 MmZlOTNhYTVmYjIxODBmOTBiMjU4YWZjZS4uMmVhZDcxMzcwZDJmMWQ5YTgyYTZiNWM2NjVhNTFj NmU3YzBmOWFkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTEyLTIyICBCcmVu dCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEhhcmRlbmluZzogZGVj b2RlQXJyYXlCdWZmZXIgaXMgbWlzc2luZyBXQVJOX1VOVVNFRF9SRVRVUk4gCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQ2MTkKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzYyNzU1MTU5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdXRobi9BdXRoZW50aWNhdG9yUmVzcG9uc2VE YXRhLmg6CisgICAgICAgIChXZWJDb3JlOjpkZWNvZGVBcnJheUJ1ZmZlcik6IEFkZCBXQVJOX1VO VVNFRF9SRVRVUk4gdG8gZGVjbGFyYXRpb24uCisKIDIwMjEtMTItMjIgIEFudHRpIEtvaXZpc3Rv ICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFs6aGFzKCkgcHNldWRvLWNsYXNzXSA6aGFz KCkgc2VsZWN0b3IgaW52YWxpZGF0aW9uIGlzc3VlIHdpdGggdG9nZ2xpbmcgOmNoZWNrZWQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXV0aG4vQXV0aGVudGljYXRvclJl c3BvbnNlRGF0YS5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdXRobi9BdXRoZW50aWNh dG9yUmVzcG9uc2VEYXRhLmgKaW5kZXggNTU5MTM2YjIzZjQ0NTQxNWFiZjYyODIwM2Q3ZDBmZWJk ZmM0ZGNkYi4uODE5MGYzOGYyNzRmYmFmMmQ4MmRlNDkwM2Q0YjJhZGM0NWQ3OGE5YyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdXRobi9BdXRoZW50aWNhdG9yUmVzcG9u c2VEYXRhLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdXRobi9BdXRoZW50aWNh dG9yUmVzcG9uc2VEYXRhLmgKQEAgLTYzLDcgKzYzLDcgQEAgc3RhdGljIHZvaWQgZW5jb2RlQXJy YXlCdWZmZXIoRW5jb2RlciYgZW5jb2RlciwgY29uc3QgQXJyYXlCdWZmZXImIGJ1ZmZlcikKIH0K IAogdGVtcGxhdGU8Y2xhc3MgRGVjb2Rlcj4KLVJlZlB0cjxBcnJheUJ1ZmZlcj4gZGVjb2RlQXJy YXlCdWZmZXIoRGVjb2RlciYgZGVjb2RlcikKK1JlZlB0cjxBcnJheUJ1ZmZlcj4gV0FSTl9VTlVT RURfUkVUVVJOIGRlY29kZUFycmF5QnVmZmVyKERlY29kZXImIGRlY29kZXIpCiB7CiAgICAgc3Rk OjpvcHRpb25hbDx1aW50NjRfdD4gbGVuZ3RoOwogICAgIGRlY29kZXIgPj4gbGVuZ3RoOwo=