234601 2021-12-22 06:16:27 -0800 [GTK][a11y] WTR: handle missing cases in isAttributeSettable with ATSPI 2021-12-23 00:57:14 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 230253 1 cgarcia webkit-unassigned aperez bugs-noreply oldest_to_newest 1826277 0 cgarcia 2021-12-22 06:16:27 -0800 We need to handle aria-readly attribute and the combobox and listbox elements 1826279 1 447799 cgarcia 2021-12-22 06:18:30 -0800 Created attachment 447799 Patch 1826509 2 cgarcia 2021-12-23 00:57:14 -0800 Committed r287391 (245531@trunk): <https://commits.webkit.org/245531@trunk> 447799 2021-12-22 06:18:30 -0800 2021-12-22 09:22:59 -0800 Patch wtr-atspi-setable.diff text/plain 2552 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlYjg5 ZjFjYWI5NDYuLmIyZmUyYWIzYjIwYyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTEyLTIyICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVthMTF5XSBX VFI6IGhhbmRsZSBtaXNzaW5nIGNhc2VzIGluIGlzQXR0cmlidXRlU2V0dGFibGUgd2l0aCBBVFNQ SQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0NjAx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgbmVl ZCB0byBoYW5kbGUgYXJpYS1yZWFkb25seSBhdHRyaWJ1dGUgYW5kIHRoZSBjb21ib2JveCBhbmQg bGlzdGJveCBlbGVtZW50cy4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRC dW5kbGUvYXRzcGkvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0c3BpLmNwcDoKKyAgICAgICAgKFdU Ujo6QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6aXNBdHRyaWJ1dGVTZXR0YWJsZSk6CisKIDIwMjEt MTItMjIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtHVEtdW2ExMXldIFdUUjogYWRkIG1pc3NpbmcgYm9vbCBhbmQgc3RyaW5nIGF0dHJpYnV0 ZSB2YWx1ZXMgd2l0aCBBVFNQSQpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9J bmplY3RlZEJ1bmRsZS9hdHNwaS9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRzcGkuY3BwIGIvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdHNwaS9BY2Nlc3NpYmlsaXR5VUlF bGVtZW50QXRzcGkuY3BwCmluZGV4IDdiMmJjZTc0NTdlMC4uNTc5NjQxMzc0NzllIDEwMDY0NAot LS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL2F0c3BpL0FjY2Vzc2li aWxpdHlVSUVsZW1lbnRBdHNwaS5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9Jbmpl Y3RlZEJ1bmRsZS9hdHNwaS9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRzcGkuY3BwCkBAIC00ODgs NiArNDg4LDM0IEBAIGJvb2wgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6aXNBdHRyaWJ1dGVTZXR0 YWJsZShKU1N0cmluZ1JlZiBhdHRyaWJ1dGUpCiAgICAgaWYgKGNoZWNrRWxlbWVudFN0YXRlKG1f ZWxlbWVudC5nZXQoKSwgV2ViQ29yZTo6QXRzcGk6OlN0YXRlOjpDaGVja2FibGUpKQogICAgICAg ICByZXR1cm4gdHJ1ZTsKIAorICAgIGF1dG8gYXR0cmlidXRlcyA9IG1fZWxlbWVudC0+YXR0cmli dXRlcygpOworICAgIFN0cmluZyBpc1JlYWRPbmx5ID0gYXR0cmlidXRlcy5nZXQoInJlYWRvbmx5 Iik7CisgICAgaWYgKCFpc1JlYWRPbmx5LmlzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIGlzUmVh ZE9ubHkgPT0gInRydWUiID8gZmFsc2UgOiB0cnVlOworCisgICAgLy8gSWYgd2UgaGF2ZSBhIGxp c3Rib3ggb3IgY29tYm9ib3ggYW5kIHRoZSB2YWx1ZSBjYW4gYmUgc2V0LCB0aGUgb3B0aW9ucyBz aG91bGQgYmUgc2VsZWN0YWJsZS4KKyAgICB1bnNpZ25lZCBlbGVtZW50Um9sZTsKKyAgICBzX2Nv bnRyb2xsZXItPmV4ZWN1dGVPbkFYVGhyZWFkQW5kV2FpdChbdGhpcywgJmVsZW1lbnRSb2xlXSB7 CisgICAgICAgIG1fZWxlbWVudC0+dXBkYXRlQmFja2luZ1N0b3JlKCk7CisgICAgICAgIGVsZW1l bnRSb2xlID0gbV9lbGVtZW50LT5yb2xlKCk7CisgICAgfSk7CisgICAgc3dpdGNoIChlbGVtZW50 Um9sZSkgeworICAgIGNhc2UgV2ViQ29yZTo6QXRzcGk6OlJvbGU6OkNvbWJvQm94OgorICAgIGNh c2UgV2ViQ29yZTo6QXRzcGk6OlJvbGU6Okxpc3RCb3g6CisgICAgICAgIGlmIChhdXRvIGNoaWxk ID0gY2hpbGRBdEluZGV4KDApKSB7CisgICAgICAgICAgICBpZiAoZWxlbWVudFJvbGUgPT0gV2Vi Q29yZTo6QXRzcGk6OlJvbGU6OkNvbWJvQm94KSB7CisgICAgICAgICAgICAgICAgLy8gRmlyc3Qg Y2hpbGQgaXMgdGhlIG1lbnUuCisgICAgICAgICAgICAgICAgY2hpbGQgPSBjaGlsZC0+Y2hpbGRB dEluZGV4KDApOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICBpZiAoY2hpbGQpCisgICAg ICAgICAgICAgICAgcmV0dXJuIGNoZWNrRWxlbWVudFN0YXRlKGNoaWxkLT5tX2VsZW1lbnQuZ2V0 KCksIFdlYkNvcmU6OkF0c3BpOjpTdGF0ZTo6U2VsZWN0YWJsZSk7CisgICAgICAgIH0KKyAgICAg ICAgYnJlYWs7CisgICAgZGVmYXVsdDoKKyAgICAgICAgYnJlYWs7CisgICAgfQorCiAgICAgaWYg KG1fZWxlbWVudC0+aW50ZXJmYWNlcygpLmNvbnRhaW5zKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlP YmplY3RBdHNwaTo6SW50ZXJmYWNlOjpWYWx1ZSkKICAgICAgICAgJiYgY2hlY2tFbGVtZW50U3Rh dGUobV9lbGVtZW50LmdldCgpLCBXZWJDb3JlOjpBdHNwaTo6U3RhdGU6OkZvY3VzYWJsZSkpIHsK ICAgICAgICAgZG91YmxlIG1pbmltdW1WYWx1ZSwgbWF4aW11bVZhbHVlOwo=