234600 2021-12-22 05:52:45 -0800 Simplify test for startOfLastParagraph in InsertListCommand::doApply 2021-12-24 09:09:15 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fred.wang fred.wang darin ews-watchlist mifenton webkit-bug-importer wenson_hsieh oldest_to_newest 1826273 0 fred.wang 2021-12-22 05:52:45 -0800 Currently, we are doing !startOfLastParagraph.deepEquivalent().anchorNode()->isConnected() but it could be replaced with startOfLastParagraph.isOrphan() which is the same as startOfLastParagraph.deepEquivalent().isOrphan() and so the same as startOfLastParagraph.deepEquivalent().anchorNode() && !startOfLastParagraph.deepEquivalent().anchorNode()->isConnected() 1826276 1 447798 fred.wang 2021-12-22 06:01:48 -0800 Created attachment 447798 Patch 1826730 2 ews-feeder 2021-12-24 09:08:12 -0800 Committed r287428 (245563@main): <https://commits.webkit.org/245563@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447798. 1826731 3 webkit-bug-importer 2021-12-24 09:09:15 -0800 <rdar://problem/86894407> 447798 2021-12-22 06:01:48 -0800 2021-12-24 09:08:13 -0800 Patch 0001-Bug-234600-Simplify-test-for-startOfLastParagraph-in.patch text/plain 2605 fred.wang RnJvbSA5YzIyYzAzODFmZjhlNTc5YzgzZTcxMDc3ZDFhNTI4OWNkOWUxNmNiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RnI9QzM9QTlkPUMzPUE5cmljPTIwV2FuZz89 IDxmd2FuZ0BpZ2FsaWEuY29tPgpEYXRlOiBXZWQsIDIyIERlYyAyMDIxIDE1OjAwOjQzICswMTAw ClN1YmplY3Q6IFtQQVRDSF0gQnVnIDIzNDYwMCAtIFNpbXBsaWZ5IHRlc3QgZm9yIHN0YXJ0T2ZM YXN0UGFyYWdyYXBoIGluCiBJbnNlcnRMaXN0Q29tbWFuZDo6ZG9BcHBseQoKLS0tCiBTb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICB8IDIwICsrKysrKysrKysrKysr KysrKysrCiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0luc2VydExpc3RDb21tYW5kLmNwcCB8ICAy ICstCiAyIGZpbGVzIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggZDM0ZGQ0NjEwYy4uNjY4NDU4MDBmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDIzIEBACisyMDIxLTEyLTIyICBGcmVkZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KKwor ICAgICAgICBTaW1wbGlmeSB0ZXN0IGZvciBzdGFydE9mTGFzdFBhcmFncmFwaCBpbiBJbnNlcnRM aXN0Q29tbWFuZDo6ZG9BcHBseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjM0NjAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ3VycmVudCB0ZXN0IGlzICFzdGFydE9mTGFzdFBhcmFncmFwaC5kZWVwRXF1 aXZhbGVudCgpLmFuY2hvck5vZGUoKS0+aXNDb25uZWN0ZWQoKS4gSXQgY291bGQKKyAgICAgICAg YmUgcmVwbGFjZWQgd2l0aCB0aGUgbGVzcyB2ZXJib3NlIHN0YXJ0T2ZMYXN0UGFyYWdyYXBoLmlz T3JwaGFuKCkgd2hpY2ggaXMgZXF1aXZhbGVudCB0bworICAgICAgICBzdGFydE9mTGFzdFBhcmFn cmFwaC5kZWVwRXF1aXZhbGVudCgpLmlzT3JwaGFuKCkgYW5kIHNvIHRvIHRoZSBjb25kaXRpb24K KyAgICAgICAgc3RhcnRPZkxhc3RQYXJhZ3JhcGguZGVlcEVxdWl2YWxlbnQoKS5hbmNob3JOb2Rl KCkgJiYKKyAgICAgICAgIXN0YXJ0T2ZMYXN0UGFyYWdyYXBoLmRlZXBFcXVpdmFsZW50KCkuYW5j aG9yTm9kZSgpLT5pc0Nvbm5lY3RlZCgpLiBBIGRpZmZlcmVuY2UgY2FuIG9ubHkKKyAgICAgICAg aGFwcGVuIGZvciBhIHBhZ2Ugd2hlcmUgYW5jaG9yTm9kZSgpIGlzIGEgbnVsbCBwb2ludGVyLiBJ biBzdWNoIGEgdGVzdCBjYXNlIGV4aXN0cywgdGhlbiBpdAorICAgICAgICBpcyBhbHJlYWR5IGNy YXNoaW5nIHdpdGggYSBudWxsIHB0ciBkZXJlZiBhbnl3YXkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLCBiZWhhdmlvciBlc3NlbnRpYWxseSB1bmNoYW5nZWQuCisKKyAgICAgICAgKiBlZGl0aW5n L0luc2VydExpc3RDb21tYW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc2VydExpc3RDb21t YW5kOjpkb0FwcGx5KTogVXNlIHN0YXJ0T2ZMYXN0UGFyYWdyYXBoLmlzT3JwaGFuKCkuCisKIDIw MjEtMTItMTkgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFN0 dWIgb3V0IE5vdGlmaWNhdGlvbkV2ZW50IGFuZCByZWxhdGVkCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL0luc2VydExpc3RDb21tYW5kLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvSW5zZXJ0TGlzdENvbW1hbmQuY3BwCmluZGV4IGZiNzRkNmQ4ZDQuLjY5M2ZiODUyMWUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvSW5zZXJ0TGlzdENvbW1hbmQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvSW5zZXJ0TGlzdENvbW1hbmQuY3BwCkBAIC0x NTYsNyArMTU2LDcgQEAgdm9pZCBJbnNlcnRMaXN0Q29tbWFuZDo6ZG9BcHBseSgpCiAgICAgICAg ICAgICAgICAgICAgIC8vIGluZmluaXRlIGxvb3AgYW5kIGJlY2F1c2UgdGhlcmUgaXMgbm8gbW9y ZSB3b3JrIHRvIGJlIGRvbmUuCiAgICAgICAgICAgICAgICAgICAgIC8vIEZJWE1FKDxyZGFyOi8v cHJvYmxlbS81OTgzOTc0Pik6IFRoZSBlbmRpbmdTZWxlY3Rpb24oKSBtYXkgYmUgaW5jb3JyZWN0 IGhlcmUuIENvbXB1dGUKICAgICAgICAgICAgICAgICAgICAgLy8gdGhlIG5ldyBsb2NhdGlvbiBv ZiBlbmRPZlNlbGVjdGlvbiBhbmQgdXNlIGl0IGFzIHRoZSBlbmQgb2YgdGhlIG5ldyBzZWxlY3Rp b24uCi0gICAgICAgICAgICAgICAgICAgIGlmICghc3RhcnRPZkxhc3RQYXJhZ3JhcGguZGVlcEVx dWl2YWxlbnQoKS5hbmNob3JOb2RlKCktPmlzQ29ubmVjdGVkKCkpCisgICAgICAgICAgICAgICAg ICAgIGlmIChzdGFydE9mTGFzdFBhcmFncmFwaC5pc09ycGhhbigpKQogICAgICAgICAgICAgICAg ICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgICAgICAgICBzZXRFbmRpbmdTZWxlY3Rpb24o c3RhcnRPZkN1cnJlbnRQYXJhZ3JhcGgpOwogCi0tIAoyLjI1LjEKCg==