234599 2021-12-22 05:26:00 -0800 [GTK][a11y] WTR: add missing bool and string attribute values with ATSPI 2021-12-23 00:56:26 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 230253 1 cgarcia webkit-unassigned aperez bugs-noreply oldest_to_newest 1826270 0 cgarcia 2021-12-22 05:26:00 -0800 We are missing some bool and string attribute values in WTR implementation for ATSPI. 1826271 1 447796 cgarcia 2021-12-22 05:27:25 -0800 Created attachment 447796 Patch 1826508 2 cgarcia 2021-12-23 00:56:26 -0800 Committed r287390 (245530@trunk): <https://commits.webkit.org/245530@trunk> 447796 2021-12-22 05:27:25 -0800 2021-12-22 09:55:32 -0800 Patch wtr-atspi-attrs.diff text/plain 3528 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzOTE5 OGI3MzFkMWUuLmViODlmMWNhYjk0NiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTEyLTIyICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVthMTF5XSBX VFI6IGFkZCBtaXNzaW5nIGJvb2wgYW5kIHN0cmluZyBhdHRyaWJ1dGUgdmFsdWVzIHdpdGggQVRT UEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDU5 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2Vi S2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdHNwaS9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50 QXRzcGkuY3BwOgorICAgICAgICAoV1RSOjpjaGVja0VsZW1lbnRTdGF0ZSk6CisgICAgICAgIChX VFI6OkFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnN0cmluZ0F0dHJpYnV0ZVZhbHVlKToKKyAgICAg ICAgKFdUUjo6QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6Ym9vbEF0dHJpYnV0ZVZhbHVlKToKKwog MjAyMS0xMi0yMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAK ICAgICAgICAgW0dUS11bYTExeV0gV1RSOiBlbnN1cmUgdGhlIHJvb3Qgb2JqZWN0IGlzIGNyZWF0 ZWQgYmVmb3JlIGdldHRpbmcgdGhlIGZvY3VzZWQgZWxlbWVudCB3aXRoIEFUU1BJCmRpZmYgLS1n aXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL2F0c3BpL0FjY2Vzc2li aWxpdHlVSUVsZW1lbnRBdHNwaS5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVk QnVuZGxlL2F0c3BpL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdHNwaS5jcHAKaW5kZXggZTI4YjYw MGJhMjZkLi43YjJiY2U3NDU3ZTAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv SW5qZWN0ZWRCdW5kbGUvYXRzcGkvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0c3BpLmNwcAorKysg Yi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL2F0c3BpL0FjY2Vzc2liaWxp dHlVSUVsZW1lbnRBdHNwaS5jcHAKQEAgLTM0Myw2ICszNDMsMTEgQEAgSlNSZXRhaW5QdHI8SlNT dHJpbmdSZWY+IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnN0cmluZ0Rlc2NyaXB0aW9uT2ZBdHRy aWJ1dGVWYWwKICAgICByZXR1cm4gSlNTdHJpbmdDcmVhdGVXaXRoQ2hhcmFjdGVycyhudWxscHRy LCAwKTsKIH0KIAorc3RhdGljIGJvb2wgY2hlY2tFbGVtZW50U3RhdGUoV2ViQ29yZTo6QWNjZXNz aWJpbGl0eU9iamVjdEF0c3BpKiBlbGVtZW50LCBXZWJDb3JlOjpBdHNwaTo6U3RhdGUgc3RhdGUp Cit7CisgICAgcmV0dXJuIGVsZW1lbnQtPnN0YXRlKCkgJiAoR19HVUlOVDY0X0NPTlNUQU5UKDEp IDw8IHN0YXRlKTsKK30KKwogSlNSZXRhaW5QdHI8SlNTdHJpbmdSZWY+IEFjY2Vzc2liaWxpdHlV SUVsZW1lbnQ6OnN0cmluZ0F0dHJpYnV0ZVZhbHVlKEpTU3RyaW5nUmVmIGF0dHJpYnV0ZSkKIHsK ICAgICBTdHJpbmcgYXR0cmlidXRlTmFtZSA9IHRvV1RGU3RyaW5nKGF0dHJpYnV0ZSk7CkBAIC0z NTksNiArMzY0LDEzIEBAIEpTUmV0YWluUHRyPEpTU3RyaW5nUmVmPiBBY2Nlc3NpYmlsaXR5VUlF bGVtZW50OjpzdHJpbmdBdHRyaWJ1dGVWYWx1ZShKU1N0cmluZ1JlCiAgICAgYXV0byBhdHRyaWJ1 dGVzID0gbV9lbGVtZW50LT5hdHRyaWJ1dGVzKCk7CiAgICAgaWYgKGF0dHJpYnV0ZU5hbWUgPT0g IkFYUGxhY2Vob2xkZXJWYWx1ZSIpCiAgICAgICAgIHJldHVybiBPcGFxdWVKU1N0cmluZzo6dHJ5 Q3JlYXRlKGF0dHJpYnV0ZXMuZ2V0KCJwbGFjZWhvbGRlci10ZXh0IikpLmxlYWtSZWYoKTsKKyAg ICBpZiAoYXR0cmlidXRlTmFtZSA9PSAiQVhJbnZhbGlkIikgeworICAgICAgICBhdXRvIHRleHRB dHRyaWJ1dGVzID0gbV9lbGVtZW50LT50ZXh0QXR0cmlidXRlcygpOworICAgICAgICBhdXRvIHZh bHVlID0gdGV4dEF0dHJpYnV0ZXMuYXR0cmlidXRlcy5nZXQoImludmFsaWQiKTsKKyAgICAgICAg aWYgKHZhbHVlLmlzRW1wdHkoKSkKKyAgICAgICAgICAgIHZhbHVlID0gY2hlY2tFbGVtZW50U3Rh dGUobV9lbGVtZW50LmdldCgpLCBXZWJDb3JlOjpBdHNwaTo6U3RhdGU6OkludmFsaWRFbnRyeSkg PyAidHJ1ZSIgOiAiZmFsc2UiOworICAgICAgICByZXR1cm4gT3BhcXVlSlNTdHJpbmc6OnRyeUNy ZWF0ZSh2YWx1ZSkubGVha1JlZigpOworICAgIH0KIAogICAgIHJldHVybiBKU1N0cmluZ0NyZWF0 ZVdpdGhDaGFyYWN0ZXJzKG51bGxwdHIsIDApOwogfQpAQCAtNDQ0LDE2ICs0NTYsMTkgQEAgUmVm UHRyPEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ+IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnVpRWxl bWVudEF0dHJpYnV0ZVZhbHVlKEoKICAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAotc3RhdGljIGJv b2wgY2hlY2tFbGVtZW50U3RhdGUoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU9iamVjdEF0c3BpKiBl bGVtZW50LCBXZWJDb3JlOjpBdHNwaTo6U3RhdGUgc3RhdGUpCi17Ci0gICAgcmV0dXJuIGVsZW1l bnQtPnN0YXRlKCkgJiAoR19HVUlOVDY0X0NPTlNUQU5UKDEpIDw8IHN0YXRlKTsKLX0KLQogYm9v bCBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojpib29sQXR0cmlidXRlVmFsdWUoSlNTdHJpbmdSZWYg YXR0cmlidXRlKQogewogICAgIFN0cmluZyBhdHRyaWJ1dGVOYW1lID0gdG9XVEZTdHJpbmcoYXR0 cmlidXRlKTsKICAgICBpZiAoYXR0cmlidXRlTmFtZSA9PSAiQVhFbGVtZW50QnVzeSIpCiAgICAg ICAgIHJldHVybiBjaGVja0VsZW1lbnRTdGF0ZShtX2VsZW1lbnQuZ2V0KCksIFdlYkNvcmU6OkF0 c3BpOjpTdGF0ZTo6QnVzeSk7CisgICAgaWYgKGF0dHJpYnV0ZU5hbWUgPT0gIkFYTW9kYWwiKQor ICAgICAgICByZXR1cm4gY2hlY2tFbGVtZW50U3RhdGUobV9lbGVtZW50LmdldCgpLCBXZWJDb3Jl OjpBdHNwaTo6U3RhdGU6Ok1vZGFsKTsKKyAgICBpZiAoYXR0cmlidXRlTmFtZSA9PSAiQVhTdXBw b3J0c0F1dG9Db21wbGV0aW9uIikKKyAgICAgICAgcmV0dXJuIGNoZWNrRWxlbWVudFN0YXRlKG1f ZWxlbWVudC5nZXQoKSwgV2ViQ29yZTo6QXRzcGk6OlN0YXRlOjpTdXBwb3J0c0F1dG9jb21wbGV0 aW9uKTsKKyAgICBpZiAoYXR0cmlidXRlTmFtZSA9PSAiQVhJbnRlcmZhY2VUYWJsZSIpCisgICAg ICAgIHJldHVybiBtX2VsZW1lbnQtPmludGVyZmFjZXMoKS5jb250YWlucyhXZWJDb3JlOjpBY2Nl c3NpYmlsaXR5T2JqZWN0QXRzcGk6OkludGVyZmFjZTo6VGFibGUpOworICAgIGlmIChhdHRyaWJ1 dGVOYW1lID09ICJBWEludGVyZmFjZVRhYmxlQ2VsbCIpCisgICAgICAgIHJldHVybiBtX2VsZW1l bnQtPmludGVyZmFjZXMoKS5jb250YWlucyhXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0QXRz cGk6OkludGVyZmFjZTo6VGFibGVDZWxsKTsKIAogICAgIHJldHVybiBmYWxzZTsKIH0K